virtio_net: Use bus_dma for command/ack buffers
Needs ReviewPublic
Actions

Authored by sarah.walker2_arm.com on Fri, Feb 27, 4:00 PM.

Tags

None

Referenced Files

	F146130639: D55564.diff
	Sat, Feb 28, 2:05 AM

	F146116488: D55564.diff
	Fri, Feb 27, 11:09 PM

	F146115067: D55564.diff
	Fri, Feb 27, 10:54 PM

	F146091780: D55564.diff
	Fri, Feb 27, 6:02 PM

	F146089354: D55564.id.diff
	Fri, Feb 27, 5:32 PM

	F146089310: D55564.id172872.diff
	Fri, Feb 27, 5:32 PM

Subscribers

imp

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

While the majority of virtio platforms will be fully coherent, some may
require cache maintenance or other specific device memory handling (eg for
secure partitioning). Using bus_dma allows for these usecases.

The virtio buffers are marked as coherent; this should ensure that sync
calls are no-ops in the common cases.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71071
Build 67954: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Fri, Feb 27, 4:00 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Feb 27, 4:00 PM

sarah.walker2_arm.com requested review of this revision.Fri, Feb 27, 4:00 PM

Harbormaster completed remote builds in B71071: Diff 172872.Fri, Feb 27, 4:00 PM

sarah.walker2_arm.com mentioned this in D55492: virtio_net: Use bus_dma for rxq/txq buffers.Fri, Feb 27, 4:00 PM

br added a subscriber: br.Fri, Feb 27, 6:12 PM

br added inline comments.

sys/dev/virtio/network/if_vtnet.c
536	is not it too large alignment? it panics somewhere in IOMMU code

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

network/

if_vtnet.c

336 lines

if_vtnetvar.h

6 lines

Diff 172872

View Options

sys/dev/virtio/network/if_vtnet.c