virtio_net: Use bus_dma for command/ack buffers
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Feb 27 2026, 4:00 PM.

Details

Reviewers

andrew

Commits

rGb5bad6df467c: virtio_net: Use bus_dma for command/ack buffers

Summary

While the majority of virtio platforms will be fully coherent, some may
require cache maintenance or other specific device memory handling (eg for
secure partitioning). Using bus_dma allows for these usecases.

The virtio buffers are marked as coherent; this should ensure that sync
calls are no-ops in the common cases.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sarah.walker2_arm.com created this revision.Feb 27 2026, 4:00 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2026, 4:00 PM

sarah.walker2_arm.com requested review of this revision.Feb 27 2026, 4:00 PM

Harbormaster completed remote builds in B71071: Diff 172872.Feb 27 2026, 4:00 PM

sarah.walker2_arm.com mentioned this in D55492: virtio_net: Use bus_dma for rxq/txq buffers.Feb 27 2026, 4:00 PM

br added a subscriber: br.Feb 27 2026, 6:12 PM

br added inline comments.

sys/dev/virtio/network/if_vtnet.c
531	is not it too large alignment? it panics somewhere in IOMMU code

Change header tag alignment size.

Harbormaster completed remote builds in B71129: Diff 172999.Mar 2 2026, 10:01 AM

Should the dma sync operations be BUS_DMASYNC_PREWRITE | BUS_DMASYNC_PREREAD and BUS_DMASYNC_POSTREAD | BUS_DMASYNC_POSTWRITE given virtio may read from & write to the buffer.

In D55564#1272503, @sarah.walker2_arm.com wrote:

Change header tag alignment size.

I get this

panic: alignment failed: ctx 0xffffffd0010d0e80 start 0x20c000 offset 3ca align 0x4
cpuid = 0
time = 1772453498
KDB: stack backtrace:
db_trace_self() at db_trace_self
db_fetch_ksymtab() at db_fetch_ksymtab+0x142
kdb_backtrace() at kdb_backtrace+0x2c
vpanic() at vpanic+0x16e
panic() at panic+0x26
iommu_domain_fini() at iommu_domain_fini+0x36a
iommu_is_buswide_ctx() at iommu_is_buswide_ctx+0x806
bus_dmamap_load() at bus_dmamap_load+0x6e
vtmmio_attach() at vtmmio_attach+0x779c
vtmmio_attach() at vtmmio_attach+0x739a
vtmmio_attach() at vtmmio_attach+0x65b2
vtmmio_attach() at vtmmio_attach+0x574a
ether_ioctl() at ether_ioctl+0x1a0
vtmmio_attach() at vtmmio_attach+0x593a
in_control_ioctl() at in_control_ioctl+0x9ac
rtnl_ifaces_destroy() at rtnl_ifaces_destroy+0x1a1e
rtnl_register_messages() at rtnl_register_messages+0x2a0
nl_send() at nl_send+0x3ca
nl_taskqueue_handler() at nl_taskqueue_handler+0x34e
taskqueue_run() at taskqueue_run+0x1f0
taskqueue_thread_loop() at taskqueue_thread_loop+0xd4
fork_exit() at fork_exit+0x68
fork_trampoline() at fork_trampoline+0xa
KDB: enter: panic
[ thread pid 0 tid 100062 ]
Stopped at      kdb_enter+0x3a: sd      zero,-948(s1)
db>

Correct header tag alignment

Harbormaster completed remote builds in B71130: Diff 173004.Mar 2 2026, 12:31 PM

emaste added a subscriber: emaste.Mar 3 2026, 4:25 PM

emaste added a subscriber: virtio.Mar 3 2026, 4:52 PM

andrew accepted this revision.Mon, Apr 27, 10:52 AM

This revision is now accepted and ready to land.Mon, Apr 27, 10:52 AM

Closed by commit rGb5bad6df467c: virtio_net: Use bus_dma for command/ack buffers (authored by sarah.walker2_arm.com, committed by andrew). · Explain WhyMon, Apr 27, 11:39 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGb5bad6df467c: virtio_net: Use bus_dma for command/ack buffers.

andrew added a reverting change: rGc8167ebb742c: Revert "virtio_net: Use bus_dma for command/ack buffers".Tue, May 5, 9:33 AM