Page MenuHomeFreeBSD

scmi: Add an SCMI VirtIO transport driver
ClosedPublic

Authored by cristian.marussi_arm.com on Dec 13 2023, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 5:45 PM
Unknown Object (File)
Wed, Oct 8, 5:23 PM
Unknown Object (File)
Fri, Oct 3, 2:24 PM
Unknown Object (File)
Thu, Oct 2, 12:29 AM
Unknown Object (File)
Sep 13 2025, 10:20 AM
Unknown Object (File)
Sep 6 2025, 12:41 PM
Unknown Object (File)
Sep 5 2025, 10:46 PM
Unknown Object (File)
Aug 19 2025, 5:14 PM

Details

Summary

Add an SCMI transport driver based on the virtio-scmi backend.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Just as a general comment - some of the device_printf() look potentially spammy and may be better as either guarded by bootverbose or debug macros.

sys/dev/firmware/arm/scmi_virtio.c
94

Nit: M_WAITOK means this cannot fail. May be slightly clearer to use mallocarray() instead.

This revision is now accepted and ready to land.Jan 31 2024, 4:13 AM

Using mallocarray and dropping empty interface method

Using mallocarray and avoding to check the retval since called as M_WAITOK.
Dropping scmi_virtio_detach() driver method since it just calls into the parent
scmi_attach()

This revision now requires review to proceed.Mar 1 2024, 7:17 PM
This revision is now accepted and ready to land.Mar 5 2024, 2:37 PM
This revision was automatically updated to reflect the committed changes.