Page MenuHomeFreeBSD

cristian.marussi_arm.com (Cristian Marussi)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 29 2023, 9:58 AM (63 w, 1 d)

Recent Activity

Sun, Jan 26

cristian.marussi_arm.com updated the diff for D47432: scmi: raw: Add sysctl queues properties.

Cleanup SYSCTL RAW OIDs on cleanup

Sun, Jan 26, 6:38 PM
cristian.marussi_arm.com updated the diff for D47429: scmi: raw: Add RAW interface for testing and developemnt.

Better cleanup on RAW initialization failure

Sun, Jan 26, 6:36 PM

Wed, Jan 15

cristian.marussi_arm.com added a comment to D47429: scmi: raw: Add RAW interface for testing and developemnt.

Thanks for the review, I will fix as stated in the replies.

Wed, Jan 15, 2:57 PM

Nov 28 2024

cristian.marussi_arm.com updated the diff for D47430: scmi: raw: Add SDT traces to the RAW stack.

Rebased on changes.

Nov 28 2024, 4:55 PM
cristian.marussi_arm.com updated the diff for D47429: scmi: raw: Add RAW interface for testing and developemnt.

Simplified raw_buffer free routines to be easily callable from cdev dtors.

Nov 28 2024, 4:55 PM
cristian.marussi_arm.com added a comment to D47429: scmi: raw: Add RAW interface for testing and developemnt.

What will happen if we read a partial message then close the file? Or if we duplicate the file descriptor?

Nov 28 2024, 2:44 PM
cristian.marussi_arm.com added inline comments to D47429: scmi: raw: Add RAW interface for testing and developemnt.
Nov 28 2024, 2:17 PM

Nov 21 2024

cristian.marussi_arm.com updated the diff for D47431: scmi: Add RAW interface call hooks into the core.

Removed 2 fields from scmi_softc that needed to be added before in this series.

Nov 21 2024, 9:12 PM
cristian.marussi_arm.com updated the diff for D47429: scmi: raw: Add RAW interface for testing and developemnt.

Added scmi_raw dep and a few missing fields in scmi_softc, mistakenly added in
a following patch

Nov 21 2024, 9:10 PM
cristian.marussi_arm.com updated the diff for D47426: scmi: Add optional asynchronous handling of replies.

Added missing parenthesis on retirn stm.

Nov 21 2024, 9:01 PM
cristian.marussi_arm.com updated the diff for D47422: scmi: Add devicetree transport properties.

Reworked handling of devicetree props

Nov 21 2024, 8:58 PM
cristian.marussi_arm.com updated the diff for D47421: scmi: Redefine max message payload size.

Reworked handling of max_payld-sz and other transport props

Nov 21 2024, 8:57 PM
cristian.marussi_arm.com updated the diff for D47420: scmi: Make transports report the effective length of the received messages.

Fix mishandled retvalue on scmi_shmem_msg_poll and related funcs

Nov 21 2024, 8:54 PM

Nov 4 2024

cristian.marussi_arm.com added inline comments to D47422: scmi: Add devicetree transport properties.
Nov 4 2024, 4:57 PM
cristian.marussi_arm.com added inline comments to D47420: scmi: Make transports report the effective length of the received messages.
Nov 4 2024, 4:52 PM
cristian.marussi_arm.com added a comment to D47421: scmi: Redefine max message payload size.

Does scmi_buf_get need to be updated with SCMI_MAX_MSG_REPLY_SIZE changing?

Nov 4 2024, 4:51 PM
cristian.marussi_arm.com added inline comments to D47426: scmi: Add optional asynchronous handling of replies.
Nov 4 2024, 4:36 PM
cristian.marussi_arm.com updated the diff for D47429: scmi: raw: Add RAW interface for testing and developemnt.

Removed options that enabled SCMI RAW by default (on the wrong file)

Nov 4 2024, 9:11 AM
cristian.marussi_arm.com added inline comments to D47429: scmi: raw: Add RAW interface for testing and developemnt.
Nov 4 2024, 9:06 AM
cristian.marussi_arm.com requested review of D47432: scmi: raw: Add sysctl queues properties.
Nov 4 2024, 8:52 AM
cristian.marussi_arm.com requested review of D47431: scmi: Add RAW interface call hooks into the core.
Nov 4 2024, 8:52 AM
cristian.marussi_arm.com requested review of D47430: scmi: raw: Add SDT traces to the RAW stack.
Nov 4 2024, 8:52 AM
cristian.marussi_arm.com requested review of D47429: scmi: raw: Add RAW interface for testing and developemnt.
Nov 4 2024, 8:52 AM
cristian.marussi_arm.com requested review of D47428: scmi: Add sysctl transport properties.
Nov 4 2024, 8:52 AM
cristian.marussi_arm.com requested review of D47427: scmi: Add SDT traces to the core stack.
Nov 4 2024, 8:52 AM
cristian.marussi_arm.com requested review of D47426: scmi: Add optional asynchronous handling of replies.
Nov 4 2024, 8:52 AM
cristian.marussi_arm.com requested review of D47425: scmi: Refactor scmi_request internal logic.
Nov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of D47424: scmi: Add scmi_token_reserve helper.
Nov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of D47423: scmi: Add helper to manipulate scmi_msg descriptors.
Nov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of D47422: scmi: Add devicetree transport properties.
Nov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of D47421: scmi: Redefine max message payload size.
Nov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of D47419: scmi: Fix race on timed out transmissions.
Nov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of D47420: scmi: Make transports report the effective length of the received messages.
Nov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of D47418: scmi: Fix token bitmask.
Nov 4 2024, 8:51 AM

Mar 7 2024

cristian.marussi_arm.com updated the diff for D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.

Fixed if (token)

Mar 7 2024, 5:53 PM
cristian.marussi_arm.com updated the diff for D43046: scmi: Introduce a new SCMI API and port CLK SCMI driver to it.

Reworked to rebase cleanly on other series changes

Mar 7 2024, 5:43 PM
cristian.marussi_arm.com updated the diff for D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.

Moved sc->trs allocation earlier

Mar 7 2024, 5:40 PM
cristian.marussi_arm.com updated the diff for D43044: scmi: Add new SCMI interfaces for init and message processing.

Made scmi_detach static

Mar 7 2024, 5:37 PM
cristian.marussi_arm.com updated the diff for D43039: scmi: Split out the SCMI mailbox to a new file.

Removed the extres header references

Mar 7 2024, 5:33 PM
cristian.marussi_arm.com added inline comments to D43039: scmi: Split out the SCMI mailbox to a new file.
Mar 7 2024, 1:44 PM
cristian.marussi_arm.com added inline comments to D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
Mar 7 2024, 1:42 PM
cristian.marussi_arm.com added inline comments to D43044: scmi: Add new SCMI interfaces for init and message processing.
Mar 7 2024, 1:41 PM

Mar 1 2024

cristian.marussi_arm.com updated the diff for D43048: scmi: Add an SCMI VirtIO transport driver.

Using mallocarray and dropping empty interface method

Mar 1 2024, 7:17 PM
cristian.marussi_arm.com updated the diff for D43047: vtscmi: Add a virtio-scmi driver.

Removed needless checks on malloc, using mallocarray

Mar 1 2024, 7:12 PM
cristian.marussi_arm.com updated the diff for D43046: scmi: Introduce a new SCMI API and port CLK SCMI driver to it.

Removed needless malloc checks

Mar 1 2024, 7:09 PM
cristian.marussi_arm.com updated the diff for D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.

Removed check on malloc return value

Mar 1 2024, 7:03 PM
cristian.marussi_arm.com updated the diff for D43044: scmi: Add new SCMI interfaces for init and message processing.

Removed needless empty interface methods

Mar 1 2024, 6:59 PM
cristian.marussi_arm.com updated the diff for D43040: scmi: Add an SCMI SMC transport driver.

Removed __FBSDID

Mar 1 2024, 6:50 PM
cristian.marussi_arm.com updated the diff for D43039: scmi: Split out the SCMI mailbox to a new file.

Removed the __FBSDID

Mar 1 2024, 6:44 PM

Feb 8 2024

cristian.marussi_arm.com added a comment to D43047: vtscmi: Add a virtio-scmi driver.

Thanks for the review @bryanv.
Regarding:

Feb 8 2024, 4:58 PM

Jan 18 2024

cristian.marussi_arm.com added a comment to D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.

Could you use unr(9), the kernel unit number allocator, to allocate the tokens?

Jan 18 2024, 4:22 PM
cristian.marussi_arm.com added a comment to D43044: scmi: Add new SCMI interfaces for init and message processing.

The attach and detach functions that just call smci_attach and smci_detach could be removed. If a driver doesn't implement a method, but the parent does then the parent implementation will be used.

Jan 18 2024, 3:43 PM

Dec 13 2023

cristian.marussi_arm.com added a comment to D43038: scmi: Implement scmi_clknode_recalc_freq method.

SCMI: Add support for multiple transports and add VirtIO/SMC transports

Dec 13 2023, 7:04 PM
cristian.marussi_arm.com requested review of D43048: scmi: Add an SCMI VirtIO transport driver.
Dec 13 2023, 6:38 PM
cristian.marussi_arm.com requested review of D43047: vtscmi: Add a virtio-scmi driver.
Dec 13 2023, 6:38 PM
cristian.marussi_arm.com requested review of D43046: scmi: Introduce a new SCMI API and port CLK SCMI driver to it.
Dec 13 2023, 6:38 PM
cristian.marussi_arm.com requested review of D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
Dec 13 2023, 6:38 PM
cristian.marussi_arm.com requested review of D43044: scmi: Add new SCMI interfaces for init and message processing.
Dec 13 2023, 6:37 PM
cristian.marussi_arm.com requested review of D43043: scmi: Protect SCMI/SMT channels from concurrent transmissions.
Dec 13 2023, 6:37 PM
cristian.marussi_arm.com requested review of D43042: scmi: Fix SCMI mailbox polling mechanism.
Dec 13 2023, 6:37 PM
cristian.marussi_arm.com requested review of D43041: scmi: Extend and refactor SCMI shmem support.
Dec 13 2023, 6:37 PM
cristian.marussi_arm.com requested review of D43040: scmi: Add an SCMI SMC transport driver.
Dec 13 2023, 6:37 PM
cristian.marussi_arm.com requested review of D43039: scmi: Split out the SCMI mailbox to a new file.
Dec 13 2023, 6:37 PM
cristian.marussi_arm.com requested review of D43038: scmi: Implement scmi_clknode_recalc_freq method.
Dec 13 2023, 6:37 PM