Page MenuHomeFreeBSD
Differential D43039

scmi: Split out the SCMI mailbox to a new file
ClosedPublic
Actions

Authored by cristian.marussi_arm.com on Dec 13 2023, 6:37 PM.
Tags
None
Referenced Files
F102689035: D43039.id131345.diff
Fri, Nov 15, 9:47 PM
Unknown Object (File)
Mon, Nov 11, 6:29 PM
Unknown Object (File)
Wed, Nov 6, 10:47 AM
Unknown Object (File)
Wed, Nov 6, 10:47 AM
Unknown Object (File)
Wed, Nov 6, 10:47 AM
Unknown Object (File)
Wed, Nov 6, 10:46 AM
Unknown Object (File)
Wed, Nov 6, 10:46 AM
Unknown Object (File)
Mon, Nov 4, 10:10 PM
View All 90 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
Group Reviewers
arm64
Commits
rGd46f01fd590e: scmi: Split out the SCMI mailbox to a new file
Summary

Add a new SCMI interface file to allow for multiple kind of transports
and move the mailbox transport to its own file, using the new interface.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cristian.marussi_arm.com created this revision.Dec 13 2023, 6:37 PM
Herald added a reviewer: andrew. · View Herald TranscriptDec 13 2023, 6:37 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
cristian.marussi_arm.com requested review of this revision.Dec 13 2023, 6:37 PM
Harbormaster completed remote builds in B54921: Diff 131345.Dec 13 2023, 6:37 PM
cristian.marussi_arm.com added a parent revision: D43038: scmi: Implement scmi_clknode_recalc_freq method.Dec 13 2023, 6:37 PM
cristian.marussi_arm.com added a child revision: D43040: scmi: Add an SCMI SMC transport driver.
andrew accepted this revision.Jan 8 2024, 5:13 PM

(reviewing my own change)

This revision is now accepted and ready to land.Jan 8 2024, 5:13 PM
andrew added inline comments.Jan 8 2024, 5:17 PM
sys/dev/firmware/arm/scmi_mailbox.c
33–35

I'll remove when pushing

cristian.marussi_arm.com updated this revision to Diff 135283.Mar 1 2024, 6:44 PM

Removed the __FBSDID

Removed the __FBSDID

This revision now requires review to proceed.Mar 1 2024, 6:44 PM
Harbormaster completed remote builds in B56381: Diff 135283.Mar 1 2024, 6:44 PM
andrew accepted this revision.Mar 5 2024, 11:13 AM
This revision is now accepted and ready to land.Mar 5 2024, 11:13 AM
cristian.marussi_arm.com added inline comments.Mar 7 2024, 1:44 PM
sys/dev/firmware/arm/scmi_mailbox.c
33–35

Removed this while reworking this series

43–44

This needs to be removed after some recent rework removing extres...or it breaks the build. I'll respin this

cristian.marussi_arm.com updated this revision to Diff 135499.Mar 7 2024, 5:33 PM

Removed the extres header references

Extres removed in recent rebase, missed this.

This revision now requires review to proceed.Mar 7 2024, 5:33 PM
Harbormaster completed remote builds in B56490: Diff 135499.Mar 7 2024, 5:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2024, 10:00 AM
Closed by commit rGd46f01fd590e: scmi: Split out the SCMI mailbox to a new file (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGd46f01fd590e: scmi: Split out the SCMI mailbox to a new file.

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
dev/
firmware/
arm/
13 lines
82 lines
32 lines
178 lines

Diff 136878

View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/firmware/arm/scmi.h

Loading...
View Options

sys/dev/firmware/arm/scmi.c

Loading...
View Options

sys/dev/firmware/arm/scmi_if.m

Loading...
View Options

sys/dev/firmware/arm/scmi_mailbox.c

Loading...