virtio_mmio: Improve V1 spec conformance
ClosedPublic
Actions

Authored by bryanv on Aug 12 2022, 3:20 AM.

Details

Reviewers

cperciva

Commits

rG926cedd9a071: virtio_mmio: Improve V1 spec conformance

Summary

Implement the virtio_bus_finalize_features method so the FEATURES_OK
status bit is set. Implement the virtio_bus_config_generation method
to ensure larger than 4-byte reads are consistent.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bryanv created this revision.Aug 12 2022, 3:20 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 12 2022, 3:20 AM

bryanv requested review of this revision.Aug 12 2022, 3:20 AM

Harbormaster completed remote builds in B46873: Diff 109214.Aug 12 2022, 3:20 AM

cperciva added inline comments.Aug 12 2022, 4:20 PM

sys/dev/virtio/mmio/virtio_mmio.c
470	I think we need to call this from `vtmmio_reinit` after the call to `vtmmio_negotiate_features`?

bryanv marked an inline comment as done.Aug 12 2022, 4:39 PM

bryanv added inline comments.

sys/dev/virtio/mmio/virtio_mmio.c
470	Yes thanks.

Address comment

Harbormaster completed remote builds in B46902: Diff 109254.Aug 12 2022, 4:39 PM

Just tested, works with Firecracker.

This revision is now accepted and ready to land.Aug 12 2022, 4:48 PM

Closed by commit rG926cedd9a071: virtio_mmio: Improve V1 spec conformance (authored by bryanv). · Explain WhyAug 17 2022, 8:16 PM

This revision was automatically updated to reflect the committed changes.

bryanv added a commit: rG926cedd9a071: virtio_mmio: Improve V1 spec conformance.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

mmio/

virtio_mmio.c

87 lines

Diff 109492

View Options

sys/dev/virtio/mmio/virtio_mmio.c

virtio_mmio: Improve V1 spec conformanceClosedPublicActions