Page MenuHomeFreeBSD
Differential D27910

if_vtnet: Defer updating generated MAC address until attached
ClosedPublic
Actions

Authored by bryanv on Jan 2 2021, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 25, 8:17 AM
Unknown Object (File)
Fri, May 15, 11:17 AM
Unknown Object (File)
Fri, May 15, 8:52 AM
Unknown Object (File)
Fri, May 15, 1:16 AM
Unknown Object (File)
Thu, May 14, 1:37 PM
Unknown Object (File)
Mon, May 11, 8:50 PM
Unknown Object (File)
Fri, May 8, 4:54 AM
Unknown Object (File)
Wed, May 6, 6:18 AM
View All Files
Subscribers
imp

Details

Reviewers
grehan
Commits
rG05041794d06f: if_vtnet: Defer updating generated MAC address until attached
Summary

This improves spec compliance because the driver is not suppose
to notify the device prior to setting the DRIVER_OK status, which
could happen with the VIRTIO_NET_F_CTRL_MAC_ADDR.

The VIRTIO_NET_F_MAC feature should always be negotiated so would
be a rare situation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bryanv created this revision.Jan 2 2021, 8:59 PM
bryanv held this revision as a draft.
Herald added a subscriber: imp. · View Herald TranscriptJan 2 2021, 9:00 PM
Harbormaster completed remote builds in B35875: Diff 81533.Jan 2 2021, 9:00 PM
bryanv added a reviewer: grehan.Jan 2 2021, 9:00 PM
bryanv published this revision for review.Jan 2 2021, 10:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 5:11 AM
Closed by commit rG05041794d06f: if_vtnet: Defer updating generated MAC address until attached (authored by bryanv). · Explain Why
This revision was automatically updated to reflect the committed changes.
bryanv added a commit: rG05041794d06f: if_vtnet: Defer updating generated MAC address until attached.

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
network/
60 lines

Diff 82537

View Options

sys/dev/virtio/network/if_vtnet.c

Loading...