Paths

Table of Contentst

Differential D41849

virtio: add comment on the spec for vring struct
AbandonedPublic
Actions

Authored by freebsd_igalic.co on Sep 13 2023, 10:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 1, 12:31 PM

	Unknown Object (File)
	Mon, Apr 29, 2:04 AM

	Unknown Object (File)
	Mar 30 2024, 8:00 PM

	Unknown Object (File)
	Feb 26 2024, 5:45 PM

	Unknown Object (File)
	Jan 30 2024, 3:13 PM

	Unknown Object (File)
	Jan 30 2024, 1:55 AM

	Unknown Object (File)
	Dec 20 2023, 8:37 AM

	Unknown Object (File)
	Dec 11 2023, 12:00 AM

View All 13 Files

Subscribers

Details

Reviewers

Summary

the 1.0 spec has renamed these structs.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53576
Build 50467: arc lint + arc unit

Event Timeline

freebsd_igalic.co created this revision.Sep 13 2023, 10:35 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2023, 10:35 PM

freebsd_igalic.co requested review of this revision.Sep 13 2023, 10:35 PM

freebsd_igalic.co added a parent revision: D41848: virtio: use bool for boolean functions.

Harbormaster completed remote builds in B53576: Diff 127348.Sep 13 2023, 10:36 PM

freebsd_igalic.co added a child revision: D41850: virtio: remove virtio_alloc_virtqueues' flags arg.Sep 13 2023, 10:37 PM

freebsd_igalic.co added a reviewer: bryanv.Sep 13 2023, 11:17 PM

pstef added a subscriber: pstef.Sep 14 2023, 6:29 AM

pstef added inline comments.

sys/dev/virtio/virtio_ring.h
92	It's a nit, but this would be the best time to capitalize `note`.

My intention has been to keep these header files closer aligned with the BSD licensed headers from Linux, which still uses the "vring" prefix. I don't think this change really clarifies much, especially when there are numerous other naming differences between the spec and those upstream header files.

aye.
i didn't know Linux virtio headers were bsd licensed.
in fact, I didn't dare look at them for fear i would breach copyright.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

5 lines

Diff 127348

sys/dev/virtio/virtio_ring.h

Loading...