Page MenuHomeFreeBSD

virtio: add comment on the spec for vring struct
AbandonedPublic

Authored by freebsd_igalic.co on Sep 13 2023, 10:35 PM.
Tags
None
Referenced Files
F99150806: D41849.diff
Sun, Oct 6, 8:55 PM
Unknown Object (File)
Sat, Oct 5, 1:34 PM
Unknown Object (File)
Wed, Oct 2, 12:34 PM
Unknown Object (File)
Wed, Oct 2, 9:55 AM
Unknown Object (File)
Mon, Sep 30, 11:27 PM
Unknown Object (File)
Mon, Sep 30, 12:18 PM
Unknown Object (File)
Mon, Sep 23, 2:24 PM
Unknown Object (File)
Fri, Sep 20, 7:33 AM
Subscribers

Details

Reviewers
bryanv
Summary

the 1.0 spec has renamed these structs.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53576
Build 50467: arc lint + arc unit

Event Timeline

pstef added inline comments.
sys/dev/virtio/virtio_ring.h
92

It's a nit, but this would be the best time to capitalize note.

My intention has been to keep these header files closer aligned with the BSD licensed headers from Linux, which still uses the "vring" prefix. I don't think this change really clarifies much, especially when there are numerous other naming differences between the spec and those upstream header files.

aye.
i didn't know Linux virtio headers were bsd licensed.
in fact, I didn't dare look at them for fear i would breach copyright.