Page MenuHomeFreeBSD

virtio: use bool for boolean functions
ClosedPublic

Authored by freebsd_igalic.co on Sep 13 2023, 10:34 PM.
Tags
None
Referenced Files
F156592559: D41848.id127513.diff
Thu, May 14, 10:53 PM
F156578565: D41848.id127347.diff
Thu, May 14, 7:54 PM
F156576216: D41848.id127371.diff
Thu, May 14, 7:22 PM
Unknown Object (File)
Tue, May 12, 6:13 PM
Unknown Object (File)
Tue, May 12, 10:13 AM
Unknown Object (File)
Thu, Apr 30, 8:31 AM
Unknown Object (File)
Mon, Apr 27, 7:42 AM
Unknown Object (File)
Sun, Apr 26, 6:35 AM
Subscribers

Details

Summary

these static functions:

  • vq_ring_use_indirect

and these public functions:

  • virtio_bus_is_modern
  • virtio_with_feature
  • virtqueue_empty
  • virtqueue_full

exclusively return a boolean value.
Change their return values to bool.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cognet added inline comments.
sys/dev/virtio/pci/virtio_pci_legacy.c
91

Hmm those int arguments, disappearing from the virtqueues method, should probably not be removed in that commit :)

sys/dev/virtio/pci/virtio_pci_modern.c
116

ditto

sys/dev/virtio/pci/virtio_pci_legacy.c
91

thanks for catching that.
looks like a botched rebase

thanks to @cognet for helping catch this rebase fuckup.

This revision is now accepted and ready to land.Sep 15 2023, 3:45 AM
This revision was automatically updated to reflect the committed changes.

I reckon this commit can easily be MFC'd without causing too much breakage