Page MenuHomeFreeBSD

virtio_pci_legacy: Allow memory space for configuration
Needs ReviewPublic

Authored by khng300_gmail.com on Sat, Feb 20, 6:11 PM.

Details

Summary

For guests running under some kind of VMMs, configuration structure is
available in memory space but not I/O space.

Reported by: Yuan Rui <number201724@me.com>
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 37294
Build 34183: arc lint + arc unit

Event Timeline

D26915 is marked as superseded by this one, but that one was for virtio_pci.c, and this one is for virtio_pci_legacy.c...?

The old virtio_pci.c code handling legacy Virtio is ported over to
virtio_pci_legacy.c in FreeBSD 13 and -CURRENT

Should we still keep the old differential open?

The old virtio_pci.c code handling legacy Virtio is ported over to
virtio_pci_legacy.c in FreeBSD 13 and -CURRENT

Ah, that makes sense then.

Should we still keep the old differential open?

No, marking it ABANDONED seems correct.

This revision is now accepted and ready to land.Sun, Feb 21, 8:17 PM
khng300_gmail.com retitled this revision from virtio_pci: Allow memory space for configuration to virtio_pci_legacy: Allow memory space for configuration.Tue, Feb 23, 7:37 AM
This revision now requires review to proceed.Tue, Feb 23, 7:41 AM