Details

Reviewers

jhb
bryanv
grehan
rpokala
number201724_me.com
philip

Commits

rG61acb3179a90: virtio_pci_legacy: Allow memory space for configuration
rG2e107638eac2: virtio_pci_legacy: Allow memory space for configuration
rGcf5d1112408d: virtio_pci_legacy: Allow memory space for configuration

Summary

For guests running under some kind of VMMs, configuration structure is
available in memory space but not I/O space.

Reported by: Yuan Rui <number201724@me.com>
MFC after: 2 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37366
Build 34255: arc lint + arc unit

Event Timeline

khng created this revision.Feb 20 2021, 6:11 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2021, 6:11 PM

khng requested review of this revision.Feb 20 2021, 6:11 PM

Harbormaster completed remote builds in B37220: Diff 84335.Feb 20 2021, 6:11 PM

khng added a parent revision: D28817: virtio_pci_legacy: Use the table BAR and PBA BAR from MSI-X cap.Feb 20 2021, 6:11 PM

Catch up with changes from D28817

Harbormaster completed remote builds in B37221: Diff 84336.Feb 20 2021, 6:18 PM

@number201724_me.com Could you test this change also?

D26915 is marked as superseded by this one, but that one was for virtio_pci.c, and this one is for virtio_pci_legacy.c...?

The old virtio_pci.c code handling legacy Virtio is ported over to
virtio_pci_legacy.c in FreeBSD 13 and -CURRENT

Should we still keep the old differential open?

In D28818#645488, @khng300_gmail.com wrote:

The old virtio_pci.c code handling legacy Virtio is ported over to
virtio_pci_legacy.c in FreeBSD 13 and -CURRENT

Ah, that makes sense then.

Should we still keep the old differential open?

No, marking it ABANDONED seems correct.

This revision is now accepted and ready to land.Feb 21 2021, 8:17 PM

bryanv accepted this revision.Feb 23 2021, 3:59 AM

khng retitled this revision from virtio_pci: Allow memory space for configuration to virtio_pci_legacy: Allow memory space for configuration.Feb 23 2021, 7:37 AM

Rebased on top of the most recent D28817.

This revision now requires review to proceed.Feb 23 2021, 7:41 AM

Harbormaster completed remote builds in B37294: Diff 84517.Feb 23 2021, 7:42 AM

Rebased.

Harbormaster completed remote builds in B37366: Diff 84667.Feb 25 2021, 11:41 AM

jhb accepted this revision.Feb 25 2021, 8:01 PM

This revision is now accepted and ready to land.Feb 25 2021, 8:01 PM

After testing, this patch runs normally on alibabacloud

khng added a reviewer: philip.Mar 19 2021, 6:02 AM

Approved by: philip (mentor)

Closed by commit rGcf5d1112408d: virtio_pci_legacy: Allow memory space for configuration (authored by khng). · Explain WhyMar 20 2021, 7:46 AM

This revision was automatically updated to reflect the committed changes.