Page MenuHomeFreeBSD
Differential D27857

Add VirtIO modern support to virtqueue
ClosedPublic
Actions

Authored by bryanv on Dec 30 2020, 11:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 4:34 AM
Unknown Object (File)
Tue, Mar 4, 5:45 PM
Unknown Object (File)
Feb 17 2025, 6:36 AM
Unknown Object (File)
Jan 31 2025, 9:56 AM
Unknown Object (File)
Jan 31 2025, 9:43 AM
Unknown Object (File)
Jan 11 2025, 7:58 PM
Unknown Object (File)
Jan 1 2025, 7:34 PM
Unknown Object (File)
Dec 11 2024, 6:16 PM
View All 69 Files
Subscribers
imp
jrtc27

Details

Reviewers
grehan
Commits
rGfbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bryanv created this revision.Dec 30 2020, 11:26 PM
bryanv held this revision as a draft.
Herald added a subscriber: imp. · View Herald TranscriptDec 30 2020, 11:26 PM
Harbormaster completed remote builds in B35808: Diff 81395.Dec 30 2020, 11:26 PM
bryanv published this revision for review.Dec 30 2020, 11:29 PM
jrtc27 added a subscriber: jrtc27.Dec 30 2020, 11:53 PM
jrtc27 added inline comments.
sys/dev/virtio/virtqueue.c
88

Why have all these fields moved around? I see no functional changes.

399

Unnecessary diff

bryanv updated this revision to Diff 81519.Jan 2 2021, 8:18 PM

Update

Harbormaster completed remote builds in B35861: Diff 81519.Jan 2 2021, 8:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 5:09 AM
Closed by commit rGfbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support (authored by bryanv). · Explain Why
This revision was automatically updated to reflect the committed changes.
bryanv added a commit: rGfbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support.
bryanv added inline comments.Jan 21 2021, 1:40 AM
sys/dev/virtio/virtqueue.c
88

Resort. These are not frequently used

399

Style consistency within this file

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
2 lines
141 lines

Diff 82524

View Options

sys/dev/virtio/virtqueue.h

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Linesec2_common() {
# The emulated keyboard attached to EC2 instances is inaccessible to # The emulated keyboard attached to EC2 instances is inaccessible to
# users, and there is no mouse attached at all; disable to keyboard # users, and there is no mouse attached at all; disable to keyboard
# and the keyboard controller (to which the mouse would attach, if # and the keyboard controller (to which the mouse would attach, if
# one existed) in order to save time in device probing. # one existed) in order to save time in device probing.
echo 'hint.atkbd.0.disabled=1' >> ${DESTDIR}/boot/loader.conf echo 'hint.atkbd.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
echo 'hint.atkbdc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf echo 'hint.atkbdc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
# There is no floppy drive on EC2 instances so disable the driver.
echo 'hint.fd.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
echo 'hint.fdc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
# There is no parallel port on EC2 instances so disable driver.
echo 'hint.ppc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
# EC2 has two consoles: An emulated serial port ("system log"), # EC2 has two consoles: An emulated serial port ("system log"),
# which has been present since 2006; and a VGA console ("instance # which has been present since 2006; and a VGA console ("instance
# screenshot") which was introduced in 2016. # screenshot") which was introduced in 2016.
echo 'boot_multicons="YES"' >> ${DESTDIR}/boot/loader.conf echo 'boot_multicons="YES"' >> ${DESTDIR}/boot/loader.conf
# Some older EC2 hardware used a version of Xen with a bug in its # Some older EC2 hardware used a version of Xen with a bug in its
# emulated serial port. It is not clear if EC2 still has any such # emulated serial port. It is not clear if EC2 still has any such
# nodes, but apply the workaround just in case. # nodes, but apply the workaround just in case.
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines
View Options

sys/dev/virtio/virtqueue.c

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Linesec2_common() {
# The emulated keyboard attached to EC2 instances is inaccessible to # The emulated keyboard attached to EC2 instances is inaccessible to
# users, and there is no mouse attached at all; disable to keyboard # users, and there is no mouse attached at all; disable to keyboard
# and the keyboard controller (to which the mouse would attach, if # and the keyboard controller (to which the mouse would attach, if
# one existed) in order to save time in device probing. # one existed) in order to save time in device probing.
echo 'hint.atkbd.0.disabled=1' >> ${DESTDIR}/boot/loader.conf echo 'hint.atkbd.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
echo 'hint.atkbdc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf echo 'hint.atkbdc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
# There is no floppy drive on EC2 instances so disable the driver.
echo 'hint.fd.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
echo 'hint.fdc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
# There is no parallel port on EC2 instances so disable driver.
echo 'hint.ppc.0.disabled=1' >> ${DESTDIR}/boot/loader.conf
# EC2 has two consoles: An emulated serial port ("system log"), # EC2 has two consoles: An emulated serial port ("system log"),
# which has been present since 2006; and a VGA console ("instance # which has been present since 2006; and a VGA console ("instance
# screenshot") which was introduced in 2016. # screenshot") which was introduced in 2016.
echo 'boot_multicons="YES"' >> ${DESTDIR}/boot/loader.conf echo 'boot_multicons="YES"' >> ${DESTDIR}/boot/loader.conf
# Some older EC2 hardware used a version of Xen with a bug in its # Some older EC2 hardware used a version of Xen with a bug in its
# emulated serial port. It is not clear if EC2 still has any such # emulated serial port. It is not clear if EC2 still has any such
# nodes, but apply the workaround just in case. # nodes, but apply the workaround just in case.
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines