Differential D27857

Add VirtIO modern support to virtqueue
ClosedPublic
Actions

Authored by bryanv on Dec 30 2020, 11:26 PM.

Details

Reviewers

grehan

Commits

rGfbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bryanv created this revision.Dec 30 2020, 11:26 PM

bryanv held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptDec 30 2020, 11:26 PM

Harbormaster completed remote builds in B35808: Diff 81395.Dec 30 2020, 11:26 PM

bryanv published this revision for review.Dec 30 2020, 11:29 PM

jrtc27 added a subscriber: jrtc27.Dec 30 2020, 11:53 PM

jrtc27 added inline comments.

sys/dev/virtio/virtqueue.c
88	Why have all these fields moved around? I see no functional changes.
399	Unnecessary diff

Update

Harbormaster completed remote builds in B35861: Diff 81519.Jan 2 2021, 8:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 5:09 AM

Closed by commit rGfbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support (authored by bryanv). · Explain Why

This revision was automatically updated to reflect the committed changes.

bryanv added a commit: rGfbe0c4f4c7f4: virtio: Add modern (v1) virtqueue support.

bryanv added inline comments.Jan 21 2021, 1:40 AM

sys/dev/virtio/virtqueue.c
88	Resort. These are not frequently used
399	Style consistency within this file

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

virtqueue.h

2 lines

virtqueue.c

141 lines

Diff 82524

View Options

sys/dev/virtio/virtqueue.h