Differential D55343

bhyve: Fix unchecked stream I/O in RFB handler
ClosedPublic
Actions

Authored by hayzam_gmail.com on Wed, Feb 18, 9:48 AM.

Details

Reviewers

markj

Group Reviewers

bhyve

Commits

rG818971cc403e: bhyve: Fix unchecked stream I/O in RFB handler

Summary

Convert rfb_send_* helpers to return status codes and check their results. Add missing checks for stream_read() and stream_write() returns during the handshake in rfb_handle() to avoid acting on failed I/O.

Sponsored by: The FreeBSD Foundation
Signed-off-by: Hayzam Sherif <hayzam@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hayzam_gmail.com created this revision.Wed, Feb 18, 9:48 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptWed, Feb 18, 9:48 AM

hayzam_gmail.com requested review of this revision.Wed, Feb 18, 9:48 AM

hayzam_gmail.com added a reviewer: markj.Wed, Feb 18, 9:51 AM

hayzam_gmail.com edited the summary of this revision. (Show Details)Wed, Feb 18, 10:04 AM

When uploading a raw patch via the web UI, please be sure to add -U999999 per the guidance here: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Otherwise it's hard to read the patch due to missing context.

Regenerated diff with full context (-U999999) as requested

markj accepted this revision as: markj.Thu, Feb 19, 7:21 PM

This revision is now accepted and ready to land.Thu, Feb 19, 7:21 PM

Closed by commit rG818971cc403e: bhyve: Fix unchecked stream I/O in RFB handler (authored by hayzam_gmail.com, committed by markj). · Explain WhyThu, Feb 19, 7:41 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG818971cc403e: bhyve: Fix unchecked stream I/O in RFB handler.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

rfb.c

76 lines

Diff 172280

View Options

bhyve: Fix unchecked stream I/O in RFB handlerClosedPublicActions