Page MenuHomeFreeBSD

adam_fenn.io (Adam Fenn)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2020, 3:23 AM (98 w, 2 d)

Recent Activity

Aug 6 2021

adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Address @kib's feedback.

Aug 6 2021, 8:02 PM
adam_fenn.io updated the diff for D31416: x86: cpufunc: Add rdtsc_ordered().

Address @kib's feedback.

Aug 6 2021, 5:26 AM

Aug 5 2021

adam_fenn.io added inline comments to D29733: kvmclock driver with vDSO support.
Aug 5 2021, 11:48 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Address @kib's feedback.

Aug 5 2021, 11:46 PM
adam_fenn.io added inline comments to D29733: kvmclock driver with vDSO support.
Aug 5 2021, 11:07 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Address @kib's feedback.

Aug 5 2021, 10:58 PM
adam_fenn.io updated the diff for D31418: pvclock: Add vDSO support.

Address @markj's feedback.

Aug 5 2021, 10:53 PM
adam_fenn.io updated the diff for D31416: x86: cpufunc: Add rdtsc_ordered().

Address @kib's feedback.

Aug 5 2021, 10:47 PM
adam_fenn.io updated the diff for D31415: x86: cpufunc: Add rdtscp_aux().

Address @markj's feedback.

Aug 5 2021, 10:41 PM
adam_fenn.io published D31418: pvclock: Add vDSO support for review.
Aug 5 2021, 2:46 AM
adam_fenn.io published D31417: x86: files: Make sys/x86/x86/pvclock.c optional for review.
Aug 5 2021, 2:46 AM
adam_fenn.io published D31416: x86: cpufunc: Add rdtsc_ordered() for review.
Aug 5 2021, 2:44 AM
adam_fenn.io published D31415: x86: cpufunc: Add rdtscp_aux() for review.
Aug 5 2021, 2:44 AM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

No functional changes intended. Since the last revision:

Aug 5 2021, 2:41 AM

Aug 2 2021

adam_fenn.io published D31385: virtio_scsi: pend CAM commands when insufficient descriptors for review.
Aug 2 2021, 7:52 PM
adam_fenn.io updated subscribers of D31004: malloc(9): Document/add aligned variants.
Aug 2 2021, 5:02 PM
adam_fenn.io published D31381: devclass_alloc_unit: move "at" hint test to after device-in-use test for review.
Aug 2 2021, 12:50 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Rebase, address @kib's review feedback, and related clean-up.

Aug 2 2021, 1:59 AM

Jul 9 2021

adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Switch the vDSO and syscall codepaths over to a common (and freestanding) version of __vdso_gettc_rdtsc().

Jul 9 2021, 9:10 PM

Jul 7 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.

Thanks a lot for the review/feedback, @kib! I'm thinking about the questions raised by the init-related item; this revision attempts to address the other items in the meantime.

Jul 7 2021, 6:54 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Initial/partial round of addressing @kib's feedback.

Jul 7 2021, 5:50 PM

Jul 2 2021

adam_fenn.io updated the diff for D31004: malloc(9): Document/add aligned variants.

Address @kib's feedback.

Jul 2 2021, 11:13 PM
adam_fenn.io published D31004: malloc(9): Document/add aligned variants for review.
Jul 2 2021, 9:35 PM

Jul 1 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.

Yes, thanks a lot, @kib, for pointing out malloc_domainset_aligned()! Much better! (Doh---I think I did see this a while back but misinterpreted its relative lack of use and absence from malloc(9) as discouraging new uses).

Jul 1 2021, 7:16 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Use malloc_domainset_aligned() as per @kib's suggestion.

Jul 1 2021, 7:04 PM

Jun 28 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.

Thanks a lot for this latest round of feedback, @royger! Revised accordingly and/or discussion inline.

Jun 28 2021, 11:15 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Address @royger's review feedback.

Jun 28 2021, 10:46 PM

Jun 14 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.
In D29733#691518, @dch wrote:

shall I just drop 11.* from the port, or do you want to make a patch for x86 & x64 versions?

Jun 14 2021, 7:24 PM

May 12 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.

Thanks for the additional round of feedback!

May 12 2021, 5:45 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.
  • Address @royger's review feedback:
    • Disconnect pvclock abstraction from DEVMETHOD etc.
    • Move libc-kernel-shared pvclock.{c,h} content into pvclock.h.
    • Avoid contigmalloc().
  • Identify and push more hypervisor-agnostic content into pvclock.{c,h}.
  • Minor cleanup (non-functional).
May 12 2021, 5:39 PM

May 1 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.

Thanks a lot for your review and feedback; one of the goals is to make it as easy as possible for the XEN PV clock code to piggyback on the vDSO portion of this work, so, your input is greatly appreciated!

May 1 2021, 1:57 AM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Address @royger's review feedback:

  • Switch to using the device pager and only allowing one page to be mmaped by /dev/pvclock.
  • Attempt to identify and push more of the hypervisor-agnostic content into the hypervisor-agnostic pvclock.{c,h} layer.
May 1 2021, 1:41 AM

Apr 20 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.

[...]
All of these are for a KVM vm running under qemu version 5.1.0 on Fedora 33 kernel 5.11.12.

Apr 20 2021, 8:48 PM
adam_fenn.io retitled D29733: kvmclock driver with vDSO support from WIP: kvmclock driver with vDSO support to kvmclock driver with vDSO support.
Apr 20 2021, 8:38 PM
adam_fenn.io updated the diff for D29733: kvmclock driver with vDSO support.

Minor changes and cleanup.

Apr 20 2021, 8:36 PM

Apr 17 2021

adam_fenn.io added a comment to D29733: kvmclock driver with vDSO support.

[...]
I applied the patch to my source tree and while compiling and using the kernel works perfectly, compiling libc failed:

Apr 17 2021, 2:04 AM

Apr 12 2021

adam_fenn.io added a comment to D29531: Add kvmclock timecounter support to FreeBSD.

So if you tell us you have no idea how long it'll take before you get the green light, I'd be for merging that one and for your review to update/rewrite it.

If you tell us you'll have something before summer, I'd say let's wait for you.

It should be days, maybe less.

Apr 12 2021, 6:47 PM
adam_fenn.io published D29733: kvmclock driver with vDSO support for review.
Apr 12 2021, 6:34 PM

Nov 27 2020

adam_fenn.io added a comment to D27375: vmm: Convert vmm_ops calls to IFUNC.

Thanks for the review @grehan and @markj! Diff updated as per @markj's feedback.

Nov 27 2020, 9:35 PM
adam_fenn.io updated the diff for D27375: vmm: Convert vmm_ops calls to IFUNC.

Incorporate review feedback from @markj.

Nov 27 2020, 9:32 PM

Nov 25 2020

adam_fenn.io published D27377: vmm: amd: Remove manual instruction encodings for review.
Nov 25 2020, 11:11 PM
adam_fenn.io published D27375: vmm: Convert vmm_ops calls to IFUNC for review.
Nov 25 2020, 8:14 PM

Nov 18 2020

adam_fenn.io added a comment to D27243: bhyve: Advance RIP after userspace instruction decode.

Thanks for the review, @markj and @cem! Diff updated with @markj's requested changes.

Nov 18 2020, 6:37 PM
adam_fenn.io updated the diff for D27243: bhyve: Advance RIP after userspace instruction decode.

Incorporate review feedback from @markj.

Nov 18 2020, 6:34 PM

Nov 16 2020

adam_fenn.io published D27243: bhyve: Advance RIP after userspace instruction decode for review.
Nov 16 2020, 7:35 PM
adam_fenn.io added inline comments to D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..
Nov 16 2020, 5:41 PM
adam_fenn.io updated the diff for D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..

Remove unnecessary assertion.

Nov 16 2020, 5:40 PM

Nov 13 2020

adam_fenn.io added inline comments to D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..
Nov 13 2020, 10:57 PM

Nov 12 2020

adam_fenn.io added a comment to D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..

Thanks a lot for the review and feedback, @markj! Diff updated and question/response added accordingly.

Nov 12 2020, 11:54 PM
adam_fenn.io updated the diff for D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests..

Incorporate @markj's review feedback and style(9)-ize pctestdev_init()'s local variable declarations.

Nov 12 2020, 11:48 PM

Nov 6 2020

adam_fenn.io published D27130: bhyve: Add legacy debug/test interfaces for kvm unit tests. for review.
Nov 6 2020, 10:52 PM

Aug 23 2020

adam_fenn.io updated the diff for D26166: cpu_auxmsr: assert caller is preventing CPU migration.

Incorporate @kib's review feedback.

Aug 23 2020, 11:34 PM
adam_fenn.io updated the diff for D26166: cpu_auxmsr: assert caller is preventing CPU migration.

Incorporate @kib's review feedback.

Aug 23 2020, 10:36 PM
adam_fenn.io requested review of D26166: cpu_auxmsr: assert caller is preventing CPU migration.
Aug 23 2020, 9:30 PM

Aug 15 2020

adam_fenn.io added a comment to D26003: vmm: intel: Support rdtscp and rdpid.

Thanks a lot for the review and feedback, @grehan and @jhb!

Aug 15 2020, 2:13 AM
adam_fenn.io updated the diff for D26003: vmm: intel: Support rdtscp and rdpid.

Incorporate @jhb's review feedback.

Aug 15 2020, 2:09 AM

Aug 8 2020

adam_fenn.io added a watcher for bhyve: adam_fenn.io.
Aug 8 2020, 12:22 AM

Aug 7 2020

adam_fenn.io requested review of D26003: vmm: intel: Support rdtscp and rdpid.
Aug 7 2020, 11:20 PM