User Details
- User Since
- Aug 7 2020, 3:23 AM (192 w, 6 d)
Aug 6 2021
Address @kib's feedback.
Address @kib's feedback.
Aug 5 2021
Address @kib's feedback.
Address @kib's feedback.
Address @markj's feedback.
Address @kib's feedback.
Address @markj's feedback.
No functional changes intended. Since the last revision:
Aug 2 2021
Rebase, address @kib's review feedback, and related clean-up.
Jul 9 2021
Switch the vDSO and syscall codepaths over to a common (and freestanding) version of __vdso_gettc_rdtsc().
Jul 7 2021
Thanks a lot for the review/feedback, @kib! I'm thinking about the questions raised by the init-related item; this revision attempts to address the other items in the meantime.
Initial/partial round of addressing @kib's feedback.
Jul 2 2021
Address @kib's feedback.
Jul 1 2021
Yes, thanks a lot, @kib, for pointing out malloc_domainset_aligned()! Much better! (Doh---I think I did see this a while back but misinterpreted its relative lack of use and absence from malloc(9) as discouraging new uses).
Use malloc_domainset_aligned() as per @kib's suggestion.
Jun 28 2021
Thanks a lot for this latest round of feedback, @royger! Revised accordingly and/or discussion inline.
Address @royger's review feedback.
Jun 14 2021
May 12 2021
Thanks for the additional round of feedback!
- Address @royger's review feedback:
- Disconnect pvclock abstraction from DEVMETHOD etc.
- Move libc-kernel-shared pvclock.{c,h} content into pvclock.h.
- Avoid contigmalloc().
- Identify and push more hypervisor-agnostic content into pvclock.{c,h}.
- Minor cleanup (non-functional).
May 1 2021
Thanks a lot for your review and feedback; one of the goals is to make it as easy as possible for the XEN PV clock code to piggyback on the vDSO portion of this work, so, your input is greatly appreciated!
Address @royger's review feedback:
- Switch to using the device pager and only allowing one page to be mmaped by /dev/pvclock.
- Attempt to identify and push more of the hypervisor-agnostic content into the hypervisor-agnostic pvclock.{c,h} layer.
Apr 20 2021
Minor changes and cleanup.
Apr 17 2021
Apr 12 2021
Nov 27 2020
Incorporate review feedback from @markj.
Nov 25 2020
Nov 18 2020
Incorporate review feedback from @markj.
Nov 16 2020
Remove unnecessary assertion.
Nov 13 2020
Nov 12 2020
Thanks a lot for the review and feedback, @markj! Diff updated and question/response added accordingly.
Incorporate @markj's review feedback and style(9)-ize pctestdev_init()'s local variable declarations.
Nov 6 2020
Aug 23 2020
Incorporate @kib's review feedback.
Incorporate @kib's review feedback.
Aug 15 2020
Incorporate @jhb's review feedback.