virtio_scsi: pend CAM commands when insufficient descriptors
Needs RevisionPublic
Actions

Authored by adam_fenn.io on Aug 2 2021, 7:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 12, 9:39 PM

	Unknown Object (File)
	Sun, Oct 12, 8:59 PM

	Unknown Object (File)
	Thu, Oct 9, 9:41 PM

	Unknown Object (File)
	Mon, Sep 29, 3:47 PM

	Unknown Object (File)
	Mon, Sep 29, 3:19 AM

	Unknown Object (File)
	Wed, Sep 24, 1:24 AM

	Unknown Object (File)
	Aug 11 2025, 4:59 AM

	Unknown Object (File)
	Aug 3 2025, 6:56 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

imp

Summary

Instead of CAM requeues on resource depletion, pend the cmds. Only
un-pend when there are enough virtio descriptors available.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #60

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40808
Build 37697: arc lint + arc unit

Event Timeline

adam_fenn.io created this revision.Aug 2 2021, 7:49 PM

adam_fenn.io held this revision as a draft.

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 2 2021, 7:49 PM

Harbormaster completed remote builds in B40808: Diff 93132.Aug 2 2021, 7:49 PM

adam_fenn.io published this revision for review.Aug 2 2021, 7:52 PM

SIMs generally are supposed to return the requests to CAM for requeueing like was done before.
Why do this? What's the benefit? Almost no other drivers do this.

This revision now requires changes to proceed.Aug 2 2021, 10:37 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

scsi/

virtio_scsi.c

28 lines

virtio_scsivar.h

3 lines

Diff 93132

View Options

sys/dev/virtio/scsi/virtio_scsi.c