Page MenuHomeFreeBSD

pvclock: Add vDSO support
ClosedPublic

Authored by adam_fenn.io on Aug 5 2021, 2:29 AM.
Tags
None
Referenced Files
F103119331: D31418.diff
Thu, Nov 21, 6:43 AM
Unknown Object (File)
Sat, Nov 16, 8:19 PM
Unknown Object (File)
Fri, Nov 8, 7:35 AM
Unknown Object (File)
Tue, Oct 29, 1:21 AM
Unknown Object (File)
Sep 30 2024, 8:59 AM
Unknown Object (File)
Sep 23 2024, 11:30 PM
Unknown Object (File)
Sep 23 2024, 8:48 PM
Unknown Object (File)
Sep 22 2024, 7:59 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adam_fenn.io held this revision as a draft.
sys/x86/x86/pvclock.c
174

Should it (formally) be atomic_cmpset_rel_64?

177

Could this be written more simply as:

ret = now;
if ((flags & PVCLOCK_FLAG_TSC_STABLE) == 0) {
    last = atomic_load_acq_64(&pvclock_last_systime);
    do {
        if (last > now) {
            ret = last;
            break;
        }
    } while (!atomic_fcmpset_64(&pvclock_last_systime, &last, now);
}

?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2021, 12:59 PM
Closed by commit rG0b3382b863f3: pvclock: Add 'struct pvclock' API (authored by adam_fenn.io, committed by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.