Page MenuHomeFreeBSD

pvclock: Add vDSO support
ClosedPublic

Authored by adam_fenn.io on Aug 5 2021, 2:29 AM.
Tags
None
Referenced Files
F159943524: D31418.diff
Fri, Jun 19, 7:22 PM
Unknown Object (File)
Thu, Jun 18, 8:16 PM
Unknown Object (File)
May 20 2026, 12:20 AM
Unknown Object (File)
May 15 2026, 9:08 PM
Unknown Object (File)
May 15 2026, 6:22 PM
Unknown Object (File)
May 15 2026, 9:39 AM
Unknown Object (File)
May 15 2026, 4:32 AM
Unknown Object (File)
May 15 2026, 3:52 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adam_fenn.io held this revision as a draft.
sys/x86/x86/pvclock.c
174

Should it (formally) be atomic_cmpset_rel_64?

177

Could this be written more simply as:

ret = now;
if ((flags & PVCLOCK_FLAG_TSC_STABLE) == 0) {
    last = atomic_load_acq_64(&pvclock_last_systime);
    do {
        if (last > now) {
            ret = last;
            break;
        }
    } while (!atomic_fcmpset_64(&pvclock_last_systime, &last, now);
}

?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2021, 12:59 PM
Closed by commit rG0b3382b863f3: pvclock: Add 'struct pvclock' API (authored by adam_fenn.io, committed by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.