- User Since
- Oct 8 2015, 1:03 AM (224 w, 4 d)
Thu, Jan 16
Any chance you have a second to review this mav?
Tue, Dec 31
Looks like a good change to me.
Mon, Dec 30
Sounds like a great solution
I'm not the one to review this whole thing but to my knowledge looks good except for single typo I found
Dec 28 2019
Looks like a good start but should it be even more robust to stop collision.
Dec 20 2019
Looks good except for one typo in man page.
Nov 21 2019
Trying to understand your bootp comment in summary. Are you pointing at no support yet for https://tools.ietf.org/html/rfc5970 or that there just isn't a ipv6 option for defining boot info like bootp had?
Oct 24 2019
Thanks don't know how I missed that commit.
Oct 17 2019
Just curious what is this a fix for? I assume some specific type or class of hardware.
Sep 12 2019
@imp Is it possible to get this and acpi_ibm autoloaded with devmatch? Not sure if it would work with current structure or need additional code paths inside devmatch itself.
Aug 20 2019
Closed by commit r509197
Aug 17 2019
@woodsb02 I think your clear to commit whenever you have time.
Aug 16 2019
Aug 13 2019
Updated diff to fix issues.
Fixed missing plugins/ports and issues raised above.
Just realized that I missed the added ports(remmina plugins) will also need to add those.
Aug 11 2019
Covered all wanted alphabetical fixes plus a few more I found during review
Aug 7 2019
Of course I will get those cleaned up slipped through my final checks.
Thanks for the greenlight if you can commit it that would be great.
Aug 6 2019
Missed a telepathy reference for it's description. (Purposely left references in the plugin mk file in case telepathy is reactivated in future)
Aug 26 2018
Tested this patch on head(trueos synced as of the 19th + vlan fix from np) with ix and cc(cxgbe) drivers. No issue with creation of vlans and nothing noticeable in cursory testing with ping floods and iperf.
Jun 29 2018
Thanks for the help kristof. I couldn't find the documentation to bound input of sysctl's but I definitely agree it's better to validate it on entry.
Updated with help from kristof to validate sysctl on change.
Jun 8 2018
Update sysctl to be based on decimal dscp value instead of toggle
Apr 11 2018
Mar 2 2018
Feb 27 2018
Fixed default setting of new sysctl in man page.