Page MenuHomeFreeBSD

woodsb02 (Ben Woods)
User

Projects

User Details

User Since
Aug 19 2015, 10:52 PM (160 w, 6 d)

Recent Activity

Sat, Sep 15

woodsb02 removed a reviewer for D17048: New port: multimedia/gstreamermm1: portmgr.
Sat, Sep 15, 1:57 AM

Thu, Sep 13

woodsb02 added reviewers for D17048: New port: multimedia/gstreamermm1: bapt, ehaupt, kwm, riggs.
Thu, Sep 13, 11:05 PM
woodsb02 added reviewers for D17042: Update multimedia/pitivi to 0.99: bapt, ehaupt, riggs.
Thu, Sep 13, 11:04 PM
woodsb02 added a comment to D17048: New port: multimedia/gstreamermm1.

Hi @mat,
As portmgr, can you please approve the changes to Mk/bsd.gstreamer.mk?
Thanks,
Ben

Thu, Sep 13, 10:58 PM

Mon, Sep 10

woodsb02 added a comment to D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

This change has been reverted pending POLA dicusssions. Refer rS479438

Mon, Sep 10, 11:37 PM
woodsb02 added a comment to D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
In D17086#364678, @bapt wrote:

I think there is absolutely no POLA here as this is a configuration, there should be some warning in the release Release note about it and that is all imho.
Considering the option to only blacklist certain patterns: dotfiles, .pkgnew etc the problem is one would need to do more than that:
remove patch leftovers: .orig, .rej, .bak
editors leftovers file~ file.bak, etc

There are too many patterns to consider

Mon, Sep 10, 10:41 PM
woodsb02 added a comment to D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.

I think I like cem's idea to only include files if they do not start with a "." or finish with ".pkgnew", ".sample" or ".bak" (any others?).

Mon, Sep 10, 4:21 PM
woodsb02 abandoned D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Abandon this change - relocating existing conf files violates POLA.

Mon, Sep 10, 4:19 PM
woodsb02 abandoned D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Abandon this change - relocating existing conf files violates POLA.

Mon, Sep 10, 4:19 PM
woodsb02 abandoned D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Abandon this change - relocating existing conf files violates POLA.

Mon, Sep 10, 4:18 PM
woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Ok. I have reverted the changes to net/ntpa and mail/mailman - these were the only ones which install the conf file for you.

Mon, Sep 10, 4:17 PM
woodsb02 committed rP479438: Revert r479294 - relocation of existing conf files violates POLA.
Revert r479294 - relocation of existing conf files violates POLA
Mon, Sep 10, 4:07 PM
woodsb02 committed rP479436: Revert r479279 - the relocation of existing conf files violates POLA.
Revert r479279 - the relocation of existing conf files violates POLA
Mon, Sep 10, 4:04 PM
woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Also, what are your thoughts on the way forward for the ports below which already have this change committed:

  • net/ntpa
  • mail/mailman
  • security/acme.sh
Mon, Sep 10, 3:17 PM
woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Can I please check that you agree with the value of only including .conf files (e.g. if the "include" was new functionality), but just disagree with the necessary changes as they violate POLA?

Mon, Sep 10, 3:07 PM
woodsb02 committed rS338558: geli init with multiple providers - fix init and fix -B "none".
geli init with multiple providers - fix init and fix -B "none"
Mon, Sep 10, 2:51 PM
woodsb02 closed D17096: geli init with multiple providers - fix init and fix -B "none".
Mon, Sep 10, 2:51 PM
woodsb02 updated the diff for D17096: geli init with multiple providers - fix init and fix -B "none".

Move all explicit_bzero commands to end of the for loop for each provider, as per asomers comment.

Mon, Sep 10, 2:36 PM
woodsb02 added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Mon, Sep 10, 1:58 PM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Incorporate pkg-install script to move old newsyslog.conf.d script to new location, addressing concerns raised by mat.
This will both prevent local modifications being reverted to default, and also clean up the old script file.

Mon, Sep 10, 1:54 PM
woodsb02 updated the diff for D17096: geli init with multiple providers - fix init and fix -B "none".

Fix comment as per asomers recommendation.
Also fix other comments, optimise if ordering and bzero sensitive and provider specific metadata.

Mon, Sep 10, 1:13 PM
woodsb02 committed rP479403: net/ladvd: Update to 1.1.2.
net/ladvd: Update to 1.1.2
Mon, Sep 10, 12:56 PM

Sun, Sep 9

woodsb02 committed rP479341: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sun, Sep 9, 10:48 PM
woodsb02 closed D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 10:48 PM
woodsb02 committed rP479294: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sun, Sep 9, 4:18 PM
woodsb02 closed D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 4:18 PM
woodsb02 added a comment to D17096: geli init with multiple providers - fix init and fix -B "none".

These issues were found whilst preparing some Kyua tests for the new geli functionality.

Sun, Sep 9, 4:15 PM
woodsb02 created D17096: geli init with multiple providers - fix init and fix -B "none".
Sun, Sep 9, 4:14 PM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 8:48 AM
woodsb02 added a parent revision for D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sun, Sep 9, 8:48 AM
woodsb02 created D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 8:48 AM
woodsb02 added a parent revision for D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sun, Sep 9, 8:41 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 8:41 AM
woodsb02 created D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 8:40 AM
woodsb02 committed rP479279: net/ntpa: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
net/ntpa: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sun, Sep 9, 8:29 AM
woodsb02 committed rP479278: www/polipo: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
www/polipo: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sun, Sep 9, 8:24 AM
woodsb02 added a parent revision for D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sun, Sep 9, 7:28 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 7:28 AM
woodsb02 created D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 7:28 AM
woodsb02 added a parent revision for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sun, Sep 9, 7:25 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 7:25 AM
woodsb02 created D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 7:25 AM
woodsb02 added a parent revision for D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sun, Sep 9, 7:17 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 7:17 AM
woodsb02 created D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sun, Sep 9, 7:16 AM
woodsb02 added reviewers for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: cem, markj, bapt, eadler.
Sun, Sep 9, 5:37 AM
woodsb02 added a reviewer for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: releng.
Sun, Sep 9, 5:23 AM
woodsb02 created D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sun, Sep 9, 5:07 AM
woodsb02 committed rP479266: Fix fetch by updating GH_TAGNAME as required by r479255.
Fix fetch by updating GH_TAGNAME as required by r479255
Sun, Sep 9, 3:43 AM

Sat, Sep 8

woodsb02 added inline comments to D17048: New port: multimedia/gstreamermm1.
Sat, Sep 8, 4:45 AM
woodsb02 updated the diff for D17048: New port: multimedia/gstreamermm1.

Re-order multimedia/gstreamermm1 Makefile per mat's comment

Sat, Sep 8, 4:42 AM

Thu, Sep 6

woodsb02 created D17048: New port: multimedia/gstreamermm1.
Thu, Sep 6, 12:24 PM
woodsb02 added a reviewer for D17048: New port: multimedia/gstreamermm1: multimedia.
Thu, Sep 6, 12:24 PM
woodsb02 added a reviewer for D17042: Update multimedia/pitivi to 0.99: multimedia.
Thu, Sep 6, 12:24 PM

Wed, Sep 5

woodsb02 created D17042: Update multimedia/pitivi to 0.99.
Wed, Sep 5, 10:38 AM

Tue, Aug 28

woodsb02 committed rP478294: net/remmina-plugins: Fix portscout.
net/remmina-plugins: Fix portscout
Tue, Aug 28, 9:37 AM

Mon, Aug 27

woodsb02 accepted D16905: sysutils/bvm: Update to 1.1.4.

Hi ygy,
This change looks ok to me, but please make sure you have the maintainers permission before committing (or wait the obligatory 2 weeks).
The typical way to do this is with a bug report.
Regards,
Ben

Mon, Aug 27, 1:15 PM
woodsb02 committed rP478203: net/remmina: Update to 1.2.31.4.
net/remmina: Update to 1.2.31.4
Mon, Aug 27, 1:05 PM
woodsb02 committed rP478200: net/freerdp: Update to 2.0.0-rc3.
net/freerdp: Update to 2.0.0-rc3
Mon, Aug 27, 1:02 PM
woodsb02 closed D16918: net/freerdp: Update to 2.0.0-rc3.
Mon, Aug 27, 1:02 PM
woodsb02 added a comment to D16918: net/freerdp: Update to 2.0.0-rc3.

Note that updating net/freerdp to 2.0.0-rc3 is a prerequisite to updating net/remmina to 1.2.31.4 (net/remmina-plugin-rdp version 1.2.31.4 does not compile with net/freerdp 2.0.0-rc1).

Mon, Aug 27, 12:38 PM
woodsb02 created D16918: net/freerdp: Update to 2.0.0-rc3.
Mon, Aug 27, 12:35 PM

Aug 4 2018

woodsb02 committed rP476334: multimedia/emby-server: Update to 3.5.2.0.
multimedia/emby-server: Update to 3.5.2.0
Aug 4 2018, 5:18 AM

Jul 28 2018

woodsb02 committed rP475490: multimedia/emby-server: Update to 3.5.0.0.
multimedia/emby-server: Update to 3.5.0.0
Jul 28 2018, 5:31 AM
woodsb02 committed rP475487: multimedia/emby-server: Update to 3.4.1.0.
multimedia/emby-server: Update to 3.4.1.0
Jul 28 2018, 3:27 AM

Jul 23 2018

woodsb02 added a comment to D16115: geli init multiple providers.

Thanks for your review Alan and Maxim.
Alan: I will try to create some tests for this new geli functionality this weekend, and will submit a phabricator review once it is ready. I am new to Kyua tests, so we will see how it goes.

Jul 23 2018, 11:35 PM
woodsb02 committed rS336659: geli init: Allow initialization of multiple geli providers at once if.
geli init: Allow initialization of multiple geli providers at once if
Jul 23 2018, 11:04 PM
woodsb02 closed D16115: geli init multiple providers.
Jul 23 2018, 11:04 PM

Jul 22 2018

woodsb02 added a reviewer for D16115: geli init multiple providers: asomers.
Jul 22 2018, 10:33 PM
woodsb02 updated the summary of D16115: geli init multiple providers.
Jul 22 2018, 1:52 PM
woodsb02 updated the diff for D16115: geli init multiple providers.

Update style to match r336602

Jul 22 2018, 1:51 PM
woodsb02 added a comment to D16386: geli attach: Fix exit codes and errors not being printed after r335673.

Thanks for your review Alan and Allan!

Jul 22 2018, 1:44 PM
woodsb02 committed rS336602: geli attach: Fix exit codes and errors not being printed after r335673.
geli attach: Fix exit codes and errors not being printed after r335673
Jul 22 2018, 1:41 PM
woodsb02 closed D16386: geli attach: Fix exit codes and errors not being printed after r335673.
Jul 22 2018, 1:41 PM
woodsb02 updated the summary of D16386: geli attach: Fix exit codes and errors not being printed after r335673.
Jul 22 2018, 2:15 AM
woodsb02 updated the test plan for D16386: geli attach: Fix exit codes and errors not being printed after r335673.
Jul 22 2018, 2:15 AM
woodsb02 created D16386: geli attach: Fix exit codes and errors not being printed after r335673.
Jul 22 2018, 2:14 AM

Jul 21 2018

woodsb02 committed rP475050: security/vuxml: Add CVE details for VLC vulnerability.
security/vuxml: Add CVE details for VLC vulnerability
Jul 21 2018, 6:59 AM
woodsb02 committed rP475048: security/vuxml: document VLC vulnerability.
security/vuxml: document VLC vulnerability
Jul 21 2018, 6:51 AM

Jul 19 2018

woodsb02 committed rP474984: Add new port sysutils/bvm.
Add new port sysutils/bvm
Jul 19 2018, 11:22 PM
woodsb02 closed D16074: [NEW PORT] sysutils/bvm: Bhyve VM Manager-Bhyve virtual machine management tool.
Jul 19 2018, 11:22 PM
woodsb02 committed rP474983: sysutils/catfish: Update to 1.4.6.
sysutils/catfish: Update to 1.4.6
Jul 19 2018, 10:36 PM

Jul 5 2018

woodsb02 updated the summary of D16115: geli init multiple providers.
Jul 5 2018, 2:55 PM
woodsb02 updated the diff for D16115: geli init multiple providers.

Incorporate manpage comment from bcr

Jul 5 2018, 2:54 PM

Jul 3 2018

woodsb02 created D16115: geli init multiple providers.
Jul 3 2018, 5:53 PM

Jul 2 2018

woodsb02 requested changes to D16074: [NEW PORT] sysutils/bvm: Bhyve VM Manager-Bhyve virtual machine management tool.

Hi guoqiang, thanks for submitting this new port! I have a few comments for you before it gets committed.

Jul 2 2018, 11:15 PM

Jul 1 2018

woodsb02 committed rP473672: sysutils/gksu and sysutils/libgksu: Fix gksudo not running command.
sysutils/gksu and sysutils/libgksu: Fix gksudo not running command
Jul 1 2018, 3:15 PM

Jun 26 2018

woodsb02 committed rS335673: geli attach multiple providers.
geli attach multiple providers
Jun 26 2018, 6:07 PM
woodsb02 closed D12644: geli attach multiple providers (no kernel changes).
Jun 26 2018, 6:07 PM
woodsb02 updated the diff for D12644: geli attach multiple providers (no kernel changes).

Rebase on r335667

Jun 26 2018, 2:59 PM
woodsb02 updated the diff for D12644: geli attach multiple providers (no kernel changes).

Update diff to implement comments from wblock, delphij, sobomax in D9396

Jun 26 2018, 2:00 PM
woodsb02 abandoned D9396: geli attach multiple providers (with kernel changes).

Abandon this change in favour of the review which only touches userland: D12644.

Jun 26 2018, 1:53 PM

Jun 16 2018

woodsb02 accepted D15790: Update devel/py-gitpython to 2.1.10.
Jun 16 2018, 7:01 AM

Jun 13 2018

woodsb02 accepted D15790: Update devel/py-gitpython to 2.1.10.

Approved for commit.

Jun 13 2018, 10:49 PM
woodsb02 accepted D15783: Update devel/py-decorator to 2.3.0.

Other than the previously mentioned changes to the title and summary (incorrect version mentioned), this revision looks fine to me. Approved to commit.

Jun 13 2018, 10:40 PM
woodsb02 added a comment to D15783: Update devel/py-decorator to 2.3.0.

The revision title and summary state this is updating to 2.3.0, but the diff shows an update to 4.3.0.

Jun 13 2018, 10:32 PM
woodsb02 added a comment to D15783: Update devel/py-decorator to 2.3.0.

The review title and summary refer to port devel/py-gitpython, but the diff refers to port devel/py-decorator?

Jun 13 2018, 10:23 AM

Jun 11 2018

woodsb02 accepted D15730: Update misc/thefuck to 3.27.

Thanks for the new diff using arcanist. Approved to commit (with svn).

Jun 11 2018, 2:19 PM

Jun 10 2018

woodsb02 accepted D15730: Update misc/thefuck to 3.27.

Looks good - approved for commit :)

Jun 10 2018, 9:01 AM

Jun 7 2018

woodsb02 accepted D14899: devel/py-gitpython: Update to 2.1.9.

Approved for you to commit.

Jun 7 2018, 10:49 PM