Sorry, I won’t be able to help with testing this, as I no longer have the multicast routing setup that I previously had when I reported this bug. Thanks for following up on it though!

I am ok with this change, and provide my approval to proceed as a ports committer.
@ngie - would you like to commit this, or would you like me to? Please note the maintainer timeout discussion below.

Hi madpilot,

In D22012#480875, @imp wrote:

Where was this discussed?

Agree the timing is not right for this yet.
I noticed that the time-out plugin has had commits in the last 5 days to move it towards GTK3. https://git.xfce.org/panel-plugins/xfce4-time-out-plugin/log/

No rush to this, just a thought that we should strive to:

1. Minimise footprint where it doesn’t sacrifice daily use functionality - rather not install GTK twice. To that end, I was going through an exercise to see if I could have Xfce and goodies installed without GTK2 - it wasn’t easy.
2. Those programs/plugins which have not moved to GTK3 yet tend to be stale/unmaintained, and should probably therefore be off by default, unless they are fundamental. Users can still elect to pkg install them manually.

Yep, agreed.

ping - any thoughts on this propose change?

Remove trailing \ character

In D21654#473469, @ngie wrote:

How did you determine this list BTW: using INDEX, etc?

Hi ngie,

This has now been committed, and this review can be closed (not sure why this wasn't automatically picked up by phabricator):
https://reviews.freebsd.org/rP509197

One more comment on how to submit phabricator reviews - it is best if the full context of the diff is submitted (allowing me to expand the other parts of the files in between the changes if I am looking for more context).
This can be done using the "arc" command, or by generating the diff with "svn diff --diff-cmd=diff -x -U999999 > change.diff".
This is described here: https://wiki.freebsd.org/Phabricator

This only minor comment I would make, is that I prefer to keep things alphabetical in Makefile entries. I have pointed these out with inline comments, but happy for this to be committed without these being changed, as it is only a preference.

Hi Nick,
Thanks for submitting this diff - it looks like great work, and I am happy for it to be committed.
Given you are not using an @freebsd.org account here, I assume you do not have a commit bit? Would you like me to commit this on your behalf?
Regards,
Ben

As per comment from madpilot, manually strip the patch from upstream,
rather than getting the ports framework to do it

Hi mizhka,