Incorporate manpage comment from bcr

Hi guoqiang, thanks for submitting this new port! I have a few comments for you before it gets committed.

Rebase on r335667

Update diff to implement comments from wblock, delphij, sobomax in D9396

Abandon this change in favour of the review which only touches userland: D12644.

Approved for commit.

Other than the previously mentioned changes to the title and summary (incorrect version mentioned), this revision looks fine to me. Approved to commit.

The revision title and summary state this is updating to 2.3.0, but the diff shows an update to 4.3.0.

The review title and summary refer to port devel/py-gitpython, but the diff refers to port devel/py-decorator?

Thanks for the new diff using arcanist. Approved to commit (with svn).

Looks good - approved for commit :)

Approved for you to commit.

In D14899#328651, @mat wrote:

Why bump dependant ports?

Hi Guangyuan,
According to https://www.freshports.org/devel/py-gitpython, there are 3 ports which depend on this port:
devel/py-git-up
devel/py-git_semver
security/w3af

Hi Ed, I haven’t had a chance to do a full review yet, but here are some initial comments for your consideration.

I believe the syslogd(8) manpage should be updated with this patch to provide details on the current functionality. Something along the following lines:

Hi ed, this is a really nice start at supporting RFC5424 logging format - you have obviously put a lot of work into it - thank you! It was far better than my initial attempt in D14918 which only brought the new timestamp format without the other required syntax updates - so I have abandoned my review.
I have reviewed this patch of your thoroughly, and provided some comments. Please be aware that I have not yet tested this patch and I don't have a lot of FreeBSD src experience (I am a ports committer) - hopefully my comments are helpful and not naïve.

This revision breaks compliance with RFC3164 (by not using the mandated timestamp format Mmm dd hh:mm:ss), without adding compliance with RFC5424 (which requires a VERSION number and space between the PRI and the TIMESTAMP).
https://tools.ietf.org/html/rfc3164#section-4.1.2
https://tools.ietf.org/html/rfc5424#section-6

Hi ygy,
This review is marked as "changes planned" - was this deliberate? If so, can you describe the problems you have found which are planning to address?
Cheers,
Ben

In D14918#313737, @dhw wrote:

I like the idea -- particularly including the year. As for "logging in UTC," I found an approach that does fairly well (though it is a bit of a configuration hack): Just run the machines in UTC, but augment /etc/rc.conf (or similar) with (e.g.):

cron_program="/usr/bin/env"
cron_flags="TZ=America/Los_Angeles /usr/sbin/cron"

(Known issue: the approach doesn't keep newsyslog's actions in sync with local time; I haven't been bothered enough by that to try to do anything about it,)

I also note that it has been more than 3 months since the original PR was submitted, which is sufficient maintainer timeout to take the maintainership.

Hi Guangyuan,

I have voted for a move to less being the default, because I like the extra features it provides and it also likely what new users coming to FreeBSD would expect.