Page MenuHomeFreeBSD

woodsb02 (Ben Woods)
Ports Committer

Projects

User Details

User Since
Aug 19 2015, 10:52 PM (456 w, 6 d)

Recent Activity

Jan 8 2024

woodsb02 committed R11:0533cd67fb6b: sysutils/nerdctl: Fix ENOTIME: return my ports to the pool (authored by woodsb02).
sysutils/nerdctl: Fix ENOTIME: return my ports to the pool
Jan 8 2024, 11:20 PM
woodsb02 committed R11:6072a5dd1ae3: sysutils/nerdctl: Update to 1.7.2 (authored by woodsb02).
sysutils/nerdctl: Update to 1.7.2
Jan 8 2024, 11:20 PM

Jan 4 2024

woodsb02 updated subscribers of D43127: net/freerdp3: new port 3.1.0 + fix net/remmina to build with installed net/freerdp3.
Jan 4 2024, 11:07 PM

Jul 19 2023

woodsb02 updated subscribers of D41092: libthr: Use a small cache to greatly reduce pshared lock latency..
Jul 19 2023, 9:24 PM · Src Committers

Mar 30 2023

woodsb02 added inline comments to D38987: Count used root directory entries in FAT12/16 file systems.
Mar 30 2023, 10:44 PM

Mar 28 2023

woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

dhcpcd-10 will be released in the next few week or so. Following that, I intend to update this diff to target importing dhcpcd into base ahead of the FreeBSD-14 code slush.

Mar 28 2023, 10:52 PM

Mar 12 2023

woodsb02 added a comment to D38987: Count used root directory entries in FAT12/16 file systems.

My testing seems to show this is working correctly
I've tested this by building a new FreeBSD-CURRENT disc1.iso, installing it into a bhyve VM that was booted with UEFI and installing with the default ZFS installer.
Upon reboot, the /boot/efi folder is automatically mounted by default with the FAT16 file system from /dev/gpt/efiboot0.
If I create files in the root directory with upper case names, the output of "df -i" increases by 1. If I use lower case names, it increases by 2. If I use long names, it increases by bigger increments depending on the length of the name.
Once I create enough files that I am no longer able to create more files in the root directory (error is "No space left on device"), then "df -i" shows the inodes are 100% full.

Mar 12 2023, 8:48 AM

Mar 9 2023

woodsb02 added a comment to D38987: Count used root directory entries in FAT12/16 file systems.

How difficult would it be to make it also work for FAT32 filesystems?

Mar 9 2023, 9:42 AM

Mar 8 2023

woodsb02 added a comment to D38987: Count used root directory entries in FAT12/16 file systems.

Hi Stefan,

Mar 8 2023, 10:47 PM

Mar 2 2023

woodsb02 committed R11:c51c820a324e: sysutils/nerdctl: Update to 1.2.1 (authored by woodsb02).
sysutils/nerdctl: Update to 1.2.1
Mar 2 2023, 6:32 AM

Feb 26 2023

woodsb02 committed R11:559cbc35f8e6: sysutils/nerdctl: Update to 1.2.0 (authored by woodsb02).
sysutils/nerdctl: Update to 1.2.0
Feb 26 2023, 10:51 PM

Jan 4 2023

woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

Sorry for not providing an update on this sooner.
The summary is I was waiting on the next release of dhcpcd before proceeding with importing it into base.
The reason was a regression related to capsicum was noticed with FreeBSD-14 starting in August 2022 where the privilged process could no longer write to the routing table. This issue isn't occurring on FreeBSD-13, nor FreeBSD-14 from 2021.
@roy_marples.name found and fixed the issue in dhcpcd, but only in what will become dhcpcd-10 (it's too invasive for dhcpcd-9 at this point which is the stable branch).
The dhcpcd-10 has been delayed a bit, since Roy has a few health issues that are his priority right now.
That said, I'm still hoping this can be merged into FreeBSD-14 before the code slush begins on 25th April 2023.

Jan 4 2023, 10:47 PM
woodsb02 closed D37928: x11/slick-greeter: Update to 1.6.0.
Jan 4 2023, 1:32 PM
woodsb02 committed R11:19e5c89e9e46: x11/slick-greeter: Update to 1.6.0 (authored by woodsb02).
x11/slick-greeter: Update to 1.6.0
Jan 4 2023, 1:32 PM

Jan 2 2023

woodsb02 requested review of D37928: x11/slick-greeter: Update to 1.6.0.
Jan 2 2023, 11:14 AM

Dec 28 2022

woodsb02 added inline comments to D37889: net-mgmt/netdata: Update to 1.37.1.
Dec 28 2022, 11:11 PM
woodsb02 committed R11:ee5ed3ea4226: sysutils/nerdctl: Update to 1.1.0 (authored by woodsb02).
sysutils/nerdctl: Update to 1.1.0
Dec 28 2022, 6:35 AM
woodsb02 committed R11:14e7c1f66098: net-mgmt/netdata: Update to 1.37.1 (authored by woodsb02).
net-mgmt/netdata: Update to 1.37.1
Dec 28 2022, 5:37 AM
woodsb02 closed D37889: net-mgmt/netdata: Update to 1.37.1.
Dec 28 2022, 5:37 AM
woodsb02 updated the diff for D37889: net-mgmt/netdata: Update to 1.37.1.

Added the FREEIPMI plist entry back in

Dec 28 2022, 5:18 AM
woodsb02 added a comment to D37889: net-mgmt/netdata: Update to 1.37.1.

I have compared my patch with that provided by Namkhai B. <me@forkbomb9.ch> - they are almost identical (great minds think alike).
A few minor differences outlined below - I'll update the review with the FREEIPMI plist entry added back in. No other changes necessary.

Dec 28 2022, 5:16 AM
woodsb02 added a comment to D37889: net-mgmt/netdata: Update to 1.37.1.

It wasn't really clear to me what is changed in the custom dashboard which was previously applied when the CLOUD option was disabled during the FreeBSD port build.

Dec 28 2022, 1:46 AM
woodsb02 requested review of D37889: net-mgmt/netdata: Update to 1.37.1.
Dec 28 2022, 1:40 AM
woodsb02 committed R11:7ee4b5097a25: security/vuxml: Document Netdata multiple vulnerabilities (authored by woodsb02).
security/vuxml: Document Netdata multiple vulnerabilities
Dec 28 2022, 12:07 AM

Dec 27 2022

woodsb02 committed R11:b02e58aec16f: net-mgmt/netdata: Enable CLOUD option by default (authored by woodsb02).
net-mgmt/netdata: Enable CLOUD option by default
Dec 27 2022, 1:04 AM
woodsb02 closed D37453: net-mgmt/netdata: Enable CLOUD option by default.
Dec 27 2022, 1:04 AM

Dec 6 2022

woodsb02 added a comment to D37453: net-mgmt/netdata: Enable CLOUD option by default.

ping @nc - any thoughts on this proposed change to the default options of the net-mgmt/netdata port?

Dec 6 2022, 10:04 PM

Nov 22 2022

woodsb02 added a comment to D37453: net-mgmt/netdata: Enable CLOUD option by default.

This should be a flavor rather than default?

Nov 22 2022, 2:46 PM

Nov 21 2022

woodsb02 requested review of D37453: net-mgmt/netdata: Enable CLOUD option by default.
Nov 21 2022, 2:19 PM

Oct 29 2022

woodsb02 committed R11:d65346d3f4ae: x11/slick-greeter: Update to 1.5.9 (authored by woodsb02).
x11/slick-greeter: Update to 1.5.9
Oct 29 2022, 8:45 AM
woodsb02 committed R11:2f899ca28078: sysutils/nerdctl: Update to 1.0.0 (authored by woodsb02).
sysutils/nerdctl: Update to 1.0.0
Oct 29 2022, 8:38 AM

Oct 6 2022

woodsb02 added a comment to D36879: bsdinstall: Fix race condition when shutting down after installation.

Interesting - I hadn’t noticed any issue during my previous testing - thanks for finding and fixing this

Oct 6 2022, 7:00 PM

Sep 17 2022

woodsb02 committed rGe4505364c087: release/rc.local: Provide option to shutdown after installation complete (authored by woodsb02).
release/rc.local: Provide option to shutdown after installation complete
Sep 17 2022, 12:08 AM
woodsb02 closed D36560: release/rc.local: Provide option to shutdown after installation complete.
Sep 17 2022, 12:08 AM

Sep 16 2022

woodsb02 added a comment to D36560: release/rc.local: Provide option to shutdown after installation complete.

Thanks - you happy for me to put approved by: philip (your src commit approval)?

Sep 16 2022, 8:35 AM

Sep 15 2022

woodsb02 accepted D36481: bridge.4: describe new MTU behaviour.

Looks good to me. Thanks for all your work on making the bridge interface faster and more user friendly Kristof!

Sep 15 2022, 11:00 PM
woodsb02 added a comment to D36481: bridge.4: describe new MTU behaviour.

Looks good! Can I propose also adding some additional info describing the new behaviour when the MTU of an existing bridge is changed?

Sep 15 2022, 6:49 AM
woodsb02 updated the test plan for D36560: release/rc.local: Provide option to shutdown after installation complete.
Sep 15 2022, 6:41 AM
woodsb02 updated the test plan for D36560: release/rc.local: Provide option to shutdown after installation complete.
Sep 15 2022, 6:30 AM

Sep 14 2022

woodsb02 updated the summary of D36560: release/rc.local: Provide option to shutdown after installation complete.
Sep 14 2022, 1:23 PM
woodsb02 requested review of D36560: release/rc.local: Provide option to shutdown after installation complete.
Sep 14 2022, 1:22 PM

Sep 12 2022

woodsb02 committed R11:8b2dd874661e: sysutils/nerdctl: Update to 0.23.0 (authored by woodsb02).
sysutils/nerdctl: Update to 0.23.0
Sep 12 2022, 4:58 AM

Sep 3 2022

woodsb02 added a comment to D36222: pkgbase: Put dhclient in its own package.
In D36222#826605, @manu wrote:
In D36222#826487, @imp wrote:

How else would you package rescue? It's a single binary with lots of hard links. It makes no sense to
package it as anything other than a single package.

I’m thinking of the situation where I’ve decided I don’t want dhclient, so I remove the dhclient package (or never install it) but I do have the rescue package.

As long as we build dhclient by default (we don't have WITH_DHCLIENT or something like that right now) dhclient will always be part of rescue.

In that case would the /rescue/dhclient be a hard link to nowhere, or would it contain its own copy of the file?

All rescue binaries are crunched together with crunchgen in /rescue/rescue and then we create some hardlink for all the files that we crunched so without installing FreeBSD-dhclient you will still have a dhclient in /rescue.

Sep 3 2022, 12:43 AM

Aug 31 2022

woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..
In D22012#826644, @pauamma wrote:

Some or all of this needs pushing upstream instead of/in addition to local changes. Since the upstream maintainer is subscribed, I haven't made the distinction.

Aug 31 2022, 7:54 AM
woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..
In D22012#826694, @imp wrote:

I'd suggest updating this review to be a diff against the copy of dhcpcd now in vendor/ merged into contrib/, so that changes if any to existing dhcpcd files are clear

That would help me greatly bringing any changes requested here upstream.

and hopefully it will be easier to review here too :)
Win win

Aug 31 2022, 6:34 AM
woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

I'd suggest updating this review to be a diff against the copy of dhcpcd now in vendor/ merged into contrib/, so that changes if any to existing dhcpcd files are clear

Aug 31 2022, 6:20 AM
woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

how to specifically disable ipv6 ( or ipv4 ) when dhcpcd is in /usr/src?

Aug 31 2022, 6:01 AM
woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Fix build WITHOUT_INET=yes: move SRCS+=privsep-bpf.c inside .if ${MK_INET_SUPPORT}

Aug 31 2022, 5:34 AM

Aug 30 2022

woodsb02 added a comment to D36222: pkgbase: Put dhclient in its own package.
In D36222#826487, @imp wrote:

How else would you package rescue? It's a single binary with lots of hard links. It makes no sense to
package it as anything other than a single package.

Aug 30 2022, 9:40 AM

Aug 29 2022

woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Fix build Makefile by adding .include <src.opts.mk>

Aug 29 2022, 2:22 PM
woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

Close comments which have been implemented

Aug 29 2022, 1:45 PM
woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Implement review comments:

  • Add dhcpcd as a separate package (not in "runtime" package)
  • Allow dhcpcd to be compiled without IPv4 or IPv6 support
  • Remove duplicate system directory configuration
  • Bump manpage dates
  • Simplify rc.conf(5) language describing master mode
Aug 29 2022, 1:43 PM
woodsb02 added a comment to D36222: pkgbase: Put dhclient in its own package.

This makes we wonder if the contents of /rescue should remain as a single rescue package... or if its contents should include files from other packages (like this dhclient package)?

Aug 29 2022, 11:58 AM
woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

A new vendor/dhcpcd branch has now been created in the src repo.
https://cgit.freebsd.org/src/commit/?h=vendor/dhcpcd&id=96dba636abec6d5451820add99300bda2ca6d86a

Aug 29 2022, 7:43 AM
woodsb02 closed D36196: Create branch vendor/dhcpcd and import dhcpcd release 9.4.1.

Committed.
https://cgit.freebsd.org/src/commit/?h=vendor/dhcpcd&id=96dba636abec6d5451820add99300bda2ca6d86a

Aug 29 2022, 7:32 AM · network
woodsb02 committed rG96dba636abec: Import dhcpcd 9.4.1 (authored by woodsb02).
Import dhcpcd 9.4.1
Aug 29 2022, 7:29 AM

Aug 27 2022

woodsb02 accepted D36051: Update dwatch-json to 1.2, maintainership.

Looks good 👍

Aug 27 2022, 3:32 AM · DTrace

Aug 24 2022

woodsb02 added a reviewer for D36196: Create branch vendor/dhcpcd and import dhcpcd release 9.4.1: philip.
Aug 24 2022, 8:09 PM · network

Aug 23 2022

woodsb02 accepted D36051: Update dwatch-json to 1.2, maintainership.
Aug 23 2022, 9:33 PM · DTrace
woodsb02 added a comment to D36051: Update dwatch-json to 1.2, maintainership.

You’re probably already aware, but ports has a commit hook so that commit messages should start the first line with “category/portname: description”.

Aug 23 2022, 9:50 AM · DTrace
woodsb02 accepted D36051: Update dwatch-json to 1.2, maintainership.

All the proposed changes look fine to me. You’re welcome to commit this to ports yourself with my ports commit bit approval.

Aug 23 2022, 12:21 AM · DTrace

Aug 14 2022

woodsb02 updated the summary of D22012: Import dhcpcd(8) into FreeBSD base..
Aug 14 2022, 8:20 AM
woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Remove any changes to rc scripts other than adding the new
/etc/rc.d/dhcpcd

Aug 14 2022, 8:18 AM
woodsb02 updated the test plan for D36196: Create branch vendor/dhcpcd and import dhcpcd release 9.4.1.
Aug 14 2022, 6:23 AM · network
woodsb02 updated the test plan for D36196: Create branch vendor/dhcpcd and import dhcpcd release 9.4.1.
Aug 14 2022, 6:22 AM · network
woodsb02 requested review of D36196: Create branch vendor/dhcpcd and import dhcpcd release 9.4.1.
Aug 14 2022, 6:08 AM · network

Aug 7 2022

woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

I posted on the freebsd-net mailing list to raise the proposal once again with the broader community

Aug 7 2022, 5:57 AM
woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

As far as I can tell the objections that were raised over the last few years have all been addressed, and it doesn't seem like much progress has been made on the proposed alternatives. It seems reasonable to me to import dhcpcd initially controlled by a build knob (i.e., WITH_DHCPCD) to allow for further development and experimentation.

Aug 7 2022, 4:09 AM
woodsb02 added a comment to D22012: Import dhcpcd(8) into FreeBSD base..
In D22012#818780, @gbe wrote:

Just one note, OpenBSD has recently implemented a new DHCP client called dhcpleased, which has a very small code size and should be checked before we integrated this patch.

Aug 7 2022, 3:13 AM

Aug 2 2022

woodsb02 committed R11:6931d45bff1e: sysutils/nerdctl: New port: Docker-compatible CLI for containerd (authored by woodsb02).
sysutils/nerdctl: New port: Docker-compatible CLI for containerd
Aug 2 2022, 2:41 PM

Jul 18 2022

woodsb02 committed R11:46a10c978683: security/headscale: add rc script and minimal working config (authored by cmcdonald_netgate.com).
security/headscale: add rc script and minimal working config
Jul 18 2022, 2:46 PM

Jul 10 2022

woodsb02 added a comment to D35597: if_bridge: change MTU for new members.

Text in the if_bridge(4) manpage to consider updating:

Jul 10 2022, 1:48 AM
woodsb02 added a comment to D35597: if_bridge: change MTU for new members.

Not sure why this review wasn’t automatically closed by the commit.

Jul 10 2022, 1:35 AM

Jun 25 2022

woodsb02 added a comment to D35597: if_bridge: change MTU for new members.

Thanks for preparing this change!

Jun 25 2022, 7:06 PM

Dec 12 2021

woodsb02 committed R11:351c42984837: multimedia/gstreamer1: Make pkg-plist PREFIX safe (authored by Mikhail Teterin <mi@FreeBSD.org>).
multimedia/gstreamer1: Make pkg-plist PREFIX safe
Dec 12 2021, 12:05 AM

Oct 23 2021

woodsb02 added inline comments to D22012: Import dhcpcd(8) into FreeBSD base..
Oct 23 2021, 11:19 AM
woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Fix a few missing compile items with the new version 9.4.1

Oct 23 2021, 4:22 AM
woodsb02 updated the summary of D22012: Import dhcpcd(8) into FreeBSD base..
Oct 23 2021, 1:41 AM
woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Fix patch to be against head, not against the previous version of the review

Oct 23 2021, 1:40 AM
woodsb02 retitled D22012: Import dhcpcd(8) into FreeBSD base. from Import dhcpcd(8) version 8.1.0 into FreeBSD base. to Import dhcpcd(8) into FreeBSD base..
Oct 23 2021, 1:36 AM
woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Update dhcpcd(8) to version 9.4.1

Oct 23 2021, 1:36 AM
woodsb02 updated the diff for D22012: Import dhcpcd(8) into FreeBSD base..

Rebase D22012 against FreeBSD src HEAD 362c6d8

Oct 23 2021, 1:10 AM
woodsb02 abandoned D32610: add file.

This was only ever a test to see the arc raw diff format for new files.
For some reason, "arc patch --patch <file>" fails to apply patches downloaded as raw diffs from reviews.freebsd.org

Oct 23 2021, 1:01 AM
woodsb02 updated the diff for D32610: add file.

Add a line

Oct 23 2021, 12:58 AM
woodsb02 requested review of D32610: add file.
Oct 23 2021, 12:57 AM
woodsb02 abandoned D32609: nehemiah: manually assemble xstore(-rng).

phabricator blunder - never meant to create a review for this existing commit!?

Oct 23 2021, 12:55 AM
woodsb02 requested review of D32609: nehemiah: manually assemble xstore(-rng).
Oct 23 2021, 12:53 AM

Oct 21 2021

woodsb02 added a comment to D32543: vt: Disable bell by default.

I think the vt(4) manpage should be updated to show this change in defaults? Could also be worth a note in UPDATING?

Oct 21 2021, 10:36 PM

Sep 18 2021

woodsb02 added a comment to D32008: Remove support for FreeBSD 11.4.

Given 11.4 EOL is 30th September, is the plan to remove support for 11.4 from ports before the 2021Q4 quarterly is branched?

Sep 18 2021, 2:49 AM

Aug 25 2021

woodsb02 committed R11:bfa13bfc5255: x11/lightdm-gtk-greeter: and x11/slick-greeter: auto-set greeter-session (authored by woodsb02).
x11/lightdm-gtk-greeter: and x11/slick-greeter: auto-set greeter-session
Aug 25 2021, 11:08 PM
woodsb02 closed D31632: x11/lightdm-gtk-greeter and x11/slick-greeter: auto-set greeter-session.
Aug 25 2021, 11:08 PM
woodsb02 added a comment to D31632: x11/lightdm-gtk-greeter and x11/slick-greeter: auto-set greeter-session.

Thanks @ericbsd.
@madpilot are you able to provide your thoughts on behalf of desktop@?

Aug 25 2021, 3:45 PM
woodsb02 closed D31631: x11/slick-greeter: Fix dependencies and prefix issues.
Aug 25 2021, 3:43 PM
woodsb02 committed R11:5673aff4cc3f: x11/slick-greeter: Fix dependencies and prefix issues (authored by woodsb02).
x11/slick-greeter: Fix dependencies and prefix issues
Aug 25 2021, 3:43 PM

Aug 22 2021

woodsb02 requested review of D31632: x11/lightdm-gtk-greeter and x11/slick-greeter: auto-set greeter-session.
Aug 22 2021, 3:04 AM
woodsb02 requested review of D31631: x11/slick-greeter: Fix dependencies and prefix issues.
Aug 22 2021, 2:23 AM

Aug 16 2021

woodsb02 added a reverting change for R11:3713253c431e: x11/lightdm-slick-greeter: Add new port: R11:1afe4175aaa4: x11/lightdm-slick-greeter: Remove duplicate port.
Aug 16 2021, 11:32 AM
woodsb02 committed R11:1afe4175aaa4: x11/lightdm-slick-greeter: Remove duplicate port (authored by woodsb02).
x11/lightdm-slick-greeter: Remove duplicate port
Aug 16 2021, 11:32 AM

Aug 15 2021

woodsb02 committed R11:3713253c431e: x11/lightdm-slick-greeter: Add new port (authored by woodsb02).
x11/lightdm-slick-greeter: Add new port
Aug 15 2021, 3:05 PM

May 22 2021

woodsb02 committed R11:95d52e52fb64: */*: Fix ENOTIME: return my ports to the pool (authored by woodsb02).
*/*: Fix ENOTIME: return my ports to the pool
May 22 2021, 2:17 AM