Hi @mat,
As portmgr, can you please approve the changes to Mk/bsd.gstreamer.mk?
Thanks,
Ben

This change has been reverted pending POLA dicusssions. Refer rS479438

In D17086#364678, @bapt wrote:

I think there is absolutely no POLA here as this is a configuration, there should be some warning in the release Release note about it and that is all imho.
Considering the option to only blacklist certain patterns: dotfiles, .pkgnew etc the problem is one would need to do more than that:
remove patch leftovers: .orig, .rej, .bak
editors leftovers file~ file.bak, etc

There are too many patterns to consider

I think I like cem's idea to only include files if they do not start with a "." or finish with ".pkgnew", ".sample" or ".bak" (any others?).

Abandon this change - relocating existing conf files violates POLA.

Abandon this change - relocating existing conf files violates POLA.

Abandon this change - relocating existing conf files violates POLA.

Ok. I have reverted the changes to net/ntpa and mail/mailman - these were the only ones which install the conf file for you.

Also, what are your thoughts on the way forward for the ports below which already have this change committed:

• net/ntpa
• mail/mailman
• security/acme.sh

Can I please check that you agree with the value of only including .conf files (e.g. if the "include" was new functionality), but just disagree with the necessary changes as they violate POLA?

Move all explicit_bzero commands to end of the for loop for each provider, as per asomers comment.

Incorporate pkg-install script to move old newsyslog.conf.d script to new location, addressing concerns raised by mat.
This will both prevent local modifications being reverted to default, and also clean up the old script file.

Fix comment as per asomers recommendation.
Also fix other comments, optimise if ordering and bzero sensitive and provider specific metadata.

These issues were found whilst preparing some Kyua tests for the new geli functionality.

Re-order multimedia/gstreamermm1 Makefile per mat's comment

Hi ygy,
This change looks ok to me, but please make sure you have the maintainers permission before committing (or wait the obligatory 2 weeks).
The typical way to do this is with a bug report.
Regards,
Ben

Note that updating net/freerdp to 2.0.0-rc3 is a prerequisite to updating net/remmina to 1.2.31.4 (net/remmina-plugin-rdp version 1.2.31.4 does not compile with net/freerdp 2.0.0-rc1).

Thanks for your review Alan and Maxim.
Alan: I will try to create some tests for this new geli functionality this weekend, and will submit a phabricator review once it is ready. I am new to Kyua tests, so we will see how it goes.

Update style to match r336602

Thanks for your review Alan and Allan!

Incorporate manpage comment from bcr

Hi guoqiang, thanks for submitting this new port! I have a few comments for you before it gets committed.

Rebase on r335667

Update diff to implement comments from wblock, delphij, sobomax in D9396

Abandon this change in favour of the review which only touches userland: D12644.

Approved for commit.

Other than the previously mentioned changes to the title and summary (incorrect version mentioned), this revision looks fine to me. Approved to commit.

The revision title and summary state this is updating to 2.3.0, but the diff shows an update to 4.3.0.

The review title and summary refer to port devel/py-gitpython, but the diff refers to port devel/py-decorator?

Thanks for the new diff using arcanist. Approved to commit (with svn).

Looks good - approved for commit :)

Approved for you to commit.