Page MenuHomeFreeBSD

woodsb02 (Ben Woods)
User

Projects

User Details

User Since
Aug 19 2015, 10:52 PM (169 w, 3 d)

Recent Activity

Yesterday

woodsb02 added a comment to D18013: Add warning to rc script of files not included by default newsyslog.conf.

Fair enough. That was my initial feel also, but I have been cautioned by others that there will be someone that doesn’t see the notices in UPDATING or the release notes, and after an hour of investigating why their log files have filled their disk they will find the change and curse my name. I do agree, there will always be at least one that doesn’t read the notes, and so thought I would propose the belt and braces approach to see what people thought.

Sat, Nov 17, 8:36 AM
woodsb02 added a reviewer for D18013: Add warning to rc script of files not included by default newsyslog.conf: mat.
Sat, Nov 17, 7:52 AM
woodsb02 updated the test plan for D18013: Add warning to rc script of files not included by default newsyslog.conf.
Sat, Nov 17, 7:14 AM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Add -f to mv to override file without prompting
  • Remove extra blank lines
Sat, Nov 17, 6:59 AM
woodsb02 updated the test plan for D18013: Add warning to rc script of files not included by default newsyslog.conf.
Sat, Nov 17, 6:55 AM
woodsb02 updated the test plan for D18013: Add warning to rc script of files not included by default newsyslog.conf.
Sat, Nov 17, 6:51 AM
woodsb02 added a comment to D18013: Add warning to rc script of files not included by default newsyslog.conf.

Note I am not a src committer (I have my ports commit bit only), so I would like this review to serve 2 purposes:

  1. Is the idea and format of this warning good practice
  2. Approval for me to commit to head (only it has been on review for > 3 days)
Sat, Nov 17, 6:50 AM
woodsb02 updated the summary of D18013: Add warning to rc script of files not included by default newsyslog.conf.
Sat, Nov 17, 6:47 AM
woodsb02 created D18013: Add warning to rc script of files not included by default newsyslog.conf.
Sat, Nov 17, 6:45 AM

Tue, Nov 13

woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Change check of new configuration file status to: if cmp -s ${samplefile} ${newfile} > /dev/null
Note that this introduces a functional change: if either the newfile or samplefile do not exist, it will be seen as a deliberate change by the sysadmin and therefore delete the oldfile

Tue, Nov 13, 11:38 AM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Modify pkg-install script - when moving the configuration file from the old location to the new location, if the file in the new location has been modified from the sample file, then delete the file from the old location instead.
The logic behind this is that if the file is the new location varies from the sample file, then the sysadmin must have modified it (knowing about the new location), and therefore the file in the old location is obsolete.

Tue, Nov 13, 10:54 AM

Mon, Nov 12

woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

If the old file exists, and the new file already exists and is different from the sample file, our options (that I can think of):

  1. Clobber the new file by moving the old file into place (print warning)
  2. Backup the new file to another directory (e.g. /var/backups/), then clobber is with the old file (print warning)
  3. Delete the old file (print warning)
  4. Do nothing, leaving old file and new file in place (print warning)
  5. Provide interactive prompt to user during pkg-install (not unheard of) to chose between these options
Mon, Nov 12, 10:51 PM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Hi mat,
Thanks for the approval.
I got some other comments from mandree in D17088, which I have incorporated here:

  • Take a backup of the new newsyslog file before clobbering it with the old one
  • Fix tense in UPDATING
Mon, Nov 12, 2:57 PM

Sat, Nov 10

woodsb02 updated the diff for D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Add pkg-install script to automatically move old newsyslog file to new filename
  • Add entries to UPDATING and pkg-message
Sat, Nov 10, 5:09 PM
woodsb02 committed rS340326: Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Add UPDATING entry for newsyslog.conf changes introduced by r340318
Sat, Nov 10, 4:58 PM
woodsb02 closed D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Sat, Nov 10, 4:58 PM
woodsb02 committed rP484624: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sat, Nov 10, 4:56 PM
woodsb02 closed D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sat, Nov 10, 4:56 PM
woodsb02 updated the diff for D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Add pkg-install script to automatically move old newsyslog file to new filename
  • Add entries to UPDATING and pkg-message
Sat, Nov 10, 4:49 PM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Add entries to UPDATING and pkg-message

Sat, Nov 10, 4:35 PM
woodsb02 added a reviewer for D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318: rgrimes.
Sat, Nov 10, 4:33 PM
woodsb02 retitled D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318 from Add UPDATING entry for newsyslog.conf changes introduced by rS340318 to Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Sat, Nov 10, 3:58 PM
woodsb02 retitled D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318 from Add UPDATING entry for newsyslog.conf changes introduced by r340318 to Add UPDATING entry for newsyslog.conf changes introduced by rS340318.
Sat, Nov 10, 3:58 PM
woodsb02 created D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Sat, Nov 10, 3:57 PM
woodsb02 reopened D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Sat, Nov 10, 10:59 AM
woodsb02 reclaimed D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Sat, Nov 10, 10:59 AM
woodsb02 reclaimed D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Sat, Nov 10, 10:59 AM
woodsb02 reclaimed D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Sat, Nov 10, 10:58 AM
woodsb02 committed rS340318: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
newsyslog.conf: Restrict included files in default config to [!.]*.conf
Sat, Nov 10, 10:46 AM
woodsb02 closed D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sat, Nov 10, 10:46 AM

Sun, Oct 28

woodsb02 committed rP483303: multimedia/emby-server: Update to 3.5.3.0.
multimedia/emby-server: Update to 3.5.3.0
Sun, Oct 28, 2:58 PM
woodsb02 committed rP483295: MFH: r483114.
MFH: r483114
Sun, Oct 28, 2:11 PM

Sat, Oct 27

woodsb02 committed rP483115: devel/gnome-vfs: Fix OpenSSL 1.1.X build.
devel/gnome-vfs: Fix OpenSSL 1.1.X build
Sat, Oct 27, 8:19 AM
woodsb02 committed rP483114: sysutils/py-salt: Update to 2018.3.3.
sysutils/py-salt: Update to 2018.3.3
Sat, Oct 27, 8:07 AM
woodsb02 committed rP483113: Add entry for sysutils/py-salt.
Add entry for sysutils/py-salt
Sat, Oct 27, 8:06 AM
woodsb02 committed rP483100: net/remmina: Fix build with security/libssh 0.8 branch.
net/remmina: Fix build with security/libssh 0.8 branch
Sat, Oct 27, 2:27 AM

Thu, Oct 25

woodsb02 committed rP482967: multimedia/librtmp: Fix build with OpenSSL 1.1.x.
multimedia/librtmp: Fix build with OpenSSL 1.1.x
Thu, Oct 25, 11:55 AM

Tue, Oct 23

woodsb02 committed rP482833: multimedia/librtmp: Fix build with OpenSSL 1.1.x.
multimedia/librtmp: Fix build with OpenSSL 1.1.x
Tue, Oct 23, 11:59 AM

Oct 16 2018

woodsb02 committed rP482216: net-mgmt/telegraf: Update to 1.8.1.
net-mgmt/telegraf: Update to 1.8.1
Oct 16 2018, 10:27 AM
woodsb02 closed D17548: net-mgmt/telegraf: Update to 1.8.1.
Oct 16 2018, 10:27 AM

Oct 15 2018

woodsb02 added a comment to D17548: net-mgmt/telegraf: Update to 1.8.1.

No automation script unfortunately - just did it manually... which took ages! If you know of one please let me know :)

Oct 15 2018, 12:28 AM

Oct 13 2018

woodsb02 created D17548: net-mgmt/telegraf: Update to 1.8.1.
Oct 13 2018, 6:34 PM

Sep 15 2018

woodsb02 removed a reviewer for D17048: New port: multimedia/gstreamermm1: portmgr.
Sep 15 2018, 1:57 AM

Sep 13 2018

woodsb02 added reviewers for D17048: New port: multimedia/gstreamermm1: bapt, ehaupt, kwm, riggs.
Sep 13 2018, 11:05 PM
woodsb02 added reviewers for D17042: Update multimedia/pitivi to 0.99: bapt, ehaupt, riggs.
Sep 13 2018, 11:04 PM
woodsb02 added a comment to D17048: New port: multimedia/gstreamermm1.

Hi @mat,
As portmgr, can you please approve the changes to Mk/bsd.gstreamer.mk?
Thanks,
Ben

Sep 13 2018, 10:58 PM

Sep 10 2018

woodsb02 added a comment to D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

This change has been reverted pending POLA dicusssions. Refer rS479438

Sep 10 2018, 11:37 PM
woodsb02 added a comment to D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
In D17086#364678, @bapt wrote:

I think there is absolutely no POLA here as this is a configuration, there should be some warning in the release Release note about it and that is all imho.
Considering the option to only blacklist certain patterns: dotfiles, .pkgnew etc the problem is one would need to do more than that:
remove patch leftovers: .orig, .rej, .bak
editors leftovers file~ file.bak, etc

There are too many patterns to consider

Sep 10 2018, 10:41 PM
woodsb02 added a comment to D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.

I think I like cem's idea to only include files if they do not start with a "." or finish with ".pkgnew", ".sample" or ".bak" (any others?).

Sep 10 2018, 4:21 PM
woodsb02 abandoned D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Abandon this change - relocating existing conf files violates POLA.

Sep 10 2018, 4:19 PM
woodsb02 abandoned D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Abandon this change - relocating existing conf files violates POLA.

Sep 10 2018, 4:19 PM
woodsb02 abandoned D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Abandon this change - relocating existing conf files violates POLA.

Sep 10 2018, 4:18 PM
woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Ok. I have reverted the changes to net/ntpa and mail/mailman - these were the only ones which install the conf file for you.

Sep 10 2018, 4:17 PM
woodsb02 committed rP479438: Revert r479294 - relocation of existing conf files violates POLA.
Revert r479294 - relocation of existing conf files violates POLA
Sep 10 2018, 4:07 PM
woodsb02 committed rP479436: Revert r479279 - the relocation of existing conf files violates POLA.
Revert r479279 - the relocation of existing conf files violates POLA
Sep 10 2018, 4:04 PM
woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Also, what are your thoughts on the way forward for the ports below which already have this change committed:

  • net/ntpa
  • mail/mailman
  • security/acme.sh
Sep 10 2018, 3:17 PM
woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Can I please check that you agree with the value of only including .conf files (e.g. if the "include" was new functionality), but just disagree with the necessary changes as they violate POLA?

Sep 10 2018, 3:07 PM
woodsb02 committed rS338558: geli init with multiple providers - fix init and fix -B "none".
geli init with multiple providers - fix init and fix -B "none"
Sep 10 2018, 2:51 PM
woodsb02 closed D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 2:51 PM
woodsb02 updated the diff for D17096: geli init with multiple providers - fix init and fix -B "none".

Move all explicit_bzero commands to end of the for loop for each provider, as per asomers comment.

Sep 10 2018, 2:36 PM
woodsb02 added inline comments to D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 10 2018, 1:58 PM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Incorporate pkg-install script to move old newsyslog.conf.d script to new location, addressing concerns raised by mat.
This will both prevent local modifications being reverted to default, and also clean up the old script file.

Sep 10 2018, 1:54 PM
woodsb02 updated the diff for D17096: geli init with multiple providers - fix init and fix -B "none".

Fix comment as per asomers recommendation.
Also fix other comments, optimise if ordering and bzero sensitive and provider specific metadata.

Sep 10 2018, 1:13 PM
woodsb02 committed rP479403: net/ladvd: Update to 1.1.2.
net/ladvd: Update to 1.1.2
Sep 10 2018, 12:56 PM

Sep 9 2018

woodsb02 committed rP479341: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sep 9 2018, 10:48 PM
woodsb02 closed D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 10:48 PM
woodsb02 committed rP479294: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sep 9 2018, 4:18 PM
woodsb02 closed D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 4:18 PM
woodsb02 added a comment to D17096: geli init with multiple providers - fix init and fix -B "none".

These issues were found whilst preparing some Kyua tests for the new geli functionality.

Sep 9 2018, 4:15 PM
woodsb02 created D17096: geli init with multiple providers - fix init and fix -B "none".
Sep 9 2018, 4:14 PM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 8:48 AM
woodsb02 added a parent revision for D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sep 9 2018, 8:48 AM
woodsb02 created D17092: security/acme.sh: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 8:48 AM
woodsb02 added a parent revision for D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sep 9 2018, 8:41 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 8:41 AM
woodsb02 created D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 8:40 AM
woodsb02 committed rP479279: net/ntpa: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
net/ntpa: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sep 9 2018, 8:29 AM
woodsb02 committed rP479278: www/polipo: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
www/polipo: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Sep 9 2018, 8:24 AM
woodsb02 added a parent revision for D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sep 9 2018, 7:28 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 7:28 AM
woodsb02 created D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 7:28 AM
woodsb02 added a parent revision for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sep 9 2018, 7:25 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 7:25 AM
woodsb02 created D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 7:25 AM
woodsb02 added a parent revision for D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/: D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sep 9 2018, 7:17 AM
woodsb02 added a child revision for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 7:17 AM
woodsb02 created D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Sep 9 2018, 7:16 AM
woodsb02 added reviewers for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: cem, markj, bapt, eadler.
Sep 9 2018, 5:37 AM
woodsb02 added a reviewer for D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf: releng.
Sep 9 2018, 5:23 AM
woodsb02 created D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Sep 9 2018, 5:07 AM
woodsb02 committed rP479266: Fix fetch by updating GH_TAGNAME as required by r479255.
Fix fetch by updating GH_TAGNAME as required by r479255
Sep 9 2018, 3:43 AM

Sep 8 2018

woodsb02 added inline comments to D17048: New port: multimedia/gstreamermm1.
Sep 8 2018, 4:45 AM
woodsb02 updated the diff for D17048: New port: multimedia/gstreamermm1.

Re-order multimedia/gstreamermm1 Makefile per mat's comment

Sep 8 2018, 4:42 AM

Sep 6 2018

woodsb02 created D17048: New port: multimedia/gstreamermm1.
Sep 6 2018, 12:24 PM
woodsb02 added a reviewer for D17048: New port: multimedia/gstreamermm1: multimedia.
Sep 6 2018, 12:24 PM
woodsb02 added a reviewer for D17042: Update multimedia/pitivi to 0.99: multimedia.
Sep 6 2018, 12:24 PM

Sep 5 2018

woodsb02 created D17042: Update multimedia/pitivi to 0.99.
Sep 5 2018, 10:38 AM

Aug 28 2018

woodsb02 committed rP478294: net/remmina-plugins: Fix portscout.
net/remmina-plugins: Fix portscout
Aug 28 2018, 9:37 AM

Aug 27 2018

woodsb02 accepted D16905: sysutils/bvm: Update to 1.1.4.

Hi ygy,
This change looks ok to me, but please make sure you have the maintainers permission before committing (or wait the obligatory 2 weeks).
The typical way to do this is with a bug report.
Regards,
Ben

Aug 27 2018, 1:15 PM
woodsb02 committed rP478203: net/remmina: Update to 1.2.31.4.
net/remmina: Update to 1.2.31.4
Aug 27 2018, 1:05 PM