Page MenuHomeFreeBSD

woodsb02 (Ben Woods)
User

Projects

User Details

User Since
Aug 19 2015, 10:52 PM (208 w, 4 d)

Recent Activity

Yesterday

D21166: net/remmina and others: remmina port update and cleanup is now accepted and ready to land.

This has now been committed, and this review can be closed (not sure why this wasn't automatically picked up by phabricator):
https://reviews.freebsd.org/rP509197

Sun, Aug 18, 2:02 PM
woodsb02 committed rP509197: net/remmina: Upgrade to 1.3.5.
net/remmina: Upgrade to 1.3.5
Sun, Aug 18, 10:34 AM
woodsb02 committed rP509196: irc/quassel: enable snorenotify support.
irc/quassel: enable snorenotify support
Sun, Aug 18, 10:23 AM
woodsb02 committed rP509195: irc/quassel: Upgrade to 0.13.1.
irc/quassel: Upgrade to 0.13.1
Sun, Aug 18, 10:12 AM

Wed, Aug 7

woodsb02 added a comment to D21166: net/remmina and others: remmina port update and cleanup.

One more comment on how to submit phabricator reviews - it is best if the full context of the diff is submitted (allowing me to expand the other parts of the files in between the changes if I am looking for more context).
This can be done using the "arc" command, or by generating the diff with "svn diff --diff-cmd=diff -x -U999999 > change.diff".
This is described here: https://wiki.freebsd.org/Phabricator

Wed, Aug 7, 11:06 PM
woodsb02 added inline comments to D21166: net/remmina and others: remmina port update and cleanup.
Wed, Aug 7, 11:03 PM
woodsb02 added a comment to D21166: net/remmina and others: remmina port update and cleanup.

This only minor comment I would make, is that I prefer to keep things alphabetical in Makefile entries. I have pointed these out with inline comments, but happy for this to be committed without these being changed, as it is only a preference.

Wed, Aug 7, 11:02 PM
D21166: net/remmina and others: remmina port update and cleanup is now accepted and ready to land.

Hi Nick,
Thanks for submitting this diff - it looks like great work, and I am happy for it to be committed.
Given you are not using an @freebsd.org account here, I assume you do not have a commit bit? Would you like me to commit this on your behalf?
Regards,
Ben

Wed, Aug 7, 10:56 PM
woodsb02 committed rP508353: net-p2p/gtk-gnutella: Update to 1.1.15.
net-p2p/gtk-gnutella: Update to 1.1.15
Wed, Aug 7, 10:19 PM

Sun, Aug 4

woodsb02 committed rP508047: science/InsightToolkit: Update to 5.0.1.
science/InsightToolkit: Update to 5.0.1
Sun, Aug 4, 3:07 AM

Sun, Jul 28

woodsb02 committed rP507505: Remove "." at end of MOVED entry to pet Tools/scripts/MOVEDlint.awk.
Remove "." at end of MOVED entry to pet Tools/scripts/MOVEDlint.awk
Sun, Jul 28, 9:58 AM
woodsb02 committed rP507504: Remove port www/p5-WebService-MusicBrainz0.
Remove port www/p5-WebService-MusicBrainz0
Sun, Jul 28, 9:57 AM
woodsb02 committed rP507502: textproc/icdiff: Update to 1.9.4.
textproc/icdiff: Update to 1.9.4
Sun, Jul 28, 9:44 AM

Jun 17 2019

woodsb02 committed rP504427: sysutils/xfce4-systemload-plugin: Fix crash on properties dialog.
sysutils/xfce4-systemload-plugin: Fix crash on properties dialog
Jun 17 2019, 3:10 PM
woodsb02 closed D20672: sysutils/xfce4-systemload-plugin: Fix crash on properties dialog.
Jun 17 2019, 3:10 PM
woodsb02 updated the test plan for D20672: sysutils/xfce4-systemload-plugin: Fix crash on properties dialog.
Jun 17 2019, 3:09 PM
woodsb02 added a comment to D20672: sysutils/xfce4-systemload-plugin: Fix crash on properties dialog.

As per comment from madpilot, manually strip the patch from upstream,
rather than getting the ports framework to do it

Jun 17 2019, 2:41 PM
woodsb02 created D20672: sysutils/xfce4-systemload-plugin: Fix crash on properties dialog.
Jun 17 2019, 2:38 PM
woodsb02 committed rP504419: security/keepass: Update to 2.42.1.
security/keepass: Update to 2.42.1
Jun 17 2019, 1:29 PM
woodsb02 committed rP504417: sysutils/zrepl: Mark as broken on i386.
sysutils/zrepl: Mark as broken on i386
Jun 17 2019, 11:53 AM

Jun 16 2019

woodsb02 committed rP504347: www/bluefish: Do not bundle MIME database files.
www/bluefish: Do not bundle MIME database files
Jun 16 2019, 2:42 PM

Jun 6 2019

woodsb02 committed rP503608: x11/lightdm: Update to 1.30.0, fix crash and change default config.
x11/lightdm: Update to 1.30.0, fix crash and change default config
Jun 6 2019, 11:05 PM
woodsb02 closed D20541: x11/lightdm update to 1.30.0, fix crash and change default config.
Jun 6 2019, 11:05 PM

Jun 4 2019

woodsb02 committed rP503474: sysutils/zrepl: Update to 0.1.1.
sysutils/zrepl: Update to 0.1.1
Jun 4 2019, 2:14 PM
woodsb02 closed D20095: [sysutils/zrepl] update to 0.1.1.
Jun 4 2019, 2:14 PM

Jun 3 2019

woodsb02 committed rP503430: Add net/rclone-browser, a simple cross platfrom GUI for the rclone.
Add net/rclone-browser, a simple cross platfrom GUI for the rclone
Jun 3 2019, 11:47 PM

May 7 2019

woodsb02 added a comment to D20095: [sysutils/zrepl] update to 0.1.1.

Hi mizhka,

May 7 2019, 11:29 PM

Apr 2 2019

woodsb02 committed rP497560: x11-wm/xfce4-session: Add xflock4 option for xfce4-screensaver-command.
x11-wm/xfce4-session: Add xflock4 option for xfce4-screensaver-command
Apr 2 2019, 11:21 AM
woodsb02 closed D19771: x11-wm/xfce4-session: Add xflock4 option for xfce4-screensaver-command.
Apr 2 2019, 11:21 AM

Mar 31 2019

woodsb02 added inline comments to D19771: x11-wm/xfce4-session: Add xflock4 option for xfce4-screensaver-command.
Mar 31 2019, 10:48 PM
woodsb02 added a reviewer for D19771: x11-wm/xfce4-session: Add xflock4 option for xfce4-screensaver-command: xfce.
Mar 31 2019, 3:44 PM
woodsb02 created D19771: x11-wm/xfce4-session: Add xflock4 option for xfce4-screensaver-command.
Mar 31 2019, 3:43 PM

Feb 27 2019

woodsb02 committed rP494060: sysutils/py-salt: Update to 2019.2.0.
sysutils/py-salt: Update to 2019.2.0
Feb 27 2019, 3:05 PM

Feb 16 2019

woodsb02 created D19207: security/pam_krb5: Update to 4.8.
Feb 16 2019, 4:02 AM

Feb 12 2019

woodsb02 added inline comments to D19130: Update multimedia/emby-server to 4.0.2.0.
Feb 12 2019, 1:23 PM

Feb 4 2019

woodsb02 committed rP492137: science/gramps: Update to 5.0.1.
science/gramps: Update to 5.0.1
Feb 4 2019, 2:14 PM
woodsb02 committed rP492135: sysutils/py-distro: Update to 1.4.0.
sysutils/py-distro: Update to 1.4.0
Feb 4 2019, 2:08 PM
woodsb02 committed rP492134: net-mgmt/etherape: Update to 0.9.18.
net-mgmt/etherape: Update to 0.9.18
Feb 4 2019, 2:02 PM
woodsb02 committed rP492130: security/keepass-plugin-keepassrpc: Update to 1.8.0.
security/keepass-plugin-keepassrpc: Update to 1.8.0
Feb 4 2019, 1:36 PM
woodsb02 committed rP492129: security/keepass: Update to 2.41.
security/keepass: Update to 2.41
Feb 4 2019, 1:14 PM
woodsb02 committed rP492125: shells/jailkit: Update to 2.20.
shells/jailkit: Update to 2.20
Feb 4 2019, 12:56 PM
woodsb02 committed rP492123: x11/lightdm-gtk-greeter: Update to 2.0.6.
x11/lightdm-gtk-greeter: Update to 2.0.6
Feb 4 2019, 12:46 PM
woodsb02 committed rP492117: x11/lightdm: Re-add patch accidentally deleted during last change.
x11/lightdm: Re-add patch accidentally deleted during last change
Feb 4 2019, 11:52 AM
woodsb02 committed rP492110: MFH: r492108.
MFH: r492108
Feb 4 2019, 10:36 AM
woodsb02 committed rP492109: x11/lightdm: Update to 1.28.0.
x11/lightdm: Update to 1.28.0
Feb 4 2019, 10:28 AM
woodsb02 committed rP492108: x11/lightdm: Include pkg-message explaining how to fix LightDM coredumps.
x11/lightdm: Include pkg-message explaining how to fix LightDM coredumps
Feb 4 2019, 10:26 AM

Jan 28 2019

woodsb02 committed rP491449: net-p2p/gtk-gnutella: Update to 1.1.14.
net-p2p/gtk-gnutella: Update to 1.1.14
Jan 28 2019, 3:06 AM
woodsb02 committed rP491448: net-p2p/gtk-gnutella: Pet portlint, MAKE_JOBS_SAFE.
net-p2p/gtk-gnutella: Pet portlint, MAKE_JOBS_SAFE
Jan 28 2019, 3:05 AM

Jan 19 2019

woodsb02 committed rP490713: misc/mc: Tidy up Makefile.
misc/mc: Tidy up Makefile
Jan 19 2019, 8:13 AM
woodsb02 committed rP490711: misc/mc: Update to 4.8.22.
misc/mc: Update to 4.8.22
Jan 19 2019, 7:44 AM

Dec 2 2018

woodsb02 committed rP486492: irc/quassel: Update to 0.13.0.
irc/quassel: Update to 0.13.0
Dec 2 2018, 11:18 PM

Nov 28 2018

woodsb02 added a comment to D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Thanks for the review team.
For the record, the old filename is printed out in the warning message if the user needs to do the cleanup - the echo command before the "if cmp" check.

Nov 28 2018, 2:21 PM
woodsb02 committed rP486092: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Nov 28 2018, 2:18 PM
woodsb02 closed D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Nov 28 2018, 2:18 PM

Nov 26 2018

woodsb02 added a comment to D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

As per the existing code, if the contents of ${newfile} are the same as ${samplefile} then there is no destruction to move ${oldfile} to ${newfile}. If the user wants to recover the content of the clobbered newfile - it is fully available in samplefile.

Nov 26 2018, 10:17 PM

Nov 25 2018

woodsb02 updated the diff for D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Only warn the user if the old configuration file exists and the new file has been modified from the default (do not delete it)
Nov 25 2018, 11:00 PM
woodsb02 added a comment to D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Makes sense to me.

Nov 25 2018, 11:00 PM
woodsb02 added a comment to D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

@mat preferred to delete the old file if the new file already exists and has been modified from the default. See further description below.

Nov 25 2018, 3:03 PM

Nov 24 2018

woodsb02 committed rP485725: net/ntpa: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
net/ntpa: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Nov 24 2018, 3:58 AM
woodsb02 committed rP485724: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Nov 24 2018, 3:44 AM
woodsb02 closed D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Nov 24 2018, 3:44 AM
woodsb02 added inline comments to D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Nov 24 2018, 3:27 AM
woodsb02 updated the diff for D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Align with D17089 which has now been approved by portmgr and committed
  • Incorporate logic if both old and new newsyslog file are present
  • Note change to UPDATING was committed in rS485721 (wording changes proposed by mandree were incorporated)
Nov 24 2018, 3:20 AM
woodsb02 committed rP485722: sysutils/munin-master: Include provisioning tool warning post r485721.
sysutils/munin-master: Include provisioning tool warning post r485721
Nov 24 2018, 2:59 AM
woodsb02 committed rP485721: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Nov 24 2018, 2:52 AM
woodsb02 closed D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Nov 24 2018, 2:52 AM

Nov 23 2018

woodsb02 abandoned D18013: Add warning to rc script of files not included by default newsyslog.conf.

Ok, I will abandon this change.
One thought I recently had, is we could have an adaptation of this change through logging in 12.0 release that simply alerted the user their system had incompatibilities with the upcoming change, and then 12.1 release could bring the change.
Any value in that?

Nov 23 2018, 11:04 AM

Nov 17 2018

woodsb02 added a comment to D18013: Add warning to rc script of files not included by default newsyslog.conf.

Fair enough. That was my initial feel also, but I have been cautioned by others that there will be someone that doesn’t see the notices in UPDATING or the release notes, and after an hour of investigating why their log files have filled their disk they will find the change and curse my name. I do agree, there will always be at least one that doesn’t read the notes, and so thought I would propose the belt and braces approach to see what people thought.

Nov 17 2018, 8:36 AM
woodsb02 added a reviewer for D18013: Add warning to rc script of files not included by default newsyslog.conf: mat.
Nov 17 2018, 7:52 AM
woodsb02 updated the test plan for D18013: Add warning to rc script of files not included by default newsyslog.conf.
Nov 17 2018, 7:14 AM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Add -f to mv to override file without prompting
  • Remove extra blank lines
Nov 17 2018, 6:59 AM
woodsb02 updated the test plan for D18013: Add warning to rc script of files not included by default newsyslog.conf.
Nov 17 2018, 6:55 AM
woodsb02 updated the test plan for D18013: Add warning to rc script of files not included by default newsyslog.conf.
Nov 17 2018, 6:51 AM
woodsb02 added a comment to D18013: Add warning to rc script of files not included by default newsyslog.conf.

Note I am not a src committer (I have my ports commit bit only), so I would like this review to serve 2 purposes:

  1. Is the idea and format of this warning good practice
  2. Approval for me to commit to head (only after it has been on review for > 3 days)
Nov 17 2018, 6:50 AM
woodsb02 updated the summary of D18013: Add warning to rc script of files not included by default newsyslog.conf.
Nov 17 2018, 6:47 AM
woodsb02 created D18013: Add warning to rc script of files not included by default newsyslog.conf.
Nov 17 2018, 6:45 AM

Nov 13 2018

woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Change check of new configuration file status to: if cmp -s ${samplefile} ${newfile} > /dev/null
Note that this introduces a functional change: if either the newfile or samplefile do not exist, it will be seen as a deliberate change by the sysadmin and therefore delete the oldfile

Nov 13 2018, 11:38 AM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Modify pkg-install script - when moving the configuration file from the old location to the new location, if the file in the new location has been modified from the sample file, then delete the file from the old location instead.
The logic behind this is that if the file is the new location varies from the sample file, then the sysadmin must have modified it (knowing about the new location), and therefore the file in the old location is obsolete.

Nov 13 2018, 10:54 AM

Nov 12 2018

woodsb02 added a comment to D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

If the old file exists, and the new file already exists and is different from the sample file, our options (that I can think of):

  1. Clobber the new file by moving the old file into place (print warning)
  2. Backup the new file to another directory (e.g. /var/backups/), then clobber is with the old file (print warning)
  3. Delete the old file (print warning)
  4. Do nothing, leaving old file and new file in place (print warning)
  5. Provide interactive prompt to user during pkg-install (not unheard of) to chose between these options
Nov 12 2018, 10:51 PM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Hi mat,
Thanks for the approval.
I got some other comments from mandree in D17088, which I have incorporated here:

  • Take a backup of the new newsyslog file before clobbering it with the old one
  • Fix tense in UPDATING
Nov 12 2018, 2:57 PM

Nov 10 2018

woodsb02 updated the diff for D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Add pkg-install script to automatically move old newsyslog file to new filename
  • Add entries to UPDATING and pkg-message
Nov 10 2018, 5:09 PM
woodsb02 committed rS340326: Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Add UPDATING entry for newsyslog.conf changes introduced by r340318
Nov 10 2018, 4:58 PM
woodsb02 closed D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Nov 10 2018, 4:58 PM
woodsb02 committed rP484624: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/
Nov 10 2018, 4:56 PM
woodsb02 closed D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
Nov 10 2018, 4:56 PM
woodsb02 updated the diff for D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.
  • Add pkg-install script to automatically move old newsyslog file to new filename
  • Add entries to UPDATING and pkg-message
Nov 10 2018, 4:49 PM
woodsb02 updated the diff for D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

Add entries to UPDATING and pkg-message

Nov 10 2018, 4:35 PM
woodsb02 added a reviewer for D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318: rgrimes.
Nov 10 2018, 4:33 PM
woodsb02 retitled D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318 from Add UPDATING entry for newsyslog.conf changes introduced by rS340318 to Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Nov 10 2018, 3:58 PM
woodsb02 retitled D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318 from Add UPDATING entry for newsyslog.conf changes introduced by r340318 to Add UPDATING entry for newsyslog.conf changes introduced by rS340318.
Nov 10 2018, 3:58 PM
woodsb02 created D17936: Add UPDATING entry for newsyslog.conf changes introduced by r340318.
Nov 10 2018, 3:57 PM
woodsb02 reopened D17088: mail/mailman: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Nov 10 2018, 10:59 AM
woodsb02 reclaimed D17089: sysutils/munin-*: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Nov 10 2018, 10:59 AM
woodsb02 reclaimed D17090: www/owncloud: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Nov 10 2018, 10:59 AM
woodsb02 reclaimed D17091: net-mgmt/icinga2: Use .conf suffix for /usr/local/etc/newsyslog.conf.d/.

D17086 has now been committed to 13-CURRENT.
Re-opening this review.
New proposal to minimise the possibility that people are caught out unaware of this:

  1. Modify port to install file to newsyslog/*.conf
  2. Add move_newsyslog_conf() to pkg-install to automatically relocate any existing copy that is missing the .conf file
  3. Add note to UPDATING and pkg-message to notify the user of this change (important if provisioning tools such as ansible, puppet, salt, etc are in use).
Nov 10 2018, 10:58 AM
woodsb02 committed rS340318: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
newsyslog.conf: Restrict included files in default config to [!.]*.conf
Nov 10 2018, 10:46 AM
woodsb02 closed D17086: newsyslog.conf: Restrict included files in default config to [!.]*.conf.
Nov 10 2018, 10:46 AM

Oct 28 2018

woodsb02 committed rP483303: multimedia/emby-server: Update to 3.5.3.0.
multimedia/emby-server: Update to 3.5.3.0
Oct 28 2018, 2:58 PM
woodsb02 committed rP483295: MFH: r483114.
MFH: r483114
Oct 28 2018, 2:11 PM

Oct 27 2018

woodsb02 committed rP483115: devel/gnome-vfs: Fix OpenSSL 1.1.X build.
devel/gnome-vfs: Fix OpenSSL 1.1.X build
Oct 27 2018, 8:19 AM