Page MenuHomeFreeBSD
Differential D32609

nehemiah: manually assemble xstore(-rng)
AbandonedPublic
Actions

Authored by woodsb02 on Oct 23 2021, 12:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 12, 9:24 PM
Unknown Object (File)
Apr 19 2025, 9:42 PM
Unknown Object (File)
Apr 19 2025, 3:23 AM
Unknown Object (File)
Feb 8 2025, 7:36 PM
Unknown Object (File)
Jan 3 2025, 12:24 AM
Unknown Object (File)
Nov 27 2024, 4:15 AM
Unknown Object (File)
Nov 8 2024, 7:37 PM
Unknown Object (File)
Nov 8 2024, 4:11 PM
View All 36 Files
Subscribers
imp
jmg

Details

Reviewers
None
Summary

It seems that clang IAS erronously adds repz prefix which should not be
there. Cpu would try to store around %ecx bytes of random, while we
only expect a word.

PR: 259218
Reported and tested by: Dennis Clarke <dclarke@blastwave.org>
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42308
Build 39196: arc lint + arc unit

Event Timeline

woodsb02 created this revision.Oct 23 2021, 12:53 AM
Herald added subscribers: jmg, imp. · View Herald TranscriptOct 23 2021, 12:53 AM
woodsb02 requested review of this revision.Oct 23 2021, 12:53 AM
Harbormaster completed remote builds in B42308: Diff 97314.Oct 23 2021, 12:53 AM
woodsb02 abandoned this revision.Oct 23 2021, 12:55 AM

phabricator blunder - never meant to create a review for this existing commit!?

Revision Contents
Changeset List

PathSize
sys/
dev/
random/
2 lines

Diff 97314

View Options

sys/dev/random/nehemiah.c

Loading...