if_bridge: change MTU for new members
AbandonedPublic
Actions

Authored by kp on Jun 25 2022, 4:56 PM.

Details

Reviewers

None

Group Reviewers

Summary

Rather than reject new bridge members because they have the wrong MTU
change it to match the bridge. If that fails, reject the new interface.

PR: 264883

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46115
Build 43004: arc lint + arc unit

Event Timeline

kp created this revision.Jun 25 2022, 4:56 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptJun 25 2022, 4:56 PM

kp requested review of this revision.Jun 25 2022, 4:56 PM

Harbormaster completed remote builds in B46115: Diff 107382.Jun 25 2022, 4:56 PM

Thanks for preparing this change!

Macro like:

zlei added a subscriber: zlei.Jun 27 2022, 4:53 AM

kp mentioned this in rG1865ebfb12dd: if_bridge: change MTU for new members.Jun 27 2022, 8:28 AM

Not sure why this review wasn’t automatically closed by the commit.

Also - does the if_bridge(4) need an update to explain this new behaviour?

Text in the if_bridge(4) manpage to consider updating:

In the DESCRIPTION section (lines 129-130):
The MTU of the first member interface to be added is used as the bridge
MTU. All additional members are required to have exactly the same value.

In the BUGS section (lines 511-514):
The if_bridge driver currently supports only Ethernet and Ethernet-like
(e.g., 802.11) network devices, with exactly the same interface MTU size
as the bridge device.

kp abandoned this revision.Oct 5 2022, 4:00 PM

eugen_grosbein.net mentioned this in rG1879f7affbf8: MFC: if_bridge: change MTU for new members.Apr 9 2024, 10:51 AM