Page MenuHomeFreeBSD

roy_marples.name (Roy Marples)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2016, 2:23 AM (261 w, 2 d)

Recent Activity

Tue, Feb 9

roy_marples.name added a comment to R10:924d1c9a050d: Revert "SO_RERROR indicates that receive buffer overflows should be handled as….

Attribution via git commit --author= would be nice next time please.

Tue, Feb 9, 8:51 AM

Mon, Feb 8

roy_marples.name updated the diff for D26652: Implement SO_RERROR.

Adjust to latest git head.

Mon, Feb 8, 5:11 AM

Sun, Feb 7

roy_marples.name added a comment to D26652: Implement SO_RERROR.

wpa_supplicant now supports SO_RERROR upstream:
https://w1.fi/cgit/hostap/commit/?id=a579642bc3c92c98daabadb5bb36c2da26ab893f

Sun, Feb 7, 6:50 AM

Mon, Feb 1

roy_marples.name added a comment to D26652: Implement SO_RERROR.

Now dealing with FreeBSD bugzilla routing socket overflow reports
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253166

Mon, Feb 1, 8:47 PM

Jan 30 2021

roy_marples.name added inline comments to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..
Jan 30 2021, 12:34 PM

Jan 7 2021

roy_marples.name added inline comments to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..
Jan 7 2021, 6:45 PM
roy_marples.name added a comment to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..
In D22012#480886, @imp wrote:

I didn't see you address Brooks' objection in the posted thread. given the extreme level of exposure here, it needs to be answered satisfactorily

Jan 7 2021, 4:50 PM

Jan 1 2021

roy_marples.name added a comment to D26652: Implement SO_RERROR.

SO_RERROR for ntpd, which FreeBSD also uses.
https://bugs.ntp.org/show_bug.cgi?id=3714

Jan 1 2021, 5:11 PM
roy_marples.name added a comment to D26652: Implement SO_RERROR.

All changes requested to the SO_RERROR approach have been made.
I have done as asked and queried this approach on the freebsd-arch mailing list. No replies which I read as no-one has anything bad to say about the approach, but sadly nothing positive either.
I would really like to see some traction here in 2021 :)

Jan 1 2021, 3:06 PM

Oct 8 2020

roy_marples.name updated the diff for D26636: Implement SIOCGIFALIAS.

Break out of the loop early on matching an address.

Oct 8 2020, 8:14 PM
roy_marples.name added inline comments to D26636: Implement SIOCGIFALIAS.
Oct 8 2020, 3:09 PM

Oct 5 2020

roy_marples.name updated the diff for D26652: Implement SO_RERROR.

Move SO_RERROR so it sits within the correct place.

Oct 5 2020, 7:31 AM

Oct 4 2020

roy_marples.name added a comment to D5469: Announce INET6 address flag changes to userland.

@melifaro any update on this?

Oct 4 2020, 8:50 PM
roy_marples.name added a comment to D26652: Implement SO_RERROR.
In D26652#593989, @pi wrote:

I had cases where quagga missed routing updates, which caused inconsistent routing between different bgp speakers. This is probably still possible with frr7, and therefore I would welcome a way to at least get some indication that data was lost.

Oct 4 2020, 7:35 PM
roy_marples.name updated the diff for D26652: Implement SO_RERROR.

Use SO_RERROR in route(8).
Warn on any errors returned by read(2) rather than assuming we always get a route message.

Oct 4 2020, 4:30 PM
roy_marples.name updated the diff for D26652: Implement SO_RERROR.

Adjusted man page as requested.

Oct 4 2020, 4:04 PM
roy_marples.name added a comment to D26652: Implement SO_RERROR.

So, it looks like even the feature has been present in Linux for 8+ years, it hasn't been adopted by the relevant software.

Oct 4 2020, 3:50 PM
roy_marples.name added a comment to D26652: Implement SO_RERROR.
In D26652#593926, @gnn wrote:

While I applaud this idea for route(4)ing sockets I think that applying it broadly to other socket types has issues that need to be considered.

Oct 4 2020, 2:16 PM
roy_marples.name added a comment to D26652: Implement SO_RERROR.

Why would you want to limit the scope?

Because an application writer might get the impression that he/she will be notified if an incoming packet was dropped. This is not true since this patch only covers one of many reasons. If any application wants to detect this, it should add some sequence numbers to the data and it will know.

Oct 4 2020, 1:55 PM
roy_marples.name added a comment to D26652: Implement SO_RERROR.

what other OSes share this API now?

Oct 4 2020, 3:51 AM

Oct 3 2020

roy_marples.name added a comment to D26652: Implement SO_RERROR.

what other OSes share this API now?

I originally implemented on NetBSD and ported it to DragonFly BSD.
OpenBSD has an API which dhcpcd also uses which is specific to the route(4) API where it sends a RTM_DESYNC message.
The irony being it has to send a message on a socket which has already overflowed.

Maybe one can force that such a message (only one) is appended to the socket buffer even if it is full.

Oct 3 2020, 9:14 PM
roy_marples.name added a comment to D26652: Implement SO_RERROR.

what other OSes share this API now?

Oct 3 2020, 8:31 PM
roy_marples.name requested review of D26652: Implement SO_RERROR.
Oct 3 2020, 6:53 PM

Oct 2 2020

roy_marples.name updated the diff for D26636: Implement SIOCGIFALIAS.

Use NET_EPOCH_{ENTER,EXIT}

Oct 2 2020, 4:24 PM
roy_marples.name added inline comments to D26636: Implement SIOCGIFALIAS.
Oct 2 2020, 8:15 AM
roy_marples.name requested review of D26636: Implement SIOCGIFALIAS.
Oct 2 2020, 2:50 AM

Sep 24 2020

roy_marples.name added a comment to D26538: Add SIOCGIFDATA.

Looks ok to me, thanks. This seems like it would be useful for programs that run under Capsicum.

Sep 24 2020, 2:24 AM

Sep 23 2020

roy_marples.name added a comment to D26538: Add SIOCGIFDATA.

Hrm, @markj pointed out on IRC https://people.freebsd.org/~emaste/patches/SIOCGIFDATA.diff

One downside of this approach (vs NetBSD) is that we'll have trouble if we want to grow if_data in the future, although we could deal with that if/when it happens.

Sep 23 2020, 10:43 PM
roy_marples.name added a comment to D26538: Add SIOCGIFDATA.

it looks like OpenBSD and NetBSD implemented this differently:

Sep 23 2020, 10:02 PM
roy_marples.name updated the diff for D26538: Add SIOCGIFDATA.

_IOW is fine.

Sep 23 2020, 9:29 PM
roy_marples.name added inline comments to D26538: Add SIOCGIFDATA.
Sep 23 2020, 9:28 PM
roy_marples.name updated the diff for D26538: Add SIOCGIFDATA.

Ensure no uninitialised padding is leaked.

Sep 23 2020, 9:06 PM
roy_marples.name updated the diff for D26538: Add SIOCGIFDATA.

Hopefully this is now enough context.

Sep 23 2020, 8:46 PM
roy_marples.name requested review of D26538: Add SIOCGIFDATA.
Sep 23 2020, 8:31 PM

May 11 2020

roy_marples.name added a comment to D5469: Announce INET6 address flag changes to userland.

Generally looking good, though my primary concern is interaction with the existing applications.

Both bird and frr ignore value of ifam_flags.

Will update the patch and look at the behaviour for both of them.

May 11 2020, 9:19 PM

Jul 12 2016

roy_marples.name added a comment to D5469: Announce INET6 address flag changes to userland.

Let me clarify.

Jul 12 2016, 7:42 PM
roy_marples.name added a comment to D5469: Announce INET6 address flag changes to userland.
In D5469#149446, @hrs wrote:

Looks reasonable to add notification when ia6_flags is changed, but why is RTM_ADD used instead of RTM_CHANGE? rt_addrmsg() is for addition/removal of an address and RTM_ADD is translated to RTM_NEWADDR there.

Jul 12 2016, 8:30 AM

Feb 27 2016

roy_marples.name retitled D5469: Announce INET6 address flag changes to userland from to Announce INET6 address flag changes to userland.
Feb 27 2016, 2:30 AM