Page MenuHomeFreeBSD

freqlabs (Ryan Moeller)
OS Developer @ iXsystems, Inc.

Projects

User Details

User Since
Jul 22 2016, 2:56 AM (235 w, 3 d)

Recent Activity

Today

freqlabs closed D28335: sysutils/openzfs*: Bump to fix build failures on HEAD.
Mon, Jan 25, 6:38 PM
freqlabs committed rP562601: sysutils/openzfs*: Bump to fix build on HEAD.
sysutils/openzfs*: Bump to fix build on HEAD
Mon, Jan 25, 6:38 PM
freqlabs requested review of D28335: sysutils/openzfs*: Bump to fix build failures on HEAD.
Mon, Jan 25, 6:06 PM

Thu, Jan 21

freqlabs updated the diff for D24832: libcasper: Create a minimal cap_netdb service.

Address feedback

Thu, Jan 21, 12:16 AM · capsicum

Mon, Jan 18

freqlabs closed D27674: sbin/sysctl: Always honor skip in sysctl_all.
Mon, Jan 18, 7:29 PM
freqlabs changed the repository for D27674: sbin/sysctl: Always honor skip in sysctl_all from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.
Mon, Jan 18, 7:28 PM

Tue, Jan 12

freqlabs accepted D28119: libifconfig: Add a symbol map.

I'm not familiar with how the symbol map works, but you've got the generated functions in there so that's good.

Tue, Jan 12, 9:59 PM

Thu, Jan 7

freqlabs accepted D28018: openzfs: attach pam_zfs_key to build.
Thu, Jan 7, 10:04 PM · ZFS

Wed, Jan 6

freqlabs closed D28002: devel/py-sysctl: Bump to 0.3.2.
Wed, Jan 6, 6:56 PM
freqlabs committed rP560556: devel/py-sysctl: Bump to 0.3.2.
devel/py-sysctl: Bump to 0.3.2
Wed, Jan 6, 6:56 PM
freqlabs requested review of D28002: devel/py-sysctl: Bump to 0.3.2.
Wed, Jan 6, 6:30 PM

Tue, Jan 5

freqlabs accepted D27981: Fix devinfo typo.
Tue, Jan 5, 7:57 PM

Dec 18 2020

freqlabs requested review of D27674: sbin/sysctl: Always honor skip in sysctl_all.
Dec 18 2020, 8:45 PM
freqlabs added a comment to D27504: Skip the vm.pmap.kernel_maps sysctl by default..

@jhb Thanks for the heads up. It's working as intended in other cases but clearly not in this case. I'm looking into it.

Dec 18 2020, 6:22 PM

Dec 17 2020

freqlabs accepted D27093: VFS_QUOTACTL: Remove needless casts of arg argument.
Dec 17 2020, 9:51 PM

Dec 4 2020

freqlabs accepted D27209: sysutils/turbostat: Update to fix sysctl kern.sched.topology_spec max length.

Thanks!

Dec 4 2020, 6:13 PM

Dec 2 2020

freqlabs closed D27442: sysutils/openzfs*: Bump to catch up with master.
Dec 2 2020, 2:55 PM
freqlabs committed rP556828: sysutils/openzfs*: Bump, fix kmod on 13-CURRENT.
sysutils/openzfs*: Bump, fix kmod on 13-CURRENT
Dec 2 2020, 2:54 PM

Dec 1 2020

freqlabs updated the diff for D27442: sysutils/openzfs*: Bump to catch up with master.

Upload the correct diff

Dec 1 2020, 10:40 PM
freqlabs requested review of D27442: sysutils/openzfs*: Bump to catch up with master.
Dec 1 2020, 10:36 PM

Nov 30 2020

freqlabs added inline comments to D27420: loader: implement framebuffer console.
Nov 30 2020, 2:39 PM
freqlabs accepted D27029: Move inner loop logic out of sysctl_sysctl_next_ls().
Nov 30 2020, 10:42 AM

Nov 16 2020

freqlabs added inline comments to D27029: Move inner loop logic out of sysctl_sysctl_next_ls().
Nov 16 2020, 10:15 PM
freqlabs requested changes to D27029: Move inner loop logic out of sysctl_sysctl_next_ls().
Nov 16 2020, 10:13 PM
freqlabs accepted D27029: Move inner loop logic out of sysctl_sysctl_next_ls().
Nov 16 2020, 10:10 PM
freqlabs added inline comments to D27029: Move inner loop logic out of sysctl_sysctl_next_ls().
Nov 16 2020, 10:09 PM
freqlabs added inline comments to D27029: Move inner loop logic out of sysctl_sysctl_next_ls().
Nov 16 2020, 9:42 PM
freqlabs accepted D27240: [zfs] Fix LZ4 function definitions to not trip up the compile.
Nov 16 2020, 5:15 PM
freqlabs updated the diff for D26958: sockstat: Use libcasper to capsicumize.

Use cap_netdb

Nov 16 2020, 1:15 AM
freqlabs updated the diff for D24832: libcasper: Create a minimal cap_netdb service.
Nov 16 2020, 1:12 AM · capsicum
freqlabs abandoned D26956: libcasper/services/cap_net: Add cap_getprotobyname.
Nov 16 2020, 1:10 AM

Nov 15 2020

freqlabs requested changes to D27209: sysutils/turbostat: Update to fix sysctl kern.sched.topology_spec max length.

I'll second Scott's three suggested changes.

Nov 15 2020, 8:59 PM

Nov 5 2020

freqlabs closed D27106: devel/py-sysctl: Bump for GIL changes.
Nov 5 2020, 8:10 PM
freqlabs committed rP554150: devel/py-sysctl: Bump for GIL changes.
devel/py-sysctl: Bump for GIL changes
Nov 5 2020, 8:10 PM
freqlabs requested review of D27106: devel/py-sysctl: Bump for GIL changes.
Nov 5 2020, 3:04 PM

Nov 4 2020

freqlabs accepted D27093: VFS_QUOTACTL: Remove needless casts of arg argument.

VFS_QUOTACTL(9) shows it as caddr_t, so I suppose that needs to be fixed as well.

Nov 4 2020, 10:29 PM

Nov 3 2020

freqlabs added a comment to D27029: Move inner loop logic out of sysctl_sysctl_next_ls().

I like that deciding what action to take at the current node is able to be split out into its own function. I don't find sysctl_sysctl_next_node to be a properly descriptive name. It kept confusing me that the "next node" function doesn't do what it sounds like. Changing that to something like sysctl_sysctl_next_action and using an enum for the different actions would avoid the confusion. The variable its return value is stored in could be called action instead of ret. Consider for example enum { ITER_STOP, ITER_SIBLINGS, ITER_CHILDREN };.

Nov 3 2020, 3:35 PM

Nov 2 2020

freqlabs committed rS367283: MFC r366465, r367003, r367006, r367009.
MFC r366465, r367003, r367006, r367009
Nov 2 2020, 8:01 PM
freqlabs closed D27055: sysutils/openzfs*: Bump for latest build fixes.
Nov 2 2020, 7:00 PM
freqlabs committed rP553924: sysutils/openzfs*: Bump for latest build fixes.
sysutils/openzfs*: Bump for latest build fixes
Nov 2 2020, 7:00 PM
freqlabs requested review of D27055: sysutils/openzfs*: Bump for latest build fixes.
Nov 2 2020, 5:54 PM

Oct 30 2020

freqlabs accepted D27027: Use a dynamic buffer for the copy of a node's new value..
Oct 30 2020, 8:54 PM

Oct 27 2020

freqlabs committed rP553457: devel/py-sysctl: Fix Python 2.7 builds.
devel/py-sysctl: Fix Python 2.7 builds
Oct 27 2020, 5:28 PM
freqlabs closed D26968: sysutils/openzfs*: Bump catch up with 1300123.
Oct 27 2020, 12:52 PM
freqlabs committed rP553435: sysutils/openzfs*: Bump to catch up with 1300123.
sysutils/openzfs*: Bump to catch up with 1300123
Oct 27 2020, 12:52 PM
freqlabs requested review of D26968: sysutils/openzfs*: Bump catch up with 1300123.
Oct 27 2020, 12:16 PM

Oct 26 2020

freqlabs added a comment to D26957: sockstat: chdir to jail path before attaching to vnet jail.

Something like this?

diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c
index afe9afb50471..91e411fb023d 100644
--- a/sys/kern/kern_jail.c
+++ b/sys/kern/kern_jail.c
@@ -2406,6 +2406,7 @@ do_jail_attach(struct thread *td, struct prison *pr)
 		goto e_unlock;
 #endif
 	VOP_UNLOCK(pr->pr_root);
+	pwd_chdir(td, pr->pr_root);
 	if ((error = pwd_chroot(td, pr->pr_root)))
 		goto e_revert_osd;
Oct 26 2020, 5:24 PM
freqlabs closed D26962: devel/py-sysctl: Update to 0.3.1.
Oct 26 2020, 4:16 PM
freqlabs committed rP553365: devel/py-sysctl: Update to 0.3.1, become maintainer.
devel/py-sysctl: Update to 0.3.1, become maintainer
Oct 26 2020, 4:16 PM
freqlabs requested review of D26962: devel/py-sysctl: Update to 0.3.1.
Oct 26 2020, 2:59 PM
freqlabs requested review of D26958: sockstat: Use libcasper to capsicumize.
Oct 26 2020, 1:28 PM
freqlabs requested review of D26957: sockstat: chdir to jail path before attaching to vnet jail.
Oct 26 2020, 1:23 PM
freqlabs requested review of D26956: libcasper/services/cap_net: Add cap_getprotobyname.
Oct 26 2020, 1:04 PM
freqlabs added a comment to D26756: jail(3lua): add a jail.list() method.

When you have the chance, please update these diffs so I can apply them locally for closer inspection.

Oct 26 2020, 12:47 PM
freqlabs added a comment to D26932: jail(3lua): Add some basic tests.

Curious, why are libifconfig bindings in the stack?

I don't know, that's a bit unusual... it doesn't look like I accidentally slapped any dependency on there (transitively or otherwise), so I'm not really sure since the only connection is that that's also dependent upon the (now-committed) libjail bits.

Oct 26 2020, 12:45 PM
freqlabs committed rS367055: MFC r366830:.
MFC r366830:
Oct 26 2020, 12:35 PM
freqlabs added a comment to D26932: jail(3lua): Add some basic tests.

Curious, why are libifconfig bindings in the stack?

Oct 26 2020, 12:16 PM

Oct 25 2020

freqlabs abandoned D24832: libcasper: Create a minimal cap_netdb service.
Oct 25 2020, 10:39 PM · capsicum

Oct 24 2020

freqlabs committed rS367025: sockstat: Fix error message when jail_attach fails.
sockstat: Fix error message when jail_attach fails
Oct 24 2020, 10:36 PM
freqlabs closed D26080: flua: Add a libjail module.
Oct 24 2020, 5:09 PM
freqlabs committed rS367013: flua: Add a libjail module.
flua: Add a libjail module
Oct 24 2020, 5:09 PM
freqlabs committed rS367010: Skip RAW kstat sysctls by default.
Skip RAW kstat sysctls by default
Oct 24 2020, 4:26 PM
freqlabs closed D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.
Oct 24 2020, 4:17 PM
freqlabs committed rS367009: sysctl+kern_sysctl: Honor SKIP for descendant nodes.
sysctl+kern_sysctl: Honor SKIP for descendant nodes
Oct 24 2020, 4:17 PM
freqlabs closed D26832: sysctl: Misc code cleanup.
Oct 24 2020, 4:05 PM
freqlabs committed rS367006: sysctl: Misc code cleanup.
sysctl: Misc code cleanup
Oct 24 2020, 4:05 PM
freqlabs closed D26854: kern_sysctl: Misc code cleanup.
Oct 24 2020, 2:47 PM
freqlabs committed rS367003: kern_sysctl: Misc code cleanup.
kern_sysctl: Misc code cleanup
Oct 24 2020, 2:47 PM

Oct 23 2020

freqlabs added a comment to D26746: Add a -R option to mountd so that it can be run without rpcbind for an NFSv4 only server.

The nesting is quite deep at this point, it would probably make sense to break things up a little but that's orthogonal to this change.

Oct 23 2020, 11:57 PM
freqlabs accepted D26746: Add a -R option to mountd so that it can be run without rpcbind for an NFSv4 only server.

Nice, looks good to me!

Oct 23 2020, 11:55 PM
freqlabs updated the diff for D26832: sysctl: Misc code cleanup.

Removed blank lines following section comments.

Oct 23 2020, 8:25 PM
freqlabs added a comment to D26832: sysctl: Misc code cleanup.
In D26832#600476, @imp wrote:

Modulo the blank line thing, this looks good. It's arguably two different commits, but it's so small splitting it further at this stage likely has little benefit.

Oct 23 2020, 8:16 PM
freqlabs updated the diff for D26854: kern_sysctl: Misc code cleanup.

Dropped various whitespace fixes to preserve blame.

Oct 23 2020, 4:08 PM
freqlabs added a reviewer for D26854: kern_sysctl: Misc code cleanup: mjg.
Oct 23 2020, 2:58 PM
freqlabs added a reviewer for D26832: sysctl: Misc code cleanup: mjg.
Oct 23 2020, 2:58 PM
freqlabs committed rS366965: MFC r366771:.
MFC r366771:
Oct 23 2020, 10:48 AM

Oct 21 2020

freqlabs updated the diff for D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.

Actually works now after testing with fixed cxl driver.

Oct 21 2020, 8:04 AM
freqlabs updated the diff for D25447: /usr/libexec/flua: Add bindings for libifconfig.
Oct 21 2020, 5:45 AM
freqlabs updated the diff for D25447: /usr/libexec/flua: Add bindings for libifconfig.
Oct 21 2020, 5:43 AM
freqlabs closed D26858: Move list_cloners to libifconfig.
Oct 21 2020, 5:27 AM
freqlabs committed rS366906: Move list_cloners to libifconfig.
Move list_cloners to libifconfig
Oct 21 2020, 5:27 AM

Oct 20 2020

freqlabs updated the diff for D26858: Move list_cloners to libifconfig.

Simplified error handling.

Oct 20 2020, 9:15 AM

Oct 19 2020

freqlabs added inline comments to D26858: Move list_cloners to libifconfig.
Oct 19 2020, 5:30 PM
freqlabs requested review of D26858: Move list_cloners to libifconfig.
Oct 19 2020, 1:42 PM
freqlabs updated the diff for D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.

Fixed edge cases where first child is a skip node and where descendants of a skip node are also flagged with skip.

Oct 19 2020, 12:40 PM
freqlabs closed D26852: efibootmgr: Use returned error code for error message, not errno.
Oct 19 2020, 10:39 AM
freqlabs committed rS366830: efibootmgr: Use returned error code for error message, not errno.
efibootmgr: Use returned error code for error message, not errno
Oct 19 2020, 10:39 AM
freqlabs updated the diff for D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.

Don't skip nodes when iterating with NEXTNOSKIP.

Oct 19 2020, 7:06 AM
freqlabs added a comment to D26832: sysctl: Misc code cleanup.

Separated kern_sysctl changes to a different patch.
Use defined CTL_SYSCTL oid names.

Oct 19 2020, 7:03 AM
freqlabs updated the diff for D26832: sysctl: Misc code cleanup.
Oct 19 2020, 7:01 AM
freqlabs requested review of D26854: kern_sysctl: Misc code cleanup.
Oct 19 2020, 6:59 AM
freqlabs added a comment to D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.

The page fault in t4_get_lb_stats with my T580-LP-SO-CR was fun.
I have fixed CTL_SYSCTL_NEXTNOSKIP so it doesn't skip nodes, will update the diffs soon.

Oct 19 2020, 5:54 AM
freqlabs requested review of D26852: efibootmgr: Use returned error code for error message, not errno.
Oct 19 2020, 5:25 AM

Oct 18 2020

freqlabs added a comment to D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.

Ok I see the problem. We don't get nodes when iterating, so the skip node never gets seen for this to skip its descendants. Back to the drawing board, then.

Oct 18 2020, 3:53 PM

Oct 17 2020

freqlabs requested review of D26833: sysctl+kern_sysctl: Honor SKIP for descendant nodes.
Oct 17 2020, 5:27 PM
freqlabs requested review of D26832: sysctl: Misc code cleanup.
Oct 17 2020, 5:10 PM

Oct 16 2020

freqlabs closed D26798: /usr/sbin/bhyve: Update TX descriptor base address and host mapping on change.
Oct 16 2020, 8:27 PM
freqlabs committed rS366771: bhyve: Update TX descriptor base address and host mapping on change.
bhyve: Update TX descriptor base address and host mapping on change
Oct 16 2020, 8:27 PM
freqlabs closed D26822: sysutils/openzfs*: Bump for vop_fplookup_vexec after 1300121.
Oct 16 2020, 7:52 PM
freqlabs committed rP552520: sysutils/openzfs*: Bump for vop_fplookup_vexec after 1300121.
sysutils/openzfs*: Bump for vop_fplookup_vexec after 1300121
Oct 16 2020, 7:52 PM