Page MenuHomeFreeBSD

freqlabs (Ryan Moeller)
OS Engineer @ iXsystems, Inc.

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 2:56 AM (200 w, 5 d)

Recent Activity

Yesterday

freqlabs updated the test plan for D25009: flua: add ucl library.
Tue, May 26, 2:30 PM
freqlabs added inline comments to D24966: lualoader: improve the design of the brand-/logo- mechanism .
Tue, May 26, 3:43 AM
freqlabs requested review of D25009: flua: add ucl library.
Tue, May 26, 2:33 AM

Fri, May 22

freqlabs added a comment to D24966: lualoader: improve the design of the brand-/logo- mechanism .

I like the direction toward the artwork being proper Lua modules, but I think to be more idiomatic we should simply return the table for the module, rather than exporting it as a name. This should simplify the loading a bit.

Fri, May 22, 10:15 PM

Thu, May 21

freqlabs committed rS361314: MFC r361066:.
MFC r361066:
Thu, May 21, 2:04 AM
freqlabs closed D24749: Deduplicate fsid comparisons.
Thu, May 21, 1:56 AM
freqlabs committed rS361313: Deduplicate fsid comparisons.
Deduplicate fsid comparisons
Thu, May 21, 1:56 AM

Tue, May 19

freqlabs committed rS361265: Mention new jail(8) command hooks in RELNOTES.
Mention new jail(8) command hooks in RELNOTES
Tue, May 19, 6:42 PM
freqlabs committed rS361264: Mention new dd flags in RELNOTES.
Mention new dd flags in RELNOTES
Tue, May 19, 6:38 PM
freqlabs committed rS361236: MFC r360960:.
MFC r360960:
Tue, May 19, 1:43 AM

Mon, May 18

freqlabs committed rS361147: MFC r360900:.
MFC r360900:
Mon, May 18, 12:33 AM

Thu, May 14

freqlabs closed D24829: jail: Add exec.prepare and exec.release command hooks.
Thu, May 14, 11:38 PM
freqlabs committed rS361066: jail: Add exec.prepare and exec.release command hooks.
jail: Add exec.prepare and exec.release command hooks
Thu, May 14, 11:38 PM
freqlabs added a comment to D24832: libcasper: Create a minimal cap_netdb service.

I wonder if this should be incorporated as part of cap_net (D24688) instead?

Thu, May 14, 3:56 PM · capsicum
freqlabs updated the diff for D24832: libcasper: Create a minimal cap_netdb service.

Incorporate feedback

Thu, May 14, 2:40 PM · capsicum

Wed, May 13

freqlabs requested review of D24832: libcasper: Create a minimal cap_netdb service.
Wed, May 13, 10:46 PM · capsicum
freqlabs added a comment to D24829: jail: Add exec.prepare and exec.release command hooks.

For what it's worth (not much, since I'm not yet a doc commiter), the manual page looks good.

Wed, May 13, 9:54 PM
freqlabs updated the diff for D24829: jail: Add exec.prepare and exec.release command hooks.

Actually upload a new diff this time :)

Wed, May 13, 9:33 PM
freqlabs updated the diff for D24829: jail: Add exec.prepare and exec.release command hooks.

Add suggested exec.release hook as well.

Wed, May 13, 9:30 PM
freqlabs updated the diff for D24829: jail: Add exec.prepare and exec.release command hooks.

Reserve reordering enum for a later patch.

Wed, May 13, 9:17 PM
freqlabs updated the summary of D24829: jail: Add exec.prepare and exec.release command hooks.
Wed, May 13, 8:33 PM
freqlabs requested review of D24829: jail: Add exec.prepare and exec.release command hooks.
Wed, May 13, 8:32 PM

Tue, May 12

freqlabs closed D24811: nfs: Remove APPLESTATIC macro.
Tue, May 12, 4:58 PM
freqlabs committed rS360960: nfs: Remove APPLESTATIC macro.
nfs: Remove APPLESTATIC macro
Tue, May 12, 1:24 PM

Mon, May 11

freqlabs requested review of D24811: nfs: Remove APPLESTATIC macro.
Mon, May 11, 7:49 PM
freqlabs closed D24752: Remove APPLEKEXT ifdefs.
Mon, May 11, 3:50 PM
freqlabs committed rS360900: vfs_exports: Tighten bounds and assert consistency of numsecflavors.
vfs_exports: Tighten bounds and assert consistency of numsecflavors
Mon, May 11, 3:39 PM
freqlabs closed D24753: vfs_exports: Tighten bounds and assert consistency of numsecflavors.
Mon, May 11, 3:39 PM

Sun, May 10

freqlabs updated the diff for D24749: Deduplicate fsid comparisons.

Make fsidcmp a macro

Sun, May 10, 6:35 PM
freqlabs updated the diff for D24753: vfs_exports: Tighten bounds and assert consistency of numsecflavors.
Sun, May 10, 5:06 PM
freqlabs added inline comments to D24753: vfs_exports: Tighten bounds and assert consistency of numsecflavors.
Sun, May 10, 8:37 AM

Fri, May 8

freqlabs added inline comments to D24753: vfs_exports: Tighten bounds and assert consistency of numsecflavors.
Fri, May 8, 4:53 PM
freqlabs added inline comments to D24749: Deduplicate fsid comparisons.
Fri, May 8, 2:50 PM
freqlabs committed rS360813: Remove APPLEKEXT ifndefs.
Remove APPLEKEXT ifndefs
Fri, May 8, 2:40 PM
freqlabs committed rP534400: sysutils/openzfs*: Update to latest master.
sysutils/openzfs*: Update to latest master
Fri, May 8, 12:37 PM
freqlabs closed D24759: openzfs*: Update to latest master.
Fri, May 8, 12:37 PM
freqlabs updated the summary of D24759: openzfs*: Update to latest master.
Fri, May 8, 10:19 AM
freqlabs requested review of D24759: openzfs*: Update to latest master.
Fri, May 8, 10:18 AM

Thu, May 7

freqlabs requested review of D24753: vfs_exports: Tighten bounds and assert consistency of numsecflavors.
Thu, May 7, 10:33 PM
freqlabs requested review of D24752: Remove APPLEKEXT ifdefs.
Thu, May 7, 10:15 PM
freqlabs updated the diff for D24749: Deduplicate fsid comparisons.
Thu, May 7, 10:01 PM
freqlabs requested review of D24749: Deduplicate fsid comparisons.
Thu, May 7, 4:46 PM

Sun, May 3

freqlabs committed rS360601: MFC r360356:.
MFC r360356:
Sun, May 3, 8:14 AM

Wed, Apr 29

freqlabs committed rS360454: MFC r360199.
MFC r360199
Wed, Apr 29, 5:11 AM

Mon, Apr 27

freqlabs added a comment to D24593: Update the cached MSI state when any MSI capability register is written..

This resolves the issue for my test VM, using:

Mon, Apr 27, 7:01 PM

Apr 26 2020

freqlabs committed rS360356: sockstat: Attach to jail if in new vnet.
sockstat: Attach to jail if in new vnet
Apr 26 2020, 8:55 PM
freqlabs closed D24413: sockstat: Attach to jail if in new vnet.
Apr 26 2020, 8:55 PM
freqlabs added a comment to D24549: Use a pthread mutex to protect the MSI and MSI-X state..

Relaying a couple more messages from Thomas:

I just had a quick look at your patch. AFAICT up to now the write to the
MSI config space was not serialized against interrupt delivery. But I
don't see how that will cure the problem.
Apr 26 2020, 6:56 PM

Apr 25 2020

freqlabs added a comment to D24570: Add support for jail.d.

It would be good to mention this in some man pages as well.

Apr 25 2020, 9:15 PM
freqlabs added a comment to D24549: Use a pthread mutex to protect the MSI and MSI-X state..

When the offending commit in Linux was first brought to my attention, I reached out to the author of the commit for their input on what specifically we might need to look at. Here is the response I received this afternoon, for posterity:

Apr 25 2020, 5:47 PM
freqlabs added a comment to D24549: Use a pthread mutex to protect the MSI and MSI-X state..

The latest patch seems functional for me as well:

vmrun -m 4G -c 2 -E -d /dev/zvol/system/vms/ubuntu/disk0 -I ubuntu-20.04-desktop-amd64.iso -L 192.168.1.190 -T -i ubuntu

I was having trouble at first but raising the ram size from 1GB to 4GB did the trick.

Apr 25 2020, 2:20 AM

Apr 24 2020

freqlabs updated the diff for D24413: sockstat: Attach to jail if in new vnet.

Integrate with existing -j option, per suggestion by @jamie

Apr 24 2020, 9:06 AM
freqlabs added inline comments to D24549: Use a pthread mutex to protect the MSI and MSI-X state..
Apr 24 2020, 5:58 AM

Apr 23 2020

freqlabs added a reviewer for D24413: sockstat: Attach to jail if in new vnet: jamie.
Apr 23 2020, 3:35 PM
freqlabs updated the diff for D24413: sockstat: Attach to jail if in new vnet.

Add context.

Apr 23 2020, 1:23 PM

Apr 22 2020

freqlabs committed rS360199: menu.lua: Give names to menu entries.
menu.lua: Give names to menu entries
Apr 22 2020, 5:04 PM
freqlabs closed D24527: menu.lua: Give names to menu entries.
Apr 22 2020, 5:04 PM

Apr 21 2020

freqlabs created D24527: menu.lua: Give names to menu entries.
Apr 21 2020, 11:08 PM

Apr 17 2020

freqlabs committed rP531944: sysutils/openzfs*: Switch to merged OpenZFS repo.
sysutils/openzfs*: Switch to merged OpenZFS repo
Apr 17 2020, 3:27 PM
freqlabs closed D24434: sysutils/openzfs*: Switch to merged OpenZFS repo.
Apr 17 2020, 3:27 PM
freqlabs added a reviewer for D24434: sysutils/openzfs*: Switch to merged OpenZFS repo: kmoore.
Apr 17 2020, 3:14 PM

Apr 16 2020

pi renamed freqlabs from ryan_freqlabs.com to freqlabs.
Apr 16 2020, 9:50 AM
freqlabs updated the summary of D24434: sysutils/openzfs*: Switch to merged OpenZFS repo.
Apr 16 2020, 12:06 AM

Apr 15 2020

freqlabs created D24434: sysutils/openzfs*: Switch to merged OpenZFS repo.
Apr 15 2020, 11:05 PM
freqlabs added inline comments to D24408: ZFS should depend on XDR, not full RPC.
Apr 15 2020, 10:28 PM
freqlabs added a comment to D24408: ZFS should depend on XDR, not full RPC.

Out of curiosity, how does options XDR (in a kernel config) avoid a name collision with the XDR typedef?

Apr 15 2020, 8:54 PM

Apr 14 2020

freqlabs created D24413: sockstat: Attach to jail if in new vnet.
Apr 14 2020, 7:44 AM

Mar 26 2020

freqlabs added a comment to D21733: loader: Fully reset terminal settings, not just colors.

@tsoome is efi console / teken in shape for this now?

Mar 26 2020, 8:13 PM

Mar 18 2020

freqlabs created D24115: loader: Add a "kernel.loaded" hook.
Mar 18 2020, 3:00 PM

Mar 16 2020

freqlabs created D24086: Update OpenZFS ports.
Mar 16 2020, 6:28 AM

Feb 27 2020

freqlabs added a reviewer for D23854: Unbreak openzfs ports: wg.
Feb 27 2020, 7:46 PM
freqlabs created D23854: Unbreak openzfs ports.
Feb 27 2020, 5:55 PM

Feb 26 2020

freqlabs accepted D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 26 2020, 9:08 AM

Feb 25 2020

freqlabs requested changes to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

This is getting really close to the finish line.

Feb 25 2020, 3:26 PM

Feb 23 2020

freqlabs added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 23 2020, 3:15 AM

Feb 14 2020

freqlabs added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 14 2020, 3:02 PM
freqlabs added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 14 2020, 2:59 PM

Feb 6 2020

freqlabs added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 6 2020, 1:54 AM

Jan 26 2020

freqlabs added a comment to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

I'll be taking a closer look when I get a chance but at a glance at the diff this looks like a much cleaner change now. Thank you for taking the time to work on it!

Jan 26 2020, 11:58 PM

Jan 23 2020

freqlabs added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Jan 23 2020, 2:44 PM
freqlabs added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Jan 23 2020, 2:32 PM

Jan 18 2020

freqlabs requested changes to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

I have not inspected the code in depth, but there are a number of style violations that jump out at a glance. Fixing these various nits will make the changes easier to read for reviewers. Rather than clutter up the diff I'll just mention the key points:

  • Several files appear to have been edited with 4-space indentation settings rather than hard tabs, in contrast with the surrounding code. The different whitespace is confusing/frustrating.
  • A bunch of added functions in block_if.c should have a newline after the function return type, rather than a bunch of horizontal space.

See style(9) as a more detailed guide, but in general matching the style of surrounding code is most desirable.

Jan 18 2020, 7:46 PM

Jan 17 2020

freqlabs accepted D23232: Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR.

Sorry about that!

Jan 17 2020, 1:28 PM

Jan 16 2020

freqlabs added a comment to D23211: setextattr: Increase stdin buffer size to 4096.

@asomers Will you commit this for me? I don't have the bit. Thanks!

Jan 16 2020, 9:03 PM
freqlabs created D23211: setextattr: Increase stdin buffer size to 4096.
Jan 16 2020, 7:33 PM
freqlabs added a comment to D23199: random(6): Fix off-by-one error.

@cem Will you commit this for me? I don't have the bit. Thanks!

Jan 16 2020, 6:20 PM
freqlabs updated the test plan for D23199: random(6): Fix off-by-one error.
Jan 16 2020, 9:33 AM
freqlabs updated the summary of D23199: random(6): Fix off-by-one error.
Jan 16 2020, 9:33 AM
freqlabs created D23199: random(6): Fix off-by-one error.
Jan 16 2020, 9:32 AM

Jan 15 2020

freqlabs added a comment to D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

@mckusick I would like to MFC your EINTEGRITY change to stable/12 along with this change. Does this seem reasonable? At a glance the only merge conflict is that stable/12 doesn't have contrib/libc++, so that part of the patch would be dropped. Anything else to look out for?
Thanks in advance!

Jan 15 2020, 4:06 PM

Jan 14 2020

freqlabs accepted D23132: libzfs: add zfs_mount_at, switch libbe to it.

Looks reasonable. This will make its way into ZoF next time we rebase, since there aren't any platform-specific files changed. The port should be updated shortly thereafter.

Jan 14 2020, 5:17 PM
freqlabs added a comment to D22979: bsdinstall: Use TMPDIR if set.

Sure! I'll try and get it committed today.

Jan 14 2020, 4:20 PM

Jan 11 2020

freqlabs updated the diff for D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

Add a comment explaining the motivation for the mapping.

Jan 11 2020, 9:36 AM

Jan 7 2020

freqlabs updated the diff for D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

Incorporate feedback. Map the constants to existing errnos instead of adding messages for old numbers.

Jan 7 2020, 8:50 PM
freqlabs retitled D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos from Add error strings for ECKSUM and EFRAGS from ZFS to Map ECKSUM and EFRAGS from ZFS onto real errnos.
Jan 7 2020, 8:48 PM

Jan 2 2020

freqlabs added a comment to D22979: bsdinstall: Use TMPDIR if set.

@bcran Thanks! Would you mind committing this for me? I don't have the bit.

Jan 2 2020, 5:00 PM
freqlabs abandoned D22937: bsdinstall: Clean up bsdinstall-esps file.

Incorporated in the TMPDIR revision: D22979

Jan 2 2020, 4:44 PM

Dec 31 2019

freqlabs updated the diff for D22979: bsdinstall: Use TMPDIR if set.

Use $BSDINSTALL_CHROOT in place of /mnt for umount.

Dec 31 2019, 12:07 AM

Dec 30 2019

freqlabs created D22979: bsdinstall: Use TMPDIR if set.
Dec 30 2019, 11:57 PM
freqlabs created D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.
Dec 30 2019, 9:13 PM