Page MenuHomeFreeBSD

freqlabs (Ryan Moeller)
OS Developer @ iXsystems, Inc.

Projects

User Details

User Since
Jul 22 2016, 2:56 AM (262 w, 3 d)

Recent Activity

Yesterday

freqlabs closed D31361: devel/py-libzfs: Bump to version 1.1.
Mon, Aug 2, 1:26 PM
freqlabs committed R11:25902949f110: devel/py-libzfs: Bump to version 1.1 (authored by freqlabs).
devel/py-libzfs: Bump to version 1.1
Mon, Aug 2, 1:26 PM
freqlabs closed D31362: sysutils/openzfs*: Bump to current master.
Mon, Aug 2, 1:23 PM
freqlabs committed R11:3202cd49e8f8: sysutils/openzfs*: Bump to current master (authored by freqlabs).
sysutils/openzfs*: Bump to current master
Mon, Aug 2, 1:23 PM

Sat, Jul 31

freqlabs requested review of D31362: sysutils/openzfs*: Bump to current master.
Sat, Jul 31, 12:15 AM

Fri, Jul 30

freqlabs requested review of D31361: devel/py-libzfs: Bump to version 1.1.
Fri, Jul 30, 11:51 PM

Thu, Jul 22

freqlabs accepted D31265: Escape any '.' characters in sysctl node names.

Seems reasonable to me.

Thu, Jul 22, 3:57 PM

Tue, Jul 13

freqlabs committed R10:207b3a418a53: zfsd: Check for error from zpool_vdev_online (authored by freqlabs).
zfsd: Check for error from zpool_vdev_online
Tue, Jul 13, 3:52 PM
freqlabs committed R10:d5a71c929dfa: zfsd: Check for error from zpool_vdev_online (authored by freqlabs).
zfsd: Check for error from zpool_vdev_online
Tue, Jul 13, 3:48 PM

Tue, Jul 6

freqlabs committed R10:4b74458dddba: bsdinstall: Avoid double-mounting /dev (authored by freqlabs).
bsdinstall: Avoid double-mounting /dev
Tue, Jul 6, 5:39 PM
freqlabs committed R10:53b438b2425c: zfsd: Check for error from zpool_vdev_online (authored by freqlabs).
zfsd: Check for error from zpool_vdev_online
Tue, Jul 6, 4:07 PM
freqlabs closed D30882: zfsd: Check for error from zpool_vdev_online.
Tue, Jul 6, 4:07 PM
freqlabs accepted D31020: Attach zpool_influxdb to OpenZFS build.

This looks good to me. I recall that Makefile.depend will be generated by whoever needs it and does not need to be committed if you aren't sure how to do it, but I don't see that in the committer's guide so I'm not sure where that idea came from. Hopefully someone else has input on that aspect.

Tue, Jul 6, 3:51 PM · ZFS

Jun 24 2021

freqlabs added a reviewer for D30882: zfsd: Check for error from zpool_vdev_online: ZFS.
Jun 24 2021, 11:06 AM
freqlabs requested review of D30882: zfsd: Check for error from zpool_vdev_online.
Jun 24 2021, 11:05 AM

Jun 23 2021

freqlabs committed R10:b50db44f021c: bsdinstall: Avoid double-mounting /dev (authored by freqlabs).
bsdinstall: Avoid double-mounting /dev
Jun 23 2021, 9:26 PM
freqlabs closed D30877: bsdinstall: Avoid double-mounting /dev.
Jun 23 2021, 9:26 PM
freqlabs requested review of D30877: bsdinstall: Avoid double-mounting /dev.
Jun 23 2021, 12:31 PM

Jun 21 2021

freqlabs retitled D30851: sysutils/openzfs*: Bump to fix build failures on HEAD from sysutils/openzfs: Bump to fix build to sysutils/openzfs*: Bump to fix build failures on HEAD.
Jun 21 2021, 6:46 PM
freqlabs requested review of D30851: sysutils/openzfs*: Bump to fix build failures on HEAD.
Jun 21 2021, 6:45 PM
freqlabs abandoned D29839: sysutils/openzfs*: Update to zfs-2.1.0-rc3.
Jun 21 2021, 6:43 PM

Jun 11 2021

freqlabs added a comment to D29419: ZFS NAME_ERR_DISKLIKE check is Solaris-specific.

This has been committed in 1603881667360c015f6685131f2f25474fa67a72 #11813 Allow pool names that look like Solaris disk names

Jun 11 2021, 2:03 PM

Jun 8 2021

freqlabs committed R10:92a9e1da60f7: Fix automake program name transformations (authored by freqlabs).
Fix automake program name transformations
Jun 8 2021, 2:39 PM

Jun 5 2021

freqlabs committed R10:c5a2d8c5f517: sockstat: Use libcasper to capsicumize (authored by freqlabs).
sockstat: Use libcasper to capsicumize
Jun 5 2021, 12:38 PM
freqlabs committed R10:94dc57159532: libcasper: Create a minimal cap_netdb service (authored by freqlabs).
libcasper: Create a minimal cap_netdb service
Jun 5 2021, 12:37 PM
freqlabs closed D26958: sockstat: Use libcasper to capsicumize.
Jun 5 2021, 12:37 PM
freqlabs closed D24832: libcasper: Create a minimal cap_netdb service.
Jun 5 2021, 12:37 PM · capsicum

May 24 2021

freqlabs added a comment to D26958: sockstat: Use libcasper to capsicumize.

@oshogbo when this looks good to you I can commit it along with cap_netdb in D24832.

May 24 2021, 12:16 AM
freqlabs accepted D30371: Delete obsolete Solaris compat files.
May 24 2021, 12:04 AM

May 13 2021

freqlabs added inline comments to D30218: VFS_QUOTACTL(9): allow implementation to indicate busy state changes.
May 13 2021, 2:58 PM

Apr 23 2021

freqlabs committed R10:550fcd830db7: Fix leak in libc NFSv4 ACL flags parsing (authored by walker.aj325_gmail.com).
Fix leak in libc NFSv4 ACL flags parsing
Apr 23 2021, 10:45 AM
freqlabs committed R10:7b61f67f398a: Fix leak in libc NFSv4 ACL flags parsing (authored by walker.aj325_gmail.com).
Fix leak in libc NFSv4 ACL flags parsing
Apr 23 2021, 10:44 AM
freqlabs committed R10:8845eea6e288: Fix leak in libc NFSv4 ACL flags parsing (authored by walker.aj325_gmail.com).
Fix leak in libc NFSv4 ACL flags parsing
Apr 23 2021, 10:43 AM

Apr 22 2021

freqlabs closed D29926: bhyve: Gracefully handle virtio-scsi with no conf.
Apr 22 2021, 4:07 PM
freqlabs committed R10:89c3c32647a5: bhyve: Gracefully handle virtio-scsi with no conf (authored by freqlabs).
bhyve: Gracefully handle virtio-scsi with no conf
Apr 22 2021, 4:07 PM
freqlabs requested review of D29926: bhyve: Gracefully handle virtio-scsi with no conf.
Apr 22 2021, 2:58 PM

Apr 20 2021

freqlabs committed R10:dd559118ab3f: Fix leak in libc NFSv4 flags parsing (authored by walker.aj325_gmail.com).
Fix leak in libc NFSv4 flags parsing
Apr 20 2021, 7:46 PM
freqlabs closed D29871: fix leak in lib/libc/posix1e/acl_support_nfs4.c.
Apr 20 2021, 7:46 PM
freqlabs accepted D29871: fix leak in lib/libc/posix1e/acl_support_nfs4.c.
Apr 20 2021, 7:22 PM

Apr 19 2021

freqlabs requested review of D29839: sysutils/openzfs*: Update to zfs-2.1.0-rc3.
Apr 19 2021, 5:44 PM
freqlabs added a comment to D29769: zfs: damage control racing .. lookups in face of mkdir/rmdir.

Is there anyone else familiar with the VFS stuff going on here who can help with this review? It's over my head at the moment.

Apr 19 2021, 5:35 PM

Apr 16 2021

freqlabs committed R10:1310ff46bf39: ifconfig: Reuse media state in ifmedia_getstate (authored by freqlabs).
ifconfig: Reuse media state in ifmedia_getstate
Apr 16 2021, 2:43 AM
freqlabs closed D29741: ifconfig: Reuse media state in ifmedia_getstate.
Apr 16 2021, 2:43 AM
freqlabs committed R10:407fb44c920a: ifconfig: Reuse media state in ifmedia_getstate (authored by freqlabs).
ifconfig: Reuse media state in ifmedia_getstate
Apr 16 2021, 2:43 AM
freqlabs changed the repository for D29741: ifconfig: Reuse media state in ifmedia_getstate from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.
Apr 16 2021, 2:27 AM

Apr 15 2021

freqlabs added a comment to D29741: ifconfig: Reuse media state in ifmedia_getstate.

I'm restoring behavior that was removed by mistake, so awkward as it may be, this is how ifconfig already worked before I tidied it up.

Apr 15 2021, 8:49 PM
freqlabs added a comment to D29741: ifconfig: Reuse media state in ifmedia_getstate.

Just waiting for approval on this.

Apr 15 2021, 12:47 PM
freqlabs added a reviewer for D29741: ifconfig: Reuse media state in ifmedia_getstate: network.
Apr 15 2021, 12:45 PM

Apr 13 2021

freqlabs requested review of D29741: ifconfig: Reuse media state in ifmedia_getstate.
Apr 13 2021, 6:04 AM

Apr 9 2021

freqlabs added a comment to D29492: Add more inodes to VM images by having makefs allocate extra inodes when making images with free space..

The snapshot AMIs built this week do work. Thanks again!

Apr 9 2021, 2:34 PM

Apr 6 2021

freqlabs added a comment to D29492: Add more inodes to VM images by having makefs allocate extra inodes when making images with free space..

Thank you. I hoped to test this but have been stumbling over how to build an AMI with make release. It's not part of my usual workflow. We'll see if the snapshots this week are fixed!

Apr 6 2021, 8:14 PM

Apr 1 2021

freqlabs accepted D29449: nfsd: don't report rpcb_unset() failures for NFSv4 only configuration.

Please add a comment to explain that calling unregistration() before fetching nfs_minvers from the sysctl is intentional when you commit.

Apr 1 2021, 3:50 PM
freqlabs added inline comments to D29449: nfsd: don't report rpcb_unset() failures for NFSv4 only configuration.
Apr 1 2021, 3:46 PM

Mar 30 2021

freqlabs committed R10:a42a0b77f0de: Fix array out of bound panic introduced in r306219. (authored by mav).
Fix array out of bound panic introduced in r306219.
Mar 30 2021, 3:05 PM

Mar 29 2021

freqlabs added a comment to D29492: Add more inodes to VM images by having makefs allocate extra inodes when making images with free space..

Fixing this here too for older makefs building images from newer sources might be reasonable, but I wonder if makefs should be made a bootstrap tool instead, along with its default being improved.

Mar 29 2021, 11:50 PM
freqlabs added a comment to D29492: Add more inodes to VM images by having makefs allocate extra inodes when making images with free space..

This appears to be the source of the discrepancy between newfs and makefs:

sbin/newfs/mkfs.c
338:            density = MAX(NFPI, minfragsperinode) * fsize;
341:            density = minfragsperinode * fsize;
Mar 29 2021, 11:40 PM
freqlabs added a comment to D29492: Add more inodes to VM images by having makefs allocate extra inodes when making images with free space..

I agree with the suggestion this would be better to fix in makefs itself.

Mar 29 2021, 10:20 PM
freqlabs committed R10:4fd5354e85e4: rpc.lockd: Unconditionally close fds as daemon (authored by yocalebo_gmail.com).
rpc.lockd: Unconditionally close fds as daemon
Mar 29 2021, 4:15 PM
freqlabs committed R10:57593b2bca76: align nfsdumpstate column output (authored by yocalebo_gmail.com).
align nfsdumpstate column output
Mar 29 2021, 4:14 PM
freqlabs committed R10:af68f5380642: rpc.lockd: Unconditionally close fds as daemon (authored by yocalebo_gmail.com).
rpc.lockd: Unconditionally close fds as daemon
Mar 29 2021, 3:13 PM
freqlabs committed R10:b92b2ffd1233: align nfsdumpstate column output (authored by yocalebo_gmail.com).
align nfsdumpstate column output
Mar 29 2021, 3:13 PM
freqlabs committed R10:16443ffd4108: bsdinstall: Drop vestigial bsdinstall-esps cleanup (authored by freqlabs).
bsdinstall: Drop vestigial bsdinstall-esps cleanup
Mar 29 2021, 3:13 PM

Mar 26 2021

freqlabs added a reviewer for D26958: sockstat: Use libcasper to capsicumize: oshogbo.
Mar 26 2021, 7:24 PM
freqlabs added a comment to D24832: libcasper: Create a minimal cap_netdb service.

@oshogbo okay to commit?

Mar 26 2021, 7:23 PM · capsicum
freqlabs committed R10:b07b7aec6534: bsdinstall: Drop vestigial bsdinstall-esps cleanup (authored by freqlabs).
bsdinstall: Drop vestigial bsdinstall-esps cleanup
Mar 26 2021, 6:14 PM
freqlabs closed D29325: bsdinstall: Drop vestigial bsdinstall-esps cleanup.
Mar 26 2021, 6:14 PM
freqlabs committed R10:badcfbacf384: rpc.lockd: Unconditionally close fds as daemon (authored by yocalebo_gmail.com).
rpc.lockd: Unconditionally close fds as daemon
Mar 26 2021, 6:07 PM
freqlabs closed D29415: fix lockd daemon().
Mar 26 2021, 6:06 PM

Mar 25 2021

freqlabs added a comment to D29419: ZFS NAME_ERR_DISKLIKE check is Solaris-specific.

Yep this can go through upstream.

Mar 25 2021, 8:42 PM

Mar 24 2021

freqlabs committed R10:efad9c8ba3ce: align nfsdumpstate column output (authored by yocalebo_gmail.com).
align nfsdumpstate column output
Mar 24 2021, 8:36 PM
freqlabs closed D18958: align nfsdumpstate column output.
Mar 24 2021, 8:36 PM
freqlabs accepted D18958: align nfsdumpstate column output.
Mar 24 2021, 8:27 PM
freqlabs added inline comments to D18958: align nfsdumpstate column output.
Mar 24 2021, 7:21 PM
freqlabs accepted D18958: align nfsdumpstate column output.
Mar 24 2021, 6:57 PM
freqlabs accepted D29415: fix lockd daemon().
Mar 24 2021, 6:56 PM
freqlabs added a reviewer for D29415: fix lockd daemon(): rmacklem.
Mar 24 2021, 6:56 PM
freqlabs requested changes to D18958: align nfsdumpstate column output.

This is still needed but the code has changed so the patch must be adapted.

Mar 24 2021, 6:27 PM
freqlabs accepted D18958: align nfsdumpstate column output.
Mar 24 2021, 6:14 PM

Mar 22 2021

freqlabs committed R10:b304cd9789ca: Drop EFI_STAGING_SIZE back down to 64M (authored by imp).
Drop EFI_STAGING_SIZE back down to 64M
Mar 22 2021, 9:48 PM

Mar 19 2021

freqlabs committed R10:ebee42edc86c: sbin/ifconfig: Get media status with libifconfig (authored by freqlabs).
sbin/ifconfig: Get media status with libifconfig
Mar 19 2021, 1:02 PM
freqlabs committed R10:534e161747f8: libifconfig: Overhaul ifconfig_media_* interfaces (authored by freqlabs).
libifconfig: Overhaul ifconfig_media_* interfaces
Mar 19 2021, 1:01 PM

Mar 18 2021

freqlabs changed the repository for D29325: bsdinstall: Drop vestigial bsdinstall-esps cleanup from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.
Mar 18 2021, 4:49 PM
freqlabs requested review of D29325: bsdinstall: Drop vestigial bsdinstall-esps cleanup.
Mar 18 2021, 4:48 PM

Mar 17 2021

freqlabs committed R10:3b71af08bb84: sbin/ifconfig: Use a global libifconfig handle (authored by freqlabs).
sbin/ifconfig: Use a global libifconfig handle
Mar 17 2021, 10:26 PM

Mar 14 2021

freqlabs committed R10:4e535a1ba72e: lib/flua/libjail: Allow empty params table (authored by freqlabs).
lib/flua/libjail: Allow empty params table
Mar 14 2021, 9:12 AM
freqlabs committed R10:137544502b05: sbin/ifconfig: Get lagg status with libifconfig (authored by freqlabs).
sbin/ifconfig: Get lagg status with libifconfig
Mar 14 2021, 9:12 AM
freqlabs committed R10:ca459d253fa3: libifconfig: Add a function to get down reason (authored by freqlabs).
libifconfig: Add a function to get down reason
Mar 14 2021, 9:12 AM
freqlabs committed R10:8eb38ceffef8: sbin/ifconfig: Get groups with libifconfig (authored by freqlabs).
sbin/ifconfig: Get groups with libifconfig
Mar 14 2021, 9:11 AM
freqlabs committed R10:3dfbda3401ab: sbin/ifconfig: Get bridge status with libifconfig (authored by freqlabs).
sbin/ifconfig: Get bridge status with libifconfig
Mar 14 2021, 9:11 AM
freqlabs committed R10:f42188552c77: sbin/ifconfig: Get carp status with libifconfig (authored by freqlabs).
sbin/ifconfig: Get carp status with libifconfig
Mar 14 2021, 9:11 AM
freqlabs committed R10:d63acd26f92b: libifconfig: Fix typo in symbol map (authored by freqlabs).
libifconfig: Fix typo in symbol map
Mar 14 2021, 9:11 AM
freqlabs committed R10:caab2f4c89ba: sbin/ifconfig: Minor housekeeping (authored by freqlabs).
sbin/ifconfig: Minor housekeeping
Mar 14 2021, 9:11 AM
freqlabs committed R10:0fed2239730f: libifconfig: Set error in ifconfig_get_groups (authored by freqlabs).
libifconfig: Set error in ifconfig_get_groups
Mar 14 2021, 9:11 AM
freqlabs committed R10:dc4fae442b86: sbin/ifconfig: Drop local name var in sfp_status (authored by freqlabs).
sbin/ifconfig: Drop local name var in sfp_status
Mar 14 2021, 9:11 AM

Mar 5 2021

freqlabs added a reviewer for D29101: wait for device mounts in zpool and dumpon: mav.
Mar 5 2021, 7:58 PM
freqlabs added a comment to D29101: wait for device mounts in zpool and dumpon.

Yeah that looks like the dance everyone else is doing.

Mar 5 2021, 7:57 PM
freqlabs added a comment to D29101: wait for device mounts in zpool and dumpon.

The other places using root_hold_wait try to avoid it first. I'd expect that strategy to work at least for dumpon, though I could imagine zpool import not failing so gracefully. Did you consider it?

Mar 5 2021, 7:14 PM
freqlabs added a comment to D26932: jail(3lua): Add some basic tests.

I was reading the diff stack wrong. This doesn't depend on flua-libifconfig after all, it's just displayed in the stack because it has a common ancestor: flua-libjail.

Mar 5 2021, 11:36 AM
freqlabs committed R10:2803fa471e77: sbin/ifconfig: Get media status with libifconfig (authored by freqlabs).
sbin/ifconfig: Get media status with libifconfig
Mar 5 2021, 11:25 AM
freqlabs committed R10:88832d59dec1: sbin/ifconfig: Minor housekeeping (authored by freqlabs).
sbin/ifconfig: Minor housekeeping
Mar 5 2021, 11:25 AM