- User Since
- Jul 22 2016, 2:56 AM (200 w, 5 d)
Fri, May 22
I like the direction toward the artwork being proper Lua modules, but I think to be more idiomatic we should simply return the table for the module, rather than exporting it as a name. This should simplify the loading a bit.
Thu, May 21
Tue, May 19
Mon, May 18
Thu, May 14
I wonder if this should be incorporated as part of cap_net (D24688) instead?
Wed, May 13
Actually upload a new diff this time :)
Add suggested exec.release hook as well.
Reserve reordering enum for a later patch.
Tue, May 12
Mon, May 11
Sun, May 10
Make fsidcmp a macro
Fri, May 8
Thu, May 7
Sun, May 3
Wed, Apr 29
Mon, Apr 27
This resolves the issue for my test VM, using:
Apr 26 2020
Relaying a couple more messages from Thomas:
I just had a quick look at your patch. AFAICT up to now the write to the MSI config space was not serialized against interrupt delivery. But I don't see how that will cure the problem.
Apr 25 2020
It would be good to mention this in some man pages as well.
When the offending commit in Linux was first brought to my attention, I reached out to the author of the commit for their input on what specifically we might need to look at. Here is the response I received this afternoon, for posterity:
The latest patch seems functional for me as well:
vmrun -m 4G -c 2 -E -d /dev/zvol/system/vms/ubuntu/disk0 -I ubuntu-20.04-desktop-amd64.iso -L 192.168.1.190 -T -i ubuntu
I was having trouble at first but raising the ram size from 1GB to 4GB did the trick.
Apr 24 2020
Integrate with existing -j option, per suggestion by @jamie
Apr 23 2020
Apr 22 2020
Apr 21 2020
Apr 17 2020
Apr 16 2020
Apr 15 2020
Out of curiosity, how does options XDR (in a kernel config) avoid a name collision with the XDR typedef?
Apr 14 2020
Mar 26 2020
@tsoome is efi console / teken in shape for this now?
Mar 18 2020
Mar 16 2020
Feb 27 2020
Feb 26 2020
Feb 25 2020
This is getting really close to the finish line.
Feb 23 2020
Feb 14 2020
Feb 6 2020
Jan 26 2020
I'll be taking a closer look when I get a chance but at a glance at the diff this looks like a much cleaner change now. Thank you for taking the time to work on it!
Jan 23 2020
Jan 18 2020
I have not inspected the code in depth, but there are a number of style violations that jump out at a glance. Fixing these various nits will make the changes easier to read for reviewers. Rather than clutter up the diff I'll just mention the key points:
- Several files appear to have been edited with 4-space indentation settings rather than hard tabs, in contrast with the surrounding code. The different whitespace is confusing/frustrating.
- A bunch of added functions in block_if.c should have a newline after the function return type, rather than a bunch of horizontal space.
See style(9) as a more detailed guide, but in general matching the style of surrounding code is most desirable.
Jan 17 2020
Sorry about that!
Jan 16 2020
@asomers Will you commit this for me? I don't have the bit. Thanks!
@cem Will you commit this for me? I don't have the bit. Thanks!
Jan 15 2020
@mckusick I would like to MFC your EINTEGRITY change to stable/12 along with this change. Does this seem reasonable? At a glance the only merge conflict is that stable/12 doesn't have contrib/libc++, so that part of the patch would be dropped. Anything else to look out for?
Thanks in advance!
Jan 14 2020
Looks reasonable. This will make its way into ZoF next time we rebase, since there aren't any platform-specific files changed. The port should be updated shortly thereafter.
Jan 11 2020
Add a comment explaining the motivation for the mapping.
Jan 7 2020
Incorporate feedback. Map the constants to existing errnos instead of adding messages for old numbers.
Jan 2 2020
@bcran Thanks! Would you mind committing this for me? I don't have the bit.
Incorporated in the TMPDIR revision: D22979
Dec 31 2019
Use $BSDINSTALL_CHROOT in place of /mnt for umount.