Page MenuHomeFreeBSD

freqlabs (Ryan Moeller)
OS Developer @ iXsystems, Inc.

Projects

User Details

User Since
Jul 22 2016, 2:56 AM (217 w, 6 d)

Recent Activity

Tue, Sep 22

freqlabs accepted D26521: fix mountd.c so that it does not allocate 4K for credential groups unless a large groups list is needed.
Tue, Sep 22, 9:14 PM

Mon, Sep 21

freqlabs closed D26457: sysutils/openzfs*: Bump for recent changes.
Mon, Sep 21, 7:30 PM
freqlabs committed rP549482: sysutils/openzfs*: Bump for recent changes.
sysutils/openzfs*: Bump for recent changes
Mon, Sep 21, 7:25 PM
freqlabs added a reviewer for D26457: sysutils/openzfs*: Bump for recent changes: kevans.
Mon, Sep 21, 7:14 PM

Wed, Sep 16

freqlabs requested review of D26457: sysutils/openzfs*: Bump for recent changes.
Wed, Sep 16, 6:37 PM
freqlabs accepted D26447: add deprecation notice to ftpd.
Wed, Sep 16, 5:47 PM

Wed, Sep 9

freqlabs committed rP548105: devel/py-libzfs: Take over as maintainer, bump for OpenZFS in base.
devel/py-libzfs: Take over as maintainer, bump for OpenZFS in base
Wed, Sep 9, 4:03 PM
freqlabs closed D26325: devel/py-libzfs: Take over as maintainer, bump for OpenZFS in base.
Wed, Sep 9, 4:03 PM
freqlabs updated the diff for D26325: devel/py-libzfs: Take over as maintainer, bump for OpenZFS in base.

Bumped to a version that works on 12 and 11, too.

Wed, Sep 9, 3:00 PM

Sat, Sep 5

freqlabs added inline comments to D26340: run clang-format over vtfontcvt.c.
Sat, Sep 5, 10:56 PM

Fri, Sep 4

freqlabs added a comment to D26325: devel/py-libzfs: Take over as maintainer, bump for OpenZFS in base.

Assuming it currently builds on 11.3 and 12.1 this shouldn't break anything, but I'll test it to be sure.

Fri, Sep 4, 3:48 PM
freqlabs requested review of D26325: devel/py-libzfs: Take over as maintainer, bump for OpenZFS in base.
Fri, Sep 4, 3:41 PM

Wed, Sep 2

freqlabs committed rS365252: Correct and expand on OpenZFS cache file and auto import.
Correct and expand on OpenZFS cache file and auto import
Wed, Sep 2, 4:03 PM
freqlabs committed rS365250: Use MLINKS where appropriate for zfs/zpool subcommand pages.
Use MLINKS where appropriate for zfs/zpool subcommand pages
Wed, Sep 2, 3:20 PM

Tue, Sep 1

freqlabs committed rS365057: Ensure zstreamdump subdir can be visited.
Ensure zstreamdump subdir can be visited
Tue, Sep 1, 7:02 PM

Mon, Aug 31

freqlabs added a comment to D26258: libifconfig now depends on libm due to usage of log10()..

Lol, who did that? :-)

Oh well!

Mon, Aug 31, 11:06 PM
freqlabs accepted D26258: libifconfig now depends on libm due to usage of log10()..
Mon, Aug 31, 10:57 PM

Fri, Aug 28

freqlabs added a comment to D26218: Integrate zstd into boot loader.

Generally happy about the cleanup and the added flexibility in the build infrastructure.

Fri, Aug 28, 5:06 PM

Thu, Aug 27

freqlabs committed rS364863: libzfs: Also add the crypto dependency to Makefile.inc1.
libzfs: Also add the crypto dependency to Makefile.inc1
Thu, Aug 27, 1:26 PM
freqlabs committed rS364861: libzfs: Add missing crypto dependency.
libzfs: Add missing crypto dependency
Thu, Aug 27, 1:05 PM

Wed, Aug 26

freqlabs accepted D26193: Fix dtrace tools bootstrap on non-FreeBSD after OpenZFS import.

Looks reasonably noninvasive. I'm surprised it's that easy :)

Wed, Aug 26, 7:15 PM
freqlabs committed rS364830: Move zstd sources from libzfs to libzpool.
Move zstd sources from libzfs to libzpool
Wed, Aug 26, 7:03 PM
freqlabs committed rS364829: Tidy up libzpool Makefile.
Tidy up libzpool Makefile
Wed, Aug 26, 7:00 PM
freqlabs committed rS364821: Install zfs-events.5.
Install zfs-events.5
Wed, Aug 26, 3:44 PM
freqlabs accepted D26192: Remove -I flag for include path that doesn't exist.

No-brainer, great :)

Wed, Aug 26, 3:00 PM
freqlabs added a comment to D26185: r364746 broke ZFS legacy mounts and zvol imports: fix.

Oh, do you need to add it to libexec/rc/rc.d/Makefile?

Wed, Aug 26, 3:13 AM
freqlabs accepted D26185: r364746 broke ZFS legacy mounts and zvol imports: fix.

This looks good to me.

Wed, Aug 26, 3:09 AM

Tue, Aug 25

freqlabs committed rS364785: bsdinstall: Update loader.conf for new OpenZFS deps.
bsdinstall: Update loader.conf for new OpenZFS deps
Tue, Aug 25, 9:07 PM
freqlabs committed rS364783: Skip zpool_clear_005_pos test until bug fixed.
Skip zpool_clear_005_pos test until bug fixed
Tue, Aug 25, 8:05 PM
freqlabs closed D26121: vuxml: Document sysutils/openzfs-kmod issues.
Tue, Aug 25, 6:57 PM
freqlabs committed rS364777: Fix zstd in OpenZFS module with CPUTYPE?=<something with BMI>.
Fix zstd in OpenZFS module with CPUTYPE?=<something with BMI>
Tue, Aug 25, 6:22 PM

Aug 24 2020

freqlabs committed rP546091: openzfs*: Bump OpenZFS ports for zstd, vdev ashift optimizations.
openzfs*: Bump OpenZFS ports for zstd, vdev ashift optimizations
Aug 24 2020, 2:57 PM
freqlabs closed D26154: openzfs*: Bump OpenZFS ports for zstd, vdev ashift optimizations.
Aug 24 2020, 2:57 PM

Aug 21 2020

freqlabs requested review of D26154: openzfs*: Bump OpenZFS ports for zstd, vdev ashift optimizations.
Aug 21 2020, 9:06 PM

Aug 20 2020

freqlabs added reviewers for D26028: Expose NFSv41 ACL automatic inheritance flags: trasz, delphij.
Aug 20 2020, 6:20 PM
freqlabs updated the diff for D26121: vuxml: Document sysutils/openzfs-kmod issues.

Committed version of patch

Aug 20 2020, 6:17 PM
freqlabs committed rP545543: security/vuxml: Document sysutils/openzfs-kmod issues.
security/vuxml: Document sysutils/openzfs-kmod issues
Aug 20 2020, 6:13 PM

Aug 19 2020

freqlabs updated the diff for D26121: vuxml: Document sysutils/openzfs-kmod issues.

Context for this file is way too big. Uploaded a diff with no context so it actually loads in phab.

Aug 19 2020, 4:27 PM
freqlabs requested review of D26121: vuxml: Document sysutils/openzfs-kmod issues.
Aug 19 2020, 4:24 PM

Aug 18 2020

freqlabs committed rP545247: openzfs*: Bump OpenZFS ports.
openzfs*: Bump OpenZFS ports
Aug 18 2020, 6:36 PM
freqlabs closed D26107: openzfs*: Bump OpenZFS ports.
Aug 18 2020, 6:36 PM
freqlabs requested review of D26107: openzfs*: Bump OpenZFS ports.
Aug 18 2020, 5:45 PM

Aug 17 2020

freqlabs updated the diff for D26080: flua: Add a libjail module.
  • Add an example for the jail module
  • Add a 3lua manpage section, with intro(3lua) and jail(3lua)
  • Add __FBSDID to the jail module
  • Unshebangify lib/flua/libjail/Makefile
Aug 17 2020, 12:48 AM

Aug 16 2020

freqlabs added inline comments to D26080: flua: Add a libjail module.
Aug 16 2020, 3:28 PM
freqlabs planned changes to D26080: flua: Add a libjail module.

I plan to add documentation and Lua code examples. And I should add $FreeBSD$ and unshebangify lib/flua/libjail/Makefile

Aug 16 2020, 4:33 AM
freqlabs requested review of D26080: flua: Add a libjail module.
Aug 16 2020, 4:31 AM

Aug 13 2020

freqlabs added inline comments to D25938: acpi_asus: Expose keyboard backlight control via a sysctl.
Aug 13 2020, 1:12 PM
freqlabs updated the diff for D25938: acpi_asus: Expose keyboard backlight control via a sysctl.

Fixed typo in manual, igor and mandoc -Tlint are clean

Aug 13 2020, 1:08 PM

Aug 12 2020

freqlabs added a comment to D26035: Refactor configuration management in bhyve..
In D26035#578018, @jhb wrote:

Agreed it's a shame this isn't UCL, it could be much closer to jail.conf (which should be made UCL someday, but it's very nearly compatible on a surface level). It doesn't look like any features unique to libnv are used.

The config file overriding options passed on the command-line seems backwards. I'd expect to be able to override config file settings explicitly on the command line.

Please read the mail on virtualization@. It is very feasible to add a UCL config file syntax (and that is even a desired plan, just not currently implemented). Using libnv is more convenient than writing trees by hand in C.

Aug 12 2020, 9:46 PM
freqlabs added a comment to D26035: Refactor configuration management in bhyve..

Agreed it's a shame this isn't UCL, it could be much closer to jail.conf (which should be made UCL someday, but it's very nearly compatible on a surface level). It doesn't look like any features unique to libnv are used.

Aug 12 2020, 5:07 PM

Aug 11 2020

freqlabs accepted D26033: sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE.

If this works for you, it's fine with me.

Aug 11 2020, 9:57 PM
freqlabs added a comment to D26033: sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE.

Shouldn't the USES=kmod bit handle this? Mk/Uses/kmod.mk

Aug 11 2020, 8:38 PM

Aug 9 2020

freqlabs committed rS364058: Move ifconfig SFP status functionality into libifconfig.
Move ifconfig SFP status functionality into libifconfig
Aug 9 2020, 4:28 PM
freqlabs closed D25494: libifconfig: Add functionality for querying SFP modules.
Aug 9 2020, 4:28 PM

Aug 8 2020

freqlabs committed rP544498: openzfs*: Bump OpenZFS ports.
openzfs*: Bump OpenZFS ports
Aug 8 2020, 4:34 PM
freqlabs closed D26007: openzfs*: Bump OpenZFS ports.
Aug 8 2020, 4:29 PM
freqlabs requested review of D26007: openzfs*: Bump OpenZFS ports.
Aug 8 2020, 11:05 AM

Aug 7 2020

freqlabs accepted D25663: Fix linker error in libuutil with recent LLVM.
Aug 7 2020, 2:04 PM
freqlabs added a member for ZFS: freqlabs.
Aug 7 2020, 1:55 PM
freqlabs updated the diff for D25938: acpi_asus: Expose keyboard backlight control via a sysctl.
  • Fix detection of the number of brightness levels supported by firmware and expose it as a read-only sysctl.
  • Improve documentation of the allowed range of values.
  • leds -> LEDs
Aug 7 2020, 5:23 AM

Aug 6 2020

freqlabs updated the diff for D25494: libifconfig: Add functionality for querying SFP modules.

Add ifconfig_sfp_id_is_qsfp and ifconfig_sfp_physical_spec helpers

Aug 6 2020, 10:10 PM

Aug 5 2020

freqlabs planned changes to D25494: libifconfig: Add functionality for querying SFP modules.

Will add an ifconfig_sfp_class function to select the description string from the appropriate field to describe the module's Ethernet specification compliance.

Aug 5 2020, 6:34 AM
freqlabs updated the diff for D25494: libifconfig: Add functionality for querying SFP modules.

Fixed 32-bit build

Aug 5 2020, 6:13 AM

Aug 4 2020

freqlabs committed rS363831: MFC r363630:.
MFC r363630:
Aug 4 2020, 12:05 PM
freqlabs requested review of D25938: acpi_asus: Expose keyboard backlight control via a sysctl.
Aug 4 2020, 4:33 AM

Aug 3 2020

freqlabs closed D25915: openzfs*: Update to latest master.
Aug 3 2020, 10:42 PM
freqlabs committed rP544111: openzfs*: Update to latest master.
openzfs*: Update to latest master
Aug 3 2020, 10:42 PM

Aug 1 2020

freqlabs requested review of D25915: openzfs*: Update to latest master.
Aug 1 2020, 7:47 PM

Jul 28 2020

freqlabs committed rS363630: libpmc: Use known pmc_cpuid buffer size.
libpmc: Use known pmc_cpuid buffer size
Jul 28 2020, 2:56 AM
freqlabs closed D25679: libpmc: Use known pmc_cpuid buffer size.
Jul 28 2020, 2:56 AM
freqlabs committed rS363629: MFC r363206:.
MFC r363206:
Jul 28 2020, 2:54 AM
freqlabs added a comment to D25679: libpmc: Use known pmc_cpuid buffer size.

Going to commit this tonight since there has been no objection

Jul 28 2020, 1:13 AM
freqlabs added a comment to D25840: ps(1): Fix formatting of the "command" field for kernel threads..

Here's how it looks with https://github.com/openzfs/zfs/pull/10630 which is what brought this to my attention:

Jul 28 2020, 12:20 AM
freqlabs accepted D25840: ps(1): Fix formatting of the "command" field for kernel threads..

That helps, thanks! :)

Jul 28 2020, 12:17 AM

Jul 27 2020

freqlabs updated the test plan for D25494: libifconfig: Add functionality for querying SFP modules.
Jul 27 2020, 1:53 AM
freqlabs updated the diff for D25494: libifconfig: Add functionality for querying SFP modules.
  • Use libifconfig for sfp status in ifconfig
Jul 27 2020, 1:44 AM

Jul 21 2020

freqlabs added a comment to D25745: MFOpenZFS: Fix zpool history unbounded memory usage.

All this is just to say that even if you don't much care to maintain API compatibility when you MFC, it would be preferable still to not merging this back at all. But if you do maintain compatibility, that's even better.

Jul 21 2020, 6:59 PM
freqlabs added a comment to D25745: MFOpenZFS: Fix zpool history unbounded memory usage.

Why do you say libzfs is private? There are ports that use it (e.g. py*-libzfs), though I don't see any that reference the zpool_get_history() symbol.

Jul 21 2020, 6:48 PM
freqlabs added a comment to D25745: MFOpenZFS: Fix zpool history unbounded memory usage.

Seems a bit of a waste if you don't MFC, since the plan is for vendored OpenZFS to land in sys/contrib before 13.

Jul 21 2020, 5:49 PM
freqlabs committed rP542751: openzfs*: Bump OpenZFS ports.
openzfs*: Bump OpenZFS ports
Jul 21 2020, 3:53 PM
freqlabs closed D25748: openzfs*: Bump OpenZFS ports.
Jul 21 2020, 3:53 PM
freqlabs requested review of D25748: openzfs*: Bump OpenZFS ports.
Jul 21 2020, 12:47 AM

Jul 20 2020

freqlabs accepted D17541: update ZFS to note support of extended attributes.

Fix the date of course.

Jul 20 2020, 8:32 PM

Jul 17 2020

freqlabs added a comment to D17541: update ZFS to note support of extended attributes.

Yes a PR clarifying this in OpenZFS would be greatly appreciated. Any change here would only be good for MFC. I think the wording suggested by @delphij is a bit more clear.

Jul 17 2020, 7:06 PM

Jul 15 2020

freqlabs requested review of D25679: libpmc: Use known pmc_cpuid buffer size.
Jul 15 2020, 5:21 PM

Jul 14 2020

freqlabs committed rS363206: hwpmc: Always set pmc_cpuid to something.
hwpmc: Always set pmc_cpuid to something
Jul 14 2020, 10:25 PM
freqlabs closed D25673: hwpmc: Always set pmc_cpuid to something.
Jul 14 2020, 10:25 PM
freqlabs added inline comments to D25673: hwpmc: Always set pmc_cpuid to something.
Jul 14 2020, 9:12 PM
freqlabs added inline comments to D25673: hwpmc: Always set pmc_cpuid to something.
Jul 14 2020, 9:10 PM
freqlabs added inline comments to D25673: hwpmc: Always set pmc_cpuid to something.
Jul 14 2020, 9:06 PM
freqlabs requested review of D25673: hwpmc: Always set pmc_cpuid to something.
Jul 14 2020, 9:02 PM

Jul 11 2020

freqlabs accepted D25627: nscd: Warn when invalid configuration options are selected.

Agreed, I would have used a bool rather than an int, but this is an improvement regardless.

Jul 11 2020, 7:00 PM

Jul 10 2020

freqlabs added a comment to D24801: Allow ls to list extattrs on a file.

If there is some critical need for a strictly compliant mode, perhaps the standard POSIXLY_COMPLIANT environment variable trick found throughout the tree can be used to skip the extattr extension.

Jul 10 2020, 5:59 PM
freqlabs added inline comments to D25608: First cut at a loader.conf.d support.
Jul 10 2020, 4:28 AM
freqlabs accepted D25608: First cut at a loader.conf.d support.
Jul 10 2020, 4:02 AM

Jul 9 2020

freqlabs added a comment to D21708: Add VIRTIO_BLK_T_DISCARD support to the virtio-blk driver.

I haven't reviewed the code, but I did a basic test in bhyve and it put zeros on the disk in an instant :)

Jul 9 2020, 8:07 PM
freqlabs committed rS363037: MFC r362824:.
MFC r362824:
Jul 9 2020, 9:33 AM

Jul 3 2020

freqlabs updated the diff for D25494: libifconfig: Add functionality for querying SFP modules.
  • Make (struct ifconfig_sfp_status).power a pointer to an array of length (struct ifconfig_sfp_status).channels so that more than 4 channels may be supported in the future without changing the struct layout.
  • Add a corresponding function to free the above allocation.
  • Fix missing comments.

Generated code:

Jul 3 2020, 4:29 PM
freqlabs added a comment to D25494: libifconfig: Add functionality for querying SFP modules.

And here are what the generated files look like now.

Jul 3 2020, 8:11 AM
freqlabs updated the diff for D25494: libifconfig: Add functionality for querying SFP modules.
  • Split out the templates for each file so they feel a bit closer to C
  • Utilize src.lua.mk in the Makefile
  • Use a suffix rule to transform the templates into C
Jul 3 2020, 8:10 AM