Page MenuHomeFreeBSD
Differential D29769

zfs: damage control racing .. lookups in face of mkdir/rmdir
ClosedPublic
Actions

Authored by mjg on Apr 15 2021, 8:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 11:43 AM
Unknown Object (File)
Tue, Oct 15, 4:36 AM
Unknown Object (File)
Mon, Oct 7, 7:35 AM
Unknown Object (File)
Mon, Oct 7, 4:39 AM
Unknown Object (File)
Mon, Oct 7, 3:31 AM
Unknown Object (File)
Sun, Oct 6, 9:02 PM
Unknown Object (File)
Sun, Oct 6, 1:54 PM
Unknown Object (File)
Sun, Oct 6, 1:53 PM
View All 55 Files
Subscribers
delphij
emaste
kib

Details

Reviewers
freqlabs
mav
kib
Commits
rGd2e0a3bb2194: zfs: damage control racing .. lookups in face of mkdir/rmdir
rG9c651561a2a3: zfs: damage control racing .. lookups in face of mkdir/rmdir
Summary

See the added comment.

Note the patch does not address anything for stable/12 as it lacks the seqc infrastructure. Regardless of that, what needs to be done here is a revamp of the lookup primitive but I have no interest in working on it.

Test Plan

Trips over patched stress2 crossmp4 test.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Apr 15 2021, 8:04 AM
Herald added a subscriber: delphij. · View Herald TranscriptApr 15 2021, 8:04 AM
mjg requested review of this revision.Apr 15 2021, 8:04 AM
emaste added a subscriber: emaste.Apr 18 2021, 5:06 PM

Panic was easily reproducible w/ (broken/modified) stress2 on arm64 and so far not reproducible with this change.

freqlabs added a comment.Apr 19 2021, 5:34 PM

Is there anyone else familiar with the VFS stuff going on here who can help with this review? It's over my head at the moment.

kib accepted this revision.Apr 21 2021, 2:28 PM
kib added a subscriber: kib.

Not entering an entry into namecache is always fine.

This revision is now accepted and ready to land.Apr 21 2021, 2:28 PM
Closed by commit rG9c651561a2a3: zfs: damage control racing .. lookups in face of mkdir/rmdir (authored by mjg). · Explain WhyApr 21 2021, 3:26 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rG9c651561a2a3: zfs: damage control racing .. lookups in face of mkdir/rmdir.
mjg added a commit: rGd2e0a3bb2194: zfs: damage control racing .. lookups in face of mkdir/rmdir.May 22 2021, 6:32 PM
GitHub <noreply@github.com> mentioned this in rGf172f759b913: FreeBSD: damage control racing .. lookups in face of mkdir/rmdir.Jun 8 2021, 2:56 PM
Brian Behlendorf <behlendorf1@llnl.gov> mentioned this in rG1b7d883eaa89: FreeBSD: damage control racing .. lookups in face of mkdir/rmdir.Jun 8 2021, 2:58 PM

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
module/
os/
freebsd/
zfs/
21 lines

Diff 87872

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c

Loading...