Page MenuHomeFreeBSD
Feed Advanced Search

Tue, Nov 12

ryan_freqlabs.com added inline comments to D22328: Clean commercial ISP.
Tue, Nov 12, 4:54 PM

Thu, Oct 31

ryan_freqlabs.com added inline comments to D22194: Colored output for err(3).
Thu, Oct 31, 4:05 PM

Mon, Oct 21

ryan_freqlabs.com added a comment to D22077: Speed up "zpool import" in the presence of many zvols.

I have recently looked at this function to port adapt it for ZoF. I like the overall idea here, but as a nit please do try matching the surrounding style. I would also find it easier to follow without the extra negations. Calling the bool skip_zvols would read more naturally to me.

Mon, Oct 21, 7:41 PM

Oct 13 2019

ryan_freqlabs.com added inline comments to D21989: Use enumeration to indicate swap almost full and full, instead of 2 variables..
Oct 13 2019, 3:49 PM

Oct 8 2019

ryan_freqlabs.com added a comment to D21385: Use makefs -t msdos in make_esp_file.

makefs become part of the bootstrap tools

Oct 8 2019, 8:37 PM
ryan_freqlabs.com added a comment to D21385: Use makefs -t msdos in make_esp_file.

How to fix it?

Oct 8 2019, 8:29 PM

Sep 26 2019

ryan_freqlabs.com updated the diff for D21733: loader: Fully reset terminal settings, not just colors.

Use the correct escape sequence for reset in forth.

Sep 26 2019, 2:55 PM
ryan_freqlabs.com added a comment to D21733: loader: Fully reset terminal settings, not just colors.

while we've transitioned to teken, it looks like it eats the ESC c

Sep 26 2019, 2:19 AM

Sep 25 2019

ryan_freqlabs.com added a comment to D21733: loader: Fully reset terminal settings, not just colors.

This aims to reset more of the state to defaults, not just colors. Things like the scroll region for example, so we don't have all the output stuck on one line. There are a multitude of software/firmware/hardware issues that can cause the state to be unfavorable at boot. Loose serial connections, buggy firmware, etc. tsoome's work complements this change rather than invalidating it.

Sep 25 2019, 10:20 PM

Sep 24 2019

ryan_freqlabs.com added a comment to D21733: loader: Fully reset terminal settings, not just colors.

I was a bit slow taking the screenshot and caught the menu mid-scroll but here it is in a black on white terminal:

Sep 24 2019, 8:01 PM

Sep 23 2019

ryan_freqlabs.com updated the diff for D21733: loader: Fully reset terminal settings, not just colors.

Eliminate menu local per review.

Sep 23 2019, 8:27 PM
ryan_freqlabs.com updated the diff for D21733: loader: Fully reset terminal settings, not just colors.

I moved the UEFI console resize to before the screen reset in loader.lua to be consistent with the order of this sequence in the forth loader.rc version. In doing so I noticed a few if blocks for the menu could be combined, so I combined them.

Sep 23 2019, 7:40 PM

Sep 20 2019

ryan_freqlabs.com planned changes to D21733: loader: Fully reset terminal settings, not just colors.

Sorry, I do need to take a second look at this one. My terminal doesn't seem to be resetting the font brightness correctly when loader_color=YES in a bhyve VM looking at the serial console. Everything looks bolded until I reset the terminal again in the shell using `printf '\033c' and then it goes back to normal.

Sep 20 2019, 8:23 PM
ryan_freqlabs.com created D21733: loader: Fully reset terminal settings, not just colors.
Sep 20 2019, 7:42 PM
ryan_freqlabs.com added a comment to D21732: loader: Respect loader_color=YES for serial consoles.

Thanks! Can I ask someone with a commit bit to please put this in for me?

Sep 20 2019, 7:32 PM
ryan_freqlabs.com updated the diff for D21732: loader: Respect loader_color=YES for serial consoles.

Fixed up nearby code as requested

Sep 20 2019, 7:29 PM
ryan_freqlabs.com created D21732: loader: Respect loader_color=YES for serial consoles.
Sep 20 2019, 7:06 PM

Sep 19 2019

ryan_freqlabs.com abandoned D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.
Sep 19 2019, 2:44 AM

Sep 16 2019

ryan_freqlabs.com updated the diff for D21441: Add iflag=fullblock to dd.

Delete redundant setting of in.dbsz in error case.

Sep 16 2019, 1:20 PM
ryan_freqlabs.com updated the diff for D21441: Add iflag=fullblock to dd.

Fixed man page additions. Thanks, @bcr!

Sep 16 2019, 1:10 PM

Sep 10 2019

ryan_freqlabs.com updated the diff for D21441: Add iflag=fullblock to dd.

Make conv=sync and iflag=fullblock mutually exclusive rather than silently ignoring the iflag.

Sep 10 2019, 4:24 PM

Sep 3 2019

ryan_freqlabs.com closed D21370: Add conv=fsync flag to dd.

Committed as rS351770

Sep 3 2019, 6:40 PM
ryan_freqlabs.com added reviewers for D21441: Add iflag=fullblock to dd: jilles, imp.
Sep 3 2019, 5:46 PM
ryan_freqlabs.com added reviewers for D21422: Add oflag=fsync and oflag=sync capability to dd: jilles, imp.
Sep 3 2019, 5:46 PM
ryan_freqlabs.com added reviewers for D21376: dd: Check result of close(2) for errors: mmacy, imp.
Sep 3 2019, 5:45 PM
ryan_freqlabs.com added reviewers for D21373: Add conv=fdatasync flag to dd: mmacy, imp.
Sep 3 2019, 5:45 PM

Aug 28 2019

ryan_freqlabs.com added inline comments to D21370: Add conv=fsync flag to dd.
Aug 28 2019, 7:48 PM
ryan_freqlabs.com retitled D20118: Fix erroneous assert in libzfs diff from Fix erronious assert in libzfs diff to Fix erroneous assert in libzfs diff.
Aug 28 2019, 1:35 PM

Aug 27 2019

ryan_freqlabs.com created D21441: Add iflag=fullblock to dd.
Aug 27 2019, 6:25 PM

Aug 26 2019

ryan_freqlabs.com added a comment to D21422: Add oflag=fsync and oflag=sync capability to dd.

I also plan to add support for iflag=fullblock in a follow-up revision.

Aug 26 2019, 8:55 PM
ryan_freqlabs.com created D21422: Add oflag=fsync and oflag=sync capability to dd.
Aug 26 2019, 8:53 PM

Aug 23 2019

ryan_freqlabs.com created D21385: Use makefs -t msdos in make_esp_file.
Aug 23 2019, 8:25 PM
ryan_freqlabs.com updated the summary of D21376: dd: Check result of close(2) for errors.
Aug 23 2019, 5:41 PM
ryan_freqlabs.com created D21376: dd: Check result of close(2) for errors.
Aug 23 2019, 1:45 PM

Aug 22 2019

ryan_freqlabs.com added a comment to D21373: Add conv=fdatasync flag to dd.

I will check the result of close(2) in a follow-up patch as suggested in PR229616

Aug 22 2019, 11:39 PM
ryan_freqlabs.com created D21373: Add conv=fdatasync flag to dd.
Aug 22 2019, 8:44 PM
ryan_freqlabs.com updated the summary of D21370: Add conv=fsync flag to dd.
Aug 22 2019, 7:09 PM
ryan_freqlabs.com added a comment to D21370: Add conv=fsync flag to dd.

I am planning a followup to add the fdatasync flag, as well.

Aug 22 2019, 7:08 PM
ryan_freqlabs.com created D21370: Add conv=fsync flag to dd.
Aug 22 2019, 7:07 PM

Aug 20 2019

ryan_freqlabs.com added a comment to D20685: Relax compat.linux.osrelease checks.

What is the motivation for being able to set 'compat.linux.osrelease=3.10.0-957.12.1.el7.x86_64'?

Aug 20 2019, 2:39 AM

Aug 19 2019

ryan_freqlabs.com updated ryan_freqlabs.com.
Aug 19 2019, 10:36 PM

Aug 18 2019

ryan_freqlabs.com created D21316: Expand description of image-size in makefs(8).
Aug 18 2019, 3:25 PM

Aug 16 2019

ryan_freqlabs.com added a comment to D21288: ping: move in_cksum() to a separate source file.

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

Aug 16 2019, 9:47 PM
ryan_freqlabs.com added a comment to D21263: tap: add support for virtio-net offloads.

Thank you for making this happen! I'm glad that you managed to reuse some code from ptnet. Is taking advantage of these pieces in vtnet on your radar as well?

Aug 16 2019, 1:58 AM

Jul 18 2019

D17103: Add runtime option for all second-stage boot blocks to reset terminal is now accepted and ready to land.
Jul 18 2019, 2:48 AM

Jul 17 2019

ryan_freqlabs.com added inline comments to D17102: Add build-time option to boot0sio to reset terminal.
Jul 17 2019, 7:32 PM
D17102: Add build-time option to boot0sio to reset terminal is now accepted and ready to land.

Thank you!

Jul 17 2019, 7:31 PM
ryan_freqlabs.com added a comment to D17103: Add runtime option for all second-stage boot blocks to reset terminal.

Whoops, spotted a few more spelling errors.

Jul 17 2019, 7:25 PM

Jul 16 2019

ryan_freqlabs.com added inline comments to D17102: Add build-time option to boot0sio to reset terminal.
Jul 16 2019, 1:19 PM
ryan_freqlabs.com added inline comments to D17103: Add runtime option for all second-stage boot blocks to reset terminal.
Jul 16 2019, 1:04 PM

Jun 13 2019

ryan_freqlabs.com added a comment to D20498: Add test cases for epair.

By the way, I don't have commit access, so someone else will have to volunteer to commit this, please. Thanks!

Jun 13 2019, 3:18 AM

Jun 2 2019

ryan_freqlabs.com updated the diff for D20498: Add test cases for epair.

Mention PR for panic in ipv6 skip message.

Jun 2 2019, 1:23 AM

Jun 1 2019

ryan_freqlabs.com abandoned D20168: Start testing cloned interfaces.

I have created a new revision for just the epair tests here: https://reviews.freebsd.org/D20498

Jun 1 2019, 11:52 PM · network
ryan_freqlabs.com created D20498: Add test cases for epair.
Jun 1 2019, 11:48 PM

May 20 2019

ryan_freqlabs.com added a comment to D20118: Fix erroneous assert in libzfs diff.

ZoL commit: https://github.com/zfsonlinux/zfs/commit/9dc41a769df164875d974c2431b2453e70e16c41

May 20 2019, 6:08 PM

May 6 2019

ryan_freqlabs.com added a comment to D20168: Start testing cloned interfaces.

I should also note that there are panics in the lagg tests, described in bugzilla here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234135

May 6 2019, 7:04 AM · network
ryan_freqlabs.com added a comment to D20168: Start testing cloned interfaces.

Perhaps the panics currently requiring tests to be skipped should be fixed before the skipped tests are enabled. Multicast cleanup is pending in the following revisions that I am aware of:
https://reviews.freebsd.org/D19886
https://reviews.freebsd.org/D20070

May 6 2019, 6:59 AM · network
ryan_freqlabs.com created D20168: Start testing cloned interfaces.
May 6 2019, 6:49 AM · network

May 1 2019

ryan_freqlabs.com created D20118: Fix erroneous assert in libzfs diff.
May 1 2019, 1:06 AM

Apr 30 2019

ryan_freqlabs.com added a comment to D19886: Fix numerous refcount bugs in multicast ....

before running tests:

ether_multi    17     2K       -       17  16,32,64,128
   in_multi     2     1K       -        2  256
  in6_multi    15     2K       -       15  32,256
Apr 30 2019, 8:39 PM
ryan_freqlabs.com added a comment to D19886: Fix numerous refcount bugs in multicast ....

I have been running the tests in tests/sys/net with Matt's patch. Many of the test cases in if_clone_test are currently skipped due to panics, and with this patch I am now able to complete a run with those tests enabled. Doing so with mdnsresponder running exposes a different issue in an lo(4) test case, which will be something else to look into. I have also added test cases for epair(4), which pass as well. I will be putting my changes to enable these tests and add the epair test cases up for review shortly.

Apr 30 2019, 4:33 PM

Mar 22 2019

ryan_freqlabs.com updated the diff for D19640: oce: Simplify probe method.

Use existing struct pci_device_table and related macros as suggested by @imp

Mar 22 2019, 12:04 AM

Mar 19 2019

ryan_freqlabs.com created D19640: oce: Simplify probe method.
Mar 19 2019, 9:14 AM
ryan_freqlabs.com created D19638: oce: Give names to promisc bits.
Mar 19 2019, 8:56 AM
ryan_freqlabs.com created D19637: oce: Fix name collision in unhygenic macros.
Mar 19 2019, 8:49 AM

Feb 1 2019

ryan_freqlabs.com added reviewers for D18924: bridge: Fix spurious warnings about capabilities: kp, mav, mmacy.
Feb 1 2019, 8:54 PM
ryan_freqlabs.com created D19052: usr.sbin/sesutil: Check element type before setting LEDs.
Feb 1 2019, 2:59 AM
ryan_freqlabs.com created D19051: cam/scsi: Use switch instead of chained if/else.
Feb 1 2019, 2:49 AM

Jan 22 2019

ryan_freqlabs.com updated the test plan for D18924: bridge: Fix spurious warnings about capabilities.
Jan 22 2019, 7:38 PM
ryan_freqlabs.com created D18924: bridge: Fix spurious warnings about capabilities.
Jan 22 2019, 7:28 PM

Oct 27 2018

ryan_freqlabs.com added a comment to D17697: Fix jail examples in jib, jng, README.

I do not. Please take it from here. Thanks!

Oct 27 2018, 5:25 PM
ryan_freqlabs.com updated the diff for D17697: Fix jail examples in jib, jng, README.

Reworded text to point out that netgraph modules are only needed for jng.

Oct 27 2018, 2:51 AM
ryan_freqlabs.com added a comment to D17697: Fix jail examples in jib, jng, README.

The rest of the examples in the README describe the steps for a persistent configuration and how to immediately bring the system to that state, without calling out the latter part as optional. However this does make me realize that it should be mentioned these steps are only for the jng examples and are not necessary for use of jib.

Oct 27 2018, 2:40 AM
ryan_freqlabs.com updated the diff for D17697: Fix jail examples in jib, jng, README.

Addressed feedback that only ng_ether must be manually loaded.

Oct 27 2018, 12:54 AM
ryan_freqlabs.com added a comment to D17697: Fix jail examples in jib, jng, README.

I missed the part about bridge and eiface autoloading, whoops!

Oct 27 2018, 12:47 AM
ryan_freqlabs.com updated the diff for D17697: Fix jail examples in jib, jng, README.

Addressed feedback by adding instructions for persistent loading of netgraph modules at boot.
(It's documented in rc.conf(5) that kld_list in rc.conf is preferable to loading with *_load in loader.conf because the kernel can load modules faster than loader.)

Oct 27 2018, 12:31 AM

Oct 25 2018

ryan_freqlabs.com created D17697: Fix jail examples in jib, jng, README.
Oct 25 2018, 4:58 AM

Oct 24 2018

ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Addressed feedback by adding handling of new ports, so creating a lagg or adding new ports to an existing lagg sets all the port interfaces to the correct MTU automatically, too.

Oct 24 2018, 3:41 AM · network

Oct 16 2018

ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Addressed feedback I received here and elsewhere on the previous patch. Please consider this alternative approach.

Oct 16 2018, 7:27 PM · network
ryan_freqlabs.com added a comment to D17576: Allow changing lagg(4) MTU.

For additional context, here is the code from if_bridge.c this is based on:

case SIOCSIFMTU:
        if (ifr->ifr_mtu < 576) {
                error = EINVAL;
                break;
        }
        if (LIST_EMPTY(&sc->sc_iflist)) {
                sc->sc_ifp->if_mtu = ifr->ifr_mtu;
                break;
        }
        BRIDGE_LOCK(sc);
        LIST_FOREACH(bif, &sc->sc_iflist, bif_next) {
                if (bif->bif_ifp->if_mtu != ifr->ifr_mtu) {
                        log(LOG_NOTICE, "%s: invalid MTU: %u(%s)"
                            " != %d\n", sc->sc_ifp->if_xname,
                            bif->bif_ifp->if_mtu,
                            bif->bif_ifp->if_xname, ifr->ifr_mtu);
                        error = EINVAL;
                        break;
                }
        }
        if (!error)
                sc->sc_ifp->if_mtu = ifr->ifr_mtu;
        BRIDGE_UNLOCK(sc);
        break;

It was not obvious to me why the minimum MTU should be limited by IPv4 but I included it here erring on the side of caution.

Oct 16 2018, 3:36 PM · network
ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Bumped the date in the man page.

Oct 16 2018, 7:44 AM · network

Oct 15 2018

ryan_freqlabs.com created D17576: Allow changing lagg(4) MTU.
Oct 15 2018, 10:34 PM · network

Sep 24 2018

ryan_freqlabs.com updated the diff for D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.

Removed TRIM quirk. Added 4k quirk for SCSI da in addition to ATA da.

Sep 24 2018, 6:50 PM

Sep 15 2018

ryan_freqlabs.com added a comment to D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.
In D17169#366159, @imp wrote:

How were you able to determine this?
The latest version of Linux doesn't have this quirk.

Sep 15 2018, 4:26 AM

Sep 14 2018

ryan_freqlabs.com created D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.
Sep 14 2018, 9:04 AM

Jul 31 2018

ryan_freqlabs.com created D16534: e1000: Don't use 9k jumbo clusters.
Jul 31 2018, 8:00 PM

Aug 30 2016

ryan_freqlabs.com updated the diff for D7369: Eliminate unnecessary loop in _cap_check().

The variable i is not necessary, either.

Aug 30 2016, 1:48 AM

Aug 3 2016

ryan_freqlabs.com added a comment to D7369: Eliminate unnecessary loop in _cap_check().
In D7369#153325, @ed wrote:

Interesting. I suspect an older version of this code hand-rolled cap_rights_contains() and was incorrectly refactored?

Aug 3 2016, 10:02 AM
ryan_freqlabs.com created P105 random blocking dhclient for several seconds.
Aug 3 2016, 5:49 AM

Jul 30 2016

ryan_freqlabs.com updated D7369: Eliminate unnecessary loop in _cap_check().
Jul 30 2016, 8:05 AM
ryan_freqlabs.com updated D7369: Eliminate unnecessary loop in _cap_check().
Jul 30 2016, 8:00 AM
ryan_freqlabs.com retitled D7369: Eliminate unnecessary loop in _cap_check() from to Eliminate unnecessary loop in _cap_check().
Jul 30 2016, 7:49 AM