Attach zpool_influxdb to OpenZFS build
AcceptedPublic
Actions

Authored by mm on Jul 4 2021, 9:13 PM.

Tags

Referenced Files

	F160290816: D31020.id91725.diff
	Mon, Jun 22, 11:48 PM

	Unknown Object (File)
	Mon, Jun 8, 9:10 AM

	Unknown Object (File)
	Thu, Jun 4, 3:47 AM

	Unknown Object (File)
	May 15 2026, 8:50 AM

	Unknown Object (File)
	May 15 2026, 8:50 AM

	Unknown Object (File)
	May 15 2026, 3:40 AM

	Unknown Object (File)
	May 13 2026, 2:33 AM

	Unknown Object (File)
	May 12 2026, 5:59 AM

View All Files

Subscribers

None

Details

Reviewers

freqlabs
rlibby
imp
sjg

Summary

This attaches /usr/libexec/zfs/zpool_influxdb to OpenZFS build.

OpenZFS targets this binary into "$(DESTDIR)$(zfsexecdir)" where "zfsexecdir = ${exec_prefix}/libexec/zfs"

Makefile.depend should be like zpool, how to autogenerate this file?

Test Plan

make universe passed

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mm requested review of this revision.Jul 4 2021, 9:13 PM

mm created this revision.

This looks good to me. I recall that Makefile.depend will be generated by whoever needs it and does not need to be committed if you aren't sure how to do it, but I don't see that in the committer's guide so I'm not sure where that idea came from. Hopefully someone else has input on that aspect.

This revision is now accepted and ready to land.Jul 6 2021, 3:51 PM

I always have to ask sjg. Maybe add him to the review?

mm added a reviewer: sjg.Jul 7 2021, 6:28 AM