Page MenuHomeFreeBSD

Attach zpool_influxdb to OpenZFS build
AcceptedPublic

Authored by mm on Jul 4 2021, 9:13 PM.

Details

Summary

This attaches /usr/libexec/zfs/zpool_influxdb to OpenZFS build.

OpenZFS targets this binary into "$(DESTDIR)$(zfsexecdir)" where "zfsexecdir = ${exec_prefix}/libexec/zfs"

Makefile.depend should be like zpool, how to autogenerate this file?

Test Plan

make universe passed

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mm requested review of this revision.Jul 4 2021, 9:13 PM
mm created this revision.

This looks good to me. I recall that Makefile.depend will be generated by whoever needs it and does not need to be committed if you aren't sure how to do it, but I don't see that in the committer's guide so I'm not sure where that idea came from. Hopefully someone else has input on that aspect.

This revision is now accepted and ready to land.Jul 6 2021, 3:51 PM

I always have to ask sjg. Maybe add him to the review?