Page MenuHomeFreeBSD

ZFS NAME_ERR_DISKLIKE check is Solaris-specific
Needs ReviewPublic

Authored by dclarke_blastwave.org on Mar 25 2021, 2:19 AM.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

I have other changes to also post but I need to verify that the enum symbol can be safely removed and then also follow up with upstream thus :

https://github.com/openzfs/zfs/issues/11781

Dennis

Hi Dennis. As I understand it, updates from OpenZFS are pulled in pretty regularly, and for non-critical fixes it is preferred to let them trickle in from upstream.

So, the best would be to wait for someone to address the OpenZFS issue, or file a pull request there.

Yep this can go through upstream.

Based on https://github.com/openzfs/zfs/pull/11813 and also the code
change https://github.com/openzfs/zfs/commit/c05eec32a7f7eeeb17c328f39da742a8096a5991

May we consider this a done deal ? That ten year old bug 159356 can be closed I would think.

Dennis

A change was pused six hours ago : https://github.com/openzfs/zfs/commit/895d39aa832a6d90cb15263f8bbe41509baa3867

The enum symbol NAME_ERR_DISKLIKE still exists in a few places however one may be able to finally create a zpool named c0ffee if you desire. That only took ten years.

Dennis Clarke

This has been committed in 1603881667360c015f6685131f2f25474fa67a72 #11813 Allow pool names that look like Solaris disk names