Page MenuHomeFreeBSD

net/remmina and others: remmina port update and cleanup

Authored by on Aug 6 2019, 5:01 AM.



Update to bring Remmina to 1.3.5 and cleanup of some minor port details.

Adding support for ST("simple" terminal), www, and spice. Enabling nx by default.

Telepathy plugin is disabled upstream and is removed as a port to match.

Test Plan

Testing ports build are clean with portlint and poudriere testport and that I can use the plugins I have easy access to (rdp/vnc/exec/st/rdp)

Any other testing anyone else can do is much appreciated

Diff Detail

rP FreeBSD ports repository
Lint Skipped
Unit Tests Skipped

Event Timeline

Missed a telepathy reference for it's description. (Purposely left references in the plugin mk file in case telepathy is reactivated in future)

linimon retitled this revision from Remmina Port update and cleanup to net/remmina and others: remmina port update and cleanup.Aug 6 2019, 3:10 PM

Hi Nick,
Thanks for submitting this diff - it looks like great work, and I am happy for it to be committed.
Given you are not using an account here, I assume you do not have a commit bit? Would you like me to commit this on your behalf?

This revision is now accepted and ready to land.Aug 7 2019, 10:56 PM

Thanks for the greenlight if you can commit it that would be great.

This only minor comment I would make, is that I prefer to keep things alphabetical in Makefile entries. I have pointed these out with inline comments, but happy for this to be committed without these being changed, as it is only a preference.


Add in alphabatical order (w before x)


Add in alphabetical order (k before w)


Add in alphabetical order (sodium before soup)


Ensure alphabetical order


Ensure alphabetical

Of course I will get those cleaned up slipped through my final checks.

One more comment on how to submit phabricator reviews - it is best if the full context of the diff is submitted (allowing me to expand the other parts of the files in between the changes if I am looking for more context).
This can be done using the "arc" command, or by generating the diff with "svn diff --diff-cmd=diff -x -U999999 > change.diff".
This is described here:

Covered all wanted alphabetical fixes plus a few more I found during review

This revision now requires review to proceed.Aug 11 2019, 12:57 AM

Those variables are not defined before, no need for +=. (same for all slave ports later.)


Please convert this to ucl so that it is only shown on install.

Just realized that I missed the added ports(remmina plugins) will also need to add those.

Fixed missing plugins/ports and issues raised above.

Updated diff to fix issues.


Does this look good now?

@woodsb02 I think your clear to commit whenever you have time.

This has now been committed, and this review can be closed (not sure why this wasn't automatically picked up by phabricator):

Thanks again for a quality submission.


I had to move the " \" to the second last line when I committed this

This revision is now accepted and ready to land.Aug 18 2019, 2:02 PM