net/remmina and others: remmina port update and cleanup

[darkfiberiru_gmail.com]

Summary

Update to bring Remmina to 1.3.5 and cleanup of some minor port details.

Adding support for ST("simple" terminal), www, and spice. Enabling nx by default.

Telepathy plugin is disabled upstream and is removed as a port to match.

Test Plan

Testing ports build are clean with portlint and poudriere testport and that I can use the plugins I have easy access to (rdp/vnc/exec/st/rdp)

Any other testing anyone else can do is much appreciated

[darkfiberiru_gmail.com]

Missed a telepathy reference for it's description. (Purposely left references in the plugin mk file in case telepathy is reactivated in future)

[woodsb02]

Hi Nick,
Thanks for submitting this diff - it looks like great work, and I am happy for it to be committed.
Given you are not using an @freebsd.org account here, I assume you do not have a commit bit? Would you like me to commit this on your behalf?
Regards,
Ben

[darkfiberiru_gmail.com]

Thanks for the greenlight if you can commit it that would be great.

[woodsb02]

This only minor comment I would make, is that I prefer to keep things alphabetical in Makefile entries. I have pointed these out with inline comments, but happy for this to be committed without these being changed, as it is only a preference.

net/remmina-plugins/bsd.plugin.mk

73

Add in alphabatical order (w before x)

76

Add in alphabetical order (k before w)

net/remmina/Makefile

16

Add in alphabetical order (sodium before soup)

18

Ensure alphabetical order

[woodsb02]

net/remmina-plugin-vnc/Makefile

12

Ensure alphabetical

[darkfiberiru_gmail.com]

Of course I will get those cleaned up slipped through my final checks.

[woodsb02]

One more comment on how to submit phabricator reviews - it is best if the full context of the diff is submitted (allowing me to expand the other parts of the files in between the changes if I am looking for more context).
This can be done using the "arc" command, or by generating the diff with "svn diff --diff-cmd=diff -x -U999999 > change.diff".
This is described here: https://wiki.freebsd.org/Phabricator

[darkfiberiru_gmail.com]

Covered all wanted alphabetical fixes plus a few more I found during review

[mat]

net/remmina-plugin-exec/Makefile

8–9

Those variables are not defined before, no need for +=. (same for all slave ports later.)

net/remmina/pkg-message

1–3

Please convert this to ucl so that it is only shown on install.

[darkfiberiru_gmail.com]

Just realized that I missed the added ports(remmina plugins) will also need to add those.

[darkfiberiru_gmail.com]

Fixed missing plugins/ports and issues raised above.

[darkfiberiru_gmail.com]

Updated diff to fix issues.

net/remmina/pkg-message

1–3

Does this look good now?

[darkfiberiru_gmail.com]

@woodsb02 I think your clear to commit whenever you have time.

[woodsb02]

This has now been committed, and this review can be closed (not sure why this wasn't automatically picked up by phabricator):
https://reviews.freebsd.org/rP509197

Thanks again for a quality submission.

net/remmina/Makefile

16

I had to move the " \" to the second last line when I committed this

[darkfiberiru_gmail.com]

Closed by commit r509197