sysutils/turbostat: Update to fix sysctl kern.sched.topology_spec max length

[darkfiberiru_gmail.com]

Summary

sysctl kern.sched.topology_spec can be over 16k characters. This code written by @freqlabs to help me as I was troubleshooting other issues on AMD epyc dynamically allocates a buffer instead of a fixed length to fix this issue.

Test Plan

Test on xeon 6242R should work fully
Test on AMD EPYC 7551 should fix sysctl size issue but still have other issues to be resolved.

[scottph]

sysutils/turbostat/files/patch-turbostat.c

154

I think this should be if (sysctlbyname() != 0 && errno != ENOMEM)

156

No need for the extra byte if you're not zeroing it for paranoia's sake.

Also, it's not hurting anything, but may as well free(spec) down at the end of the function.

Otherwise this looks like a good change.

[freqlabs]

I'll second Scott's three suggested changes.

[darkfiberiru_gmail.com]

Update commit to fix according to feedback.

[darkfiberiru_gmail.com]

Resolved all three requested fixes

[darkfiberiru_gmail.com]

This build has been tested on dual intel 6242R where turbostat works as expected and and on dual AMD EPYC 7551 32-Core where this code fixes the sysctl issues but fails on futher issues which I have a bug report for here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251113

[darkfiberiru_gmail.com]

Thank you ryan for catching my mess up using git diff instead of git show for the commit.

[freqlabs]

Thanks!

[darkfiberiru_gmail.com]

I don't have my commit bit. Can someone commit this fix?

[ericbsd]

In D27209#614630, @darkfiberiru_gmail.com wrote:

I don't have my commit bit. Can someone commit this fix?

I Can if anyone did not commit it already.

[ericbsd]

Done https://svnweb.freebsd.org/ports?view=revision&revision=557382