Page MenuHomeFreeBSD

scottph (D Scott Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2018, 5:54 PM (337 w, 6 d)

Recent Activity

Jul 25 2024

scottph added a comment to D46094: arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash..

Thanks Andrew, could you (or anybody else) help merge that? My commit bit is taking a nap at the moment.

Jul 25 2024, 3:40 PM

Jul 24 2024

scottph added inline comments to D46094: arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash..
Jul 24 2024, 1:56 AM
scottph requested review of D46094: arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash..
Jul 24 2024, 1:16 AM

Oct 12 2023

scottph accepted D42080: arm64: Set the Guarded Page flag in the kernel.

Looks good, my BTI capable machine continues booting with this applied.

Oct 12 2023, 7:12 PM

Mar 30 2022

scottph committed rGcf9f384de949: Fix arm64 TLB invalidation with non-4k pages (authored by andrew).
Fix arm64 TLB invalidation with non-4k pages
Mar 30 2022, 9:05 PM
scottph committed rG8f95edc10dca: arm64: Add explicit barrier after address translation instruction (authored by scottph).
arm64: Add explicit barrier after address translation instruction
Mar 30 2022, 9:05 PM
scottph committed rG33a625b1d6cd: arm64: pmap: Mask VA operand in TLBI instructions (authored by scottph).
arm64: pmap: Mask VA operand in TLBI instructions
Mar 30 2022, 9:05 PM

Mar 29 2022

scottph committed rG341953bc12c8: Add the Ampere and Fujitsu arm64 implementer IDs (authored by scottph).
Add the Ampere and Fujitsu arm64 implementer IDs
Mar 29 2022, 3:55 PM
scottph committed rG0e19a22dd145: arm64: Add explicit barrier after address translation instruction (authored by scottph).
arm64: Add explicit barrier after address translation instruction
Mar 29 2022, 3:55 PM
scottph committed rG2c013d142b14: arm64: pmap: Mask VA operand in TLBI instructions (authored by scottph).
arm64: pmap: Mask VA operand in TLBI instructions
Mar 29 2022, 3:55 PM
scottph committed rG89166c063a9a: Fix arm64 TLB invalidation with non-4k pages (authored by andrew).
Fix arm64 TLB invalidation with non-4k pages
Mar 29 2022, 3:54 PM

Mar 25 2022

scottph committed rG220c48e2d987: Add the Ampere and Fujitsu arm64 implementer IDs (authored by scottph).
Add the Ampere and Fujitsu arm64 implementer IDs
Mar 25 2022, 4:50 PM
scottph committed rGa693a3003827: arm64: pmap: Mask VA operand in TLBI instructions (authored by scottph).
arm64: pmap: Mask VA operand in TLBI instructions
Mar 25 2022, 4:50 PM
scottph committed rG7be7bd677585: arm64: Add explicit barrier after address translation instruction (authored by scottph).
arm64: Add explicit barrier after address translation instruction
Mar 25 2022, 4:50 PM
scottph closed D34664: arm64: pmap: Mask VA operand in TLBI instructions.
Mar 25 2022, 4:50 PM
scottph closed D34665: arm64: Add explicit barrier after address translation instruction.
Mar 25 2022, 4:50 PM
scottph closed D34666: Add the Ampere and Fujitsu arm64 implementer IDs.
Mar 25 2022, 4:50 PM

Mar 24 2022

scottph requested review of D34666: Add the Ampere and Fujitsu arm64 implementer IDs.
Mar 24 2022, 5:11 PM
scottph requested review of D34665: arm64: Add explicit barrier after address translation instruction.
Mar 24 2022, 5:10 PM
scottph requested review of D34664: arm64: pmap: Mask VA operand in TLBI instructions.
Mar 24 2022, 5:09 PM

Feb 17 2021

scottph added a comment to D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.

You can check the IPMI Specification, sec 12.5 for info on SSIF Multi-part Read Transactions

Feb 17 2021, 11:06 PM
scottph abandoned D26765: Order SI_SUB_SMP before intrhooks when !EARLY_AP_STARTUP.
Feb 17 2021, 10:11 PM
scottph added a comment to D26765: Order SI_SUB_SMP before intrhooks when !EARLY_AP_STARTUP.

D28340's approach of letting all CPUs get targeted by an ITS removes the need for moving around SI_SUB_SMP.

Feb 17 2021, 10:11 PM
scottph abandoned D26764: arm64/gicv3: Initialize all ITS collections at attach time.

D28340's approach of letting all CPUs get targeted by an ITS removes the need for changing this initialization.

Feb 17 2021, 10:10 PM
scottph added inline comments to D28737: stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure.
Feb 17 2021, 10:06 PM
scottph closed D28340: gicv3_its: Don't restrict target CPUs based on SRAT.
Feb 17 2021, 9:56 PM
scottph committed rG3046eb03ccf0: gicv3_its: Don't restrict target CPUs based on SRAT (authored by scottph).
gicv3_its: Don't restrict target CPUs based on SRAT
Feb 17 2021, 9:56 PM

Feb 16 2021

scottph added inline comments to D28707: Fix attachment of IPMI driver on ARM64.
Feb 16 2021, 6:50 PM
scottph requested review of D28709: gicv3_its: Leave LPI interrupts enable during handling.
Feb 16 2021, 6:10 PM
scottph added inline comments to D28340: gicv3_its: Don't restrict target CPUs based on SRAT.
Feb 16 2021, 6:08 PM
scottph updated the diff for D28340: gicv3_its: Don't restrict target CPUs based on SRAT.
Feb 16 2021, 6:08 PM

Jan 25 2021

scottph added a comment to D28340: gicv3_its: Don't restrict target CPUs based on SRAT.

We need to limit which CPUs we send these interrupts to on the original dual socket ThunderX as it is unable to forward them between the two sockets.

Jan 25 2021, 9:44 PM
scottph updated the diff for D28340: gicv3_its: Don't restrict target CPUs based on SRAT.
Jan 25 2021, 9:39 PM
scottph requested review of D28340: gicv3_its: Don't restrict target CPUs based on SRAT.
Jan 25 2021, 8:18 PM

Dec 14 2020

scottph added a comment to D24066: bhyve: support relocating fbuf and passthru data BARs.

Is this waiting on anything?

Dec 14 2020, 5:47 PM · bhyve

Dec 4 2020

scottph accepted D27209: sysutils/turbostat: Update to fix sysctl kern.sched.topology_spec max length.
Dec 4 2020, 6:57 PM

Nov 13 2020

scottph added inline comments to D27209: sysutils/turbostat: Update to fix sysctl kern.sched.topology_spec max length.
Nov 13 2020, 11:06 PM

Oct 22 2020

scottph accepted D26907: Conditionally compile struct vm_phys_seg's md_first field.
Oct 22 2020, 6:06 PM

Oct 15 2020

scottph closed D26766: arm64: Increase NIRQ to 16k.
Oct 15 2020, 3:12 AM
scottph committed rS366715: arm64: Increase NIRQ to 16k.
arm64: Increase NIRQ to 16k
Oct 15 2020, 3:12 AM

Oct 14 2020

scottph accepted D26741: Avoid dump_avail[] redefinition..
Oct 14 2020, 6:31 PM

Oct 13 2020

scottph added a comment to D26741: Avoid dump_avail[] redefinition..

Thanks for fixing this. Grepping around, I believe vm_dumpset.h should also be included in:

Oct 13 2020, 10:22 PM
scottph added a comment to D26766: arm64: Increase NIRQ to 16k.

This increases bss by ~1.5 MiB

Oct 13 2020, 8:44 PM
scottph requested review of D26766: arm64: Increase NIRQ to 16k.
Oct 13 2020, 7:21 PM
scottph added a comment to D26765: Order SI_SUB_SMP before intrhooks when !EARLY_AP_STARTUP.

This works for my case, but I'm not sure if this will be a problem for other platforms, or maybe for downstream codebases?

Oct 13 2020, 7:19 PM
scottph requested review of D26765: Order SI_SUB_SMP before intrhooks when !EARLY_AP_STARTUP.
Oct 13 2020, 7:17 PM
scottph added a comment to D26764: arm64/gicv3: Initialize all ITS collections at attach time.

Another approach could be to just all interrupts to target the boot cpu, maybe before ap startup and maybe apply proximity restrictions after ap startup?

Oct 13 2020, 7:16 PM
scottph requested review of D26764: arm64/gicv3: Initialize all ITS collections at attach time.
Oct 13 2020, 7:14 PM

Oct 12 2020

scottph accepted D26741: Avoid dump_avail[] redefinition..
Oct 12 2020, 3:19 PM

Sep 30 2020

scottph accepted D26602: acpi: Tweak _DSM method evaluation helpers. .
Sep 30 2020, 5:26 PM

Sep 21 2020

scottph committed rS365982: stand/reloc_elf: Handle relative relocations for arm{,64} and riscv.
stand/reloc_elf: Handle relative relocations for arm{,64} and riscv
Sep 21 2020, 10:25 PM
scottph closed D26365: stand/reloc_elf: Handle relative relocations for arm{,64} and riscv.
Sep 21 2020, 10:25 PM
scottph committed rS365981: arm64/pmap: Sparsify pv_table.
arm64/pmap: Sparsify pv_table
Sep 21 2020, 10:24 PM
scottph closed D26132: arm64/pmap: Sparsify pv_table.
Sep 21 2020, 10:24 PM
scottph committed rS365980: vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE.
vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE
Sep 21 2020, 10:23 PM
scottph closed D26130: vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE.
Sep 21 2020, 10:23 PM
scottph committed rS365978: Sparsify the vm_page_dump bitmap.
Sparsify the vm_page_dump bitmap
Sep 21 2020, 10:22 PM
scottph closed D26131: Sparsify the vm_page_dump bitmap.
Sep 21 2020, 10:22 PM
scottph committed rS365977: Move vm_page_dump bitset array definition to MI code.
Move vm_page_dump bitset array definition to MI code
Sep 21 2020, 10:21 PM
scottph closed D26129: Move vm_page_dump bitset array definition to MI code.
Sep 21 2020, 10:21 PM
scottph closed D26190: bitset: expand bit index type to `long`.
Sep 21 2020, 10:19 PM
scottph committed rS365975: bitset: expand bit index type to `long`.
bitset: expand bit index type to `long`
Sep 21 2020, 10:19 PM
scottph committed rS365974: vchi: rename bitset macros to avoid collision with bitset(9).
vchi: rename bitset macros to avoid collision with bitset(9)
Sep 21 2020, 10:18 PM
scottph closed D26177: vchi: rename bitset macros to avoid collision with bitset(9).
Sep 21 2020, 10:18 PM
scottph abandoned D26519: arm64/pmap: Remove valid bit check from r365879 assertions.
Sep 21 2020, 9:31 PM
scottph added a comment to D26519: arm64/pmap: Remove valid bit check from r365879 assertions.

See D26510

Sep 21 2020, 9:31 PM
scottph requested review of D26519: arm64/pmap: Remove valid bit check from r365879 assertions.
Sep 21 2020, 9:07 PM

Sep 10 2020

scottph added a comment to D26177: vchi: rename bitset macros to avoid collision with bitset(9).

I wonder if we can upstream this too

Sep 10 2020, 1:36 AM

Sep 9 2020

scottph added a comment to D26365: stand/reloc_elf: Handle relative relocations for arm{,64} and riscv.
In D26365#586260, @manu wrote:

Thanks !
My investigation of this problem 1 year ago lead me to think it was relocation related but I'm clueless on how that work.
I'll try to test that asap (especially arm where I don't think we had a problem).

Sep 9 2020, 6:05 PM
scottph committed rS365505: stand/efihttp: Work around a bug in edk2 http instance reconfiguration.
stand/efihttp: Work around a bug in edk2 http instance reconfiguration
Sep 9 2020, 4:36 PM
scottph closed D21281: Work around a bug in the EFI HTTP driver.
Sep 9 2020, 4:36 PM
scottph requested review of D26365: stand/reloc_elf: Handle relative relocations for arm{,64} and riscv.
Sep 9 2020, 2:26 AM

Sep 8 2020

scottph added a comment to D21281: Work around a bug in the EFI HTTP driver.

I've tracked this down to a particular use-after-free type bug in edk2: https://www.mail-archive.com/devel@edk2.groups.io/msg25730.html

Sep 8 2020, 4:57 AM

Aug 31 2020

scottph added a comment to D26131: Sparsify the vm_page_dump bitmap.
In D26131#582102, @jhb wrote:

In general it seems like there's an implicit assumption that nothing will ask
for a PA that isn't in dump_avail[], and if it does we just return the wrong
page since we just return some offset relative to the previous dump_avail
entry that overflows into the next entry's bitmap? It would be annoying to
fix as it means all the places that call _kvm_pa_to_bit(), and or adding some
kind of _kvm_has_pa().

Aug 31 2020, 11:18 PM
scottph updated the diff for D26131: Sparsify the vm_page_dump bitmap.
Aug 31 2020, 11:12 PM
scottph added inline comments to D26132: arm64/pmap: Sparsify pv_table.
Aug 31 2020, 10:47 PM
scottph updated the diff for D26132: arm64/pmap: Sparsify pv_table.
Aug 31 2020, 10:28 PM

Aug 27 2020

scottph added a comment to D26190: bitset: expand bit index type to `long`.

Can we reuse the algorithm from is_dumpable()? That is, if the PA corresponds
to a vm_page, use a flag to decide whether the page is to be included in the
minidump, otherwise include it so long as the PA is in dump_avail[].

Aug 27 2020, 5:50 PM
scottph added a comment to D26190: bitset: expand bit index type to `long`.
In D26190#582299, @kib wrote:

If dump bitmap becomes so large, may be it is better to get rid of it at all ?
You can use vm_page aflags to track dumpable state.

Aug 27 2020, 4:48 PM

Aug 26 2020

scottph added inline comments to D26130: vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE.
Aug 26 2020, 9:01 PM
scottph updated the diff for D26130: vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE.
Aug 26 2020, 8:52 PM
scottph requested review of D26190: bitset: expand bit index type to `long`.
Aug 26 2020, 6:42 AM
scottph added inline comments to D26130: vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE.
Aug 26 2020, 6:40 AM
scottph updated the diff for D26130: vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE.
Aug 26 2020, 6:33 AM
scottph added a comment to D25839: efibootmgr: Add option to request booting to the firmware user interface.

So this is the moral equivalent of ipmitool chassis bootdev bios?

Aug 26 2020, 2:17 AM
scottph committed rS364798: arm64: Increase dmap size to 95 TiB.
arm64: Increase dmap size to 95 TiB
Aug 26 2020, 2:13 AM
scottph closed D26134: arm64: Increase dmap size to 95 TiB.
Aug 26 2020, 2:13 AM
scottph committed rS364797: arm64/acpi: Give the real PA limit to ACPI.
arm64/acpi: Give the real PA limit to ACPI
Aug 26 2020, 2:12 AM
scottph closed D26133: arm64/acpi: Give the real PA limit to ACPI.
Aug 26 2020, 2:12 AM
scottph committed rS364796: bitset: add BIT_FFS_AT() for finding the first bit set greater than a start bit.
bitset: add BIT_FFS_AT() for finding the first bit set greater than a start bit
Aug 26 2020, 2:08 AM
scottph closed D26128: bitset: add BIT_FFS_AT() for finding the first bit set greater than a start bit.
Aug 26 2020, 2:08 AM
scottph closed D25839: efibootmgr: Add option to request booting to the firmware user interface.
Aug 26 2020, 2:06 AM
scottph committed rS364795: efibootmgr: Add option to request booting to the firmware user interface.
efibootmgr: Add option to request booting to the firmware user interface
Aug 26 2020, 2:06 AM
scottph committed rS364794: arm64: Make local stores observable before sending IPIs.
arm64: Make local stores observable before sending IPIs
Aug 26 2020, 2:04 AM
scottph closed D25798: arm64: Make local stores observable before sending IPIs.
Aug 26 2020, 2:04 AM

Aug 25 2020

scottph added a comment to D26130: vm_reserv: Sparsify the vm_reserv_array when VM_PHYSSEG_SPARSE.
In D26130#581703, @alc wrote:

I'm curious to see the output from "sysctl vm.phys_segs" on this machine.

Aug 25 2020, 5:08 PM

Aug 24 2020

scottph added a comment to D26129: Move vm_page_dump bitset array definition to MI code.

Adding bitset.h to vm_page.h breaks the vhci driver. D26177 fixes that.

Aug 24 2020, 11:52 PM
scottph requested review of D26177: vchi: rename bitset macros to avoid collision with bitset(9).
Aug 24 2020, 11:50 PM
scottph added a comment to D26132: arm64/pmap: Sparsify pv_table.

I augmented vm_phys_seg with a void *md_first field that is used for the pointer to the starting entry in pv_table. Is void * alright, or should I be making some new md_something type for the field?

Aug 24 2020, 11:48 PM
scottph updated the diff for D26132: arm64/pmap: Sparsify pv_table.
Aug 24 2020, 11:45 PM