Page MenuHomeFreeBSD

scottph (D Scott Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2018, 5:54 PM (69 w, 3 d)

Recent Activity

Mon, Sep 9

scottph committed rS352109: MFC 351897: nvdimm(4): Add description of NVDIMM Namespace support.
MFC 351897: nvdimm(4): Add description of NVDIMM Namespace support
Mon, Sep 9, 9:03 PM
scottph committed rS352108: MFC 348757,351225: acpi and nvdimm location_str updates.
MFC 348757,351225: acpi and nvdimm location_str updates
Mon, Sep 9, 8:50 PM
scottph closed D20644: MFC 348757,351225: acpi and nvdimm location_str updates.
Mon, Sep 9, 8:50 PM

Thu, Sep 5

scottph committed rS351897: nvdimm(4): Add description of NVDIMM Namespace support.
nvdimm(4): Add description of NVDIMM Namespace support
Thu, Sep 5, 8:52 PM
scottph closed D21536: nvdimm(4): Add description of NVDIMM Namespace support.
Thu, Sep 5, 8:52 PM
scottph updated the diff for D21536: nvdimm(4): Add description of NVDIMM Namespace support.
Thu, Sep 5, 8:01 PM
scottph created D21536: nvdimm(4): Add description of NVDIMM Namespace support.
Thu, Sep 5, 6:37 PM

Fri, Aug 30

scottph retitled D19504: devel/pmdk: update to 1.6.1 from devel/pmdk: update to 1.5.1 to devel/pmdk: update to 1.6.1.

Sorry for the long delay here, I was waiting for the pmdk-1.6 release which incorporates some of our fixes upstream, and then went on vacation for the summer.

Fri, Aug 30, 6:08 PM

Mon, Aug 26

scottph retitled D20644: MFC 348757,351225: acpi and nvdimm location_str updates from MFC 348757: nvdimm: Provide nvdimm location information to MFC 348757,351225: acpi and nvdimm location_str updates.

Index: stable/12

and also:

Mon, Aug 26, 5:10 PM

Aug 19 2019

scottph closed D21326: Don't set the string "unknown" as a device's location_str.
Aug 19 2019, 5:51 PM
scottph committed rS351225: Don't set the string "unknown" as a device's location_str.
Don't set the string "unknown" as a device's location_str
Aug 19 2019, 5:51 PM
scottph created D21326: Don't set the string "unknown" as a device's location_str.
Aug 19 2019, 5:10 PM

Aug 16 2019

scottph added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

The additional note on style(9) on variable order declaration is informative only, you can choose to fix at your option.

Aug 16 2019, 6:52 PM
scottph added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

@rgrimes I believe I've addressed your comments from earlier. Would you mind taking a look at the new patch? Thanks.

Aug 16 2019, 5:09 PM
scottph added a comment to D21281: Work around a bug in the EFI HTTP driver.

Is this error case something that happens only sometimes? Fetching multiple files is something that has definitely worked for me before.

Yes, it only happens if a file can't be found. For example if it's asked to open /boot/foo, then it'll try /boot/foo and /boot/foo/ before failing. And the crash is only seen when booting over a secure connection: HTTP works fine, HTTPS crashes.

Aug 16 2019, 4:45 PM

Aug 15 2019

scottph added a comment to D21281: Work around a bug in the EFI HTTP driver.

Is this error case something that happens only sometimes? Fetching multiple files is something that has definitely worked for me before.

Aug 15 2019, 10:56 PM

Jun 23 2019

scottph added inline comments to D20644: MFC 348757,351225: acpi and nvdimm location_str updates.
Jun 23 2019, 1:22 PM

Jun 14 2019

scottph created D20644: MFC 348757,351225: acpi and nvdimm location_str updates.
Jun 14 2019, 9:36 PM
scottph created D20643: loader: add HTTP support using UEFI.
Jun 14 2019, 8:55 PM
scottph created D20642: efinet: Defer exclusively opening the network handles.
Jun 14 2019, 8:53 PM

Jun 6 2019

scottph committed rS348757: nvdimm: Provide nvdimm location information.
nvdimm: Provide nvdimm location information
Jun 6 2019, 8:12 PM
scottph closed D20528: nvdimm: Provide nvdimm location information.
Jun 6 2019, 8:12 PM

Jun 5 2019

scottph added inline comments to D20528: nvdimm: Provide nvdimm location information.
Jun 5 2019, 7:36 PM
scottph created D20528: nvdimm: Provide nvdimm location information.
Jun 5 2019, 7:19 PM
scottph committed rS348680: Add myself to committers-src.dot and calendar.freebsd.
Add myself to committers-src.dot and calendar.freebsd
Jun 5 2019, 4:01 AM

Jun 3 2019

scottph committed rD53103: Add myself as a new committer.
Add myself as a new committer
Jun 3 2019, 10:49 PM

May 31 2019

pi renamed scottph from scott.d.phillips_intel.com to scottph.
May 31 2019, 6:18 AM

May 23 2019

scottph added a comment to D20309: Support software breakpoints in the debug server..

Still working on fully reviewing this, but I noticed this one thing in testing.

May 23 2019, 4:41 PM

May 21 2019

scottph accepted D20308: Add initial support for qSupported..

Looks good to me

May 21 2019, 9:05 PM
scottph accepted D20307: Add support for writing to guest memory in the debug server..

gdb_read_mem and gdb_write_mem could conceivably be factored together, though I'm not sure the complexity of that would be worth it. With or without that, this patch looks good to me.

May 21 2019, 9:03 PM

May 3 2019

scottph added inline comments to D19975: vmm: Add emulation for the `add` instruction.
May 3 2019, 8:04 PM

Apr 24 2019

scottph added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

@scott.d.phillips_intel.com I'm wondering if sysutils/uefi-edk2-bhyve will work out of the box with these new options, or do we need to update this port as well?

Apr 24 2019, 5:21 PM

Apr 22 2019

scottph added inline comments to D19976: bhyve: Support a _VARS.fd file for bootrom.
Apr 22 2019, 10:43 PM
scottph updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.
Apr 22 2019, 10:32 PM
scottph updated the diff for D19975: vmm: Add emulation for the `add` instruction.

reword comment about GETADDFLAGS macro

Apr 22 2019, 10:31 PM
scottph added a comment to D19975: vmm: Add emulation for the `add` instruction.

A question to @jhb, should the order of the enum and the code updated to be in alphabetic order, in a separate review, it would only obfuscate the change to do it here.

Apr 22 2019, 6:16 PM

Apr 19 2019

scottph updated the diff for D19976: bhyve: Support a _VARS.fd file for bootrom.

bhyve.8, update .Dd, start sentences on a new line.

Apr 19 2019, 9:43 PM
scottph added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

Note that the UEFI firmware used with this needs to have the flash variable driver added in, as in: https://github.com/freebsd/uefi-edk2/pull/8

Apr 19 2019, 9:09 PM
scottph created D19976: bhyve: Support a _VARS.fd file for bootrom.
Apr 19 2019, 9:08 PM
scottph created D19975: vmm: Add emulation for the `add` instruction.
Apr 19 2019, 9:05 PM

Apr 15 2019

scottph added inline comments to D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.
Apr 15 2019, 7:51 PM

Apr 10 2019

scottph added a comment to D19875: Add sysutils/uefi-edk2-bhyve-devel based on branch bhyve/edk2-stable201903.

Aside from Makefile formatting questions, this looks fine to me and makes a working UEFI binary for me.

Apr 10 2019, 8:52 PM

Mar 7 2019

scottph created D19504: devel/pmdk: update to 1.6.1.
Mar 7 2019, 10:48 PM

Jan 29 2019

scottph updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.
  • fix one more style(9) problem
Jan 29 2019, 9:17 PM
scottph added inline comments to D18439: nvdimm: only enumerate present nvdimm devices.
Jan 29 2019, 8:00 PM
scottph updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.
  • rebase patch
  • add commit message tags
  • Don't use i for non-int loop variables
  • Fix some style(9) issues with braces
  • Don't use variable names prefixed with underscore
  • Handle unaligned accesses in find_matches()
  • Fix an off-by-one error in the allocation of ivars
Jan 29 2019, 7:57 PM
scottph updated the diff for D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device.
  • rebase patch
  • add commit message tags
Jan 29 2019, 7:56 PM

Jan 17 2019

scottph updated the diff for D18733: nvdimm: initialize SPA uuids statically.

Add Intel copyright, add commit message tags.

Jan 17 2019, 6:27 PM
scottph updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.

Add copyright for Intel, add commit message tags, allocate flush addrs with mallocarray .

Jan 17 2019, 6:23 PM

Jan 3 2019

scottph updated the diff for D17619: nvdimm: Simple namespace support.
Jan 3 2019, 8:13 PM
scottph created D18736: nvdimm: split spa dev into a separate entity.
Jan 3 2019, 8:12 PM
scottph created D18735: nvdimm: Read NVDIMM namespace labels.
Jan 3 2019, 8:11 PM
scottph updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.
Jan 3 2019, 8:10 PM
scottph created D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device.
Jan 3 2019, 8:09 PM
scottph created D18733: nvdimm: initialize SPA uuids statically.
Jan 3 2019, 8:08 PM
scottph updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.
Jan 3 2019, 8:07 PM

Dec 12 2018

scottph added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#394764, @kib wrote:

Ok. I think we could do some cross of what you want and what I do not want.
Right now how I wrote nvdimm.c, it directly digs into subordinate devices of the root NVDIMM device and instantiate device_t for each found device in the namespace in probe. What if we add a top-level newbus driver (in nvdimm.c) which attaches to the root ACPI device. This driver duties would be:

  • create children for each subordinate device, where the current nvdimm.c driver attaches. Basically, this moves the nvdimm_probe() into the root device driver;
  • iterate over the NFIT and create SPAs, basically identical to what you do in the current patch.

The difference with the patch is that root driver is not a hack but a place where we put all the enumeration logic.

Dec 12 2018, 2:35 AM
scottph added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#394755, @kib wrote:

I do not understand your fixation on the newbus attachment for SPA. Now you are trying to hide it under the root NVDIMM device, but again, I do not see any connection between the root and activation of SPA support. To get SPA used, we only need SPA entries from the NFIT table.

Dec 12 2018, 1:11 AM

Dec 11 2018

scottph added inline comments to D18439: nvdimm: only enumerate present nvdimm devices.
Dec 11 2018, 11:31 PM

Dec 10 2018

scottph updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.

rebase diff so that it is no longer against D18346

Dec 10 2018, 10:11 PM
scottph updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.
Dec 10 2018, 10:08 PM

Dec 6 2018

scottph added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.

ah, the other thing was that having SPAs as devices gave me a convenient fix to the ordering problem where the nvdimm devices are not yet attached at SPA initialization time. perhaps a better fix would be to have a device on the acpi bus for the NVDIMM root device (ACPI0012), which control the SPA initialization, outside of anything related to geom.

Dec 6 2018, 1:11 AM

Dec 5 2018

scottph added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#392753, @kib wrote:

But namespaces have no relevance for newbus at all, e.g. we do not create device_t for partitions for the same reason.

Dec 5 2018, 7:57 PM
scottph added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#392735, @kib wrote:

What do we need ? I see that we need a unique unit number (currently punned by reusing the SPA index) and a way to list all SPAs at the unload time, to destruct them. Would be a global list of all SPAs enough for the later ?

Dec 5 2018, 7:28 PM
scottph added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#392701, @kib wrote:

Why do we need newbus attachment for SPAs ?
For ACPI-enumerated NVDIMMs, creating the devices is more or less natural since they represent physical objects that exist in the chassis. But SPAs are purely software constructs, which newbus devices seems to only tunnel the calls to init_ine()/fini_one().

Dec 5 2018, 7:01 PM
scottph added a comment to D18439: nvdimm: only enumerate present nvdimm devices.

FYI, this diff is on top of D18346

Dec 5 2018, 5:37 PM
scottph created D18439: nvdimm: only enumerate present nvdimm devices.
Dec 5 2018, 5:33 PM
scottph updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.
  • check for the existence of an spa device before adding a new one to the acpi bus.
Dec 5 2018, 5:29 PM

Nov 29 2018

scottph updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.

@kib Here's an approach to splitting the geom and spa device by making nvdimm_spa devices on the acpi bus. Let me know if this looks like the right direction here.

Nov 29 2018, 10:19 PM

Nov 28 2018

scottph added a comment to D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.
In D18009#390469, @0mp wrote:

@mat, I believe that this revision is ready to be committed.
The whole Doxygen and Pandoc thing could be dropped all together. We may add them later if @scott.d.phillips_intel.com decides it is useful.

Nov 28 2018, 4:28 PM

Nov 27 2018

scottph updated the diff for D18345: Fix assert condition in pmap_large_unmap().

Fix assert to use va loop variable.

Nov 27 2018, 8:02 PM
scottph updated the diff for D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.
  • revert to pmdk 1.5
  • address @mat's comments on Diff 50890
Nov 27 2018, 7:30 PM
scottph added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#390124, @kib wrote:

So there are really two changes, and the addition of the spa_g_destroy() is rather small comparing to the other part. You stopped allocating spa_mappings[] array at all. Can you extract it into separate change ?
BTW, I am not sure if it is possible to destroy geom forcibly by a user command. If yes, then the tight bind between spa lifetime and geom lifetime is undesirable, I think, because besides geom spa provides usermode access device.

Nov 27 2018, 7:23 PM

Nov 26 2018

scottph created D18346: nvdimm: add a driver for the NVDIMM root device.
Nov 26 2018, 9:21 PM
scottph created D18345: Fix assert condition in pmap_large_unmap().
Nov 26 2018, 9:18 PM
scottph added inline comments to D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.
Nov 26 2018, 6:00 PM

Nov 16 2018

scottph added a comment to D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.

@0mp: sorry for all the errors still in portlint, I was running it without any options and thinking I would see everything important. I've fixed the man pages path. There were warnings about the other documentation files too in the older patch, but those got moved out of pmdk in the 1.5 version. The 1.5 version also added a strangely packaged python module which I've left out of the port altogether for the time being.

Nov 16 2018, 11:38 PM
scottph updated the diff for D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.

Update DISTVERSION to 1.5, update man path, add USE_LDCONFIG

Nov 16 2018, 11:36 PM

Oct 19 2018

scottph created D17619: nvdimm: Simple namespace support.
Oct 19 2018, 7:59 PM

Jul 11 2018

scottph added a comment to D16211: run(4): Add a new USB device ID..

... the numbers just happened to coincide here.

I'm not sure what you mean by that.
I guess what I'm asking is:

  1. The RT5372 radio is already supported by run(4), modulo having to add the look-up table entries?
Jul 11 2018, 2:19 AM
scottph added a comment to D16211: run(4): Add a new USB device ID..

(I'm assuming its been tested by at least one person)

Jul 11 2018, 1:39 AM

Jul 10 2018

scottph created D16211: run(4): Add a new USB device ID..
Jul 10 2018, 11:06 PM