arm64: pmap: Mask VA operand in TLBI instructions
ClosedPublic
Actions

Authored by scottph on Mar 24 2022, 5:08 PM.

Details

Reviewers

andrew
manu

Commits

rG33a625b1d6cd: arm64: pmap: Mask VA operand in TLBI instructions
rG2c013d142b14: arm64: pmap: Mask VA operand in TLBI instructions
rGa693a3003827: arm64: pmap: Mask VA operand in TLBI instructions

Summary

Bits 43:0 of the TLBI operand are bits 55:12 of the VA. Leaving
bits 63:55 of the VA in bits 51:44 of the operand might wind up
setting the TTL field (47:44) and accidentally restricting which
translation levels are flushed in the TLB.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

scottph created this revision.Mar 24 2022, 5:08 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 24 2022, 5:08 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

scottph requested review of this revision.Mar 24 2022, 5:08 PM

andrew accepted this revision.Mar 24 2022, 5:39 PM

This revision is now accepted and ready to land.Mar 24 2022, 5:39 PM

Closed by commit rGa693a3003827: arm64: pmap: Mask VA operand in TLBI instructions (authored by scottph). · Explain WhyMar 25 2022, 4:50 PM

This revision was automatically updated to reflect the committed changes.

scottph added a commit: rGa693a3003827: arm64: pmap: Mask VA operand in TLBI instructions.

scottph added a commit: rG2c013d142b14: arm64: pmap: Mask VA operand in TLBI instructions.Mar 29 2022, 3:55 PM

scottph added a commit: rG33a625b1d6cd: arm64: pmap: Mask VA operand in TLBI instructions.Mar 30 2022, 9:04 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

3 lines

Diff 104198

View Options

arm64: pmap: Mask VA operand in TLBI instructionsClosedPublicActions