Page MenuHomeFreeBSD

ipmi_ssif: Fix inverted for the end of multi-part reads
ClosedPublic

Authored by allanjude on Feb 17 2021, 9:35 PM.
Tags
None
Referenced Files
F80107869: D28749.diff
Thu, Mar 28, 1:00 AM
Unknown Object (File)
Fri, Mar 22, 11:54 PM
Unknown Object (File)
Feb 17 2024, 7:27 PM
Unknown Object (File)
Feb 10 2024, 5:48 AM
Unknown Object (File)
Jan 9 2024, 5:36 PM
Unknown Object (File)
Dec 28 2023, 6:44 AM
Unknown Object (File)
Dec 23 2023, 3:48 AM
Unknown Object (File)
Dec 19 2023, 8:15 PM
Subscribers

Details

Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Any docs on what this should contain ?

In D28749#643720, @manu wrote:

Any docs on what this should contain ?

I think specifically this one 0xff indicates 'last block, no more entries', and the logic was accidently inverted before.

You can check the IPMI Specification, sec 12.5 for info on SSIF Multi-part Read Transactions

You can check the IPMI Specification, sec 12.5 for info on SSIF Multi-part Read Transactions

Thanks, that was exactly what I was looking for.

This revision is now accepted and ready to land.Feb 17 2021, 11:24 PM

Do we want to put this link and section reference in the commit message?

Do we want to put this link and section reference in the commit message?

I'm not a fan of putting links as they tend to disappear over time but citing the name of the doc and chapter would be nice to do.