Page MenuHomeFreeBSD

ipmi_ssif: Fix inverted for the end of multi-part reads
ClosedPublic

Authored by allanjude on Feb 17 2021, 9:35 PM.

Details

Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Any docs on what this should contain ?

In D28749#643720, @manu wrote:

Any docs on what this should contain ?

I think specifically this one 0xff indicates 'last block, no more entries', and the logic was accidently inverted before.

You can check the IPMI Specification, sec 12.5 for info on SSIF Multi-part Read Transactions

You can check the IPMI Specification, sec 12.5 for info on SSIF Multi-part Read Transactions

Thanks, that was exactly what I was looking for.

This revision is now accepted and ready to land.Feb 17 2021, 11:24 PM

Do we want to put this link and section reference in the commit message?

Do we want to put this link and section reference in the commit message?

I'm not a fan of putting links as they tend to disappear over time but citing the name of the doc and chapter would be nice to do.