Page MenuHomeFreeBSD

smbios: Move smbios driver out from x86 machdep code
ClosedPublic

Authored by allanjude on Feb 17 2021, 9:34 PM.

Details

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

IMO it's reasonable to do the moving/refactoring first to facilitate additional testing/experimentation, and add it to GENERIC kern confs later (when we're quite confident it is going to be completed, as here).

manu added inline comments.
sys/conf/files.x86
296

So, it seems that smbios wasn't part of GENERIC as it was optional smbios here but now it is. That should be reflected in the commit.

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

That is done here: https://reviews.freebsd.org/D28744

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

That is done here: https://reviews.freebsd.org/D28744

Thanks!

This revision is now accepted and ready to land.Feb 18 2021, 6:54 PM