Paths

Table of Contentst

ig4(4): Use calculated value when sda_hold is zero in ACPI
Needs ReviewPublic
Actions

Authored by allanjude on Feb 17 2021, 9:35 PM.

Tags

None

Referenced Files

	F174469937: D28748.id84143.diff
	Sat, Oct 3, 12:22 PM

	Unknown Object (File)
	Fri, Oct 2, 8:05 PM

	Unknown Object (File)
	Thu, Oct 1, 10:25 AM

	Unknown Object (File)
	Thu, Sep 24, 4:42 AM

	Unknown Object (File)
	Thu, Sep 10, 3:22 PM

	Unknown Object (File)
	Mon, Sep 7, 7:02 AM

	Unknown Object (File)
	Sat, Sep 5, 7:11 PM

	Unknown Object (File)
	Sat, Sep 5, 12:55 AM

Subscribers

Details

Reviewers

scottph

Summary

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37123
Build 34012: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 17 2021, 9:35 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 9:35 PM

allanjude requested review of this revision.Feb 17 2021, 9:35 PM

Harbormaster completed remote builds in B37123: Diff 84143.Feb 17 2021, 9:35 PM

allanjude added a parent revision: D28747: ig4(4): Increase timeout to about 1 second.Feb 17 2021, 9:35 PM

allanjude added a child revision: D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.

allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM

Is there any docs on what the acpi objects should contain ?

allanjude added a reviewer: scottph.Feb 18 2021, 3:53 PM

So this isn't needed for what I'm doing... it looks interesting. What's the status?

Is this a workaround for a broken ACPI implementation, possibly in early firmware? I notice Linux's equivalent i2c_dw_acpi_params does not do this. I do see Linux explicitly skips ACPI here for Dell Inspiron 7348.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ichiic/

ig4_iic.c

8 lines

Diff 84143

View Options

ig4(4): Use calculated value when sda_hold is zero in ACPINeeds ReviewPublicActions