Page MenuHomeFreeBSD
Differential D28750

ipmi: on aarch64, load dependancies to increase chance of finding ipmi device
AcceptedPublic
Actions

Authored by allanjude on Feb 17 2021, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 25, 1:15 PM
Unknown Object (File)
Fri, Dec 12, 10:39 AM
Unknown Object (File)
Wed, Dec 10, 1:45 PM
Unknown Object (File)
Fri, Dec 5, 12:42 PM
Unknown Object (File)
Fri, Dec 5, 8:31 AM
Unknown Object (File)
Nov 22 2025, 7:25 AM
Unknown Object (File)
Oct 25 2025, 12:33 AM
Unknown Object (File)
Oct 24 2025, 6:21 AM
View All 87 Files
Subscribers
emaste
imp

Details

Reviewers
imp
Summary

Sponsored By: Ampere Computing LLC
Submitted By: Klara Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37125
Build 34014: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 17 2021, 9:35 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 9:35 PM
allanjude requested review of this revision.Feb 17 2021, 9:35 PM
Harbormaster completed remote builds in B37125: Diff 84145.Feb 17 2021, 9:35 PM
allanjude added a parent revision: D28749: ipmi_ssif: Fix inverted for the end of multi-part reads.Feb 17 2021, 9:36 PM
allanjude added a child revision: D28751: ipmi_smbios: remove unused smbios_cksum function.
allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM
imp accepted this revision.Feb 17 2021, 11:21 PM
This revision is now accepted and ready to land.Feb 17 2021, 11:21 PM
imp added a comment.EditedJun 27 2024, 10:31 PM

I don't understand this.
I wonder why both of these aren't always depends...
Also, I can't find the places where those two modules are built in this review chain...
So @allanjude what's the story.
I know that I approved this before, but maybe that was premature.

emaste added a subscriber: emaste.Wed, Dec 24, 5:02 PM

Is there any reason this isn't committed?

imp added a comment.Wed, Dec 24, 7:25 PM
In D28750#1242275, @emaste wrote:

Is there any reason this isn't committed?

Why do. we need the ig4iic module? It iicsmb makes sense, but the ig4 one isn't actually used here.
Also, why not have iicsmb always be a dependency? Why is it aarch64 dependent?

I think that's why it hasn't been committed: they aren't really needed.

Revision Contents
Changeset List

PathSize
sys/
dev/
ipmi/
4 lines

Diff 84145

View Options

sys/dev/ipmi/ipmi_smbus.c

Loading...