Differential D28745

ipmi: Add smbus and pci ipmi types to aarch64 builds
ClosedPublic
Actions

Authored by imp on Feb 17 2021, 9:35 PM.

Tags

None

Referenced Files

	F176603591: D28745.id84140.diff
	Tue, Oct 20, 4:07 AM

	F176601422: D28745.id84591.diff
	Tue, Oct 20, 3:40 AM

	Unknown Object (File)
	Sun, Oct 4, 7:00 PM

	Unknown Object (File)
	Sat, Oct 3, 12:03 PM

	Unknown Object (File)
	Fri, Oct 2, 3:36 PM

	Unknown Object (File)
	Thu, Sep 24, 6:08 AM

	Unknown Object (File)
	Sep 10 2026, 11:20 AM

	Unknown Object (File)
	Sep 9 2026, 3:37 AM

Subscribers

Details

Reviewers

rpokala
manu
andrew
allanjude
imp

Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37333
Build 34222: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 17 2021, 9:35 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2021, 9:35 PM

allanjude requested review of this revision.Feb 17 2021, 9:35 PM

Harbormaster completed remote builds in B37120: Diff 84140.Feb 17 2021, 9:35 PM

allanjude added a parent revision: D28744: Enable smbios in ARM64 GENERIC.Feb 17 2021, 9:35 PM

allanjude added a child revision: D28746: ig4(4): Add an EMAG device type.

allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM

It likely makes sense to squash this with https://reviews.freebsd.org/D28738

allanjude mentioned this in D28738: smbios: Move smbios driver out from x86 machdep code.Feb 17 2021, 9:47 PM

rpokala accepted this revision.Feb 17 2021, 9:55 PM

This revision is now accepted and ready to land.Feb 17 2021, 9:55 PM

manu accepted this revision.Feb 17 2021, 10:16 PM

imp accepted this revision.Feb 17 2021, 11:30 PM

allanjude retitled this revision from ipmi: Add smbus and pci ipmi types to aarch64 build to ipmi: Add smbus and pci ipmi types to aarch64 builds.Feb 23 2021, 9:38 PM

Add the new code to sys/conf/files.arm64 as well, so IPMI works when built into the kernel

This revision now requires review to proceed.Feb 23 2021, 9:38 PM

Herald added subscribers: emaste, andrew. · View Herald TranscriptFeb 23 2021, 9:38 PM

Harbormaster completed remote builds in B37333: Diff 84591.Feb 23 2021, 9:38 PM

https://reviews.freebsd.org/D45765 replaces this.
I think this should be Author: allanjude, and that will be what I push (even though I tweaked it in a tiny way, it's not enough to get to co-author)

Herald added a reviewer: andrew. · View Herald TranscriptJun 27 2024, 10:25 PM

Herald added a reviewer: andrew. · View Herald Transcript

imp commandeered this revision.Jun 27 2024, 10:27 PM

imp accepted this revision.

imp edited reviewers, added: allanjude; removed: imp.

This revision is now accepted and ready to land.Jun 27 2024, 10:27 PM

imp closed this revision.Jun 27 2024, 10:27 PM

Revision Contents
Changeset List

Path

Size

sys/

conf/

4 lines

modules/

ipmi/

11 lines

Diff 84591

sys/conf/files.arm64

Loading...

sys/modules/ipmi/Makefile

Loading...