Page MenuHomeFreeBSD

ig4(4): Add an EMAG device type
Needs RevisionPublic

Authored by allanjude on Feb 17 2021, 9:35 PM.

Details

Reviewers
scottph
imp
manu
Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 37121
Build 34010: arc lint + arc unit

Event Timeline

sys/dev/ichiic/ig4_acpi.c
92

In the original review, Warner asks: https://reviews.freebsd.org/D28707#inline-178924

Is there some way this can be part of a table of hids to matchs? that makes the device play nicer with devmatch.

manu requested changes to this revision.Feb 17 2021, 10:18 PM
manu added a subscriber: manu.

I agree with Warner here, having a table would be nicer.

This revision now requires changes to proceed.Feb 17 2021, 10:18 PM
In D28746#643683, @manu wrote:

I agree with Warner here, having a table would be nicer.

There is no devmatch info in ig4_acpi.c at all for now. It can be added with placing of following line at the bottom of ig4_acpi.c

ACPI_PNP_INFO(ig4iic_ids);

Along with checking of ACPI_ID_PROBE output instead of extra acpi_MatchHid() call, it will make devmatch happier.

sys/dev/ichiic/ig4_acpi.c
92

ACPI_ID_PROBE returns a pointer to matched HID/CID in ig4iic_ids array in fouth parameter. It should be used instead of acpi_MatchHid() to detect "APMC0D0F" device.