ipmi_smbios: Deduplicate smbios entry point discovery logic
ClosedPublic
Actions

/usr/src/sys/dev/smbios/smbios.c:212:14: error: no member named 'eps_64bit' in 'struct smbios_softc'
        if (smbios->eps_64bit) {
            ~~~~~~  ^
/usr/src/sys/dev/smbios/smbios.c:213:20: error: no member named 'eps3' in 'struct smbios_softc'; did you mean 'eps'?
                *table = smbios->eps3->structure_table_address;
                                 ^~~~
                                 eps
/usr/src/sys/dev/smbios/smbios.c:66:22: note: 'eps' declared here
        struct smbios_eps *     eps;
                                ^
/usr/src/sys/dev/smbios/smbios.c:214:19: error: no member named 'eps3' in 'struct smbios_softc'; did you mean 'eps'?
                *size = smbios->eps3->structure_table_max_size;
                                ^~~~
                                eps
/usr/src/sys/dev/smbios/smbios.c:66:22: note: 'eps' declared here
        struct smbios_eps *     eps;
                                ^
/usr/src/sys/dev/smbios/smbios.c:214:25: error: no member named 'structure_table_max_size' in 'struct smbios_eps'; did you mean 'structure_table_address'?
                *size = smbios->eps3->structure_table_max_size;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~
                                      structure_table_address
/usr/src/sys/dev/smbios/smbios.h:58:11: note: 'structure_table_address' declared here
        uint32_t        structure_table_address;
                        ^
4 errors generated.

It looks like the patch depends on D28707.

I had to revert this, as it depends on https://reviews.freebsd.org/D28739 which isn't ready to land yet

allanjude added a reverting change: rG6d67af5f8e66: Revert "ipmi_smbios: Deduplicate smbios entry point discovery logic".Feb 23 2021, 10:51 PM

After rebase

Harbormaster completed remote builds in B37343: Diff 84607.Feb 24 2021, 2:51 PM

imp mentioned this in D45763: smbios: Add length sanity checking.Jun 27 2024, 9:58 PM

Most of this change has been re-committed / re-implemented.
The only thing this adds that isn't in the tree is length checks, which I've added.

commit f689cb23b2782d0d0f586bcfabbad68f728ed1df
Author: Val Packett <val@packett.cool>
Date:   Wed Apr 7 15:05:49 2021 -0500

    ipmi,smbios: move smbios_walk_table to smbios.h

    This function will be used for exposing DMI info as sysctls in the
    smbios module (in an upcoming review).

    While here, add __packed to the structs.

    Reviewed by:    dab
    MFC after:      1 week
    Sponsored by:   Dell EMC Isilon
    Differential Revision:  https://reviews.freebsd.org/D29270

So I'm snagging this revision.
https://reviews.freebsd.org/D45763

imp accepted this revision.Jun 27 2024, 9:59 PM

This revision is now accepted and ready to land.Jun 27 2024, 9:59 PM

See https://reviews.freebsd.org/D45763 for what little missing functionality was missing.
As always, flag anything I missed, etc

imp mentioned this in rG06326613afeb: smbios: Add length sanity checking.Jul 25 2024, 5:13 AM