Page MenuHomeFreeBSD

ipmi_smbios: Deduplicate smbios entry point discovery logic
Needs ReviewPublic

Authored by allanjude on Feb 17 2021, 9:35 PM.

Details

Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 37343
Build 34232: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 17 2021, 11:21 PM

This broke build on amd64:

/usr/src/sys/dev/smbios/smbios.c:212:14: error: no member named 'eps_64bit' in 'struct smbios_softc'
        if (smbios->eps_64bit) {
            ~~~~~~  ^
/usr/src/sys/dev/smbios/smbios.c:213:20: error: no member named 'eps3' in 'struct smbios_softc'; did you mean 'eps'?
                *table = smbios->eps3->structure_table_address;
                                 ^~~~
                                 eps
/usr/src/sys/dev/smbios/smbios.c:66:22: note: 'eps' declared here
        struct smbios_eps *     eps;
                                ^
/usr/src/sys/dev/smbios/smbios.c:214:19: error: no member named 'eps3' in 'struct smbios_softc'; did you mean 'eps'?
                *size = smbios->eps3->structure_table_max_size;
                                ^~~~
                                eps
/usr/src/sys/dev/smbios/smbios.c:66:22: note: 'eps' declared here
        struct smbios_eps *     eps;
                                ^
/usr/src/sys/dev/smbios/smbios.c:214:25: error: no member named 'structure_table_max_size' in 'struct smbios_eps'; did you mean 'structure_table_address'?
                *size = smbios->eps3->structure_table_max_size;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~
                                      structure_table_address
/usr/src/sys/dev/smbios/smbios.h:58:11: note: 'structure_table_address' declared here
        uint32_t        structure_table_address;
                        ^
4 errors generated.

It looks like the patch depends on D28707.

I had to revert this, as it depends on https://reviews.freebsd.org/D28739 which isn't ready to land yet