Page MenuHomeFreeBSD
Differential D28744

Enable smbios in ARM64 GENERIC
ClosedPublic
Actions

Authored by imp on Feb 17 2021, 9:35 PM.
Tags
None
Referenced Files
F163239377: D28744.id84139.diff
Tue, Jul 21, 8:16 AM
Unknown Object (File)
Sun, Jul 19, 2:34 AM
Unknown Object (File)
Sat, Jul 18, 11:22 AM
Unknown Object (File)
Sun, Jul 5, 9:24 PM
Unknown Object (File)
Jun 18 2026, 3:15 AM
Unknown Object (File)
Jun 16 2026, 2:47 AM
Unknown Object (File)
Jun 8 2026, 8:15 PM
Unknown Object (File)
Jun 4 2026, 8:53 AM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
allanjude
andrew
Summary

Sponsored by: Ampere Computing LLC

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37119
Build 34008: arc lint + arc unit

Event Timeline

allanjude created this revision.Feb 17 2021, 9:35 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 17 2021, 9:35 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B37119: Diff 84139.Feb 17 2021, 9:35 PM
allanjude requested review of this revision.Feb 17 2021, 9:35 PM
allanjude added a parent revision: D28743: ipmi_smbios: Deduplicate smbios entry point discovery logic.
allanjude added a child revision: D28745: ipmi: Add smbus and pci ipmi types to aarch64 builds.
allanjude mentioned this in D28707: Fix attachment of IPMI driver on ARM64.Feb 17 2021, 9:38 PM
manu accepted this revision.Feb 17 2021, 10:15 PM

For when the others depending review are accepted : Reviewed-by: manu

This revision is now accepted and ready to land.Feb 17 2021, 10:15 PM
imp accepted this revision.Feb 17 2021, 11:31 PM

Also conditional on the other reviews landing first.... But once those are in, I can't see any reason not to enable this... we can always disable it if this causes a problem.

allanjude mentioned this in D28738: smbios: Move smbios driver out from x86 machdep code.Feb 18 2021, 3:41 PM
emaste added a comment.Feb 19 2021, 2:27 AM

LGTM once the other reviews are in

imp commandeered this revision.Jun 27 2024, 10:14 PM
imp edited reviewers, added: allanjude; removed: imp.

This no longer applies.
I've create a new review
https://reviews.freebsd.org/D45764
and closing this one.

Herald added a reviewer: andrew. · View Herald TranscriptJun 27 2024, 10:14 PM
Herald added a reviewer: andrew. · View Herald Transcript
imp closed this revision.Jun 27 2024, 10:15 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
conf/
1 line

Diff 84139

View Options

sys/arm64/conf/GENERIC

Loading...