Page MenuHomeFreeBSD

WIP bootnext: Next Generation
Needs ReviewPublic

Authored by tsoome on Mon, Jun 29, 10:23 PM.

Details

Reviewers
imp
allanjude
Group Reviewers
bhyve
Summary

First take on bootnext update.

This work is based on https://github.com/openzfs/zfs/commit/108a454a4604df6ea3be817f3cf076726df2c67a

Test Plan

incidentally it seems to work already:)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 32147
Build 29658: arc lint + arc unit

Event Timeline

tsoome created this revision.Mon, Jun 29, 10:23 PM
tsoome requested review of this revision.Mon, Jun 29, 10:23 PM
imp added a comment.Mon, Jun 29, 10:50 PM

I can't easily review the ZFS parts of this, so just a couple of questions...

stand/efi/boot1/boot1.c
56 ↗(On Diff #73889)

why is this deleted? It should, imho, be separate from all this...

tsoome added inline comments.Tue, Jun 30, 10:10 AM
stand/efi/boot1/boot1.c
56 ↗(On Diff #73889)

at some point the linker did start to complain about duplicate symbols Malloc, Free, Calloc (defined in boot1.c and libsa). But yes, I will do separate commit for it. I was just pushing whole set to phab for completeness.

@tsoome Is this purely refactoring or some additional features/improvements as the goal.

@tsoome Is this purely refactoring or some additional features/improvements as the goal.

What we want to get is nvlist based data store on pad2. That will allow us to do interesting things:)

kevans added a subscriber: kevans.Tue, Jun 30, 7:16 PM

I'd still like it if we could already be plotting our direction to making bectl activate -t DTRT with a libzfsbootcfg to encapsulate the bits that are needed to do this. Even if you just give me a single function that takes a dataset name, we can work with that easily enough.

tsoome updated this revision to Diff 73928.Tue, Jun 30, 9:52 PM

boot1 change was committed.

tsoome edited the summary of this revision. (Show Details)Tue, Jun 30, 10:11 PM
tsoome updated this revision to Diff 73950.Wed, Jul 1, 7:30 AM

Mistake on dates

tsoome updated this revision to Diff 73952.Wed, Jul 1, 8:32 AM

Read and write all 4 label instances.

tsoome updated this revision to Diff 74070.Sat, Jul 4, 12:09 PM

clean signed vs unsigned

tsoome updated this revision to Diff 74098.Sun, Jul 5, 5:41 PM

replace sprintf by snprintf