Page MenuHomeFreeBSD

andy_omniosce.org (Andy Fiddaman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2019, 11:25 AM (153 w, 6 d)

Recent Activity

Mar 30 2022

andy_omniosce.org added inline comments to D34587: bhyve - snapshot capsicum integration[Part 3].
Mar 30 2022, 9:08 AM

Mar 23 2022

andy_omniosce.org added a comment to D34465: bhyve: use bhyve_config for SMBIOS strings.

Thanks for doing this, we have something similar in the illumos port, although only for the type1 strings (https://man.omnios.org/bhyve.8#B), and the config keys are different (but I can add translators for backwards compatibility when I port this over).

Mar 23 2022, 10:29 AM · bhyve

Mar 14 2022

andy_omniosce.org added a comment to D34372: bhyve: missing mutex initialisations.

Great, thanks all. Is there anything else I need to do to get this merged?

Mar 14 2022, 11:53 AM

Mar 11 2022

andy_omniosce.org added inline comments to D33129: bhyve: add ROM emulation.
Mar 11 2022, 11:30 AM · bhyve
andy_omniosce.org added inline comments to D33129: bhyve: add ROM emulation.
Mar 11 2022, 11:14 AM · bhyve

Feb 28 2022

andy_omniosce.org added a comment to D34372: bhyve: missing mutex initialisations.
In D34372#778858, @rew wrote:

I didn't realize that these mutex's get initialized on FreeBSD, even without your patch.

Feb 28 2022, 9:33 AM

Feb 27 2022

andy_omniosce.org added a comment to D34372: bhyve: missing mutex initialisations.
In D34372#778732, @rew wrote:
Feb 27 2022, 12:07 AM

Feb 26 2022

andy_omniosce.org updated the diff for D34372: bhyve: missing mutex initialisations.

Two more missing mutex initialisations.

Feb 26 2022, 11:52 PM

Feb 25 2022

andy_omniosce.org requested review of D34372: bhyve: missing mutex initialisations.
Feb 25 2022, 10:45 AM

Feb 24 2022

andy_omniosce.org added a comment to D34301: bhyve: memory leak in topology_parse().
In D34301#778155, @jhb wrote:

In some other places that use strsep the pattern is to name this variable tofree which might be a more obvious name than o[riginal]str.

Feb 24 2022, 1:26 PM
andy_omniosce.org updated the diff for D34301: bhyve: memory leak in topology_parse().

Renamed 'ostr' to 'tofree'

Feb 24 2022, 1:26 PM

Feb 21 2022

andy_omniosce.org added a comment to D34331: bhyve nvme: Advertise Namespace changed AEN.

Thanks for picking this up, looks good to me.

Feb 21 2022, 7:20 PM
andy_omniosce.org added a comment to D34301: bhyve: memory leak in topology_parse().
In D34301#777509, @rew wrote:

what purpose is ostr serving here?

Feb 21 2022, 7:16 PM
andy_omniosce.org retitled D34301: bhyve: memory leak in topology_parse() from bhyve: fix two small memory leaks to bhyve: memory leak in topology_parse().
Feb 21 2022, 11:41 AM
andy_omniosce.org updated the diff for D34301: bhyve: memory leak in topology_parse().

Dropping the fix for bootrom.c

Feb 21 2022, 11:40 AM

Feb 16 2022

andy_omniosce.org requested review of D34301: bhyve: memory leak in topology_parse().
Feb 16 2022, 3:20 PM

Feb 5 2022

andy_omniosce.org added a comment to D32953: bhyve nvme: Inform guests of namespace resize.

Thanks for catching this. Your change will work just fine, but I'm tempted to add a helper wrapper like the below. Thoughts?

Feb 5 2022, 11:29 AM

Feb 1 2022

andy_omniosce.org added a comment to D32953: bhyve nvme: Inform guests of namespace resize.

I'm in the process of porting this change over to illumos, and it looks like we should also be setting the appropriate bit in the oaes field in nvme_controller_data.

Feb 1 2022, 11:43 AM

Jan 12 2022

andy_omniosce.org added inline comments to D33433: bhyve: add varfile option to nvlist of lpc device.
Jan 12 2022, 10:04 AM · bhyve

Jan 4 2022

andy_omniosce.org added inline comments to D32359: bhyve: Map the MSI-X table unconditionally when passthrough is enabled.
Jan 4 2022, 6:15 PM

Sep 17 2021

andy_omniosce.org added a comment to D31983: bhyve: Support setting the disk serial number for VirtIO block devices..
In D31983#721639, @jhb wrote:

I think the goal was to also be similar to the name used for the AHCI and NVMe device models which both use "ser" for this.

Sep 17 2021, 12:42 PM

Jun 15 2021

andy_omniosce.org added a comment to D30717: bhyve nvme ramdisk backend cli option is broken after configuration management refactor..

I am used to contributing to illumos so please feel free to ignore these comments.

Jun 15 2021, 2:14 PM · bhyve
andy_omniosce.org added a comment to D30717: bhyve nvme ramdisk backend cli option is broken after configuration management refactor..

Fine with me, thanks for doing this.

Jun 15 2021, 8:17 AM · bhyve

Jun 14 2021

andy_omniosce.org added a comment to D30717: bhyve nvme ramdisk backend cli option is broken after configuration management refactor..
In D30717#690975, @jhb wrote:

I think I like Chuck's shorter version a bit better

Jun 14 2021, 9:51 AM · bhyve

Jun 10 2021

andy_omniosce.org updated the test plan for D30717: bhyve nvme ramdisk backend cli option is broken after configuration management refactor..
Jun 10 2021, 1:39 PM · bhyve
andy_omniosce.org updated the test plan for D30717: bhyve nvme ramdisk backend cli option is broken after configuration management refactor..
Jun 10 2021, 1:25 PM · bhyve
andy_omniosce.org requested review of D30717: bhyve nvme ramdisk backend cli option is broken after configuration management refactor..
Jun 10 2021, 1:23 PM · bhyve

Apr 4 2021

andy_omniosce.org added inline comments to D29571: bhyve: abstract the configuration managment internal implementation.
Apr 4 2021, 6:56 PM
andy_omniosce.org updated the diff for D29571: bhyve: abstract the configuration managment internal implementation.

Addressed feedback.

Apr 4 2021, 6:56 PM
andy_omniosce.org requested review of D29571: bhyve: abstract the configuration managment internal implementation.
Apr 4 2021, 11:53 AM

Dec 13 2019

andy_omniosce.org added a watcher for bhyve: andy_omniosce.org.
Dec 13 2019, 8:09 PM