wjw_digiware.nl (Willem Jan Withagen)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 13 2017, 8:23 PM (48 w, 3 d)

Recent Activity

Sun, Dec 31

wjw_digiware.nl added a comment to D13699: Upgrade net/ceph to version 12.2.2.
  1. I need LLD because otherwise one off the executables does not link. Seems to be a size limitation in the regular ld And after discussion with Ed Maste this was the solution that worked. Not sure how that impacts on 11.x. But my Ceph testruns do seem to work.

I can't reproduce. Even without -fuse-ld= and -B${LOCALBASE}/bin ceph-12.2.2 builds fine: boost-libs-1.65.1_1 (11.1 amd64, 12.0 amd64), boost-libs-1.66.0 (11.1 amd64, 12.0 amd64). Can you provide more details e.g., poudriere log?

Sun, Dec 31, 11:32 AM
wjw_digiware.nl added a comment to D13699: Upgrade net/ceph to version 12.2.2.

@jbeich
Could you approve once again, fixed the way the versioning was done.
This makes more sense IMHO

Sun, Dec 31, 2:09 AM
wjw_digiware.nl updated the diff for D13699: Upgrade net/ceph to version 12.2.2.

Reorder to make portlint happy

Sun, Dec 31, 2:06 AM
wjw_digiware.nl updated the diff for D13699: Upgrade net/ceph to version 12.2.2.

Cleanup of versionstring in package.
And remove the v from v12.2.2

Sun, Dec 31, 2:03 AM
wjw_digiware.nl added inline comments to D13699: Upgrade net/ceph to version 12.2.2.
Sun, Dec 31, 1:23 AM
wjw_digiware.nl added a comment to D13699: Upgrade net/ceph to version 12.2.2.

Is it OK to land before Boost 1.66.0 for 2018Q1 users given Ceph 12.2.2 builds fine against Boost 1.65.1? Or did you disable some features (e.g., WITH_RADOSGW_BEAST_FRONTEND) for the sake of Boost 1.66?

Sun, Dec 31, 12:48 AM
wjw_digiware.nl added inline comments to D13699: Upgrade net/ceph to version 12.2.2.
Sun, Dec 31, 12:18 AM
wjw_digiware.nl updated the diff for D13699: Upgrade net/ceph to version 12.2.2.

Remove verbose output during linking
leftover from getting lld to work

Sun, Dec 31, 12:01 AM

Sat, Dec 30

wjw_digiware.nl updated the diff for D13699: Upgrade net/ceph to version 12.2.2.

Move cython usage to USE_PYTHON

Sat, Dec 30, 11:54 PM
wjw_digiware.nl added inline comments to D13699: Upgrade net/ceph to version 12.2.2.
Sat, Dec 30, 11:51 PM
wjw_digiware.nl added a comment to D13699: Upgrade net/ceph to version 12.2.2.
  1. I need LLD because otherwise one off the executables does not link. Seems to be a size limitation in the regular ld And after discussion with Ed Maste this was the solution that worked. Not sure how that impacts on 11.x. But my Ceph testruns do seem to work.
  2. I tried all kinds of incantations to get LLD to work, and this was the one that actually worked. It was painfull since it needs a poudriere rerun for every attempt. And even with ccache Ceph is big to build.
  3. Not really sure on how to verify that. But I would expect LDFLAGS to end up in LINK_FLAGS
Sat, Dec 30, 11:48 PM
wjw_digiware.nl updated the diff for D13699: Upgrade net/ceph to version 12.2.2.

Reduce diffs on white spaces and trivia

Sat, Dec 30, 11:21 PM
wjw_digiware.nl updated the diff for D13699: Upgrade net/ceph to version 12.2.2.

Accidently include the Boost 1.66 updates.
Try to remove them from this PR

Sat, Dec 30, 11:18 PM
wjw_digiware.nl updated the diff for D13699: Upgrade net/ceph to version 12.2.2.

Since my port was change in between by ports-managers
there were some unneeded changes.
So reduce the difference between version.

Sat, Dec 30, 11:16 PM
wjw_digiware.nl updated the summary of D13699: Upgrade net/ceph to version 12.2.2.
Sat, Dec 30, 11:09 PM
wjw_digiware.nl created D13699: Upgrade net/ceph to version 12.2.2.
Sat, Dec 30, 11:02 PM

Aug 11 2017

wjw_digiware.nl added a comment to D11770: inet/ceph-devel: bimonthly ports update v2017-07-27.

@mat
I understand, and will ask on the ports-list if somebody wants to do the honnurs.

Aug 11 2017, 12:34 PM
wjw_digiware.nl added a comment to D11770: inet/ceph-devel: bimonthly ports update v2017-07-27.

@mat @mmokhi
Any particular reason why this cannot move forward.
I'm having the first official release of net/ceph in the pipe.
Just waiting for it to be release by the Ceph-developers.
Would be nice if that one have not the same discussion we have here.

Aug 11 2017, 10:15 AM

Jul 28 2017

wjw_digiware.nl added inline comments to D11770: inet/ceph-devel: bimonthly ports update v2017-07-27.
Jul 28 2017, 2:07 PM
wjw_digiware.nl added inline comments to D11770: inet/ceph-devel: bimonthly ports update v2017-07-27.
Jul 28 2017, 1:38 PM
wjw_digiware.nl added inline comments to D11770: inet/ceph-devel: bimonthly ports update v2017-07-27.
Jul 28 2017, 11:55 AM
wjw_digiware.nl added inline comments to D11770: inet/ceph-devel: bimonthly ports update v2017-07-27.
Jul 28 2017, 11:47 AM
wjw_digiware.nl added reviewers for D11770: inet/ceph-devel: bimonthly ports update v2017-07-27: mmokhi, asomers.
Jul 28 2017, 8:05 AM
wjw_digiware.nl created D11770: inet/ceph-devel: bimonthly ports update v2017-07-27.
Jul 28 2017, 8:00 AM

Mar 28 2017

wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.
In D9584#210073, @feld wrote:

Looks good now, builds cleanly.

Macro goforit:

Mar 28 2017, 1:56 PM

Mar 25 2017

wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: Update the submission

Mar 25 2017, 12:11 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

Going to fix that

Mar 25 2017, 12:06 PM

Mar 23 2017

wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

@feld
Hi Mark,

Mar 23 2017, 11:02 AM

Mar 20 2017

wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: integrating mmokhi patches.

Mar 20 2017, 4:48 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: integrating mmokhi patches.

Mar 20 2017, 4:39 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

Hmm, yeah.
@feld I'd suggest to test the patch that I attached on the PR (or @wjw_digiware.nl can update diffs here :D)
I forgot to state this problem on PR (but it's fixed on attached patch) that recently things are added to GID/UID files right before our entry, which makes this patch fail.

Mar 20 2017, 4:17 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

@feld
Not sure why it would fail.
Other than that @mmokhi 's changes are perhaps not in this review.
But that should not prevent you from importing the basic files.
But it seems to confilect on the ceph entries in GUIDs and UIDs.

Mar 20 2017, 3:43 PM

Mar 13 2017

wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.
In D9584#206275, @mat wrote:

@mat
Sorry to nag, but is there a reason this does not move forward?

Well, this, here, is a code review tool, we review code, and make it better, and then commit it. For non committers, I still think that once everything is ok, a PR should be openned with the final patch so that it is added to the tree. I don't have the spare time to test-build it and commit it.

Mar 13 2017, 3:55 PM

Mar 9 2017

wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

@mat
Sorry to nag, but is there a reason this does not move forward?

Mar 9 2017, 2:27 PM

Feb 28 2017

wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

@mat
Is there anything else I need to do?

Feb 28 2017, 9:50 PM

Feb 24 2017

wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: Deleted auto file etc/rc.d/ceph

Feb 24 2017, 4:02 PM

Feb 23 2017

wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: sorted pkg-plist

Feb 23 2017, 2:32 PM

Feb 22 2017

wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.
In D9584#200509, @mat wrote:

Other than that, it looks good, I assume that you have tested that poudriere testport does not complain about anything ? (the "I think" you said makes me wonder)

Feb 22 2017, 9:37 AM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: Fixed location of sample files

Feb 22 2017, 9:21 AM

Feb 21 2017

wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 21 2017, 11:02 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.
In D9584#200509, @mat wrote:

Other than that, it looks good, I assume that you have tested that poudriere testport does not complain about anything ? (the "I think" you said makes me wonder)

Feb 21 2017, 1:06 PM

Feb 20 2017

wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: need to include everything

Feb 20 2017, 10:07 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: fixing portlint -A warnings and errors

Feb 20 2017, 9:20 PM

Feb 18 2017

wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

I think that this version runs poudriere testport without complaints/errors.

Feb 18 2017, 2:36 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: Fixed a type on pkg-plist

Feb 18 2017, 2:24 PM

Feb 17 2017

wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: added type of CMake defines

Feb 17 2017, 1:31 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

**>>>! In D9584#199162, @wjw_digiware.nl wrote:

And I'd then run find ${STAGEDIR} against the list in pkg-plist to remove what is not there.
But then again that is not trivial, since all the %%_%% codes need to be resolved..

make makeplist does the find and %% dance for you, why bother doing it manually ?

Feb 17 2017, 1:20 PM

Feb 16 2017

wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: fixed the staging directory for not used items

Feb 16 2017, 9:54 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

I'll set the Developer=yes in /etc/make.conf.
I guess it needs to go in the jail?

Feb 16 2017, 8:33 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

Poudriere still shows a lot of orphaned files that aren't present in pkg-plist. If it's your intentional not to install these things, you can either modify the build to not build or not install them, or you can simply delete them from the STAGEDIR during the post-install target. Examples:

Error: Orphaned: bin/ceph_tpbench
Error: Orphaned: %%PYTHON_SITELIBDIR%%/ceph_detect_init/__init__.pyc
Error: Orphaned: sbin/ceph-disk-udev
Error: Orphaned: @dir etc/init.d
Feb 16 2017, 8:14 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: Fixed some more paths

Feb 16 2017, 7:15 PM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 16 2017, 7:13 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: Added ceph:ceph to UIDs:GIDs

Feb 16 2017, 4:50 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: More review changes.

Feb 16 2017, 4:48 PM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 16 2017, 4:46 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

I'm real sorry if I'm starting to annoy. That is certainly not my intention.
There is just this balancing act that I have to do between keepign all sides happy:

  • Ceph and their Linux perception on Life And anything not Linux is sort frowned upon.
  • FreeBSD ports, Whom I now find out have a lot more "requirement" than I've just read browsing thru the porters handbook And yes in the +25 years of FreeBSD usage, this in only the second ports contribution. The old one (Cocktail compiler tools) has long faded.
  • My efforts to get things working in a way that requires the least amount of manual maintenance. Because the more diversions on all kinds of places, the more things I have to address going from one place to the next.
Feb 16 2017, 1:41 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: fixed more reviewer remarks

Feb 16 2017, 12:47 AM

Feb 15 2017

wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 15 2017, 11:29 PM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

After your latest update the port will build, but Poudriere reports many missing files from the plist. For example:

Error: Orphaned: include/rados/page.h

Feb 15 2017, 11:07 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: Rewrote the Makefile to the suggestions of reviewers

Feb 15 2017, 5:18 PM

Feb 14 2017

wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 5:28 PM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 2:43 PM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 2:39 PM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 2:30 PM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 2:25 PM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel: fixed a typo in package dependancies

Feb 14 2017, 11:14 AM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 11:13 AM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 11:05 AM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 10:59 AM
wjw_digiware.nl updated the diff for D9584: First version of net/ceph-devel.

net/ceph-devel/Makefile: obvious request changes to Makefile

Feb 14 2017, 10:10 AM
wjw_digiware.nl added inline comments to D9584: First version of net/ceph-devel.
Feb 14 2017, 9:02 AM
wjw_digiware.nl added a comment to D9584: First version of net/ceph-devel.

I thought you said that it passed portlint and poudriere? When I try, portlint gives me 5 errors. And "portlint -A" give 17 errors and 67 warnings. Please fix all the errors and most of the warnings. If you're unsure about whether a certain warning requires fixing, feel free to ask. Overall, I'm really excited about the work you've done, and I look forward to being able to run an OSD on FreeBSD. I plan to add more comments after my own Poudriere run has finished, but it's taking awhile to download all these dependencies.

Feb 14 2017, 8:27 AM
wjw_digiware.nl retitled D9584: First version of net/ceph-devel from to First version of net/ceph-devel.
Feb 14 2017, 1:50 AM