olivier (Olivier Cochard-Labbé)
User

Projects

User Details

User Since
Feb 5 2016, 2:19 PM (123 w, 6 d)

Recent Activity

Thu, Jun 14

olivier added a comment to D15789: Switch RIB and RADIX_NODE_HEAD lock from rwlock(9) to rmlock(9).
In D15789#334385, @bz wrote:

I am totally not surprised by these numbers. However (a) did you do the same test for IPv6? (b) is that a forwarding setup or an end node setup? (c) how many route updates per second did you try on a forwarding node?

Thu, Jun 14, 9:58 PM
olivier accepted D15789: Switch RIB and RADIX_NODE_HEAD lock from rwlock(9) to rmlock(9).

On a 2 sockets, 12 Core Xeon E5 2650 with a Mellanox ConnectX-4:

Thu, Jun 14, 9:40 PM

Wed, Jun 6

olivier committed rP471874: Update to 2.3.12.
Update to 2.3.12
Wed, Jun 6, 6:40 PM
olivier committed rP471873: Update to 2.3.12.
Update to 2.3.12
Wed, Jun 6, 6:39 PM
olivier committed rP471872: Update to 2.3.12.
Update to 2.3.12
Wed, Jun 6, 6:37 PM
olivier committed rP471871: Update to 2.3.12 and fix build with the latest ffmpeg version.
Update to 2.3.12 and fix build with the latest ffmpeg version
Wed, Jun 6, 6:36 PM

Mon, Jun 4

olivier committed rP471530: Due to stability problems with FRR 4.0, reintroduce previous FRR 3.0.3..
Due to stability problems with FRR 4.0, reintroduce previous FRR 3.0.3.
Mon, Jun 4, 5:12 AM

Sat, Jun 2

olivier committed rP471343: Due to regression detected on FRR 4.0, preparing re-introduction of.
Due to regression detected on FRR 4.0, preparing re-introduction of
Sat, Jun 2, 7:42 AM

Tue, May 29

olivier committed rP471108: Remove no more true comment.
Remove no more true comment
Tue, May 29, 7:02 PM

Sat, May 26

olivier committed rP470880: Forgot to enable RPKI (Resource Public Key Infrastructure) support.
Forgot to enable RPKI (Resource Public Key Infrastructure) support
Sat, May 26, 6:09 AM

Fri, May 25

olivier committed rP470869: Rename net/bird-devel to net/bird2.
Rename net/bird-devel to net/bird2
Fri, May 25, 9:40 PM

May 2 2018

olivier committed rP468806: New port: graphics/natron.
New port: graphics/natron
May 2 2018, 12:08 AM

May 1 2018

olivier committed rP468805: New port: graphics/openfx-arena.
New port: graphics/openfx-arena
May 1 2018, 11:59 PM
olivier committed rP468804: New port: graphics/openfx-misc.
New port: graphics/openfx-misc
May 1 2018, 11:51 PM
olivier committed rP468803: New port: graphics/openfx-io.
New port: graphics/openfx-io
May 1 2018, 11:44 PM

Apr 29 2018

olivier committed rP468621: Add new port: net/graphpath.
Add new port: net/graphpath
Apr 29 2018, 11:51 AM
olivier committed rP468620: MFH: r467384 r467574.
MFH: r467384 r467574
Apr 29 2018, 11:41 AM

Apr 18 2018

olivier added a comment to D15120: Fix queue distribution when there are no threads.

Same improvement on 8-cores ATOM with ixgbe drivers:

Apr 18 2018, 9:09 AM

Apr 17 2018

olivier added a comment to D15120: Fix queue distribution when there are no threads.

Lot's better on 4core AMD, but need to reset my non-IPMI Netgate tomorrow on the lab:

Apr 17 2018, 11:04 PM
olivier added a comment to D15120: Fix queue distribution when there are no threads.

Panic on PC engines APU2 (AMD GX-412TC):

Apr 17 2018, 9:35 PM
olivier committed rP467574: Fix plist with FPM option.
Fix plist with FPM option
Apr 17 2018, 7:59 AM

Apr 15 2018

olivier committed rP467384: Fix watchfrr RC script and build on 10.3.
Fix watchfrr RC script and build on 10.3
Apr 15 2018, 11:24 AM

Apr 13 2018

olivier committed rP467210: Update to 2.8.0.
Update to 2.8.0
Apr 13 2018, 6:56 AM

Mar 28 2018

olivier committed rP465848: Forgot to port BGP MD5 patch into -devel branch.
Forgot to port BGP MD5 patch into -devel branch
Mar 28 2018, 9:23 PM
olivier committed rP465782: Update to 2.0.2.
Update to 2.0.2
Mar 28 2018, 8:18 AM

Mar 27 2018

olivier committed rP465764: Fix installation when RPKI option is disabled.
Fix installation when RPKI option is disabled
Mar 27 2018, 9:43 PM
olivier committed rP465731: Source tarball was updated..
Source tarball was updated.
Mar 27 2018, 6:38 PM
olivier committed rP465713: Update to 1.6.4 and remove the FreeBSD's specific feature FIREWALL option.
Update to 1.6.4 and remove the FreeBSD's specific feature FIREWALL option
Mar 27 2018, 3:09 PM

Mar 25 2018

olivier committed rP465501: Update to 4.0..
Update to 4.0.
Mar 25 2018, 7:45 AM

Mar 19 2018

olivier committed rP465004: Update to 4.8.0.
Update to 4.8.0
Mar 19 2018, 10:13 AM
olivier committed rP465000: Forgot to take maintainership on the net/bird-devel too.
Forgot to take maintainership on the net/bird-devel too
Mar 19 2018, 9:22 AM

Mar 13 2018

olivier committed rP464436: Update to 2.7.0.
Update to 2.7.0
Mar 13 2018, 10:12 PM

Feb 26 2018

olivier added a comment to D14385: Wrap a vlan's parent's if_output in a separate function..

Then, here is my bench results regarding forwarding performance impact with this patch: I'm using a simple 802.1q setup (no LAGG).
Configuration on the Device Under Test (DUT):

Feb 26 2018, 4:07 PM

Feb 20 2018

olivier committed rP462456: Update Mattermost (server and webapp) to 4.7.1.
Update Mattermost (server and webapp) to 4.7.1
Feb 20 2018, 10:11 PM

Feb 17 2018

olivier added a comment to D14385: Wrap a vlan's parent's if_output in a separate function..
In D14385#301730, @ae wrote:

Reducing inbound call path improves forwarding performance for up to 20%. Additional entries can hit performance. This is not noticeable for stock FreeBSD, that can't do more that 3-5Mpps due to lock contention. But when packet rate is about 10-12Mpps it will be significant. We can ask Olivier to try test with our patches.

Feb 17 2018, 7:35 AM

Feb 13 2018

olivier committed rP461754: Update to 1.19c.
Update to 1.19c
Feb 13 2018, 10:20 PM
olivier committed rP461701: Update to 3.0.3.
Update to 3.0.3
Feb 13 2018, 12:45 PM

Feb 9 2018

olivier added a comment to D12446: Support attaching tx queues to cpus.

OK: This patch improves ixgbe performance with 8core Xeon, but on a 4core Atom with igb, I've got a big degradation (almost half performance):

Feb 9 2018, 6:28 AM

Feb 7 2018

olivier committed rP461153: Also, take over maintainership (previous maintainer requests)..
Also, take over maintainership (previous maintainer requests).
Feb 7 2018, 4:31 PM

Feb 2 2018

olivier added a comment to D11137: PF: implement RFC 4787 REQ 1 and 3 (full cone NAT).

Any news about pushing this change to head ?

Feb 2 2018, 1:32 PM
olivier committed rP460678: Add new port: www/mattermost-server.
Add new port: www/mattermost-server
Feb 2 2018, 8:50 AM
olivier committed rP460677: Add new port: www/mattermost-webapp.
Add new port: www/mattermost-webapp
Feb 2 2018, 8:39 AM

Jan 28 2018

olivier added a comment to D12685: Make ipfw dynamic states lockless on fast path.

ConcurrencyKit was MFC : https://svnweb.freebsd.org/base?view=revision&revision=328515

Jan 28 2018, 7:57 PM

Jan 15 2018

olivier accepted D13825: Rename php-xdebug to pecl-xdebug.
Jan 15 2018, 2:16 PM

Jan 10 2018

olivier added a comment to D13825: Rename php-xdebug to pecl-xdebug.

And what about updating all ports depending of your renamed ports ? like devel/pear-PHP_CodeCoverage

Jan 10 2018, 1:35 PM

Dec 19 2017

olivier added a comment to D12446: Support attaching tx queues to cpus.

Yes it's work now, and here are the result: This patch greatly improve D11727 performance!

Dec 19 2017, 1:03 PM
olivier committed rP456710: Update to 2.3.6.
Update to 2.3.6
Dec 19 2017, 6:32 AM

Dec 7 2017

olivier added a comment to D9876: apuled(4): add support for LEDs on PC Engines APU boards.
In D9876#280057, @avg wrote:

Is there still an interest in getting this moving forward?
I think that it should be relatively easy to address my comments and get this into a committable shape.

Dec 7 2017, 11:07 AM

Nov 30 2017

olivier added a comment to D12446: Support attaching tx queues to cpus.

Same problem on fresh r326378 "panic: Lock (rw) ifnet_rw not locked ".
I can fix this problem by adding kern.smp.disabled="1" into the boot/loader.

Nov 30 2017, 3:07 PM

Nov 29 2017

olivier added a comment to D12446: Support attaching tx queues to cpus.

Still the same problem: I've svnuped to r326359 and I've still have this panic (only when this patch is applied):

Nov 29 2017, 9:12 AM

Nov 28 2017

olivier committed rP455023: Release pizzamig from mentorship..
Release pizzamig from mentorship.
Nov 28 2017, 8:46 AM

Nov 27 2017

olivier accepted D13277: benchmarks/stress-ng: Update to 0.09.04.
Nov 27 2017, 11:37 PM

Nov 23 2017

olivier accepted D13191: databases/timescaledb: Update to 0.7.0.
Nov 23 2017, 9:11 AM
olivier added a comment to D12446: Support attaching tx queues to cpus.

Would it be possible to get the output of the ddb "ps", "show all locks", and "show witness" commands? This is just weird.

Nov 23 2017, 7:12 AM

Nov 22 2017

olivier added a comment to D12446: Support attaching tx queues to cpus.

I've got a new panic (head with WITNESS and INVARIANTS enabled):

Nov 22 2017, 7:24 AM

Nov 21 2017

olivier committed rP454613: Document vulnerability in net/frr.
Document vulnerability in net/frr
Nov 21 2017, 2:46 PM
olivier accepted D13167: devel/rubygem-rspec-its: Fix shebang.
Nov 21 2017, 12:24 PM
olivier accepted D13175: net-mgmt/cacti: Update to 1.1.28.
Nov 21 2017, 9:35 AM

Nov 20 2017

olivier added a comment to D13167: devel/rubygem-rspec-its: Fix shebang.

This PR can be merged in quarterly.

Do you think I can add:

MFH: 2017Q4

in the comment?

Nov 20 2017, 11:45 PM
olivier added a comment to D12446: Support attaching tx queues to cpus.

And you try this after r326033? These issues could have been caused by the memory corruption fixed in that commit.

Nov 20 2017, 11:20 PM
olivier accepted D13168: multimedia/kodi: Fix RPI2 support on 11.x.
Nov 20 2017, 10:38 AM
olivier added a comment to D12446: Support attaching tx queues to cpus.

Hrm... you could build a kernel without ix in it and kldload if_ix after the system is up... though that may cause the issue to not occur.

Nov 20 2017, 10:36 AM
olivier accepted D13167: devel/rubygem-rspec-its: Fix shebang.
Nov 20 2017, 9:57 AM

Nov 19 2017

olivier added a comment to D13017: Add IPSec tests in tunnel mode.

Good catch for the no_dad!

Nov 19 2017, 8:56 AM
olivier updated the diff for D13017: Add IPSec tests in tunnel mode.

Add no_dad to inet6 setup for avoiding a sleep

Nov 19 2017, 8:55 AM

Nov 17 2017

olivier added a comment to D12446: Support attaching tx queues to cpus.

How to dump a panic when the kernel crash during boot before loading disk controller drivers ?
Can I compile a kernel with .debug embedded into the kernel ?

Nov 17 2017, 5:58 PM
olivier added a comment to D13017: Add IPSec tests in tunnel mode.

New tests output following r325872 that fixed cbc key lenght:

Nov 17 2017, 4:40 PM
olivier added inline comments to D13017: Add IPSec tests in tunnel mode.
Nov 17 2017, 4:38 PM
olivier updated the diff for D13017: Add IPSec tests in tunnel mode.

Updating test scripts following kristof's advices

Nov 17 2017, 4:35 PM

Nov 15 2017

olivier accepted D12770: ipsec: Use the same keysize values for HMAC as prior to r324017.
Nov 15 2017, 8:35 PM
olivier added a comment to D12446: Support attaching tx queues to cpus.

Once I've applied this patch on my system (that is already patched with D11727 and D13096) it panic.

Nov 15 2017, 8:28 PM
olivier added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Created D13096 to fix the overallocation of queues. However, even with 24 queues, there should have been two per core (one per thread with HTT), not one per core across the two sockets.

Nov 15 2017, 7:28 AM
olivier accepted D13097: net/xrdp-devel: Update to 0.9.4.
Nov 15 2017, 7:15 AM
olivier accepted D13089: x11-drivers/xorgxrdp: Update to 0.2.4.
Nov 15 2017, 6:19 AM

Nov 14 2017

olivier added a comment to D12446: Support attaching tx queues to cpus.

I don't reach to apply the patch, and when I've tried to "manually" merge it, I've broke the compilation :-(

Nov 14 2017, 9:57 PM

Nov 13 2017

olivier added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Are you sure about the number of queues? For iflib version of driver the default number is based on number of cores. Are you setting dev.ix.X.override_n(r|t)xqs sysctls?

Nov 13 2017, 10:50 PM
olivier added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Second, on a Dual CPU, Xeon_E5-2650 (12Cores), with Intel 82599ES 10Gigabit (using default 8 queues):

Hrm... is that two E5-2651s for 24 cores total, or two 6-core E5s for 12 cores total?

Nov 13 2017, 7:56 PM
olivier added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

@olivier Can you post the sysctl/loader.conf settings you are using from both iterations of the test?

Nov 13 2017, 7:40 PM
olivier added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

@olivier So a decrease of ~33% with IFLIB?

Nov 13 2017, 7:34 PM
olivier accepted D13071: benchmarks/stress-ng: Update to 0.09.02.
Nov 13 2017, 5:00 PM
olivier added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Here are my updated benches "forwarding smallest packet size" results on 2 different hardware.
I'm using a fresh head (r325763) and the latest diff (35190) of this review.

Nov 13 2017, 3:57 PM
olivier committed rP454110: Update to 0.170.
Update to 0.170
Nov 13 2017, 12:17 PM

Nov 10 2017

olivier accepted D13037: www/yarn: Use www/node as default.
Nov 10 2017, 7:51 PM
olivier added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

I've tried to update my previous benches, but on a recent head (r325618), and this review need to be updated because it no more apply (a small part was committed into head).
And compilation failed on this recent head too:

Nov 10 2017, 10:10 AM

Nov 9 2017

olivier added reviewers for D13017: Add IPSec tests in tunnel mode: jmg, bz.
Nov 9 2017, 2:27 PM
olivier created D13017: Add IPSec tests in tunnel mode.
Nov 9 2017, 2:26 PM

Nov 8 2017

olivier accepted D13006: www/yarn: Add support to www/node8.
Nov 8 2017, 6:08 PM
olivier committed rP453751: Update to 3.0.2.
Update to 3.0.2
Nov 8 2017, 3:17 PM

Nov 5 2017

olivier accepted D12939: www/yarn: Update to 1.3.2.
Nov 5 2017, 7:28 PM
olivier accepted D12938: benchmarks/stress-ng: Update to 0.09.01.
Nov 5 2017, 4:20 PM

Nov 3 2017

olivier accepted D12786: devel/liblas12: Fix build error on CURRENT.
Nov 3 2017, 11:00 AM

Nov 1 2017

olivier committed rP453268: Update to 1.11.2 and conditionally uses NLS.
Update to 1.11.2 and conditionally uses NLS
Nov 1 2017, 8:40 AM

Oct 31 2017

olivier committed rP453216: Update to 2.6.0.
Update to 2.6.0
Oct 31 2017, 6:33 AM

Oct 30 2017

olivier accepted D12835: benchmarks/stress-ng: Update to 0.09.00.
Oct 30 2017, 3:28 PM
olivier added a comment to D12770: ipsec: Use the same keysize values for HMAC as prior to r324017.

I confirm: I'm using static key only on my tests.

Oct 30 2017, 3:06 PM

Oct 27 2017

olivier added a comment to D12770: ipsec: Use the same keysize values for HMAC as prior to r324017.

I've found the commit that broke AES-GCM: r324037 "aesni(4): Add support for x86 SHA intrinsics".
But how is possible that I'm impacted without loading aesni module ?!?

Oct 27 2017, 11:10 PM
olivier added a comment to D12685: Make ipfw dynamic states lockless on fast path.

And now comparing pf vs ipfw:

Oct 27 2017, 1:11 PM
olivier accepted D12806: devel/codeblocks-devel: new port.
Oct 27 2017, 8:21 AM
olivier added a comment to D12685: Make ipfw dynamic states lockless on fast path.

Wow, results regarding the 5M UDP session bench:

Oct 27 2017, 8:03 AM
olivier requested changes to D12806: devel/codeblocks-devel: new port.

After adding a new port, you need to add it to the category Makefile too (here in devel/Makefile): I didn't see modifications to devel/Makefile here.
And each time I'm touching such category Makefile file, I'm checking index is still building fine with an indexbuild (cd /usr/port; make index).

Oct 27 2017, 5:45 AM