Page MenuHomeFreeBSD

olivier (Olivier Cochard-Labbé)
User

Projects

User Details

User Since
Feb 5 2016, 2:19 PM (250 w, 6 d)

Recent Activity

Wed, Nov 25

olivier committed rP556294: Update to 1.9.4.
Update to 1.9.4
Wed, Nov 25, 3:10 PM

Tue, Nov 24

olivier added inline comments to D26137: Wireguard merge.
Tue, Nov 24, 9:45 AM

Sat, Nov 14

olivier added inline comments to D26137: Wireguard merge.
Sat, Nov 14, 10:32 AM

Wed, Nov 11

olivier accepted D27173: Add regression test for D27164.
Wed, Nov 11, 7:29 PM

Tue, Nov 10

olivier committed rP554860: Update to 7.5.
Update to 7.5
Tue, Nov 10, 11:56 PM

Mon, Nov 9

olivier requested review of D27155: Fixing build on -head and removing useless function.
Mon, Nov 9, 8:26 PM

Sun, Nov 8

olivier closed D27123: Reporting same value for smbios.chassis.maker as smbios.system.maker.
Sun, Nov 8, 7:50 AM
olivier committed rS367478: Return the same value for smbios.chassis.maker as smbios.system.maker (and….
Return the same value for smbios.chassis.maker as smbios.system.maker (and…
Sun, Nov 8, 7:50 AM

Fri, Nov 6

olivier requested review of D27123: Reporting same value for smbios.chassis.maker as smbios.system.maker.
Fri, Nov 6, 4:45 PM

Fri, Oct 30

olivier committed rS367152: bhyve currently reports each of "smbios.system.maker" and.
bhyve currently reports each of "smbios.system.maker" and
Fri, Oct 30, 12:04 AM

Oct 25 2020

olivier committed rP553273: Fix distinfo for maildir.patch..
Fix distinfo for maildir.patch.
Oct 25 2020, 4:55 PM

Oct 5 2020

olivier added a comment to D26076: Switch net.add_addr_allfibs default to 0.

What the current status of this review ? Wasn't it supposed to be committed at the end of August ?

Oct 5 2020, 1:51 PM
olivier committed rP551478: Harden RC script by adding double quotes..
Harden RC script by adding double quotes.
Oct 5 2020, 7:48 AM

Oct 2 2020

olivier committed rP551207: Update to 4.1.0.
Update to 4.1.0
Oct 2 2020, 1:34 PM

Oct 1 2020

olivier committed rP550880: Update to 4.15.0-1..
Update to 4.15.0-1.
Oct 1 2020, 11:30 PM

Sep 28 2020

olivier added inline comments to D26549: Enabling SO_LINGER to the so_reuseport_lb_test regression tests.
Sep 28 2020, 9:54 PM

Sep 25 2020

olivier closed D26549: Enabling SO_LINGER to the so_reuseport_lb_test regression tests.
Sep 25 2020, 4:02 PM
olivier committed rS366159: Enable SO_LINGER to the so_reuseport_lb_test regression tests, preventing.
Enable SO_LINGER to the so_reuseport_lb_test regression tests, preventing
Sep 25 2020, 4:02 PM
olivier updated the diff for D26549: Enabling SO_LINGER to the so_reuseport_lb_test regression tests.

switching a variable to const.

Sep 25 2020, 3:49 PM

Sep 24 2020

olivier requested review of D26549: Enabling SO_LINGER to the so_reuseport_lb_test regression tests.
Sep 24 2020, 10:19 PM

Sep 23 2020

olivier added a comment to D26449: Stage 2: Introduce scalable route multipath.

Tested with net/frr7 compiled with MULTIPATH option, and it is working great:

Sep 23 2020, 1:06 PM
olivier committed rP549715: Update to 2.0.0.
Update to 2.0.0
Sep 23 2020, 12:15 PM

Sep 22 2020

olivier committed rP549638: Fixing bug in frr-reload and while here fix a typo in the package name suffix….
Fixing bug in frr-reload and while here fix a typo in the package name suffix…
Sep 22 2020, 9:33 PM

Sep 21 2020

olivier added a comment to D26449: Stage 2: Introduce scalable route multipath.

Tested on my ECMP lab (https://bsdrp.net/documentation/examples/ecmp#testing_load_balancing) and the flow-id load-balancing seems working great.
Would you like test using bird and FRR too ?

Sep 21 2020, 11:14 AM

Sep 18 2020

olivier added inline comments to D26449: Stage 2: Introduce scalable route multipath.
Sep 18 2020, 7:48 PM
olivier added a comment to D26449: Stage 2: Introduce scalable route multipath.

Look like the review contains a patch to file usr.bin/netstat/nhgrp.c that doesn't exist on -head

Sep 18 2020, 6:18 PM

Sep 10 2020

olivier committed rP548198: Remove old net/frr6..
Remove old net/frr6.
Sep 10 2020, 10:14 AM

Sep 7 2020

olivier added a comment to D26324: net: Mitigate vnet / epair cleanup races.

My jail/vnet burn test is still generating a panic:

Sep 7 2020, 4:08 PM

Sep 5 2020

olivier committed rP547651: Update Maildir patch URL..
Update Maildir patch URL.
Sep 5 2020, 2:29 PM
olivier added a comment to D26137: Wireguard merge.
In D26137#585268, @mjg wrote:
Sep 5 2020, 8:05 AM

Sep 4 2020

olivier added a comment to D26137: Wireguard merge.

@olivier Thanks for the analysis. Could you share some pmc profiles from unhalted core cycles?

Sep 4 2020, 1:27 PM

Sep 1 2020

olivier added a comment to D26137: Wireguard merge.

Comparing wireguard userland vs kernel module on a small device: +300% (from 117Mb/s to 483Mb/s)

  • PC Engines APU2C4 (quad core AMD GX-412T Processor 1 GHz)
  • 3 Intel i210AT Gigabit Ethernet ports
  • FreeBSD 13-head r365033
  • Wireguard kernel: D26137
  • Wireguard userland: 1.0.20200827
  • 2000 flows of UDP packets
  • 500Bytes UDP load => packet size: 528B => Ethernet frame size:542B
Sep 1 2020, 8:37 PM

Aug 28 2020

olivier committed rP546828: Remove no more used option TCPSOCKETS..
Remove no more used option TCPSOCKETS.
Aug 28 2020, 8:53 PM

Aug 25 2020

olivier committed rP546187: Remove old net/frr5..
Remove old net/frr5.
Aug 25 2020, 3:47 PM

Aug 24 2020

olivier committed rP546101: Fix build with -fno-common.
Fix build with -fno-common
Aug 24 2020, 5:20 PM

Aug 20 2020

olivier committed rP545571: Revert r545567: A smarter patch was committed 10 minutes before this one..
Revert r545567: A smarter patch was committed 10 minutes before this one.
Aug 20 2020, 11:15 PM
olivier committed rP545569: Fix build on FreeBSD 13.
Fix build on FreeBSD 13
Aug 20 2020, 11:03 PM
olivier committed rP545567: Fix build on FreeBSD 13.
Fix build on FreeBSD 13
Aug 20 2020, 9:48 PM

Aug 18 2020

olivier updated the diff for D9876: apuled(4): add support for LEDs on PC Engines APU boards.

Updating the patch to latest -head.

Aug 18 2020, 9:18 AM

Aug 4 2020

olivier committed rS363868: Skip sbin/route tests if jail not installed (WITHOUT_JAIL)..
Skip sbin/route tests if jail not installed (WITHOUT_JAIL).
Aug 4 2020, 9:34 PM
olivier closed D25935: skip sbin/route jail test if jail not installed.
Aug 4 2020, 9:34 PM
olivier committed rP544169: Update to 1.7.1.
Update to 1.7.1
Aug 4 2020, 1:46 PM

Aug 3 2020

olivier committed rP544112: Update to 1.21c.
Update to 1.21c
Aug 3 2020, 11:05 PM
olivier requested review of D25935: skip sbin/route jail test if jail not installed.
Aug 3 2020, 9:46 PM
olivier committed rP544108: New port: net/read_bbrlog.
New port: net/read_bbrlog
Aug 3 2020, 8:40 PM
olivier committed rP544107: New port: devel/bbparse.
New port: devel/bbparse
Aug 3 2020, 8:37 PM
olivier committed rP544106: New port: net/tcplog_dumper.
New port: net/tcplog_dumper
Aug 3 2020, 8:34 PM
olivier committed rP544072: New sub-port: mstflint-lite including only some essential tools.
New sub-port: mstflint-lite including only some essential tools
Aug 3 2020, 3:10 PM
olivier committed rP544066: Update to 4.14.0-3 and added new options:.
Update to 4.14.0-3 and added new options:
Aug 3 2020, 1:14 PM

Aug 2 2020

olivier committed rP543977: Update to 4.0.2.
Update to 4.0.2
Aug 2 2020, 4:49 PM
olivier committed rP543975: Update to 2.0.2.
Update to 2.0.2
Aug 2 2020, 4:45 PM
olivier committed rP543969: Update my location.
Update my location
Aug 2 2020, 3:09 PM

Jul 24 2020

olivier committed rP543378: Fix crash on config read.
Fix crash on config read
Jul 24 2020, 8:21 PM
olivier committed rP543259: Add missing python version requirement.
Add missing python version requirement
Jul 24 2020, 4:40 PM
olivier committed rP543002: Update to 1.21b.
Update to 1.21b
Jul 24 2020, 6:20 AM

Jul 23 2020

olivier committed rP542960: New port net/frr7-pythontools provide configuration reload functionality for.
New port net/frr7-pythontools provide configuration reload functionality for
Jul 23 2020, 8:24 PM
olivier committed rP542959: - Update to 7.4.
- Update to 7.4
Jul 23 2020, 8:16 PM
olivier committed rP542958: Update to 1.0.184.
Update to 1.0.184
Jul 23 2020, 8:12 PM
olivier committed rP542919: Update to 2.0.1.
Update to 2.0.1
Jul 23 2020, 7:58 AM

Jul 21 2020

olivier updated the diff for D24830: sendfile_test: Finish to implement linear probing to find a free port .

Following gleb's advice, use getsockname avoiding the random port generation part
I've still binded the port (I didn't understand the improvement brings by not binding it).

Jul 21 2020, 4:16 PM

Jul 8 2020

olivier committed rS363032: Install extra TCP stack header files: They are needed to compile a userland.
Install extra TCP stack header files: They are needed to compile a userland
Jul 8 2020, 9:40 PM
olivier closed D25584: Install extra tcp stack headers.
Jul 8 2020, 9:40 PM

Jul 7 2020

olivier requested review of D25584: Install extra tcp stack headers.
Jul 7 2020, 4:25 PM

Jun 29 2020

olivier added a comment to D25454: cxgbe(4): changes in the Tx path to help increase tx coalescing..

First result on a 'small' server Xeon E5 2650 8 cores with a 10G Chelsio T540-CR (one port used as RX and the other as TX) :

x r362778: inet4 packets-per-second forwarded
+ r362778 with D25454: inet4 packets-per-second forwarded
+--------------------------------------------------------------------------+
|                                                                         +|
|                                                                         +|
|                                                                         +|
|     x                                                                   +|
|x   xx  x                                                                +|
|  |__A_|                                                                  |
|                                                                         A|
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5      11767747      11782957      11777032      11776267     5465.3431
+   5      11905318      11905348      11905340      11905335     11.436783
Difference at 95.0% confidence
        129068 +/- 5636.28
        1.096% +/- 0.0483859%
        (Student's t, pooled s = 3864.59)
Jun 29 2020, 10:34 PM

Jun 23 2020

olivier closed D24613: skip bectl jail test if jail not installed.
Jun 23 2020, 3:16 AM
olivier requested review of D24613: skip bectl jail test if jail not installed.
Jun 23 2020, 3:16 AM

Jun 18 2020

olivier added inline comments to D24830: sendfile_test: Finish to implement linear probing to find a free port .
Jun 18 2020, 9:18 AM

Jun 16 2020

olivier updated the diff for D24830: sendfile_test: Finish to implement linear probing to find a free port .

Fixing style and almost all other remarks.

Jun 16 2020, 9:20 PM

May 28 2020

olivier committed rP536813: Update to 1.6.3.
Update to 1.6.3
May 28 2020, 7:54 PM

May 27 2020

olivier committed rP536671: Fix duplicate line..
Fix duplicate line.
May 27 2020, 6:43 AM
olivier committed rP536669: Update to 7.3.1.
Update to 7.3.1
May 27 2020, 6:22 AM

May 26 2020

olivier committed rP536637: Fix error messages with SSH service..
Fix error messages with SSH service.
May 26 2020, 4:15 PM

May 14 2020

olivier added inline comments to D24830: sendfile_test: Finish to implement linear probing to find a free port .
May 14 2020, 4:21 PM

May 13 2020

olivier requested review of D24830: sendfile_test: Finish to implement linear probing to find a free port .
May 13 2020, 9:07 PM

May 8 2020

olivier committed rP534410: Update to 1.5.7.
Update to 1.5.7
May 8 2020, 4:11 PM

May 6 2020

olivier accepted D24659: em/ix/ixv/ixl/iavf: Implement ifdi_needs_restart iflib method.

Tested on igb and excellent result!

May 6 2020, 9:41 PM

Apr 29 2020

olivier committed rS360465: Skip bectl jail test if jail not installed (WITHOUT_JAIL)..
Skip bectl jail test if jail not installed (WITHOUT_JAIL).
Apr 29 2020, 2:15 PM
olivier added reviewers for D24613: skip bectl jail test if jail not installed: lwhsu, ngie.
Apr 29 2020, 1:52 PM
olivier added a member for tests: olivier.
Apr 29 2020, 5:04 AM

Apr 17 2020

olivier added a comment to D20869: vnet: Fix panic when shutting down jails and deleting interfaces simultaneously.

Once this patch applied to a current, my build kernel failed with a

Apr 17 2020, 7:46 PM
olivier closed D24468: Skip sys/net/routing/test_rtsock_* regression tests if module if_epair doesn't exist.
Apr 17 2020, 4:31 PM
olivier committed rS360045: Skip routing regression tests depending on if_epair if this module isn't….
Skip routing regression tests depending on if_epair if this module isn't…
Apr 17 2020, 4:31 PM
olivier updated the diff for D24468: Skip sys/net/routing/test_rtsock_* regression tests if module if_epair doesn't exist.

Moving module load later.

Apr 17 2020, 3:39 PM
olivier created D24468: Skip sys/net/routing/test_rtsock_* regression tests if module if_epair doesn't exist.
Apr 17 2020, 1:45 PM

Apr 12 2020

olivier committed rP531526: Add 'service frr onerestart all' usage..
Add 'service frr onerestart all' usage.
Apr 12 2020, 4:01 PM

Apr 6 2020

olivier added a comment to D24249: bridge: Change lists to CK_LIST as a peparation for epochification.

Here are my result:

x r359647 in bridge mode: inet 4 packets forwarded per second
+ r359647 with D24250 in bridge mode: inet 4 packets forwarded per second
+--------------------------------------------------------------------------+
|xx                                                                      + |
|xx                                                                 +  + ++|
|A|                                                                        |
|                                                                     |_AM||
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5       3314595       3582601       3450403       3448858     99435.922
+   5      22726995      24346441      23963008      23715416     617156.45
Difference at 95.0% confidence
        2.02666e+07 +/- 644666
        587.631% +/- 27.5422%
        (Student's t, pooled s = 442024)
Apr 6 2020, 12:53 PM

Mar 30 2020

olivier committed rP529901: Move groff dependency to an option..
Move groff dependency to an option.
Mar 30 2020, 5:02 PM

Mar 29 2020

olivier accepted D24182: Switch rtsock tests to per-test jails and epair interfaces..
Mar 29 2020, 5:18 AM

Mar 13 2020

olivier committed rP528342: Fix distfile fetch and while here improve portlint..
Fix distfile fetch and while here improve portlint.
Mar 13 2020, 9:45 AM

Mar 12 2020

olivier committed rP528290: Update to 7.3..
Update to 7.3.
Mar 12 2020, 1:35 PM
olivier committed rP528289: Update to 1.0.130..
Update to 1.0.130.
Mar 12 2020, 1:34 PM

Mar 3 2020

olivier committed rS358589: Skip if_epair regression test if module doesn't exist.
Skip if_epair regression test if module doesn't exist
Mar 3 2020, 5:35 PM
olivier closed D23876: Skip if_epair test if module doesn't exist.
Mar 3 2020, 5:35 PM

Mar 2 2020

olivier updated the diff for D23876: Skip if_epair test if module doesn't exist.

Keept the same behaviour as previously by loading the if_epair module.

Mar 2 2020, 9:22 PM

Mar 1 2020

olivier added a comment to D23876: Skip if_epair test if module doesn't exist.
In D23876#525342, @kp wrote:

This does change the behaviour of the test: if the if_epair module isn't loaded yet it doesn't load it, it skips the test.

Arguably that's better, because that's what we do for other modules (e.g. pf). On the other hand, other tests load it implicitly (e.g. the pf tests) in the process of making their test setup.
I'm torn on the best way to deal with this. Perhaps the best fix is to keep the kldload(), but to skip the test if the load fails rather than failing the test.

If we do go with this approach we should change freebsd-ci so that it loads if_epair (just as it already loads pf) for the automated tests.

Mar 1 2020, 7:13 AM

Feb 28 2020

olivier added a comment to D23886: ip6_output: use new routing KPI when not passed a cached route.
In D23886#525161, @bz wrote:

@olivier do you have a non-forwarding TCP test-bed these days?

Feb 28 2020, 10:08 PM
olivier created D23876: Skip if_epair test if module doesn't exist.
Feb 28 2020, 4:50 PM

Feb 23 2020

olivier committed rP526902: Update to 1.4.33.
Update to 1.4.33
Feb 23 2020, 8:16 AM

Feb 20 2020

olivier added a comment to D23329: Make ICMP redirect processing depend on routing daemon.

Thanks to their maintainers, the RC scripts of net/quagga, net/openbgpd and net/openbgpd6 are now publishing the "dynamicrouting" keyword too.

Feb 20 2020, 11:48 PM

Feb 14 2020

olivier added a comment to D23674: Change smarter epoch support for NIC drivers to opt-in..

So, if I've correctly understood:

Feb 14 2020, 2:00 PM