In D44548#1016031, @des wrote:

I think D44558 is a better approach.

In D44548#1015876, @des wrote:

Why are you testing lorder, which is part of the toolchain, on a system without a toolchain?

On 2 identical servers (Intel Xeon CPU E5-2697A v4 @ 2.60GHz), one running the unpatched and the other this patched review, here are the results of this script (extracting the "real" in seconds from the time command):

#!/bin/sh
set -eu
lenght=100000000000
sizes="8000 32000 64000 128000 256000 512000 1000000"
cmd=""
for s in $sizes; do
        echo "Benching with size $s (lenght: $lenght)..."
        for i in $(seq 3); do
                time -p -o bulk.$s.$i.txt ./unix_bulk $lenght $s $s
        done
        grep real bulk.$s.*.txt | cut -d ' ' -f 2 > bulk.$s.data
        cmd="$cmd bulk.$s.data"
done
ministat -w 74 -s $cmd

On similar review (https://reviews.freebsd.org/D44005) the idea was to still build and install it, but "skip" the test if jail binary was missing.
@jamie Do you have a preference ?

In D44005#1004021, @lwhsu wrote:

I don't really object this approach, but I don't really support it either. Do you think it's okay to let the test case check if jail utility exists, and skip running if no?

fix typo

Add variables usage description

In D43497#991634, @arrowd wrote:

Thank you. Now, how about adding support for requesting several sanitizers at the same time? Let SANITIZE_FLAGS accept a list of values like SANITIZE_FLAGS= memory thread and then iterate over it with .for?

Let me know if you don't want to do this. Your change is already pretty useful.

Add meson support and sort

Ship it please :-)

Replacing hardcoded port number with dynamic ones.

In D38828#884135, @ngie wrote:

The kldload check function seems like it should be in a common function. Also: I might reword the message to state: “This test requires the tarfs kernel module (not available).”

Fixed the crash here:

Need more work

In file included from /usr/src/bin/cat/cat.c:60:
/usr/obj/amd64.amd64/tmp/usr/include/capsicum_helpers.h:42:10: fatal error: 'libcasper.h' file not found
#include <libcasper.h>