Page MenuHomeFreeBSD

olivier (Olivier Cochard-Labbé)
User

Projects

User Details

User Since
Feb 5 2016, 2:19 PM (188 w, 2 d)

Recent Activity

Thu, Sep 12

olivier committed rP511909: Update to 2.0.6.
Update to 2.0.6
Thu, Sep 12, 10:47 PM
olivier committed rP511908: Update to 1.6.8.
Update to 1.6.8
Thu, Sep 12, 10:46 PM
olivier added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

New results with this new version on atom C2558 (4 cores):

x bypass_mpring_disabled (default): inet4 packets-per-second forwarded
+ bypass_mpring_enabled: inet4 packets-per-second forwarded
+--------------------------------------------------------------------------+
|x         x               x          xx                 +   +  + +       +|
|     |________________A___M____________|                                  |
|                                                         |_____A______|   |
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5      884557.5        909555        902052      899342.3      11144.15
+   5        921463        932932        926300      926564.8     4308.0002
Difference at 95.0% confidence
        27222.5 +/- 12321.5
        3.02693% +/- 1.40621%
        (Student's t, pooled s = 8448.4)
Thu, Sep 12, 10:22 PM

Wed, Aug 28

olivier committed rP510039: Custom OSPF "wrong LSA collision detection patch" is in conflict with the fix.
Custom OSPF "wrong LSA collision detection patch" is in conflict with the fix
Wed, Aug 28, 3:15 AM

Tue, Aug 27

olivier added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

Yes you've right! The correct label should be "bypass_mpring" disabled/enabled... which revert the logic.

Tue, Aug 27, 12:59 PM

Mon, Aug 26

olivier added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

Flamegraph (fixed labels):

Mon, Aug 26, 7:50 PM

Sat, Aug 24

olivier committed rP509755: Update to 1.20.
Update to 1.20
Sat, Aug 24, 9:05 PM

Aug 15 2019

olivier added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

On another hardware (Atom 4cores):

x inet4 forwarding of small packet size, bypass_mpring=0 in packets-per-second
+ inet4 forwarding of small packet size, bypass_mpring=1 in packets-per-second
+--------------------------------------------------------------------------+
|+                              +  ++  +                x           x x x  |
|                                                          |______A__M____||
|            |_______________A_____M________|                              |
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   4      927858.5        983285        971934     963752.88      24606.11
+   5        749042        872241        859294      839484.8     51106.313
Difference at 95.0% confidence
        -124268 +/- 66405
        -12.8942% +/- 6.76603%
        (Student's t, pooled s = 41856.6)

Bigger impact her: -12%

Aug 15 2019, 2:19 AM

Aug 14 2019

olivier added a comment to D21122: Proof-of-concept hack: remove mp_ring from TX path.

Results on PC Engines APU2 (notice that I had to set back iflib.tx_abdicate=0, because if=1, all packets are dropped in another dimension):

x inet4 forwarding of small packet size, bypass_mpring=0 in packets-per-second
+ inet4 forwarding of small packet size, bypass_mpring=1 in packets-per-second
+--------------------------------------------------------------------------+
|+         +         + +  +                                    x    x x  xx|
|                                                                |____A___||
|     |_________A____M_____|                                               |
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5        462506        464435        463851      463697.4     759.63235
+   5        451908        456286        455316        454538     1785.9727
Difference at 95.0% confidence
        -9159.4 +/- 2001.51
        -1.9753% +/- 0.430346%
        (Student's t, pooled s = 1372.36)
Aug 14 2019, 11:31 PM

Aug 10 2019

olivier committed rP508497: Update to 2.0.5.
Update to 2.0.5
Aug 10 2019, 3:41 PM
olivier committed rP508496: Update to 1.6.7.
Update to 1.6.7
Aug 10 2019, 3:39 PM
olivier committed rP508495: Update to 7.1.
Update to 7.1
Aug 10 2019, 3:26 PM

Jul 15 2019

olivier committed rS350019: Fix filename to avoid skipping lib/libc/net/servent test..
Fix filename to avoid skipping lib/libc/net/servent test.
Jul 15 2019, 11:41 PM
olivier closed D20943: Fix test for lib/libc/net/servent_test.
Jul 15 2019, 11:41 PM
olivier added a comment to D20943: Fix test for lib/libc/net/servent_test.

Update following Enji's advice.

Jul 15 2019, 3:41 PM

Jul 14 2019

olivier added a comment to D20943: Fix test for lib/libc/net/servent_test.
In D20943#453979, @ngie wrote:

Good eye!
Could you please adjust the script from the Makefile so this script doesn’t need to diverge from upstream?

Jul 14 2019, 8:20 AM

Jul 12 2019

olivier created D20943: Fix test for lib/libc/net/servent_test.
Jul 12 2019, 10:28 PM

Jun 27 2019

olivier committed rP505214: Add MRT protocol support.
Add MRT protocol support
Jun 27 2019, 6:27 PM

May 28 2019

olivier committed rP502902: Restrict python versions used to build net/frr7.
Restrict python versions used to build net/frr7
May 28 2019, 4:39 PM

May 13 2019

olivier added a comment to D20224: Eliminate rwlock from fast path processing in BPF code.

Let's try the benefit of this patch on a 8-core Atom with a 10G Chelsio, during a forwarding bench with tcdpump running:

x r347519: inet4 smallest size packets-per-second forwarded with tcpdump running
+ r347519 and D20224: inet4 smallest size packets-per-second forwarded with tcpdump running
+--------------------------------------------------------------------------+
|   xx              x                                          +  +   +  ++|
||___M__A______|                                                           |
|                                                                |___AM___||
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5       3682162       3816554       3684703     3711296.2     58889.489
+   5     4179733.5       4274492       4240164     4234216.7     39505.425
Difference at 95.0% confidence
        522920 +/- 73130.8
        14.09% +/- 2.16578%
        (Student's t, pooled s = 50143)
May 13 2019, 2:39 PM

Apr 30 2019

olivier committed rP500484: Fix build with GCC-based architectures..
Fix build with GCC-based architectures.
Apr 30 2019, 12:44 PM

Apr 23 2019

olivier committed rS346605: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes.
Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes
Apr 23 2019, 9:08 PM
olivier closed D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Apr 23 2019, 9:08 PM
olivier updated the diff for D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.

Applying ngie's comments

Apr 23 2019, 3:46 PM
olivier added inline comments to D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Apr 23 2019, 2:27 PM

Apr 19 2019

olivier created D19970: Fix typo in comment.
Apr 19 2019, 5:56 PM

Apr 18 2019

olivier created D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Apr 18 2019, 3:56 PM

Apr 16 2019

olivier committed rP499086: Remove net/frr3 and net/frr4: Upstream no longer maintained.
Remove net/frr3 and net/frr4: Upstream no longer maintained
Apr 16 2019, 9:57 AM

Apr 15 2019

olivier committed rP499060: New port: net/frr7 (7.0).
New port: net/frr7 (7.0)
Apr 15 2019, 9:34 PM

Apr 5 2019

olivier committed rP497976: Update to 1.6.6.
Update to 1.6.6
Apr 5 2019, 6:32 PM

Apr 4 2019

olivier committed rS345893: Add requiered programs (cc and c++) for some lib/atf regression tests.
Add requiered programs (cc and c++) for some lib/atf regression tests
Apr 4 2019, 8:34 PM

Apr 1 2019

olivier committed rS345765: Fix and simplify code by using ATF_REQUIRE_FEATURE macro.
Fix and simplify code by using ATF_REQUIRE_FEATURE macro
Apr 1 2019, 2:21 PM

Mar 29 2019

olivier committed rS345681: Skip test if feature security_capabilities is not available.
Skip test if feature security_capabilities is not available
Mar 29 2019, 8:43 AM

Mar 28 2019

olivier committed rS345644: Skip this test if if_tap module is not available.
Skip this test if if_tap module is not available
Mar 28 2019, 4:17 PM

Mar 26 2019

olivier committed rP496886: Update to 2.0.4.
Update to 2.0.4
Mar 26 2019, 10:47 AM

Mar 21 2019

olivier committed rP496469: Fix: build against SSL from ports and connection problem with TLS 1.3.
Fix: build against SSL from ports and connection problem with TLS 1.3
Mar 21 2019, 3:05 PM

Mar 14 2019

olivier committed rP495743: Update to 0.16-R3.
Update to 0.16-R3
Mar 14 2019, 11:43 PM
olivier committed rP495731: Fix RC script when VTYSH (integrated configuration) mode is enabled.
Fix RC script when VTYSH (integrated configuration) mode is enabled
Mar 14 2019, 8:17 PM

Feb 14 2019

olivier committed rP492921: Fix compilation when TARGET_ARCH is set.
Fix compilation when TARGET_ARCH is set
Feb 14 2019, 2:49 PM

Feb 3 2019

olivier committed rP492078: Fix build on 12-stable when using OpenSSL from port..
Fix build on 12-stable when using OpenSSL from port.
Feb 3 2019, 9:04 PM

Jan 14 2019

olivier added a comment to D18532: Use byte-counting rather than packet counting for TX batch size.

I'm generating about 2000 flows and I'm seeing a big improvement by enabling tx_abduction too with iflib.
But my understanding is this review is not about tx_abduction but about TX_BATCH_SIZE, and that I had to check if this TX_BATCH_SIZE patch will bring better performances in forwarding mode.
This is why I've made 2 DoS forwarding benches:

  • One comparing TX_BATCH_SIZE patch against 2 head configured identically
  • One comparing performance impact brings by this TX_BATCH_SIZE patch against the performance brings by tx_abduction
Jan 14 2019, 11:50 PM
olivier added a comment to D18532: Use byte-counting rather than packet counting for TX batch size.

It's the standard "DoS" method: I'm unidirectional sending line-rate of smallest size packet.

Jan 14 2019, 12:48 PM

Jan 11 2019

olivier added a comment to D18532: Use byte-counting rather than packet counting for TX batch size.

Ok, so let's try again with this latest version (I'm calling this one D18532v3):

Jan 11 2019, 7:20 PM

Jan 8 2019

olivier committed rP489707: Update to 3.0.4.
Update to 3.0.4
Jan 8 2019, 3:25 PM
olivier committed rP489706: Update to 4.0.1.
Update to 4.0.1
Jan 8 2019, 3:24 PM
olivier committed rP489705: Update to 5.0.2.
Update to 5.0.2
Jan 8 2019, 3:22 PM
olivier committed rP489703: Update to 6.0.2.
Update to 6.0.2
Jan 8 2019, 3:22 PM
olivier committed rP489702: Update to 1.6.5.
Update to 1.6.5
Jan 8 2019, 3:20 PM
olivier committed rP489701: Update to 2.0.3 and add birdvty group.
Update to 2.0.3 and add birdvty group
Jan 8 2019, 3:19 PM

Jan 5 2019

olivier added a comment to D18690: Reduce overhead of per-packet processing by ipfw(4).

Here are my classical DoS benches with ipfw (stateless with one rule "allow ip from any to any") results on 3 different setup:

Jan 5 2019, 10:36 PM

Jan 4 2019

olivier added a comment to D18532: Use byte-counting rather than packet counting for TX batch size.

Hi,
I've got igb only NIC, not em, so I can't use my lab to bench this new review version.

Jan 4 2019, 12:22 PM

Dec 17 2018

olivier added a comment to D18532: Use byte-counting rather than packet counting for TX batch size.

Other platform (supermicro 5018A-FTN4, Atom C2758 8-cores at 2.4Ghz with intel 82599ES 10-Gigabit):

x r342020 with D18532(old: diff51924) and tx_abdicate disabled (default): inet4 pps
+ r342020 with D18532(new: diff51986) and tx_abdicate disabled (default): inet4 pps
+--------------------------------------------------------------------------+
| x             xx                      +    +          *               + +|
||______________M____A____________________|                                |
|                                         |_____________MA_______________| |
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5       3179260       3260787       3200772     3208284.5     30758.531
+   5       3235848       3287655       3260728     3262531.6     23384.011
Difference at 95.0% confidence
        54247.1 +/- 39846.4
        1.69084% +/- 1.25533%
        (Student's t, pooled s = 27321.2)
Dec 17 2018, 9:28 PM
olivier added a comment to D18532: Use byte-counting rather than packet counting for TX batch size.

Comparing DoS benches results with the previous Diff version applied and this one didn't show difference.

Dec 17 2018, 4:59 PM

Dec 13 2018

olivier added a comment to D18532: Use byte-counting rather than packet counting for TX batch size.

Here is my DoS benches results on my smallest 2 hardwares.
First serie comparing the benefit of D18532, so with tx_abdicate disabled (default behaviour)

Dec 13 2018, 10:28 PM

Dec 3 2018

olivier added a comment to D18373: pfsync: Performance improvement.

Benches results using Denial-of-Service mode (line-rate at maximum pps) on small hardware with pf+pfysnc (using loopback interface):
PC Engines APU 2 (4 cores AMD GX 1Ghz):

Dec 3 2018, 4:25 PM

Nov 29 2018

olivier committed rP486154: MFH: r484647 r484756 r484876.
MFH: r484647 r484756 r484876
Nov 29 2018, 6:18 AM

Nov 25 2018

olivier committed rP485900: Fix openssl 1.1.1 breakage.
Fix openssl 1.1.1 breakage
Nov 25 2018, 8:37 PM

Nov 13 2018

olivier committed rP484876: Be stricter when matching URLs..
Be stricter when matching URLs.
Nov 13 2018, 3:00 PM
olivier committed rP484857: Fix creating birdvty at installation time.
Fix creating birdvty at installation time
Nov 13 2018, 5:37 AM

Nov 12 2018

olivier committed rP484845: libssh is a dependency of RPKI option.
libssh is a dependency of RPKI option
Nov 12 2018, 10:30 PM

Nov 11 2018

olivier added a comment to D17901: Use busdma unconditionally in iflib.

Yes, I confirm a little improvement on small devices (same iflib.tx_abdicate=1 and ip_redirect disabled).

Nov 11 2018, 12:13 AM

Nov 10 2018

olivier committed rP484648: Fixes wrong LSA collision detection and add birdvty group.
Fixes wrong LSA collision detection and add birdvty group
Nov 10 2018, 11:03 PM
olivier committed rP484647: Fixes:.
Fixes:
Nov 10 2018, 10:45 PM

Nov 9 2018

olivier added a comment to D17901: Use busdma unconditionally in iflib.

I've forgot to disable IP redirect in my previous bench.
Here are the other results, on 3 different small platforms (-5% on all).
All of these are using common tuning features for routing/firewalling which are:

  • net.inet.ip.redirect=0 and net.inet6.ip6.redirect=0, this allow to re-enable fastforwarding path
  • dev.igb|ix.X.iflib.tx_abdicate=1, because they are receiving maximum link packet rate
Nov 9 2018, 9:10 AM

Nov 8 2018

olivier added a comment to D17901: Use busdma unconditionally in iflib.

Here is the first result on forwarding performance impact on low-end hardware (AMD GX-412TC, 4Cores and Intel i210AT NIC) :

Nov 8 2018, 10:51 AM

Oct 22 2018

olivier committed rP482740: New port: net/frr6 (6.0).
New port: net/frr6 (6.0)
Oct 22 2018, 9:06 AM

Oct 18 2018

olivier committed rP482324: Update to 1.2.
Update to 1.2
Oct 18 2018, 4:48 AM

Oct 11 2018

olivier committed rP481853: Fix build with GCC-based architectures..
Fix build with GCC-based architectures.
Oct 11 2018, 8:49 PM

Oct 6 2018

olivier committed rP481325: Fix 2 bugs into the RC script (restart and quietstart).
Fix 2 bugs into the RC script (restart and quietstart)
Oct 6 2018, 7:31 AM
olivier committed rP481324: Fix 2 bugs into the RC script (restart and quietstart).
Fix 2 bugs into the RC script (restart and quietstart)
Oct 6 2018, 7:29 AM
olivier committed rP481322: Fix 2 bugs into the RC script (restart and quietstart) and add ISIS patch..
Fix 2 bugs into the RC script (restart and quietstart) and add ISIS patch.
Oct 6 2018, 7:25 AM

Oct 3 2018

olivier committed rP481186: Forgot to add pkgconfig as dependency..
Forgot to add pkgconfig as dependency.
Oct 3 2018, 8:11 PM

Oct 1 2018

olivier committed rP481041: Enable an option by default (mandatory to net/frr7).
Enable an option by default (mandatory to net/frr7)
Oct 1 2018, 4:02 PM

Sep 26 2018

olivier committed rP480743: New port: net/libyang.
New port: net/libyang
Sep 26 2018, 3:54 PM

Sep 9 2018

olivier committed rP479274: Update net/py-maxminddb to 1.4.1.
Update net/py-maxminddb to 1.4.1
Sep 9 2018, 7:11 AM

Aug 22 2018

olivier committed rP477786: MFH: r474490.
MFH: r474490
Aug 22 2018, 1:37 PM

Aug 6 2018

olivier committed rP476513: Update to 2.3.14.
Update to 2.3.14
Aug 6 2018, 1:03 PM
olivier committed rP476512: Update to 2.3.14.
Update to 2.3.14
Aug 6 2018, 1:03 PM
olivier committed rP476511: Update to 2.3.14.
Update to 2.3.14
Aug 6 2018, 1:02 PM
olivier committed rP476510: Update to 2.3.14.
Update to 2.3.14
Aug 6 2018, 1:01 PM

Jul 12 2018

olivier committed rP474505: Use DISTVERSIONPREFIX in place of GH_TAGNAME..
Use DISTVERSIONPREFIX in place of GH_TAGNAME.
Jul 12 2018, 12:12 PM
olivier committed rP474493: New port: net/mininet, tool to create virtual network, including openflow.
New port: net/mininet, tool to create virtual network, including openflow
Jul 12 2018, 8:37 AM
olivier committed rP474492: New port: net/ryu, a component-based Software-defined Networking Framework.
New port: net/ryu, a component-based Software-defined Networking Framework
Jul 12 2018, 8:30 AM
olivier committed rP474491: New port: devel/py-ovs, python library for working with Open vSwitch..
New port: devel/py-ovs, python library for working with Open vSwitch.
Jul 12 2018, 8:24 AM
olivier committed rP474490: Remove compile-time-bomb code (#if CONFDATE > 20180828) and backport patches.
Remove compile-time-bomb code (#if CONFDATE > 20180828) and backport patches
Jul 12 2018, 8:07 AM

Jul 11 2018

olivier committed rP474441: Fix crash of ovs-vswitchd with 'add-br' command..
Fix crash of ovs-vswitchd with 'add-br' command.
Jul 11 2018, 12:42 PM

Jul 6 2018

olivier committed rP473998: New port: net/frr5 (5.0.1)..
New port: net/frr5 (5.0.1).
Jul 6 2018, 7:36 AM

Jul 1 2018

olivier committed rP473669: Update to 2.3.13.
Update to 2.3.13
Jul 1 2018, 12:09 PM
olivier committed rP473668: Update to 2.3.13.
Update to 2.3.13
Jul 1 2018, 12:08 PM
olivier committed rP473667: Update to 2.3.13.
Update to 2.3.13
Jul 1 2018, 12:07 PM
olivier committed rP473666: Update to 2.3.13.
Update to 2.3.13
Jul 1 2018, 12:06 PM

Jun 28 2018

olivier committed rP473523: Fix plist with non-default FPM option.
Fix plist with non-default FPM option
Jun 28 2018, 10:24 PM
olivier committed rP473496: Update to 2.9.0.
Update to 2.9.0
Jun 28 2018, 1:46 PM

Jun 14 2018

olivier added a comment to D15789: Switch RIB and RADIX_NODE_HEAD lock from rwlock(9) to rmlock(9).
In D15789#334385, @bz wrote:

I am totally not surprised by these numbers. However (a) did you do the same test for IPv6? (b) is that a forwarding setup or an end node setup? (c) how many route updates per second did you try on a forwarding node?

Jun 14 2018, 9:58 PM
olivier accepted D15789: Switch RIB and RADIX_NODE_HEAD lock from rwlock(9) to rmlock(9).

On a 2 sockets, 12 Core Xeon E5 2650 with a Mellanox ConnectX-4:

Jun 14 2018, 9:40 PM

Jun 6 2018

olivier committed rP471874: Update to 2.3.12.
Update to 2.3.12
Jun 6 2018, 6:40 PM
olivier committed rP471873: Update to 2.3.12.
Update to 2.3.12
Jun 6 2018, 6:39 PM
olivier committed rP471872: Update to 2.3.12.
Update to 2.3.12
Jun 6 2018, 6:37 PM
olivier committed rP471871: Update to 2.3.12 and fix build with the latest ffmpeg version.
Update to 2.3.12 and fix build with the latest ffmpeg version
Jun 6 2018, 6:36 PM

Jun 4 2018

olivier committed rP471530: Due to stability problems with FRR 4.0, reintroduce previous FRR 3.0.3..
Due to stability problems with FRR 4.0, reintroduce previous FRR 3.0.3.
Jun 4 2018, 5:12 AM