Differential D44005

hostname(1): test cases requires jail
ClosedPublic
Actions

Authored by olivier on Feb 21 2024, 6:32 AM.

Details

Reviewers

lwhsu

Commits

rG3562b7b1eb80: hostname(1): skip test if jail binary is missing

Summary

Skip test if jail binary is missing

Test Plan

A system with WITHOUT_JAIL=YES fails this test with:

Original stderr
---------------

/usr/tests/bin/hostname/hostname_test: jail: not found
/usr/tests/bin/hostname/hostname_test: jexec: not found
Files left in work directory after failure: jail.conf
/usr/tests/bin/hostname/hostname_test: jail: not found

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier requested review of this revision.Feb 21 2024, 6:32 AM

olivier created this revision.

I don't really object this approach, but I don't really support it either. Do you think it's okay to let the test case check if jail utility exists, and skip running if no?

In D44005#1004021, @lwhsu wrote:

I don't really object this approach, but I don't really support it either. Do you think it's okay to let the test case check if jail utility exists, and skip running if no?

yes, "skip" if jail is missing is a correct solution too.

olivier mentioned this in D44010: jail: tests requires jail.Feb 21 2024, 5:35 PM

olivier updated this revision to Diff 134854.Feb 22 2024, 8:38 PM

olivier edited the summary of this revision. (Show Details)

lwhsu accepted this revision.Feb 23 2024, 12:34 AM

This revision is now accepted and ready to land.Feb 23 2024, 12:34 AM

Closed by commit rG3562b7b1eb80: hostname(1): skip test if jail binary is missing (authored by olivier). · Explain WhyFeb 23 2024, 9:49 AM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rG3562b7b1eb80: hostname(1): skip test if jail binary is missing.

Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2024, 9:49 AM