Page MenuHomeFreeBSD

testsUmbrella
ActivePublic

Recent Activity

Mar 13 2018

badfilemagic_gmail.com removed a watcher for tests: badfilemagic_gmail.com.
Mar 13 2018, 4:23 PM

Jan 20 2018

kevans added a member for tests: kevans.
Jan 20 2018, 2:59 AM

Dec 28 2017

robak closed D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 28 2017, 10:57 PM · tests
kib accepted D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 28 2017, 3:34 PM · tests

Dec 23 2017

pawel.biernacki-gmail.com updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Man: start a sentence from new line.

Dec 23 2017, 7:15 PM · tests
pawel.biernacki-gmail.com updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Add CAVEATS section to the man page to point out the rounding issue with too short buffers.

Dec 23 2017, 6:09 PM · tests
pawel.biernacki-gmail.com added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#284349, @kib wrote:

In one branch of the snprintf() use, we add divisor / 2 and remainder * 10, not remainder. Does this case need to be handled differently ?

Dec 23 2017, 6:07 PM · tests
kib added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#283989, @cem wrote:

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Issue was caused by the way the final value was calculated in snprintf call, where remainder and divisor/2 was added back to the divided number. If remainder + divisor/2 was larger than 1024, it added 1 to the final value. If the final value as already 999 (as in the example reported), that brought it to 1000. If the buffer length provided was 4 (as is the case with ls), that left no space for the unit character.
Same issue was also present for other numbers if too small buffer lengths where used.

The fix continues the division of the original number if the above case happens -- added the appropriate check to the for loop performing the division. This lowers the value shown, to make it fit into the buffer space provided (1.0M for 4 character buffer, as used by ls).

Dec 23 2017, 1:42 PM · tests

Dec 22 2017

pawel.biernacki-gmail.com updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:37 PM · tests
pawel.biernacki-gmail.com updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:30 PM · tests
pawel.biernacki-gmail.com updated the summary of D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 22 2017, 5:08 PM · tests
cem accepted D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#283989, @cem wrote:

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Issue was caused by the way the final value was calculated in snprintf call, where remainder and divisor/2 was added back to the divided number. If remainder + divisor/2 was larger than 1024, it added 1 to the final value. If the final value as already 999 (as in the example reported), that brought it to 1000. If the buffer length provided was 4 (as is the case with ls), that left no space for the unit character.
Same issue was also present for other numbers if too small buffer lengths where used.

The fix continues the division of the original number if the above case happens -- added the appropriate check to the for loop performing the division. This lowers the value shown, to make it fit into the buffer space provided (1.0M for 4 character buffer, as used by ls).

Dec 22 2017, 3:55 AM · tests
ish_amail.plala.or.jp added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.

Thank you for patch.
I apply this patch to 12.0-CURRENT r327074, the right value is shown with ls -lh.

Dec 22 2017, 3:28 AM · tests

Dec 21 2017

pawel.biernacki-gmail.com added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.
In D13578#283989, @cem wrote:

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Dec 21 2017, 10:07 PM · tests
pawel.biernacki-gmail.com updated the diff for D13578: humanize_number(3): fix edge case for rounding 999.5+.

Address @cem comments about style(9).

Dec 21 2017, 10:06 PM · tests
cem added a comment to D13578: humanize_number(3): fix edge case for rounding 999.5+.

I don't understand the actual algorithmic change, but given the strong test coverage, I think I'm ok with this. Some style nits below.

Dec 21 2017, 9:47 PM · tests
pawel.biernacki-gmail.com added a reviewer for D13578: humanize_number(3): fix edge case for rounding 999.5+: robak.
Dec 21 2017, 9:39 PM · tests
pawel.biernacki-gmail.com created D13578: humanize_number(3): fix edge case for rounding 999.5+.
Dec 21 2017, 9:30 PM · tests

Jun 11 2017

badfilemagic_gmail.com added a watcher for tests: badfilemagic_gmail.com.
Jun 11 2017, 3:32 PM

Apr 20 2016

mat removed a member for tests: mat.
Apr 20 2016, 8:30 AM

Dec 2 2015

eccramer_gmail.com added a member for tests: eccramer_gmail.com.
Dec 2 2015, 9:04 PM

Nov 20 2015

rodrigc closed D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests. by committing rS291089: Copy README into /usr/tests.
Nov 20 2015, 3:24 AM · tests
rodrigc added inline comments to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..
Nov 20 2015, 3:17 AM · tests
rodrigc added inline comments to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..
Nov 20 2015, 3:16 AM · tests
jmmv added inline comments to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..
Nov 20 2015, 2:05 AM · tests

Nov 19 2015

ngie accepted D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..
Nov 19 2015, 11:29 PM · tests
rodrigc added a comment to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..

They already see it, they just don't know what to do once they are there.

Nov 19 2015, 11:23 PM · tests
ngie added a comment to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..

No, I don't want this in `/usr/share/docs`. This is meant to be *newbie* friendly so people can just go in /usr/tests
and figure out what to do relatively quickly by looking at the README.
The way to figure this out right now is confusing enough as it is with info scattered all over the place in different man pages,
wikis, etc. The end result is that newbies can't figure out what to do, and keep asking me.

Nov 19 2015, 11:22 PM · tests
rodrigc added a comment to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..

No, I don't want this in `/usr/share/docs`. This is meant to be *newbie* friendly so people can just go in /usr/tests
and figure out what to do relatively quickly by looking at the README.
The way to figure this out right now is confusing enough as it is with info scattered all over the place in different man pages,
wikis, etc. The end result is that newbies can't figure out what to do, and keep asking me.

Nov 19 2015, 11:09 PM · tests
ngie added a comment to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..

It seems like this should be installed to /usr/share/docs

Nov 19 2015, 11:06 PM · tests
rodrigc added a reviewer for D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests.: tests.
Nov 19 2015, 9:59 PM · tests
rodrigc added a project to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests.: tests.
Nov 19 2015, 9:59 PM · tests
rodrigc added a member for tests: rodrigc.
Nov 19 2015, 9:49 PM

Nov 5 2015

mat added a member for tests: mat.
Nov 5 2015, 12:42 PM

Oct 19 2015

kib closed D3925: Tests for copyin(9) handling of kernel addresses by committing rS289603: Add tests for the copyin(9) handling of illegal buffers..
Oct 19 2015, 8:22 PM · tests
ngie added a comment to D3925: Tests for copyin(9) handling of kernel addresses.
In D3925#81904, @kib wrote:
In D3925#81898, @ngie wrote:
int rc;

ATF_CHECK_MSG((rc = foo()) == exp_result, "foo() failed. Expected: %d; got: %d");

This is extremely ugly. For my tests, the function is the same, but the arguments are what produce the test case. In essense, I have to either retype the same thing twice, or create a wrapper that would call ATF_CHECK_MSG() only in case of failure.

Oct 19 2015, 6:58 PM · tests
kib added a comment to D3925: Tests for copyin(9) handling of kernel addresses.
In D3925#81898, @ngie wrote:
int rc;

ATF_CHECK_MSG((rc = foo()) == exp_result, "foo() failed. Expected: %d; got: %d");

This is extremely ugly. For my tests, the function is the same, but the arguments are what produce the test case. In essense, I have to either retype the same thing twice, or create a wrapper that would call ATF_CHECK_MSG() only in case of failure.

Oct 19 2015, 6:54 PM · tests
emaste accepted D3925: Tests for copyin(9) handling of kernel addresses.
Oct 19 2015, 6:41 PM · tests
ngie accepted D3925: Tests for copyin(9) handling of kernel addresses.

Sidenote: the only thing that's slightly painful with ATF that other test infrastructures seem to do better is that ATF_CHECK/ATF_REQUIRE don't print out the result of the expression, so if you need to dump out the result of the check, use ATF_CHECK_MSG/ATF_REQUIRE_MSG instead, like:

Oct 19 2015, 6:40 PM · tests
kib updated the diff for D3925: Tests for copyin(9) handling of kernel addresses.

Do not create temp file in /tmp. Use ATF_CHECK instead of ATF_CHECK_EQ.

Oct 19 2015, 6:35 PM · tests
ngie requested changes to D3925: Tests for copyin(9) handling of kernel addresses.
Oct 19 2015, 6:11 PM · tests
ngie added inline comments to D3925: Tests for copyin(9) handling of kernel addresses.
Oct 19 2015, 6:11 PM · tests
emaste accepted D3925: Tests for copyin(9) handling of kernel addresses.
Oct 19 2015, 4:33 PM · tests
kib updated the diff for D3925: Tests for copyin(9) handling of kernel addresses.

Add VM_MAXUSER + 1, 0 test.

Oct 19 2015, 4:29 PM · tests
kib added a comment to D3925: Tests for copyin(9) handling of kernel addresses.
In D3925#81835, @emaste wrote:

Is it worth checking VM_MAXUSER_ADDRESS + 1, 0?

Oct 19 2015, 4:21 PM · tests
emaste accepted D3925: Tests for copyin(9) handling of kernel addresses.
Oct 19 2015, 4:06 PM · tests
emaste updated subscribers of D3925: Tests for copyin(9) handling of kernel addresses.
Oct 19 2015, 4:04 PM · tests
emaste added a comment to D3925: Tests for copyin(9) handling of kernel addresses.

Is it worth checking VM_MAXUSER_ADDRESS + 1, 0?

Oct 19 2015, 4:01 PM · tests

Oct 17 2015

kib retitled D3925: Tests for copyin(9) handling of kernel addresses from to Tests for copyin(9) handling of kernel addresses.
Oct 17 2015, 10:41 AM · tests

Aug 30 2015

bapt added a member for tests: bapt.
Aug 30 2015, 6:10 PM