Page MenuHomeFreeBSD

jmmv (Julio Merino)
User

Projects

User Details

User Since
May 16 2014, 6:28 PM (266 w, 2 d)

Recent Activity

Apr 22 2019

jmmv accepted D20002: Backport patch to fix error check with access(3) failures.
Apr 22 2019, 11:31 PM

Oct 10 2016

jmmv requested changes to D8073: skip geom_uzip test on big-endian systems.
Oct 10 2016, 7:34 PM

Sep 28 2016

jmmv accepted D7952: fix atf on MIPS64.
Sep 28 2016, 6:10 PM
jmmv added inline comments to D7952: fix atf on MIPS64.
Sep 28 2016, 4:10 PM
jmmv added a comment to D7952: fix atf on MIPS64.

Note that this is not a workaround: this is a proper fix for broken code.

Sep 28 2016, 2:43 PM
jmmv added inline comments to D7952: fix atf on MIPS64.
Sep 28 2016, 1:35 PM

Sep 7 2016

jmmv added inline comments to D7264: Add test case for >65535 segment coredumps.
Sep 7 2016, 6:43 PM

Aug 30 2016

jmmv accepted D7702: Filter certain compile-time options into -DATF_BUILD_*.

I think this is fine. I just wonder if we should just zero out the parameters instead, or hardcode them to known values. I can't imagine a well-behaving compiler that wouldn't correctly build the test programs just with a call to ${CC} and no explicit flags.

Aug 30 2016, 1:30 AM

Aug 26 2016

jmmv closed D7642: Update devel/kyua to 0.13. by committing rP420923: Update devel/kyua to 0.13 from 0.11:.
Aug 26 2016, 2:59 PM
jmmv committed rP420923: Update devel/kyua to 0.13 from 0.11:.
Update devel/kyua to 0.13 from 0.11:
Aug 26 2016, 2:59 PM
jmmv added a comment to D7642: Update devel/kyua to 0.13..

bapt, this still requires your review as mentor. Thanks!

Aug 26 2016, 10:54 AM

Aug 25 2016

jmmv added inline comments to D7642: Update devel/kyua to 0.13..
Aug 25 2016, 5:22 PM
jmmv retitled D7642: Update devel/kyua to 0.13. from to Update devel/kyua to 0.13..
Aug 25 2016, 10:39 AM
jmmv added a comment to D4254: Mark tests that cannot run in parallel as is_exclusive.

I've fixed sys/kqueue/kqueue_test for correctness reasons, but it needn't fixing from a parallelization point of view. The driver of those tests is a TAP test program, and Kyua cannot parallelize the execution of individual test cases within a TAP test program.

Aug 25 2016, 10:30 AM
jmmv committed rS304797: Make use of Kyua's work directories..
Make use of Kyua's work directories.
Aug 25 2016, 10:28 AM

Aug 24 2016

jmmv updated the diff for D4254: Mark tests that cannot run in parallel as is_exclusive.

Also mark etc/rc.d/routing_test and sys/netinet/fibs_test as requested by asomers

Aug 24 2016, 10:50 AM
jmmv updated the diff for D4254: Mark tests that cannot run in parallel as is_exclusive.

Also mark sys/geom/class as exclusive

Aug 24 2016, 10:48 AM
jmmv committed rS304741: Skip ls tests that use sparse files if these are not supported..
Skip ls tests that use sparse files if these are not supported.
Aug 24 2016, 10:10 AM
jmmv closed D7609: Skip ls tests that use sparse files if these are not supported. by committing rS304741: Skip ls tests that use sparse files if these are not supported..
Aug 24 2016, 10:10 AM

Aug 23 2016

jmmv abandoned D7608: Expose _SC_MIN_HOLE_SIZE as MIN_HOLE_SIZE via getconf(1)..
Aug 23 2016, 9:05 PM
jmmv added inline comments to D7609: Skip ls tests that use sparse files if these are not supported..
Aug 23 2016, 7:13 PM
jmmv retitled D7609: Skip ls tests that use sparse files if these are not supported. from to Skip ls tests that use sparse files if these are not supported..
Aug 23 2016, 11:04 AM
jmmv retitled D7608: Expose _SC_MIN_HOLE_SIZE as MIN_HOLE_SIZE via getconf(1). from to Expose _SC_MIN_HOLE_SIZE as MIN_HOLE_SIZE via getconf(1)..
Aug 23 2016, 10:53 AM

Aug 22 2016

jmmv accepted D7597: Forcibly disable MK_TESTS if building without C++.

Looks good, but it's unfortunate that this is the case.

Aug 22 2016, 5:26 PM

Jun 9 2016

jmmv added a comment to D6627: Don't let ATF call basename() and dirname() in a non-standard way..

ngie is right in that basename and dirname are used for sanity-checking purposes. Why this is in the live code path and not in tests... doesn't make much sense, and I guess this could all be dropped.

Jun 9 2016, 12:57 AM

Apr 8 2016

jmmv accepted D5851: Fix printing out binary/UTF-8 characters in kyua 0.11 by backporting fix for issue # 136.
Apr 8 2016, 1:39 PM

Apr 6 2016

jmmv added inline comments to D5851: Fix printing out binary/UTF-8 characters in kyua 0.11 by backporting fix for issue # 136.
Apr 6 2016, 9:38 PM
jmmv added inline comments to D5851: Fix printing out binary/UTF-8 characters in kyua 0.11 by backporting fix for issue # 136.
Apr 6 2016, 2:27 PM

Nov 23 2015

jmmv committed rP402256: Update devel/kyua to 0.12..
Update devel/kyua to 0.12.
Nov 23 2015, 3:03 AM
jmmv closed D4243: Update devel/kyua to 0.12. by committing rP402256: Update devel/kyua to 0.12..
Nov 23 2015, 3:03 AM

Nov 22 2015

jmmv committed rP402245: Add a MULTILIB option to gcc{,48,49,5} for powerpc64.
Add a MULTILIB option to gcc{,48,49,5} for powerpc64
Nov 22 2015, 9:07 PM
jmmv closed D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64 by committing rP402245: Add a MULTILIB option to gcc{,48,49,5} for powerpc64.
Nov 22 2015, 9:07 PM
jmmv added a reviewer for D4254: Mark tests that cannot run in parallel as is_exclusive: tests.
Nov 22 2015, 8:30 PM
jmmv retitled D4254: Mark tests that cannot run in parallel as is_exclusive from to Mark tests that cannot run in parallel as is_exclusive.
Nov 22 2015, 8:30 PM
jmmv added a reviewer for D4243: Update devel/kyua to 0.12.: bapt.
Nov 22 2015, 8:16 PM
jmmv updated the diff for D4243: Update devel/kyua to 0.12..

Updated distinfo with final checksum of actual release.

Nov 22 2015, 8:15 PM

Nov 21 2015

jmmv requested changes to D4228: Make tests(7) more concise..
Nov 21 2015, 7:01 PM
jmmv retitled D4243: Update devel/kyua to 0.12. from to Update devel/kyua to 0.12..
Nov 21 2015, 6:43 PM

Nov 20 2015

jmmv added inline comments to D4224: Add quick steps for running kyua tests to README. Install the README in /usr/tests..
Nov 20 2015, 2:05 AM · tests

Nov 8 2015

jmmv reopened D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

I messed up the commits and this was only intended to be enabled on powerpc64. I think I committed an older version of the diff. I have undone the committed changes and will take a closer look at what happened.

Nov 8 2015, 8:33 PM
jmmv committed rP401074: Revert r401072..
Revert r401072.
Nov 8 2015, 8:32 PM
jmmv committed rP401072: Add a MULTILIB option to gcc{,48,49,5} for powerpc64.
Add a MULTILIB option to gcc{,48,49,5} for powerpc64
Nov 8 2015, 8:10 PM
jmmv closed D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64 by committing rP401072: Add a MULTILIB option to gcc{,48,49,5} for powerpc64.
Nov 8 2015, 8:10 PM

Nov 2 2015

jmmv reopened D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

I only committed a subset of the changes, so let's reopen this. The automatic closing caused by a commit wasn't desirable in this case.

Nov 2 2015, 3:09 AM
jmmv added a comment to D3966: Fix the build of libglapi on powerpc and powerpc64..

Sorry for not submitting this promptly, but I was waiting on mentor approval...

Nov 2 2015, 3:07 AM
jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

Thank you everyone. I've done the last stylistic change requested by gerald and committed the changes to gcc5-devel and gcc6-devel. The rest will follow later in the week.

Nov 2 2015, 2:58 AM
jmmv committed rP400632: Add a MULTILIB option to gcc[56]-devel for powerpc64.
Add a MULTILIB option to gcc[56]-devel for powerpc64
Nov 2 2015, 2:58 AM
jmmv closed D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64 by committing rP400632: Add a MULTILIB option to gcc[56]-devel for powerpc64.
Nov 2 2015, 2:58 AM

Oct 28 2015

jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

ping reviewers

Oct 28 2015, 1:12 AM

Oct 26 2015

jmmv updated the diff for D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

Fix description according to suggestion.

Oct 26 2015, 2:26 AM
jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.
In D3952#83510, @gerald wrote:

Re "why is lang/gcc48 still there?", there is a number of users interested in older versions,
which by definition do not make much sense for newer ports or newer uses, though.

Oct 26 2015, 2:25 AM

Oct 25 2015

jmmv retitled D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64 from Add a MULTILIB option to gcc, gcc48 and gcc49. to Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.
Oct 25 2015, 2:16 PM
jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

Ok with me.
I often used to build with --disable-multilib to save time. But I usually have a lib32/libc.so. So if this test works, fine.
powerpc64 is the only target in FreeBSD land which has multilib support in gcc. For all other targets the --disable-multilib is a nop.

Oct 25 2015, 2:14 PM
jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.
In D3952#83418, @gerald wrote:

Okay, so it's okay to make this change for lang/gcc, lang/gcc49 and later.
Let's leave lang/gcc48 alone, there should be no reason to use this any more.

Oct 25 2015, 2:13 PM
jmmv updated the diff for D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

Patch gcc 5 and 6 as well and only offer MULTILIB on powerpc64.

Oct 25 2015, 2:13 PM

Oct 23 2015

jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

I'd say depending on the presence of /usr/lib32 is fine. The builds will be reproducible for the host building the packages, and the standard binary packages should be built on a host without src.conf tweaks. Once you've modified MK_* settings in src.conf, you are in la la land.

Oct 23 2015, 9:10 PM

Oct 21 2015

jmmv retitled D3966: Fix the build of libglapi on powerpc and powerpc64. from to Fix the build of libglapi on powerpc and powerpc64..
Oct 21 2015, 6:46 PM
jmmv closed D3957: Mark spidermonkey185 as not for powerpc nor powerpc64. by committing rP399905: Mark spidermonkey185 as not for PowerPC/PowerPC64.
Oct 21 2015, 12:03 PM
jmmv committed rP399905: Mark spidermonkey185 as not for PowerPC/PowerPC64.
Mark spidermonkey185 as not for PowerPC/PowerPC64
Oct 21 2015, 12:03 PM
jmmv added a comment to D3957: Mark spidermonkey185 as not for powerpc nor powerpc64..

Suggestion applied. Given that you said "approved with this change made", which I have done, I'm going to submit now.

Oct 21 2015, 12:01 PM
jmmv retitled D3957: Mark spidermonkey185 as not for powerpc nor powerpc64. from Mark spidermonkey180 as not for powerpc nor powerpc64. to Mark spidermonkey185 as not for powerpc nor powerpc64..
Oct 21 2015, 2:21 AM
jmmv retitled D3957: Mark spidermonkey185 as not for powerpc nor powerpc64. from to Mark spidermonkey180 as not for powerpc nor powerpc64..
Oct 21 2015, 2:08 AM

Oct 20 2015

jmmv committed rS289662: Handle lib32 files during delete-old* when MK_LIB32=no..
Handle lib32 files during delete-old* when MK_LIB32=no.
Oct 20 2015, 8:35 PM
jmmv closed D3923: Handle lib32 files during delete-old* when MK_LIB32=no. by committing rS289662: Handle lib32 files during delete-old* when MK_LIB32=no..
Oct 20 2015, 8:35 PM
jmmv removed a reviewer for D3372: Avoid building unnecessary demos and tests: bapt.
Oct 20 2015, 6:50 PM
jmmv committed rP399873: Avoid building unnecessary demos and tests..
Avoid building unnecessary demos and tests.
Oct 20 2015, 6:50 PM
jmmv closed D3372: Avoid building unnecessary demos and tests by committing rP399873: Avoid building unnecessary demos and tests..
Oct 20 2015, 6:50 PM
jmmv added a comment to D3372: Avoid building unnecessary demos and tests.

Committed as r399873. Thank you!

Oct 20 2015, 6:50 PM
jmmv updated the diff for D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

Make sure to disable multilib when MULTILIB is not defined.

Oct 20 2015, 4:30 PM
jmmv added inline comments to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.
Oct 20 2015, 3:56 PM
jmmv updated the diff for D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

Use MULTILIB_CONFIGURE_ENABLE.

Oct 20 2015, 3:54 PM
jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

+bdrewery. Let's add my primary mentor... my memory served me wrong and I got things backwards. (Now also waiting for a reply from Gerald via email; pointed him at here.)

Oct 20 2015, 1:03 PM
jmmv added a reviewer for D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64: bdrewery.
Oct 20 2015, 1:03 PM
jmmv added a comment to D3372: Avoid building unnecessary demos and tests.

Actually... +bdrewery. Had to look at my invitation email and now noticed that my primary mentor is Bryan, not Baptiste! Oops.

Oct 20 2015, 1:02 PM
jmmv added a reviewer for D3372: Avoid building unnecessary demos and tests: bdrewery.
Oct 20 2015, 1:02 PM
jmmv added a comment to D3923: Handle lib32 files during delete-old* when MK_LIB32=no..

FYI: "make tinderbox" was successful and a bunch of test builds on amd64 and powerpc64 where I enabled/disabled lib32 and ran an update have worked as intended.

Oct 20 2015, 1:00 PM
jmmv added a comment to D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64.

I'm going to poke gerald@ by email to take a look and possibly to register for a Phabricator account.

Oct 20 2015, 12:46 PM
jmmv retitled D3952: Add a MULTILIB option to gcc{,48,49,5,5-devel,6-devel} for powerpc64 from to Add a MULTILIB option to gcc, gcc48 and gcc49..
Oct 20 2015, 12:45 PM
jmmv updated the diff for D3923: Handle lib32 files during delete-old* when MK_LIB32=no..

Add missing etc/Makefile to the diff.

Oct 20 2015, 1:20 AM

Oct 19 2015

jmmv added inline comments to D3923: Handle lib32 files during delete-old* when MK_LIB32=no..
Oct 19 2015, 2:38 PM
jmmv updated the diff for D3923: Handle lib32 files during delete-old* when MK_LIB32=no..

Nest MK_DEBUG_FILES inside MK_LIB32 for consistency.

Oct 19 2015, 2:36 PM

Oct 18 2015

jmmv added a comment to D3372: Avoid building unnecessary demos and tests.

Thanks. Now... ping bapt / mentor!

Oct 18 2015, 2:22 AM

Oct 17 2015

jmmv added a comment to D3923: Handle lib32 files during delete-old* when MK_LIB32=no..

Please take a look now. The intermediate revisions were kinda broken, but my tests as described in the test plan have now passed with the last patch snapshot.

Oct 17 2015, 8:02 PM
jmmv updated the diff for D3923: Handle lib32 files during delete-old* when MK_LIB32=no..

And now fix a typo to allow deletion of the stale BSD.lib32.dist file.

Oct 17 2015, 8:00 PM
jmmv updated the diff for D3923: Handle lib32 files during delete-old* when MK_LIB32=no..

Also patch etc/Makefile.

Oct 17 2015, 7:51 PM
jmmv updated the diff for D3923: Handle lib32 files during delete-old* when MK_LIB32=no..

Add missing calls to mtree for LIB32TMP.

Oct 17 2015, 10:35 AM
jmmv retitled D3923: Handle lib32 files during delete-old* when MK_LIB32=no. from to Handle lib32 files during delete-old* when MK_LIB32=no..
Oct 17 2015, 2:01 AM

Oct 16 2015

jmmv added a comment to D3372: Avoid building unnecessary demos and tests.

So, kwm, do you want this changed to a patch or is it good to go? See my previous comment for the rationale.

Oct 16 2015, 7:32 PM
jmmv committed rP399507: Fix build on 64-bit big-endian machines..
Fix build on 64-bit big-endian machines.
Oct 16 2015, 7:31 PM
jmmv closed D3397: Fix build on 64-bit big-endian machines..

With much delay, this is now committed as r399507. Thanks!

Oct 16 2015, 7:31 PM

Aug 17 2015

jmmv added a comment to D3372: Avoid building unnecessary demos and tests.

This is your package, so it's up to you.

Aug 17 2015, 3:06 PM
jmmv retitled D3397: Fix build on 64-bit big-endian machines. from to Fix build on 64-bit big-endian machines..
Aug 17 2015, 3:24 AM
jmmv updated the diff for D3372: Avoid building unnecessary demos and tests.

Oops... messed up the previous "arc diff" upload and pushed changes for
an unrelated package to this revision. Repushing for review.

Aug 17 2015, 3:23 AM
jmmv updated the diff for D3372: Avoid building unnecessary demos and tests.

Fix build on 64-bit big-endian machines.

Aug 17 2015, 3:22 AM

Aug 13 2015

jmmv retitled D3372: Avoid building unnecessary demos and tests from to Avoid building unnecessary demos and tests.
Aug 13 2015, 2:49 AM

Aug 12 2015

jmmv committed rS286652: Mark usr/include/c++/v1/tr1 as obsolete.
Mark usr/include/c++/v1/tr1 as obsolete
Aug 12 2015, 3:04 AM

Jul 4 2015

jmmv committed rS285119: Add support for TEST_METADATA.
Add support for TEST_METADATA
Jul 4 2015, 2:37 AM
jmmv committed rS285118: Add missing shebang.
Add missing shebang
Jul 4 2015, 2:24 AM
jmmv committed rS285117: Make cleanup routines idempotent.
Make cleanup routines idempotent
Jul 4 2015, 2:22 AM

Jun 28 2015

jmmv committed rS284912: Only initialize libedit when necessary.
Only initialize libedit when necessary
Jun 28 2015, 4:43 PM