Avoid building unnecessary demos and tests
ClosedPublic
Actions

Authored by jmmv on Aug 13 2015, 2:49 AM.

Details

Reviewers

kwm
bdrewery

Commits

rP399873: Avoid building unnecessary demos and tests.

Summary

The pixmap package does not install neither the demos nor the tests it
includes, yet these get built as part of "make all". Disable them to
shorten build times and, particularly, to workaround ld(1) crashes
triggered by them in powerpc64; see PR bin/202284 for details.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jmmv updated this revision to Diff 7914.Aug 13 2015, 2:49 AM

jmmv retitled this revision from to Avoid building unnecessary demos and tests.

jmmv updated this object.

jmmv edited the test plan for this revision. (Show Details)

jmmv added a reviewer: bapt.

bapt added a reviewer: kwm.Aug 13 2015, 5:35 AM

Fix build on 64-bit big-endian machines.

Oops... messed up the previous "arc diff" upload and pushed changes for
an unrelated package to this revision. Repushing for review.

I don't object to this change in spirit. But for some reason I don't like it this way, I rather have a Makefile.in patch, with the comment you added to the Makefile on top.

This is your package, so it's up to you.

But the reason I did this in the package Makefile is to simplify upgrades. Maintaining patches, especially when they are for auto-generated files such as Makefile.in, is harder to do than just relying on MAKE_ARGS to do effectively the same thing here.

So, kwm, do you want this changed to a patch or is it good to go? See my previous comment for the rationale.

Thanks

kwm accepted this revision.Oct 17 2015, 10:23 AM

kwm edited edge metadata.

This revision is now accepted and ready to land.Oct 17 2015, 10:23 AM

Thanks. Now... ping bapt / mentor!

Actually... +bdrewery. Had to look at my invitation email and now noticed that my primary mentor is Bryan, not Baptiste! Oops.

bdrewery accepted this revision.Oct 20 2015, 3:40 PM

bdrewery edited edge metadata.

Committed as r399873. Thank you!

Closed by commit rP399873: Avoid building unnecessary demos and tests. (authored by jmmv). · Explain WhyOct 20 2015, 6:50 PM

This revision was automatically updated to reflect the committed changes.