Differential D20002

Backport patch to fix error check with access(3) failures
ClosedPublic
Actions

Authored by ngie on Apr 22 2019, 5:36 AM.

Details

Reviewers

asomers
jmmv
lwhsu

Commits

rP499695: Backport patch to fix error check with access(3) failures

Summary

The code was not properly checking the failure from access(3).

Backport the patch from GitHub (made after the 0.4 release) which fixes this
issue.

PR: 237459
Obtained from: https://github.com/jmmv/lutok (a23c7b894cf50dea5e927e36a3578b720fffcf23)

Test Plan

I built and installed the patched package on my host and reran the kyua tests
successfully, like so:

$ kyua test -k /usr/local/tests/kyua/Kyuafile
...
utils/text/templates_test:templates_def__get_vector__ok  ->  passed  [0.004s]
utils/text/templates_test:templates_def__get_vector__unknown  ->  passed  [0.005s]
utils/text/templates_test:templates_def__remove_variable  ->  passed  [0.004s]

Results file id is usr_local_tests_kyua.20190421-223154-368801
Results saved to /home/ngie/.kyua/store/results.usr_local_tests_kyua.20190421-223154-368801.db

1438/1438 passed (0 failed)
$ uname -a
FreeBSD fbsd-11-i386 11.2-STABLE FreeBSD 11.2-STABLE #0 r346333: Thu Apr 18 02:21:56 UTC 2019     root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  i386