Page MenuHomeFreeBSD

Allows running socket_afinet regression tests in parallel
ClosedPublic

Authored by olivier on Jul 3 2023, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 10:45 PM
Unknown Object (File)
Wed, Oct 15, 4:30 PM
Unknown Object (File)
Wed, Oct 15, 2:22 AM
Unknown Object (File)
Wed, Oct 15, 2:22 AM
Unknown Object (File)
Wed, Oct 15, 2:21 AM
Unknown Object (File)
Wed, Oct 15, 2:21 AM
Unknown Object (File)
Tue, Oct 14, 5:24 PM
Unknown Object (File)
Tue, Oct 7, 9:44 PM

Details

Summary

They all are using the same port for binding server, so conflicting when running in parallel.

Test Plan

Before:
Set parallelism=8 in /etc/kyua/kyua.conf, and run it.
It will fails once reach socket_afinet_stream_reconnect tests

After:
No more failure

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olivier retitled this revision from Allows running /socket_afinet regression tests in parallel to Allows running socket_afinet regression tests in parallel.
This revision is now accepted and ready to land.Jul 3 2023, 6:48 PM

Ok, but this is still fragile. It assumes that nothing else in the entire test suite will bind to ports 6667-6669. Probably these tests should specify sin.sin_port = 0 and then use getsockname() to figure out which port was assigned.

Replacing hardcoded port number with dynamic ones.

This revision now requires review to proceed.Jul 4 2023, 5:19 PM
This revision is now accepted and ready to land.Jul 4 2023, 5:23 PM