cxgbe: Tidy TOE tunables under hw.cxgbe

[jhb]

Summary

• Only two of these tunables are used for RATELIMIT without TCP_OFFLOAD.

• Mark t4_tmr_idx_ofld and t4_pktc_idx_ofld static.

• Move hw.cxgbe.cop_managed_offloading under hw.cxgbe.toe since it is specific to TOE.

[jhb]

Note to self: need to update cxgbetool.8 manpage which references the hw.cxgbe.cop_managed_offloading tunable.

sys/dev/cxgbe/t4_main.c

 {
         struct unpcb *unp, *unp2;
         const struct sockaddr *sa;
 
         unp = sotounpcb(so);
         KASSERT(unp != NULL, ("uipc_peeraddr: unp == NULL"));
 
         *nam = malloc(sizeof(struct sockaddr_un), M_SONAME, M_WAITOK);
-        UNP_LINK_RLOCK();
-        /*
-         * XXX: It seems that this test always fails even when connection is
-         * established.  So, this else clause is added as workaround to
-         * return PF_LOCAL sockaddr.
-         */
-        unp2 = unp->unp_conn;
+
+        UNP_PCB_LOCK(unp);
+        unp2 = unp_pcb_lock_peer(unp);
         if (unp2 != NULL) {
-                UNP_PCB_LOCK(unp2);
                 if (unp2->unp_addr != NULL)
                         sa = (struct sockaddr *) unp2->unp_addr;
                 else
                         sa = &sun_noname;
                 bcopy(sa, *nam, sa->sa_len);
                 UNP_PCB_UNLOCK(unp2);
         } else {
                 sa = &sun_noname;
                 bcopy(sa, *nam, sa->sa_len);
         }
-        UNP_LINK_RUNLOCK();
+        UNP_PCB_UNLOCK(unp);
         return (0);
 }
 
 static int
 uipc_rcvd(struct socket *so, int flags)
 {
         struct unpcb *unp, *unp2;
         struct socket *so2;

usr.sbin/cxgbetool/cxgbetool.8

 {
         struct unpcb *unp, *unp2;
         const struct sockaddr *sa;
 
         unp = sotounpcb(so);
         KASSERT(unp != NULL, ("uipc_peeraddr: unp == NULL"));
 
         *nam = malloc(sizeof(struct sockaddr_un), M_SONAME, M_WAITOK);
-        UNP_LINK_RLOCK();
-        /*
-         * XXX: It seems that this test always fails even when connection is
-         * established.  So, this else clause is added as workaround to
-         * return PF_LOCAL sockaddr.
-         */
-        unp2 = unp->unp_conn;
+
+        UNP_PCB_LOCK(unp);
+        unp2 = unp_pcb_lock_peer(unp);
         if (unp2 != NULL) {
-                UNP_PCB_LOCK(unp2);
                 if (unp2->unp_addr != NULL)
                         sa = (struct sockaddr *) unp2->unp_addr;
                 else
                         sa = &sun_noname;
                 bcopy(sa, *nam, sa->sa_len);
                 UNP_PCB_UNLOCK(unp2);
         } else {
                 sa = &sun_noname;
                 bcopy(sa, *nam, sa->sa_len);
         }
-        UNP_LINK_RUNLOCK();
+        UNP_PCB_UNLOCK(unp);
         return (0);
 }
 
 static int
 uipc_rcvd(struct socket *so, int flags)
 {
         struct unpcb *unp, *unp2;
         struct socket *so2;